Re: Jute max buffer size related question

2018-08-29 Thread Karan Mehta
Got it. That makes sense. Thanks! Let me know your thoughts on https://issues.apache.org/jira/browse/ZOOKEEPER-3129 Karan On Fri, Aug 24, 2018 at 6:10 PM Benjamin Reed wrote: > we stop reading the socket once we hit max buffer size so we don't > overflow memory. it was put in when a buggy

Re: Jute max buffer size related question

2018-08-24 Thread Benjamin Reed
we stop reading the socket once we hit max buffer size so we don't overflow memory. it was put in when a buggy client cause the server to think it was getting a 1G packet and ran out of memory trying to allocate memory for it. in theory we could read in the data and just drop it on the floor. this

Jute max buffer size related question

2018-08-24 Thread Karan Mehta
Hello everyone, Why do we close the clientCnxn whenever a client sends a request which payload larger than jute max buffer size? (and similar for client as well) Is it a security issue if we send a relevant KeeperException instead? Even more, we send the parameter value to the client and client