Re: New merge script with GH api

2023-12-01 Thread Enrico Olivelli
ks, > > > > We've just submitted > > https://issues.apache.org/jira/browse/ZOOKEEPER-4756 to all active > > branches. It's about an improvement for the merge script to use GH api > > for merging PRs instead of manually pushing and leaving the PR is > > "clo

Re: New merge script with GH api

2023-12-01 Thread tison
anches. It's about an improvement for the merge script to use GH api > for merging PRs instead of manually pushing and leaving the PR is > "closed" state. > > The PR itself has been merged with the new script and it nicely turned > into "Merged" status. > > Plea

New merge script with GH api

2023-12-01 Thread Andor Molnar
Hi folks, We've just submitted https://issues.apache.org/jira/browse/ZOOKEEPER-4756 to all active branches. It's about an improvement for the merge script to use GH api for merging PRs instead of manually pushing and leaving the PR is "closed" state. The PR itself has been merged wi

[jira] [Created] (ZOOKEEPER-4756) Merge script should use GitHub api to merge pull requests

2023-10-06 Thread Andor Molnar (Jira)
Andor Molnar created ZOOKEEPER-4756: --- Summary: Merge script should use GitHub api to merge pull requests Key: ZOOKEEPER-4756 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4756 Project

Re: Problems with the merge script

2021-09-01 Thread Damien Diederen
Hi Enrico, Enrico Olivelli writes: > I saw the error below, can anyone take a look at it? I have encountered such an error error before, and couldn't explain it. In my case, the actual Python exception was 'IndexError: list index out of range'. (I assume that's the one you also saw, but it

Problems with the merge script

2021-08-25 Thread Enrico Olivelli
Hello, today I merge a patch from Demien, I saw the error below, can anyone take a look at it? thanks Enrico Would you like to update an associated JIRA? (y/n): y Enter a JIRA id [ZOOKEEPER-4342]: === JIRA ZOOKEEPER-4342 === summary Robustify C client against errors during SASL negotiation

Re: Question on merge script

2018-05-09 Thread Edward Ribeiro
FYI, the merge script was created in the Spark project then ported to Kafka project. And Kafka version was ported to ZK. :) Ed Em qua, 9 de mai de 2018 19:46, Patrick Hunt <ph...@apache.org> escreveu: > I believe we forked the script and the process/docs off another TLP, > p

Re: Question on merge script

2018-05-09 Thread Patrick Hunt
wiki page with merge script > instructions needs updating. I'll explore it a bit further and will update > it. > > -Flavio > > > On 9 May 2018, at 20:05, Patrick Hunt <ph...@apache.org> wrote: > > > > On Wed, May 9, 2018 at 1:18 AM, Flavio Junqueira <f...@a

Re: Question on merge script

2018-05-09 Thread Flavio Junqueira
Thanks for the feedback, Pat. I think the wiki page with merge script instructions needs updating. I'll explore it a bit further and will update it. -Flavio > On 9 May 2018, at 20:05, Patrick Hunt <ph...@apache.org> wrote: > > On Wed, May 9, 2018 at 1:18 AM, Flavio Junqueira &

Re: Question on merge script

2018-05-09 Thread Patrick Hunt
On Wed, May 9, 2018 at 1:18 AM, Flavio Junqueira <f...@apache.org> wrote: > Hey Michael, > > I was trying to merge yesterday a PR generated against branch-3.5, and > fetching the PR branch did not give me the merge script. I ended up asking > the contributor to change the ta

Re: Question on merge script

2018-05-09 Thread Flavio Junqueira
Hey Michael, I was trying to merge yesterday a PR generated against branch-3.5, and fetching the PR branch did not give me the merge script. I ended up asking the contributor to change the target branch to master so that I avoid any small hacks with the merge script. We should consider doing

Re: Question on merge script

2018-05-08 Thread Michael Han
Hi Flavio, The merge script is branch agnostic - it only cares about the pull request number. As long as in the pull request the correct target branch is specified, the merge script will do its job by merging the change to the specified target branch. I guess we could commit the same script

Question on merge script

2018-05-08 Thread Flavio Junqueira
Could anyone remind me why we don't have the merge script on branch-3.5? Say I have a change that targets branch-3.5 alone. Shouldn't I be able to have a PR that targets branch-3.5 and use the merge script? Thanks, -Flavio

Re: Merge script

2016-11-14 Thread Flavio P JUNQUEIRA
y_install JIRA` is wrong because I should have put 'jira' > > (lowercase). > > > > The library is this one: https://pypi.python.org/pypi/jira/ > > > > Edward > > > > Em 13 de nov de 2016 10:13 PM, "Michael Han" <h...@cloudera.com> > escreveu: > > &g

Re: Merge script

2016-11-13 Thread Edward Ribeiro
? > > On Sun, Nov 13, 2016 at 12:34 PM, Flavio Junqueira <f...@apache.org> wrote: > >> I've used the merge script and it works great... mostly. I had an issue >> with the jira bit and I'm not entirely sure what the problem is, but I can >> use some help. It is probably

Re: Merge script

2016-11-13 Thread Flavio Junqueira
for you? > > On Sun, Nov 13, 2016 at 12:34 PM, Flavio Junqueira <f...@apache.org> wrote: > >> I've used the merge script and it works great... mostly. I had an issue >> with the jira bit and I'm not entirely sure what the problem is, but I can >> use some help.

Re: Merge script

2016-11-13 Thread Edward Ribeiro
sudo pip install jira' work for you? On Sun, Nov 13, 2016 at 12:34 PM, Flavio Junqueira <f...@apache.org> wrote: > I've used the merge script and it works great... mostly. I had an issue > with the jira bit and I'm not entirely sure what the problem is, but I can > use some help. It is

Re: Merge script

2016-11-13 Thread Michael Han
Would 'sudo pip install jira' work for you? On Sun, Nov 13, 2016 at 12:34 PM, Flavio Junqueira <f...@apache.org> wrote: > I've used the merge script and it works great... mostly. I had an issue > with the jira bit and I'm not entirely sure what the problem is, but I can >

Merge script

2016-11-13 Thread Flavio Junqueira
I've used the merge script and it works great... mostly. I had an issue with the jira bit and I'm not entirely sure what the problem is, but I can use some help. It is probably something silly on my end. I have installed the jira package with pip, like the merge script recommends