Re: New precommit job 'retest this please' trick

2018-09-25 Thread Fangmin Lv
This makes things much easier! Thanks a lot for setting this up! Fangmin On Tue, Sep 25, 2018 at 10:37 AM Brian Nixon wrote: > Excellent! > > > On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár wrote: > > > Awesome! > > > > > > > > On 09/24/2018 06:27 PM, Michael Han wrote: > > >>> How the new

Re: New precommit job 'retest this please' trick

2018-09-25 Thread Brian Nixon
Excellent! On Mon, Sep 24, 2018 at 11:06 AM Andor Molnár wrote: > Awesome! > > > > On 09/24/2018 06:27 PM, Michael Han wrote: > >>> How the new process any different from that? > > Jenkins job triggered by "Rebuild" button can't write back the job result > > to github, leading to a yellow

Re: New precommit job 'retest this please' trick

2018-09-24 Thread Andor Molnár
Awesome! On 09/24/2018 06:27 PM, Michael Han wrote: >>> How the new process any different from that? > Jenkins job triggered by "Rebuild" button can't write back the job result > to github, leading to a yellow pending check status even after the job > finished; while "test this please" does not

Re: New precommit job 'retest this please' trick

2018-09-24 Thread Michael Han
>> How the new process any different from that? Jenkins job triggered by "Rebuild" button can't write back the job result to github, leading to a yellow pending check status even after the job finished; while "test this please" does not have this issue. On Mon, Sep 24, 2018 at 7:01 AM, Andor

Re: New precommit job 'retest this please' trick

2018-09-24 Thread Andor Molnar
I usually logged in to Jenkins for other reasons, but that's also fine to have this option. Cheers Andor On Mon, Sep 24, 2018 at 3:51 PM, Enrico Olivelli wrote: > Il lun 24 set 2018, 15:25 Andor Molnar ha > scritto: > > > Thanks Enrico. Afaik the Rebuild button was already available for > >

Re: New precommit job 'retest this please' trick

2018-09-24 Thread Enrico Olivelli
Il lun 24 set 2018, 15:25 Andor Molnar ha scritto: > Thanks Enrico. Afaik the Rebuild button was already available for > committers. > How the new process any different from th > In order to relaunch tests you do not need to go to jenkins but simply add a 'retest this please' comment on the PR

Re: New precommit job 'retest this please' trick

2018-09-24 Thread Andor Molnar
Thanks Enrico. Afaik the Rebuild button was already available for committers. How the new process any different from that? Andor On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli wrote: > Hi ZooKeepers, > we have enhanced the "precommit" automated QA testing. > Before merging any patch the

New precommit job 'retest this please' trick

2018-09-23 Thread Enrico Olivelli
Hi ZooKeepers, we have enhanced the "precommit" automated QA testing. Before merging any patch the committer should wait for a "green light" on CI, but unfortunately we have a few flaky tests which are very annoying. Now any Apache Committer, member of the 'apache' organization on github, is able