Ben, What are the tests that we would need to disable? If any have any concrete insight here, could you please add to the jira?
Thanks, -Flavio > -----Original Message----- > From: Benjamin Reed [mailto:br...@apache.org] > Sent: 10 October 2013 04:22 > To: dev@zookeeper.apache.org > Subject: Re: [jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't > work on macos > > i've been looking into the --wrap issue. the linker on osx just doesn't support > it, and the functionality is pretty magical. i think we should just disable the > tests that use them on osx > > > On Wed, Oct 9, 2013 at 10:18 AM, Patrick Hunt (JIRA) > <j...@apache.org>wrote: > > > > > [ > > https://issues.apache.org/jira/browse/ZOOKEEPER- > 1742?page=com.atlassia > > n.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId= > > 13790630#comment-13790630] > > > > Patrick Hunt commented on ZOOKEEPER-1742: > > ----------------------------------------- > > > > Should we split these out? How do you want to handle it? The failing > > test is a blocker for 3.4.6 IMO. > > > > > "make check" doesn't work on macos > > > ---------------------------------- > > > > > > Key: ZOOKEEPER-1742 > > > URL: > > https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > > > Project: ZooKeeper > > > Issue Type: Bug > > > Reporter: Flavio Junqueira > > > Assignee: Benjamin Reed > > > Fix For: 3.4.6, 3.5.0 > > > > > > > > > There are two problems I have spotted when running "make check" with > > > the > > C client. First, it complains that the sleep call is not defined in > > two test files: tests/ZooKeeperQuorumServer.cc and > tests/TestReconfigServer.cc. > > Including unistd.h works. The second problem is with linker options. > > It complains that "--wrap" is not a valid. I'm not sure how to deal > > with this one yet, since I'm not sure why we are using it. > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.1#6144) > >
