Re: Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build

2021-02-20 Thread Justin Ling Mao
"dev" Cc: "andor" Subject: Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build Date: 2021-02-10 17:26 Haha, it scared me. Let me go through this accident. The root cause is: I'm over-confident, frivolous and hasty. I flatter myself that it's just a typo an

Re: [Commit Accident Case Study] Commit 4faf507 broke the build

2021-02-13 Thread Andor Molnar
Hi Ben, Sure, here’re the daily builds: https://ci-hadoop.apache.org/view/ZooKeeper/job/zookeeper-multi-branch-build/ I see bind failed (address already in use) exception much more frequently on branch-3.7 and master branches. It would worth to diff with 3.6, I suspect we introduced something

Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build

2021-02-12 Thread Benjamin Reed
thank you for figuring this out! two questions: 1) is there a daily test build still running? if so, where can we see its status? 2) what is the easiest way to retrigger tests? (sorry, i know i've asked this before :'( ) ben On Wed, Feb 10, 2021 at 2:18 AM Szalay-Bekő Máté wrote: > > > For

Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build

2021-02-10 Thread Szalay-Bekő Máté
> For punishment: > I will frozen/forbid my committership permission for three months I think you took this too seriously. Mistakes / accidents happen when someone is working (I did much more serious ones myself on different projects). And the community is grateful for the contribution, no one

Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build

2021-02-10 Thread Justin Ling Mao
Haha, it scared me. Let me go through this accident. The root cause is: I'm over-confident, frivolous and hasty. I flatter myself that it's just a typo and committing it could not have anything bad happens. And I also don't give this PR a buffer time for other people's review. Accident is bad,