Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ --- (Updated 2011-07-28 07:13:52.220703) Review request for zookeeper and Mahadev Ko

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-21 06:02:33, Patrick Hunt wrote: > > I ran "ant deb" successfully, although I have not yet tried to install it. > > I noticed a couple issues with the generated package. > > > > shouldn't /etc/zookeeper contain zoo.cfg? > > > > drwxr-xr-x 0/0 0 2011-07-20 22:41 ./etc

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-22 18:50:04, Patrick Hunt wrote: > > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control, line 1 > > > > > > missing license - is there a way to add comments here or no? > > Eric Yang wrote: >

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-22 18:50:04, Patrick Hunt wrote: > > The packaging code itself looks pretty good now. I've moved on to verifying > > the installation, however I see issues installing the deb on a clean ubuntu > > 10.10. Can you try generating the packages, install them and work through > > these?

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-22 18:50:04, Patrick Hunt wrote: > > The packaging code itself looks pretty good now. I've moved on to verifying > > the installation, however I see issues installing the deb on a clean ubuntu > > 10.10. Can you try generating the packages, install them and work through > > these?

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1169 --- The packaging code itself looks pretty good now. I've moved on to veri

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ --- (Updated 2011-07-22 18:24:20.565434) Review request for zookeeper and Mahadev Ko

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-20 18:00:29, Patrick Hunt wrote: > > ./src/packages/templates/conf/zoo.cfg, lines 1-12 > > > > > > no longer needed? Yes > On 2011-07-20 18:00:29, Patrick Hunt wrote: > > ./build.xml, lines 750-754 > >

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1149 --- I ran "ant deb" successfully, although I have not yet tried to install

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ --- (Updated 2011-07-21 05:31:05.468929) Review request for zookeeper and Mahadev Ko

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1140 --- a few small issues ./build.xml

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ --- (Updated 2011-07-20 17:45:08.665910) Review request for zookeeper and Mahadev Ko

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-19 22:46:10, Patrick Hunt wrote: > > 1) src/recipes/election has been added recently to trunk, are changes > > needed there as well? (see my comments below - seems like if we separated > > out pkg building from regular build it would make this more > > explicit/obvious) > > > > 2

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-19 22:46:10, Patrick Hunt wrote: > > 1) src/recipes/election has been added recently to trunk, are changes > > needed there as well? (see my comments below - seems like if we separated > > out pkg building from regular build it would make this more > > explicit/obvious) > > > > 2

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-19 22:46:10, Patrick Hunt wrote: > > 1) src/recipes/election has been added recently to trunk, are changes > > needed there as well? (see my comments below - seems like if we separated > > out pkg building from regular build it would make this more > > explicit/obvious) > > > > 2

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-19 22:46:10, Patrick Hunt wrote: > > 1) src/recipes/election has been added recently to trunk, are changes > > needed there as well? (see my comments below - seems like if we separated > > out pkg building from regular build it would make this more > > explicit/obvious) > > > > 2

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-19 22:16:54, Patrick Hunt wrote: > > there are a number of places in this patch where ZooKeeper is referred to > > as Zookeeper, this should be made consistent ("ZooKeeper"). Will do. - Eric --- This is an automatically ge

Re: Review Request: ZOOKEEPER-999 Create an package integration project

> On 2011-07-19 22:46:10, Patrick Hunt wrote: > > ./bin/zkEnv.sh, lines 31-35 > > > > > > this was recently changed by ZOOKEEPER-1084 to either use the variable > > if passed, or use ../conf (but not ../etc) Hadoop stack

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1120 --- 1) src/recipes/election has been added recently to trunk, are changes

Re: Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/#review1119 --- there are a number of places in this patch where ZooKeeper is referred

Review Request: ZOOKEEPER-999 Create an package integration project

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1143/ --- Review request for zookeeper and Mahadev Konar. Summary --- This goal of th