Re: Review Request: automating log and snapshot cleaning

2011-09-01 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1043/ --- (Updated 2011-09-01 16:40:46.185217) Review request for zookeeper, Patrick

Re: Review Request: automating log and snapshot cleaning

2011-07-19 Thread Patrick Hunt
On 2011-07-07 23:40:32, Patrick Hunt wrote: The documentation (src/docs) need to be updated - specifically the cleanup section in the admin guide. Have you considered hooking this into JMX or the 4letterwords? It would be nice for operators to get basic information. In JMX they

Re: Review Request: automating log and snapshot cleaning

2011-07-19 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1043/#review1116 --- This is looking pretty close! ./conf/zoo_sample.cfg

Re: Review Request: automating log and snapshot cleaning

2011-07-15 Thread Laxman Ch
On 2011-07-07 23:40:32, Patrick Hunt wrote: The documentation (src/docs) need to be updated - specifically the cleanup section in the admin guide. Have you considered hooking this into JMX or the 4letterwords? It would be nice for operators to get basic information. In JMX they

Review Request: automating log and snapshot cleaning

2011-07-07 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1043/ --- Review request for zookeeper, Patrick Hunt, Benjamin Reed, and Mahadev Konar.

Re: Review Request: automating log and snapshot cleaning

2011-07-07 Thread Camille Fournier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1043/#review1000 --- Are people just supposed to create their own new ZooKeeperPurger and

Re: Review Request: automating log and snapshot cleaning

2011-07-07 Thread Patrick Hunt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1043/#review998 --- The documentation (src/docs) need to be updated - specifically the

Re: Review Request: automating log and snapshot cleaning

2011-07-07 Thread Patrick Hunt
On 2011-07-07 23:34:13, Camille Fournier wrote: Are people just supposed to create their own new ZooKeeperPurger and call start on it? I don't see any hooks for starting this anywhere, or even a main method to use to start it. Would be nice to give that to people so they have a

Re: Review Request: automating log and snapshot cleaning

2011-07-07 Thread Patrick Hunt
On 2011-07-07 23:40:32, Patrick Hunt wrote: ./src/java/main/org/apache/zookeeper/ZooKeeperPurger.java, lines 74-77 https://reviews.apache.org/r/1043/diff/1/?file=22149#file22149line74 move this check to the start method. 1) INFO level log if turned off 2) exit the