[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132010827 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112975#comment-16112975 ] Jonathan Halterman commented on ZOOKEEPER-1416: --- I'm really interested to see this move

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112838#comment-16112838 ] Hadoop QA commented on ZOOKEEPER-1416: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112803#comment-16112803 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @hanm done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112200#comment-16112200 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user hanm commented on the issue

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/136 This patch requires a rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

ZOOKEEPER-1416 - can we get some movement?

Hi Folks, The number of watches in our system here at Elastic Cloud is causing severe problems. I created a patch that implements ZOOKEEPER-1416 in March. We'd really love to see some movement on this. It would reduce the number of watches in our system by orders of magnitude. I'm sure we're

Failed: ZOOKEEPER-1416 PreCommit Build #3640

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3640/ ### ## LAST 60 LINES OF THE CONSOLE

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107349#comment-16107349 ] Jordan Zimmerman commented on ZOOKEEPER-1416: - [~hanm] This issue now has 13 votes - what

Re: ZOOKEEPER-1416

> On Thu, Mar 9, 2017 at 6:26 PM, Jordan Zimmerman < > > jor...@jordanzimmerman.com> wrote: > > > >> ping > >> > >> On Mar 2, 2017, at 8:06 AM, Jordan Zimmerman < > jor...@jordanzimmerman.com> > >> wrote: > >> > >> H

Re: ZOOKEEPER-1416

dan Zimmerman < > jor...@jordanzimmerman.com> wrote: > >> ping >> >> On Mar 2, 2017, at 8:06 AM, Jordan Zimmerman <jor...@jordanzimmerman.com> >> wrote: >> >> Hey Folks, >> >> I'd like to see movement on ZOOKEEPER-1416. Michael Han has som

Re: ZOOKEEPER-1416

, > > I'd like to see movement on ZOOKEEPER-1416. Michael Han has some issues > (most of them I've addressed). This is a really great feature for ZooKeeper > and will help the community. Also, there is a lot of support for it on > https://issues.apache.org/jira/browse/ZOOKEEPER-1416. Can so

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938964#comment-15938964 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @stuhood - FYI - here's a new version of Curator's cache recipes consolidated into one-recipe-to-rule-them-all that relies on this new Persistent Recursive Watch implementation.

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 Thanks @eribeiro - at minimum it would be good to get feedback. This feature will really help the community. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936774#comment-15936774 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue

Failed: ZOOKEEPER-1416 PreCommit Build #3620

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1416 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3620/ ### ## LAST 60 LINES OF THE CONSOLE

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15936752#comment-15936752 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on the issue

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/136 Hey @fpj, @phunt, @breed, @skamille (or any PMC/commiter), it would be really cool to have this patch by @Randgalt merged, wouldn't it? If you have any cycles would you mind to review this one?

Re: ZOOKEEPER-1416

ping > On Mar 2, 2017, at 8:06 AM, Jordan Zimmerman <jor...@jordanzimmerman.com> > wrote: > > Hey Folks, > > I'd like to see movement on ZOOKEEPER-1416. Michael Han has some issues (most > of them I've addressed). This is a really great feature for ZooKeeper and

ZOOKEEPER-1416

Hey Folks, I'd like to see movement on ZOOKEEPER-1416. Michael Han has some issues (most of them I've addressed). This is a really great feature for ZooKeeper and will help the community. Also, there is a lot of support for it on https://issues.apache.org/jira/browse/ZOOKEEPER-1416 <ht

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839573#comment-15839573 ] Henrik Nordvik commented on ZOOKEEPER-1416: --- When I read ZOOKEEPER-153 it looks to me

[jira] [Comment Edited] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836532#comment-15836532 ] Jordan Zimmerman edited comment on ZOOKEEPER-1416 at 1/25/17 9:39 PM

[jira] [Comment Edited] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836532#comment-15836532 ] Jordan Zimmerman edited comment on ZOOKEEPER-1416 at 1/24/17 7:56 PM

[jira] [Comment Edited] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836532#comment-15836532 ] Jordan Zimmerman edited comment on ZOOKEEPER-1416 at 1/24/17 7:53 PM

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836532#comment-15836532 ] Jordan Zimmerman commented on ZOOKEEPER-1416: - I'd note that this issue has 9 votes

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836514#comment-15836514 ] Michael Han commented on ZOOKEEPER-1416: bq. For the vast majority of use cases users just

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836468#comment-15836468 ] Jordan Zimmerman commented on ZOOKEEPER-1416: - * "I think persistent and recu

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836460#comment-15836460 ] Michael Han commented on ZOOKEEPER-1416: I have some design questions first: * I think

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793085#comment-15793085 ] Jordan Zimmerman commented on ZOOKEEPER-1416: - FYI - I've written Curator recipes

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793074#comment-15793074 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- GitHub user Randgalt opened a pull request

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783361#comment-15783361 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r94030738 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml --- @@ -729,7 +729,7 @@ Persistent recursive watches are set

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782327#comment-15782327 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782323#comment-15782323 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782039#comment-15782039 ] Hadoop QA commented on ZOOKEEPER-1416: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781533#comment-15781533 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781502#comment-15781502 ] Hadoop QA commented on ZOOKEEPER-1416: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781467#comment-15781467 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @stuhood I'll end up writing one for Apache Curator. The short answer is that large ZK users end up with 100s of thousands or millions of watchers when a few dozen would suffice. The use case is

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user stuhood commented on the issue: https://github.com/apache/zookeeper/pull/136 Driveby comment: would be great to see a "recipe" or some real world example of correctly using this API to watch a tree. Is the goal that consumption of only the watch events would be sufficient

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781462#comment-15781462 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user stuhood commented on the issue

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781440#comment-15781440 ] Jordan Zimmerman commented on ZOOKEEPER-1416: - It turns out that ignoring

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781088#comment-15781088 ] Edward Ribeiro commented on ZOOKEEPER-1416: --- My two cents: to leave as is would be **very

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781043#comment-15781043 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93960121 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,47 +40,52 @@ class WatchManager { private static final

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15781041#comment-15781041 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93960053 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779538#comment-15779538 ] Jordan Zimmerman commented on ZOOKEEPER-1416: - Question for reviewers: right now, when

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779534#comment-15779534 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779517#comment-15779517 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779489#comment-15779489 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93893162 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,47 +40,52 @@ class WatchManager { private static final

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779380#comment-15779380 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 > it is required to add a C client change in this patch too? @eribeiro C client work is separate. I usually add a new Jira for them. If/when this patch is accepted I'll do that. ---

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93889832 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,43 @@ synchronized void removeWatcher(Watcher watcher) {

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779366#comment-15779366 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779361#comment-15779361 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93889759 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779247#comment-15779247 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779248#comment-15779248 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779246#comment-15779246 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887170 --- Diff: src/java/test/org/apache/zookeeper/test/PersistentWatcherTest.java --- @@ -0,0 +1,170 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887652 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,47 +40,52 @@ class WatchManager { private static final

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887190 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,43 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/136 @Randgalt it is required to add a C client change in this patch too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779229#comment-15779229 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on the issue

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on the issue: https://github.com/apache/zookeeper/pull/136 @Randgalt yup, very cool the ``asIterable()`` solution. +1. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779222#comment-15779222 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on the issue

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779215#comment-15779215 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779212#comment-15779212 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779199#comment-15779199 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887080 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779197#comment-15779197 ] Hadoop QA commented on ZOOKEEPER-1416: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779195#comment-15779195 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93887048 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @eribeiro Have a look at the change to `PathIterator` I think this solves your desire while not breaking implicit contracts. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779190#comment-15779190 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on the issue

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779172#comment-15779172 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779171#comment-15779171 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779168#comment-15779168 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779169#comment-15779169 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779167#comment-15779167 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886810 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,19 @@ synchronized void dumpWatches(PrintWriter pwriter,

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886806 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher) {

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886802 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886789 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779166#comment-15779166 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886801 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886805 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -522,6 +566,15 @@ protected boolean removeWatches(Map pathVsWatcher,

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779164#comment-15779164 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886777 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779148#comment-15779148 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886566 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779145#comment-15779145 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user eribeiro commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886519 --- Diff: src/java/test/org/apache/zookeeper/test/PathIteratorTest.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779136#comment-15779136 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[jira] [Commented] (ZOOKEEPER-1416) Persistent Recursive Watch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779138#comment-15779138 ] ASF GitHub Bot commented on ZOOKEEPER-1416: --- Github user Randgalt commented on a diff

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886440 --- Diff: src/java/test/org/apache/zookeeper/test/PathIteratorTest.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

<    1   2   3   >