[
https://issues.apache.org/jira/browse/ZOOKEEPER-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139970#comment-13139970
]
Mahadev konar commented on ZOOKEEPER-1264:
--
Ben/Flavio,
Any comments?
Support Child watcher to be displayed with 4 letter zookeeper commands i.e,
wchs,wchp,wchc
--
Key: ZOOKEEPER-1274
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1274
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13139971#comment-13139971
]
Mahadev konar commented on ZOOKEEPER-1273:
--
@Thomas,
Might be better to do
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/4/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
Building remotely on solaris1
FATAL:
See https://builds.apache.org/job/ZooKeeper_trunk_solaris/34/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by timer
Building remotely on solaris1
FATAL:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.eb3374019bb_triggerwatchesoutofprocess.patch
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140004#comment-13140004
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.50edf991_triggerwatches_out.patch
trigger jenkins dummy
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kavita sharma reassigned ZOOKEEPER-1274:
Assignee: kavita sharma
Support Child watcher to be displayed with 4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1273:
---
Attachment: ZOOKEEPER-1273.patch
Copy'n'pasted unit test
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140028#comment-13140028
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/742/
###
## LAST 60 LINES OF THE CONSOLE
###
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1273
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/743/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.145d386_jutestuffoutdatanode.patch
trigger jenkins dummy
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/744/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140067#comment-13140067
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.145d386_triggerwatches_out.patch
trigger jenkins dummy
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/745/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140080#comment-13140080
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.145d386_triggerwatches_out.patch
trigger jenkins dummy
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.0e7f27c_moved_processtxnresult.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.145d386_jutestuffoutdatanode.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.145d386_triggerwatches_out.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.50edf991_triggerwatches_out.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.2799799_remove_processtxn.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was:
ZOOKEEPER-1250.eb3374019bb_triggerwatchesoutofprocess.patch)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.c4aa81b_remove_processtxn.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.readrequest.patch)
trigger jenkins dummy issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.8fc2ebe_jutestuffoutdatanode.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.563aafb9_remove_processtxn.patch)
trigger
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.f0fc1f28_triggerwatches.patch)
trigger jenkins
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.readrequest.patch)
trigger jenkins dummy issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.readrequest.patch)
trigger jenkins dummy issue
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: (was: ZOOKEEPER-1250.readrequest.patch)
trigger jenkins dummy issue
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/746/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140088#comment-13140088
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.c121ec_jute_out_datanode.patch
trigger jenkins dummy
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140123#comment-13140123
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/747/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.d23d30_copyStat_getStat.patch
trigger jenkins dummy
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.a948f6f_jute_out_datanode.patch
trigger jenkins dummy
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/748/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140158#comment-13140158
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/749/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140168#comment-13140168
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-1250:
---
Attachment: ZOOKEEPER-1250.a948f6f_jute_out_datanode.patch
trigger jenkins dummy
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1250
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/750/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140180#comment-13140180
]
Hadoop QA commented on ZOOKEEPER-1250:
--
-1 overall. Here are the results of
There's a reason why we have min set the way we do. ;-) ZK was never
designed for such tight latencies, first and foremost is
reliability/availability and correctness.
I suspect if you want that level of latency you'd be better off
turning down the ticktime instead. Then you're going to have to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2642/
---
Review request for bookkeeper.
Summary
---
save master key in header part
[
https://issues.apache.org/jira/browse/BOOKKEEPER-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140362#comment-13140362
]
jirapos...@reviews.apache.org commented on BOOKKEEPER-50:
-
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jordan Zimmerman updated ZOOKEEPER-1262:
Attachment: recipes.html
recipes.diff
Here is an updated
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140390#comment-13140390
]
Thomas Koch commented on ZOOKEEPER-1255:
I've created classes representing
https://issues.apache.org/jira/browse/ZOOKEEPER-1271
this was caused by https://issues.apache.org/jira/browse/ZOOKEEPER-1174
Ted (Camille) any insights on this? Can you comment on my findings
and ideas for a fix? If you can provide a patch asap that would be
great.
Patrick
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-1271:
Affects Version/s: 3.3.4
Fix Version/s: 3.3.4
testEarlyLeaderAbandonment
Rethrowing seems plausible at the micro level. I have a moment right now
and will look at the callers to see if I can understand this code better.
On Mon, Oct 31, 2011 at 11:40 AM, Patrick Hunt ph...@apache.org wrote:
https://issues.apache.org/jira/browse/ZOOKEEPER-1271
this was caused by
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1262
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/751/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140452#comment-13140452
]
Hadoop QA commented on ZOOKEEPER-1262:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140459#comment-13140459
]
Jordan Zimmerman commented on ZOOKEEPER-1262:
-
FYI - I don't have access
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140494#comment-13140494
]
Patrick Hunt commented on ZOOKEEPER-1262:
-
Hi Jordan - you do have access, the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-1273:
Component/s: tests
Fix Version/s: 3.5.0
Copy'n'pasted unit test
I've been thinking that we need better testing for the client code. In
particular it's currently difficult to simulate all the different
types of failures a client might see. I'm wondering how we might do
this - two ideas come to mind; 1) aspectj and 2) mocks (mockito).
Anyone have other
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140547#comment-13140547
]
Vikas Mehta commented on ZOOKEEPER-1177:
Is it ok for me to submit this patch?
i know we have discussed this in the past, but we never really came to
a consensus or policy, so i'd like to reopen the discussion on cleanup
and subjective patches.
currently there are 7 jiras for cleanup issues, 6 of them marked as
major. the problem with cleanup or subjective patches is that
This is a bold position.
I can't disagree with the prioritization. And I can't disagree with the
risk assessment (see
https://issues.apache.org/jira/browse/ZOOKEEPER-1271for an example
where my fixing one bug caused another).
But summarily rejecting all such changes seems a bit harsh. I think
Is that any better?
In some sense, it can be said to be worse because the enhancement or bug
fix would be the focus of review. That could make it less likely that the
bugs caused by the aesthetic changes are overlooked.
On Mon, Oct 31, 2011 at 2:15 PM, Benjamin Reed br...@apache.org wrote:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140572#comment-13140572
]
Ted Dunning commented on ZOOKEEPER-1271:
I traced through this code and it
Thanks to Ted for replying. I will save the mail I started in the drafts
folder until I've calmed down again.
Benjamin Reed:
deprioritizing them doesn't help because the patches themselves bit
rot. shortly they will not apply and then they will be worthless. the
poor contributor would then be
Jumping over to Ben's side of the discussion,
Git helps with this, but does not eliminate the problem. At some point the
changes become difficult to understand relative to the new code and may
even collide in ways that are difficult to merge.
It is true, however, that patches can be kept live
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13140598#comment-13140598
]
Patrick Hunt commented on ZOOKEEPER-1177:
-
Hi Vikas, yes, you can submit at
Benjamin Reed:
i know we have discussed this in the past, but we never really came to
a consensus or policy, so i'd like to reopen the discussion on cleanup
and subjective patches.
Just one question: Could you please try to elaborate on how a non subjective
distinction could be made between
One test for this is to note when reasonable experts disagree on the
correct action on a non-functional basis.
A key example is indentation. Nobody worth listening to makes an argument
that bad indentation or the use of tabs directly causes a bug.
A counter example is a behavior that is
that isn't really middle ground. adding new tests for code is added
functionality, so it would be a valid patch under the criteria i
suggested. changing an int to an enum is not adding functionality. the
later may be subjectively better and the former adds functionality.
the nice thing is that you
What is an aesthetic change? Thomas just removed a duplicate test in
the source base (copy/paste), should that go in or not? (imo it
should) Many of the changes that have been going in are improvements,
such as reducing warnings in eclipse so that when you are using
eclipse you can actually see
Thomas,
Let me second that suggestion. If you could figure out how to make tests
easier to do without starting a full scale server, it would make a BIG
positive impact.
On Mon, Oct 31, 2011 at 4:31 PM, Patrick Hunt ph...@apache.org wrote:
I'd love it if someone were willing to work with me on
I'd have to agree with Pat here. I think we should be open to code
cleanup especially code cleanup that makes testing easier. There is no
harm in folks contributing minor cleanups (all the more easier to
review). It is a nice way of encouraging folks to contribute more and
get more involved in the
those pieces of code are core to the system. as i said for
reasonsearlier, risking destabilizing them to make the code look
prettier forsome definition of pretty does not seem wise to me.
changing code toadd functionality such as testability, performance,
bug fix, etc doesseem wise.
even then, i
I am all for using mockito. I have found it very handy in writing good
unit tests. Our codebase needs little changes to be able to unit test
our codebase.
Writing a real unit test for the java client would be a good use
case to see what all changes need to happen on the client.
thanks
mahadev
[
https://issues.apache.org/jira/browse/BOOKKEEPER-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sijie Guo updated BOOKKEEPER-50:
Attachment: BookieReadAfterBookieRestartTest.java
Add a test case to reproduce this issue.
79 matches
Mail list logo