[
https://issues.apache.org/jira/browse/ZOOKEEPER-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benedict Jin updated ZOOKEEPER-2790:
Fix Version/s: 4.0.0
> Should we consider using `LongAdder` instead of `AtomicLong`
>
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/262
A good and interesting question!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022741#comment-16022741
]
ASF GitHub Bot commented on ZOOKEEPER-2789:
---
Github user maoling commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023057#comment-16023057
]
ASF GitHub Bot commented on ZOOKEEPER-2733:
---
Github user afine closed the pull request at:
Mike Heffner created ZOOKEEPER-2791:
---
Summary: Quorum doesn't recover after zxid rollover
Key: ZOOKEEPER-2791
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2791
Project: ZooKeeper
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/232
+1 LGTM, I'll commit this shortly.
Thanks @afine for the good work.
Thanks @hanm for the reviews.
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022989#comment-16022989
]
ASF GitHub Bot commented on ZOOKEEPER-2762:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R resolved ZOOKEEPER-2733.
-
Resolution: Fixed
> Cleanup findbug warnings in branch-3.4: Dodgy code Warnings
>
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/236
Merged, please close pr @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
+1 LGTM.
@afine, could you please rebase the patch on latest branch-3.4 code, there
are few conflicts due to `ZOOKEEPER-2732` commits.
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023044#comment-16023044
]
ASF GitHub Bot commented on ZOOKEEPER-2733:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated ZOOKEEPER-2749:
Affects Version/s: 3.4.10
> Cleanup findbug warnings in branch-3.4: Experimental Warnings
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated ZOOKEEPER-2733:
Affects Version/s: 3.4.10
> Cleanup findbug warnings in branch-3.4: Dodgy code Warnings
>
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022962#comment-16022962
]
ASF GitHub Bot commented on ZOOKEEPER-2762:
---
Github user rakeshadr commented on a diff in
Github user rakeshadr commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/239#discussion_r118267625
--- Diff: src/java/test/config/findbugsExcludeFile.xml ---
@@ -90,6 +90,16 @@
+
+
--- End diff --
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/236
Thanks @afine for the contribution.
+1 LGTM, I'll commit shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023015#comment-16023015
]
ASF GitHub Bot commented on ZOOKEEPER-2733:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023060#comment-16023060
]
Rakesh R commented on ZOOKEEPER-2730:
-
[~gosubpl], I'd appreciate if you could post a pull request
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1508/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 2.64 MB...]
[junit] 2017-05-24
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R resolved ZOOKEEPER-2731.
-
Resolution: Fixed
Issue resolved by pull request 232
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023159#comment-16023159
]
ASF GitHub Bot commented on ZOOKEEPER-2731:
---
Github user rakeshadr commented on the issue:
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/232
Merged, please close pr @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/999/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 31.28 MB...]
[junit] 2017-05-24 16:27:43,984
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023229#comment-16023229
]
ASF GitHub Bot commented on ZOOKEEPER-2731:
---
Github user afine closed the pull request at:
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1509/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by an SCM change
Started by an SCM change
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
Thanks @afine for the updates.
+1, changes looks pretty good. I will merge this shortly.
---
If your project is set up for it, you can reply to this email and have your
reply
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1510/
###
## LAST 60 LINES OF THE CONSOLE
###
Started by an SCM change
[EnvInject] - Loading node
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023989#comment-16023989
]
ASF GitHub Bot commented on ZOOKEEPER-2762:
---
Github user afine commented on the issue:
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/239
@rakeshadr this should be rebased and ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024084#comment-16024084
]
ASF GitHub Bot commented on ZOOKEEPER-2762:
---
Github user rakeshadr commented on the issue:
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/746/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 34.99 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024071#comment-16024071
]
Hadoop QA commented on ZOOKEEPER-2762:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R resolved ZOOKEEPER-2762.
-
Resolution: Fixed
Issue resolved by pull request 239
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/239
Merged, please close the PR, @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024118#comment-16024118
]
ASF GitHub Bot commented on ZOOKEEPER-2762:
---
Github user rakeshadr commented on the issue:
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1527/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 31.17 MB...]
[junit] 2017-05-25 04:00:52,520
Github user afine closed the pull request at:
https://github.com/apache/zookeeper/pull/239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abraham Fine reassigned ZOOKEEPER-2791:
---
Assignee: Abraham Fine
> Quorum doesn't recover after zxid rollover
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024154#comment-16024154
]
ASF GitHub Bot commented on ZOOKEEPER-2762:
---
Github user afine closed the pull request at:
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/262#discussion_r118168282
--- Diff:
src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java ---
@@ -121,8 +121,8 @@ public JsonGenerator(LogIterator iter) {
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/240
@hanm I don't think it is ever safe to make assumptions about the state of
the process after a bug/"programming problem" has been encountered. So I think
its better to exit the process.
I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022355#comment-16022355
]
ASF GitHub Bot commented on ZOOKEEPER-2684:
---
Github user nerdyyatrice commented on the
Github user nerdyyatrice commented on the issue:
https://github.com/apache/zookeeper/pull/167
I canât repro it on my laptop so I tried to see if it can pass on the
machine. I will look into code in more detail.
> On May 23, 2017, at 9:15 PM, Michael Han
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022356#comment-16022356
]
ASF GitHub Bot commented on ZOOKEEPER-2789:
---
Github user asdf2014 commented on a diff in the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022364#comment-16022364
]
ASF GitHub Bot commented on ZOOKEEPER-2757:
---
Github user afine commented on the issue:
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/741/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 69.98 MB...]
[exec] +0
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022366#comment-16022366
]
Hadoop QA commented on ZOOKEEPER-2757:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/744/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 68.12 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022510#comment-16022510
]
Hadoop QA commented on ZOOKEEPER-2789:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/742/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 3.14 KB...]
[exec]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022448#comment-16022448
]
ASF GitHub Bot commented on ZOOKEEPER-2789:
---
Github user asdf2014 commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022407#comment-16022407
]
ASF GitHub Bot commented on ZOOKEEPER-2789:
---
Github user asdf2014 commented on a diff in the
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/262#discussion_r118176130
--- Diff:
src/contrib/loggraph/src/java/org/apache/zookeeper/graph/JsonGenerator.java ---
@@ -121,8 +121,8 @@ public JsonGenerator(LogIterator iter) {
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/743/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 3.13 KB...]
[exec] % Total
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/262
Due to this [jvm
bug](http://bugs.java.com/bugdatabase/view_bug.do?bug_id=7177813), JDK7 cannot
recognition `static import`... I will use fully qualified name replace of it.
```bash
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022547#comment-16022547
]
Hadoop QA commented on ZOOKEEPER-2789:
--
-1 overall. GitHub Pull Request Build
+1
Benedict Jin created ZOOKEEPER-2790:
---
Summary: Should we consider using `LongAdder` instead of
`AtomicLong`
Key: ZOOKEEPER-2790
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2790
Project:
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1525/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 30.78 MB...]
[junit] 2017-05-24 21:18:14,529
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023091#comment-16023091
]
ASF GitHub Bot commented on ZOOKEEPER-2731:
---
Github user rakeshadr commented on the issue:
61 matches
Mail list logo
