Re: Proposal for reworked ZK web site generation: CMS -> jekyll

Although I'm not a committer I really appreciate this work. Andor On Fri, Dec 1, 2017 at 1:51 AM, Michael Han wrote: > +1, the new publish process sounds much better. Thanks Pat. > > On Thu, Nov 30, 2017 at 5:00 AM, Camille Fournier > wrote: > > > +1 good

[jira] [Commented] (ZOOKEEPER-2793) [QP MutualAuth]: Implement a mechanism to build "authzHosts" for dynamic reconfig servers

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274757#comment-16274757 ] Patrick Hunt commented on ZOOKEEPER-2793: - > Does this make sense to you? Yes, I believe that

Re: Proposal for reworked ZK web site generation: CMS -> jekyll

Thanks for all the feedback everyone. I didn't mean to exclude non-committers from providing feedback, all is welcome (just that I do need some committers to +1 this thing, thanks for that). I've pushed the website and asf-site branches to the official git repo and created the following jira with

Re: Squash/fixup commits

I think in most cases what Abe mentioned makes sense. That's the easiest way to see the changes between updates to a PR. The tool Camille linked to manages the cherry-pick process for the committer so that's handled no problems. Usually. The only issue is when a PR can't be merged on the the

[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274817#comment-16274817 ] ASF GitHub Bot commented on ZOOKEEPER-2807: --- Github user afine commented on the issue:

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/300 Thanks for taking a look @anmolnar! I'm confused by what you mean in item 3. Unless I am missing something, I don't understand how `FollowerZooKeeperServer` is "already running and keep

Re: Squash/fixup commits

You can find details here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes C On Fri, Dec 1, 2017 at 1:25 AM, Andor Molnar wrote: > Hi, > > @afine raised this on my latest PR: > "going forward it would be great if you didn't squash your commits when

[GitHub] zookeeper pull request #423: ZOOKEEPER-2949: using hostname and port to crea...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/423#discussion_r154133881 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java --- @@ -340,13 +340,24 @@ public static Packet getInstance() {

[jira] [Commented] (ZOOKEEPER-2949) SSL ServerName not set when using hostname, some proxies may failed to proxy the request.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274603#comment-16274603 ] ASF GitHub Bot commented on ZOOKEEPER-2949: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #423: ZOOKEEPER-2949: using hostname and port to crea...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/423#discussion_r154445237 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java --- @@ -340,13 +340,24 @@ public static Packet getInstance() {

[jira] [Commented] (ZOOKEEPER-2949) SSL ServerName not set when using hostname, some proxies may failed to proxy the request.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274953#comment-16274953 ] ASF GitHub Bot commented on ZOOKEEPER-2949: --- Github user afine commented on a diff in the

Success: ZOOKEEPER- PreCommit Build #1326

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1326/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 73.50 MB...] [exec]

Re: Proposal for reworked ZK web site generation: CMS -> jekyll

Hi Patrick, +1 is just my non-counting vote. Looks really good. I've just found some broken tables in the following file: https://github.com/phunt/zookeeper/blob/website/credits.md which might be because github's markdown is not the same as other implementations. Regards, Tamaas On Fri, Dec

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274321#comment-16274321 ] Hadoop QA commented on ZOOKEEPER-2939: -- +1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274484#comment-16274484 ] ASF GitHub Bot commented on ZOOKEEPER-2807: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeepe...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/300#discussion_r154363054 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java --- @@ -327,6 +257,95 @@ public void run() {

[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274498#comment-16274498 ] ASF GitHub Bot commented on ZOOKEEPER-2807: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeepe...

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/300#discussion_r154367742 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java --- @@ -240,84 +240,14 @@ public void run() { }

[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274540#comment-16274540 ] ASF GitHub Bot commented on ZOOKEEPER-2807: --- Github user anmolnar commented on the issue:

[GitHub] zookeeper issue #300: ZOOKEEPER-2807: Flaky test: org.apache.zookeeper.test....

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/300 @afine Generally speaking, I like the idea of using LinkedBlockingQueue's intrinsic lock to wait for becoming empty, but in this particular case I think it's possible that committedRequests will

[jira] [Commented] (ZOOKEEPER-2915) Use "strict" conflict management in ivy

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275180#comment-16275180 ] ASF GitHub Bot commented on ZOOKEEPER-2915: --- Github user phunt commented on the issue:

ZooKeeper-trunk - Build # 3638 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk/3638/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.54 MB...] [junit] at

[GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java

Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/420 > I don't think most of these tests make any assertions that could be impacted by the snapCount. This is an ambiguous statement to me. You do see that some of the tests are impacted

[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275195#comment-16275195 ] ASF GitHub Bot commented on ZOOKEEPER-2924: --- Github user phunt commented on the issue:

[GitHub] zookeeper issue #426: ZOOKEEPER-2915: Use "strict" conflict management in iv...

Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/426 Look good. +1 thanks Abe. Please close this as it's not the default branch. ---

[jira] [Resolved] (ZOOKEEPER-2915) Use "strict" conflict management in ivy

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-2915. - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.4.11