[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181002193 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435149#comment-16435149 ] ASF GitHub Bot commented on ZOOKEEPER-2959: --- Github user lavacat commented on a diff in the

Success: ZOOKEEPER- PreCommit Build #1571

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1571/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.74 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435153#comment-16435153 ] ASF GitHub Bot commented on ZOOKEEPER-2959: --- Github user lavacat commented on a diff in the

[GitHub] zookeeper issue #500: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO a...

Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/500 Moved these 3 new tests into new class - LeaderWithObserverTest. Had to make createLeader and createQuorumPeer 'public static' in Zab1_0Test. Happy to refactor into common base class ---

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435154#comment-16435154 ] ASF GitHub Bot commented on ZOOKEEPER-2959: --- Github user lavacat commented on the issue:

[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

Github user lavacat commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/500#discussion_r181001854 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java --- @@ -245,6 +245,180 @@ public void testLastAcceptedEpoch() throws Exception

[GitHub] zookeeper issue #500: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO a...

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/500 @lavacat I think either moving these methods/classes to a base class or creating a separate `ZabUtils` makes sense in this case to get cleaner code. ---

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435177#comment-16435177 ] ASF GitHub Bot commented on ZOOKEEPER-2959: --- Github user anmolnar commented on the issue:

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435275#comment-16435275 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- GitHub user nkalmar opened a pull request:

ZooKeeper-trunk-jdk8 - Build # 1439 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1439/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.23 KB...] [junit] Tests run: 1, Failures: 0,

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435465#comment-16435465 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

GitHub user nkalmar opened a pull request: https://github.com/apache/zookeeper/pull/501 ZOOKEEPER-3019 add metric for slow fsyncs count Added metric to count fsyncWarningThresholdMS exceed in FileTxnLog.commit(). Both jmx bean and Command can be used to get the stat. Also

Success: ZOOKEEPER- PreCommit Build #1572

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1572/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.28 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435466#comment-16435466 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181059907 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -146,6 +149,16 @@ public FileTxnLog(File logDir) {

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181060856 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -32,6 +32,7 @@ private long minLatency = Long.MAX_VALUE;

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435474#comment-16435474 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user nkalmar commented on a diff in the

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181063500 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -32,6 +32,7 @@ private long minLatency = Long.MAX_VALUE;

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181134958 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -55,6 +53,7 @@ private final File snapDir;

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435832#comment-16435832 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user edwardoliveira commented on a diff

[GitHub] zookeeper issue #499: ZOOKEEPER-3017: Link libm in CMake on FreeBSD.

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/499 Yay @anmolnar the tests were flaky, last CI run was clean. ---

[jira] [Commented] (ZOOKEEPER-3017) Link libm in CMake on FreeBSD

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435877#comment-16435877 ] ASF GitHub Bot commented on ZOOKEEPER-3017: --- Github user andschwa commented on the issue:

ZooKeeper_branch34_openjdk7 - Build # 1878 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1878/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 39.67 KB...] [junit] Running

[GitHub] zookeeper issue #486: ZOOKEEPER-2999: CMake build should use target-level co...

Github user andschwa commented on the issue: https://github.com/apache/zookeeper/pull/486 @anmolnar Yay! Flaky tests passed CI. ---

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435787#comment-16435787 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user edwardoliveira commented on a diff

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435791#comment-16435791 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user edwardoliveira commented on a diff

Success: ZOOKEEPER- PreCommit Build #1573

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1573/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.84 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435790#comment-16435790 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user edwardoliveira commented on a diff

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181126991 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -30,10 +30,8 @@ import

[jira] [Commented] (ZOOKEEPER-3017) Link libm in CMake on FreeBSD

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435902#comment-16435902 ] ASF GitHub Bot commented on ZOOKEEPER-3017: --- Github user anmolnar commented on the issue:

[GitHub] zookeeper issue #499: ZOOKEEPER-3017: Link libm in CMake on FreeBSD.

Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/499 @andschwa yeah, I've managed to run it locally fine. ---

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435920#comment-16435920 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user nkalmar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2999) CMake build should use target-level commands

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435919#comment-16435919 ] ASF GitHub Bot commented on ZOOKEEPER-2999: --- Github user andschwa commented on the issue:

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user nkalmar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181150889 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -55,6 +53,7 @@ private final File snapDir;

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181129644 --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java --- @@ -148,9 +150,23 @@ synchronized public void resetRequestCounters(){

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181127170 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java --- @@ -135,6 +136,8 @@ long currentSize; File

[GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count

Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/501#discussion_r181127430 --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java --- @@ -55,6 +53,7 @@ private final File snapDir;

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435806#comment-16435806 ] ASF GitHub Bot commented on ZOOKEEPER-3019: --- Github user edwardoliveira commented on a diff

Success: ZOOKEEPER- PreCommit Build #1574

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1574/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 40.43 MB...] [exec] +1

ZooKeeper_branch34_jdk7 - Build # 1881 - Failure

See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1881/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 38.40 KB...] [junit] Running

ZooKeeper-trunk - Build # 3797 - Still Failing

See https://builds.apache.org/job/ZooKeeper-trunk/3797/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 141.93 KB...] [junit] Running

[GitHub] zookeeper issue #500: ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO a...

Github user lavacat commented on the issue: https://github.com/apache/zookeeper/pull/500 @anmolnar added ZabUtils ---

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436644#comment-16436644 ] ASF GitHub Bot commented on ZOOKEEPER-2959: --- Github user lavacat commented on the issue: