Hey Michael,
I was trying to merge yesterday a PR generated against branch-3.5, and fetching
the PR branch did not give me the merge script. I ended up asking the
contributor to change the target branch to master so that I avoid any small
hacks with the merge script.
We should consider doing t
Oded created ZOOKEEPER-3036:
---
Summary: Unexpected exception in zookeeper
Key: ZOOKEEPER-3036
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3036
Project: ZooKeeper
Issue Type: Bug
C
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/952/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 7.76 KB...]
[ivy:retrieve] found commons-cli#common
So I am trying to create a patch in order to expose on JMX the id of the
current "leader" (on the JVM of a follower)
I am trying to find in ZK which is the variable which holds the ID of the
current leader.
I am new to the internal of QuorumPeer
Can someone give me some hint ?
Enrico
Il giorno
Hi Enrico,
Well, I am not an expert on QuorumPeer either (not an expert on anything,
really), but maybe it's the variable and method below?
- QuorumPeer --
/**
* This is who I think the leader currently is.
*/
volatile private Vote currentVote;
public synchroni
Sent before finishing the previous email. Only to complement, the
findLeader() could have been as below, but this change is only a nitty
detail and totally irrelevant to the questions you are asking. :)
/**
* Returns the address of the node we think is the leader.
*/
protected QuorumServer findL
Hi,
I just got a tip that we could improve on the logging in ZooKeeper. After a
ZK crash, or client timeout sometimes it's hard to determine from the logs
what happened. Knowing if ZK was responsive at the time would help a lot.
For example, ZK might spend a lot of time waiting on GC (there is sti
+1. Sounds really nice to have feature. Let's open a ticket and open a PR.
:)
Ed
Em qua, 9 de mai de 2018 11:15, Norbert Kalmar
escreveu:
> Hi,
>
> I just got a tip that we could improve on the logging in ZooKeeper. After a
> ZK crash, or client timeout sometimes it's hard to determine from the
I like the idea of indicating to the application that there is something wrong
with the list of servers so that it has a chance to look into it. With the
current code in `ClientCnxn`, we will log at warn level and hope that someone
sees it, but we are not really stopping the client. Throwing mig
Norbert Kalmar created ZOOKEEPER-3037:
-
Summary: Add JvmPauseMonitor to ZooKeeper
Key: ZOOKEEPER-3037
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3037
Project: ZooKeeper
Issue Ty
Okay, thanks Ed, I created the Jira, will look into it soon :)
https://issues.apache.org/jira/browse/ZOOKEEPER-3037
Regards,
Norbert
On Wed, May 9, 2018 at 4:44 PM Edward Ribeiro
wrote:
> +1. Sounds really nice to have feature. Let's open a ticket and open a PR.
> :)
>
> Ed
>
> Em qua, 9 de mai
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar reassigned ZOOKEEPER-3037:
-
Assignee: Norbert Kalmar
> Add JvmPauseMonitor to ZooKeeper
> ---
I'm actually now wondering whether we should be using an unchecked exception
instead. A lot of things have changed with exception handling since we wrote
this code base initially. An unchecked exception would actually match better my
current mental model of what that signature should look like.
Thank you Edward
I will pack all together and send out a patch as soon as I have time.
I am running 3.5 in production and given than an RC for 3.5.4 is going to
be cut soon I will have to wait for 3.5.5 and I assume it won't be
immediate.
Cheers
Enrico
Il giorno mer 9 mag 2018 alle ore 14:37 Edw
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norbert Kalmar updated ZOOKEEPER-3037:
--
Description:
After a ZK crash, or client timeout sometimes it's hard to determine fr
+1 cool!
On Wed, May 9, 2018 at 7:59 AM, Norbert Kalmar wrote:
> Okay, thanks Ed, I created the Jira, will look into it soon :)
> https://issues.apache.org/jira/browse/ZOOKEEPER-3037
>
> Regards,
> Norbert
>
> On Wed, May 9, 2018 at 4:44 PM Edward Ribeiro
> wrote:
>
> > +1. Sounds really nice
I am updating my local repo and noticed some transaction logs and snapshots
files in src/java/test/data/invalidsnap/version-2. Are those files static
data used by unit tests or just artifacts accidentally pushed to the repo?
ls -lah src/java/test/data/invalidsnap/version-2/
total 936
drwxr-xr-x
Hi Ed,
Static data used by unit tests.
Andor
On Wed, May 9, 2018 at 9:46 AM, Edward Ribeiro
wrote:
> I am updating my local repo and noticed some transaction logs and snapshots
> files in src/java/test/data/invalidsnap/version-2. Are those files static
> data used by unit tests or just artif
Oh, nice. Thanks, Andor!
Ed
On Wed, May 9, 2018 at 1:52 PM, Andor Molnar wrote:
> Hi Ed,
>
> Static data used by unit tests.
>
> Andor
>
>
>
> On Wed, May 9, 2018 at 9:46 AM, Edward Ribeiro
> wrote:
>
> > I am updating my local repo and noticed some transaction logs and
> snapshots
> > files i
Do you know why they did this rather than just enabling GC logging by
default? Why re-invent the wheel?
I seem to remember seeing a push do enable GC logging by default a few
years ago. In particular around the time when the JVM added GC log rolling
as a feature. Here's an example:
https://batmat.
On Wed, May 9, 2018 at 1:18 AM, Flavio Junqueira wrote:
> Hey Michael,
>
> I was trying to merge yesterday a PR generated against branch-3.5, and
> fetching the PR branch did not give me the merge script. I ended up asking
> the contributor to change the target branch to master so that I avoid an
Thanks Patrick, great question.
My understanding is that this tool not only shows if JVM spends too much
time in GC, but if, for any other reason, there is a JVM pause (The tool
only differentiates GC pause from all other pause). This could be slow
fsync (although we do have logs for that) or even
iiuc what you are interested in the information is already available. The
beans have a "state" attribute which indicates following vs leading.
Try attaching a jconsole to the running servers, use the "mbeans" tab and
open org.apache.ZooKeeperService -> replicatedserver -> replica ->
attributes, yo
On Wed, May 9, 2018 at 11:11 AM, Norbert Kalmar
wrote:
> Thanks Patrick, great question.
> My understanding is that this tool not only shows if JVM spends too much
> time in GC, but if, for any other reason, there is a JVM pause (The tool
> only differentiates GC pause from all other pause). This
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/377
@Randgalt Not strictly part of this PR, but I noticed that ContainerManager
doesn't log the name of the container being deleted here:
```java
try {
LOG.info("Attempting to d
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/377
Never mind. I'll create a separate PR for that.
---
Thanks for the feedback, Pat. I think the wiki page with merge script
instructions needs updating. I'll explore it a bit further and will update it.
-Flavio
> On 9 May 2018, at 20:05, Patrick Hunt wrote:
>
> On Wed, May 9, 2018 at 1:18 AM, Flavio Junqueira wrote:
>
>> Hey Michael,
>>
>> I w
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469516#comment-16469516
]
Bogdan Kanivets commented on ZOOKEEPER-2959:
I think this is ready to merg
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/377
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt resolved ZOOKEEPER-2901.
-
Resolution: Fixed
Fix Version/s: 3.5.4
3.6.0
Issue resolved
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/514
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/514
+1, thanks @anmolnar
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/515
+1, thanks @anmolnar
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt resolved ZOOKEEPER-3012.
-
Resolution: Fixed
Hadoop Flags: Reviewed
> Fix unit test: testDataDirAndDataLogD
Github user anmolnar closed the pull request at:
https://github.com/apache/zookeeper/pull/515
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469624#comment-16469624
]
Hudson commented on ZOOKEEPER-3012:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469623#comment-16469623
]
Hudson commented on ZOOKEEPER-2901:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-
Andor Molnar created ZOOKEEPER-3038:
---
Summary: Cleanup some nitpicks in TTL implementation
Key: ZOOKEEPER-3038
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3038
Project: ZooKeeper
I
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/516
ZOOKEEPER-3038 Cleanup some nitpicks in TTL implementation
A few nitpicks which needs to be cleaned up:
1. Rename OldEphemeralType --> EphemeralTypeEmulate353
2. Remove unused method
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3038:
Description:
A few nitpicks which needs to be cleaned up:
1. Rename OldEphemeralType --
I believe we forked the script and the process/docs off another TLP,
perhaps spark or kafka? Might be worth checking what they are currently
doing/changed.
Patrick
On Wed, May 9, 2018 at 1:45 PM, Flavio Junqueira wrote:
> Thanks for the feedback, Pat. I think the wiki page with merge script
> i
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469641#comment-16469641
]
Hadoop QA commented on ZOOKEEPER-3038:
--
-1 overall. GitHub Pull Request Build
Andor Molnar created ZOOKEEPER-3039:
---
Summary: TxnLogToolkit uses Scanner badly
Key: ZOOKEEPER-3039
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3039
Project: ZooKeeper
Issue Type:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3039:
Affects Version/s: 3.6.0
3.5.4
> TxnLogToolkit uses Scanner badly
GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/517
ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly
Fixed by creating a single Scanner for all queries in the main() method.
You can merge this pull request into a Git repository by running:
$
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1669/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 2.14 MB...]
[exec] +1 javad
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469663#comment-16469663
]
Hadoop QA commented on ZOOKEEPER-3039:
--
-1 overall. GitHub Pull Request Build
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1670/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 34.13 KB...]
[exec]
[exec
FYI, the merge script was created in the Spark project then ported to Kafka
project. And Kafka version was ported to ZK. :)
Ed
Em qua, 9 de mai de 2018 19:46, Patrick Hunt escreveu:
> I believe we forked the script and the process/docs off another TLP,
> perhaps spark or kafka? Might be worth c
Hi,
This looks cool :) I have a suggestion. It would be nice if we could add
the current size of the heap or (% of heap used) in the log entry whenever
sleep threshold had exceeded a lot. It could be helpful.
On Wed, May 9, 2018 at 11:26 AM, Patrick Hunt wrote:
> On Wed, May 9, 2018 at 11:11 AM,
+1
On Mon, May 7, 2018 at 12:44 AM, Norbert Kalmar
wrote:
> Yes, the plan is to backport to 3.5 and also 3.4, but the possibility to
> backport just the package changes is still in question.
>
> I am writing up a document which I will share for comments. Should be done
> in 1 or 2 days. I am als
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/953/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 60.65 KB...]
[junit] Tests run: 1, Failures: 0,
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/512
+1 looks good
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Shraer resolved ZOOKEEPER-2959.
-
Resolution: Fixed
Fix Version/s: 3.4.13
3.6.0
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/516
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt resolved ZOOKEEPER-3038.
-
Resolution: Fixed
Fix Version/s: 3.5.4
3.6.0
Issue resolved
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/516
+1 - thanks Andor.
---
Many thanks to Patrick, Andor and the rest of the Cloudera team for hosting
us tonight. I appreciated the chance to compare notes with other users and
also discuss some of where the future of Zookeeper is heading.
Cheers,
Jeff
PS: Apologies to the remote folks for the dead sound at the end--the
h
On Wed, May 9, 2018 at 9:24 PM, Jeff Widman wrote:
> Many thanks to Patrick, Andor and the rest of the Cloudera team for hosting
> us tonight. I appreciated the chance to compare notes with other users and
> also discuss some of where the future of Zookeeper is heading.
>
>
Thanks everyone for at
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/378
@Randgalt can you close this out? I applied the master PR to branch-3.5 and
committed it already. I think this is taken care of, lmk otw.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt resolved ZOOKEEPER-2903.
-
Resolution: Fixed
Hadoop Flags: Reviewed
Resolved with commit 282dc836802f67ed48
See https://builds.apache.org/job/ZooKeeper-trunk/18/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 140.86 KB...]
[junit] Tests run: 1, Failures: 0, Errors:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469973#comment-16469973
]
Hudson commented on ZOOKEEPER-2959:
---
FAILURE: Integrated in Jenkins build ZooKeeper-
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469974#comment-16469974
]
Hudson commented on ZOOKEEPER-3038:
---
FAILURE: Integrated in Jenkins build ZooKeeper-
64 matches
Mail list logo