[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2315/ ---

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221938215 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221937665 --- Diff: src/java/test/org/apache/zookeeper/ClientCanonicalizeTest.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221937882 --- Diff: src/java/test/org/apache/zookeeper/ClientCanonicalizeTest.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221937931 --- Diff: src/java/test/org/apache/zookeeper/ClientCanonicalizeTest.java --- @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221936001 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/648 There were some comments in the other pull request about the test code. I will address them in both places. ---

Failed: ZOOKEEPER- PreCommit Build #2314

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2314/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.41 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2314/ ---

Failed: ZOOKEEPER- PreCommit Build #2315

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2315/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.72 MB...] [exec]

ZooKeeper_branch35_jdk8 - Build # 1138 - Failure

2018-10-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1138/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 105.84 KB...] [junit] Running

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221928277 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

Failed: ZOOKEEPER- PreCommit Build #2318

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2318/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.25 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2318/ ---

[jira] [Created] (ZOOKEEPER-3159) Flaky: ClientRequestTimeoutTest.testClientRequestTimeout

2018-10-02 Thread Andor Molnar (JIRA)
Andor Molnar created ZOOKEEPER-3159: --- Summary: Flaky: ClientRequestTimeoutTest.testClientRequestTimeout Key: ZOOKEEPER-3159 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3159 Project:

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221964223 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

[GitHub] zookeeper pull request #:

2018-10-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/c57b62d57b8b22d568b1cea3b8039566936e0558#commitcomment-30735811 In src/java/main/org/apache/zookeeper/SaslServerPrincipal.java: In

Failed: ZOOKEEPER- PreCommit Build #2316

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2316/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.09 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2316/ ---

[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/653 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2320/ ---

Success: ZOOKEEPER- PreCommit Build #2320

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2320/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 75.01 MB...] [exec] +1

[GitHub] zookeeper issue #652: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/zookeeper/pull/652 @anmolnar and @lvfangmin I think I have addressed all of your review comments. I named the new class SaslServerPrincipal but if you have a different idea for a name I am happy to change it.

Success: ZOOKEEPER- PreCommit Build #2324

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2324/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.34 MB...] [exec] +1

[GitHub] zookeeper issue #652: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/652 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2324/ ---

[jira] [Updated] (ZOOKEEPER-3159) Flaky: ClientRequestTimeoutTest.testClientRequestTimeout

2018-10-02 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated ZOOKEEPER-3159: Affects Version/s: 3.6.0 3.5.4 > Flaky:

[jira] [Updated] (ZOOKEEPER-3159) Flaky: ClientRequestTimeoutTest.testClientRequestTimeout

2018-10-02 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar updated ZOOKEEPER-3159: Fix Version/s: 3.5.5 3.6.0 > Flaky:

[jira] [Updated] (ZOOKEEPER-3159) Flaky: ClientRequestTimeoutTest.testClientRequestTimeout

2018-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3159: -- Labels: flaky flaky-test pull-request-available (was: flaky flaky-test) > Flaky:

[GitHub] zookeeper pull request #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest...

2018-10-02 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/653 ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testClientRequestTimeout Can't see a reason why testing again the create method without packet drop. Timeout scenario has already been tested and

Failed: ZOOKEEPER- PreCommit Build #2325

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2325/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.82 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/633 retest this please ---

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/633 retest this please ---

[GitHub] zookeeper pull request #650: ZOOKEEPER-1908: setAcl should be have a recursi...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/650#discussion_r221899955 --- Diff: src/java/test/org/apache/zookeeper/ZooKeeperTest.java --- @@ -566,4 +566,25 @@ public void testLsrNonexistantZnodeCommand() throws Exception {

[GitHub] zookeeper pull request #650: ZOOKEEPER-1908: setAcl should be have a recursi...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/650#discussion_r221922741 --- Diff: src/java/main/org/apache/zookeeper/cli/SetAclCommand.java --- @@ -69,9 +72,22 @@ public boolean exec() throws CliException {

Failed: ZOOKEEPER- PreCommit Build #2317

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2317/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.22 MB...] [exec]

[GitHub] zookeeper issue #652: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/652 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2321/ ---

Success: ZOOKEEPER- PreCommit Build #2321

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2321/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.58 MB...] [exec] +1

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/648 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2326/ ---

[GitHub] zookeeper pull request #654: ZOOKEEPER-3160: Custom User SSLContext

2018-10-02 Thread arankin-irl
GitHub user arankin-irl opened a pull request: https://github.com/apache/zookeeper/pull/654 ZOOKEEPER-3160: Custom User SSLContext The Zookeeper libraries currently allow you to set up your SSL Context via system properties such as "zookeeper.ssl.keyStore.location" in the

[jira] [Updated] (ZOOKEEPER-3160) Custom User SSLContext

2018-10-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3160: -- Labels: features pull-request-available ready-to-commit (was: features

[GitHub] zookeeper pull request #654: ZOOKEEPER-3160: Custom User SSLContext

2018-10-02 Thread arankin-irl
Github user arankin-irl commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/654#discussion_r222028424 --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java --- @@ -85,60 +85,73 @@ public static SSLContext createSSLContext() throws

[GitHub] zookeeper issue #654: ZOOKEEPER-3160: Custom User SSLContext

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/654 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2329/ ---

Failed: ZOOKEEPER- PreCommit Build #2329

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2329/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.56 MB...] [exec] Test

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2317/ ---

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread nkalmar
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/633 org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority seems pretty flaky, bu it runs without a problem on my local machine. Anyway, one

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221956355 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

Failed: ZOOKEEPER- PreCommit Build #2319

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2319/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.85 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2319/ ---

[GitHub] zookeeper issue #652: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/652 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2325/ ---

Success: ZOOKEEPER- PreCommit Build #2326

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2326/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 41.82 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #2327

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2327/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.09 MB...] [exec]

[GitHub] zookeeper issue #643: ZOOKEEPER-3153: Create MarkDown files and build proces...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/643 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2327/ ---

Failed: ZOOKEEPER- PreCommit Build #2328

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2328/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.44 MB...] [exec] Test

[GitHub] zookeeper issue #654: ZOOKEEPER-3160: Custom User SSLContext

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/654 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2328/ ---

[GitHub] zookeeper pull request #654: ZOOKEEPER-3160: Custom User SSLContext

2018-10-02 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/654#discussion_r222023353 --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java --- @@ -85,60 +85,73 @@ public static SSLContext createSSLContext() throws

Success: ZOOKEEPER- PreCommit Build #2322

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2322/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 33.80 MB...] [exec] +1

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/648 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2322/ ---

Success: ZOOKEEPER- PreCommit Build #2323

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2323/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 41.26 MB...] [exec] +1

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/648 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2323/ ---

[jira] [Created] (ZOOKEEPER-3160) Custom User SSLContext

2018-10-02 Thread Alex Rankin (JIRA)
Alex Rankin created ZOOKEEPER-3160: -- Summary: Custom User SSLContext Key: ZOOKEEPER-3160 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3160 Project: ZooKeeper Issue Type: New Feature

[jira] [Updated] (ZOOKEEPER-3160) Custom User SSLContext

2018-10-02 Thread Alex Rankin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rankin updated ZOOKEEPER-3160: --- Fix Version/s: (was: 3.5.5) > Custom User SSLContext > -- > >

Failed: ZOOKEEPER- PreCommit Build #2330

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2330/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.61 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2330/ ---

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-10-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r222111859 --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java --- @@ -84,61 +163,61 @@ public static SSLContext createSSLContext() throws

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-10-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r222110824 --- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java --- @@ -0,0 +1,151 @@ +/** + * Licensed to the Apache Software Foundation

Failed: ZOOKEEPER- PreCommit Build #2312

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2312/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.89 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2312/ ---

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2313/ ---

Failed: ZOOKEEPER- PreCommit Build #2313

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2313/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.58 MB...] [exec]

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221963829 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-02 Thread Reidddddd
Github user Reidd commented on the issue: https://github.com/apache/zookeeper/pull/650 - Add descriptions about SetAclCommand.class - Fix the variable overriding. - Fix missed @Test annotation - Add a test case for unsetAcl znode. - Fix the wrong order of assertion.

[GitHub] zookeeper issue #643: ZOOKEEPER-3153: Create MarkDown files and build proces...

2018-10-02 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/643 hi @tamaashu - how to generate html documents based on mark down files? >> PDF support is dropped since it is not really used and makes everything overcomplicated. Seems good to

ZooKeeper-trunk - Build # 215 - Failure

2018-10-02 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/215/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 148.61 KB...] [junit] Running

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/650 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2306/ ---

Failed: ZOOKEEPER- PreCommit Build #2305

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2305/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.62 MB...] [exec]

[GitHub] zookeeper issue #624: ZOOKEEPER-3108:use a new property server.id in the zoo...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/624 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2305/ ---

Failed: ZOOKEEPER- PreCommit Build #2306

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2306/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 36.33 KB...] [exec] Test

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-02 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/650 retest this please ---

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221836418 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

[GitHub] zookeeper pull request #652: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-10-02 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/652#discussion_r221835045 --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java --- @@ -793,7 +794,87 @@ public RWServerFoundException(String msg) {

Prometheus Metrics Provider

2018-10-02 Thread Enrico Olivelli
Hi, I am going to work on Prometheus Metrics Provider, I see these ways: 1) add Prometheus metrics to current code base using ANT (add depedencies and change build scripts) 3) implement the provider using Maven in a metrics/prometheus folder, assuming that one day we will have Maven and it

Re: Prometheus Metrics Provider

2018-10-02 Thread Andor Molnar
Awesome news! I recommend waiting for Norbert to finish migrating the server code, before implementing a new feature to avoid harmful conflicts. He’s just about to finish rebasing: https://github.com/apache/zookeeper/pull/633 Regards, Andor >

[GitHub] zookeeper issue #651: ZOOKEEPER-3113 EphemeralType.get() fails to verify eph...

2018-10-02 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/651 Thanks folks for the review. Need approval from a committer. @hanm ? ---

[GitHub] zookeeper issue #624: ZOOKEEPER-3108:use a new property server.id in the zoo...

2018-10-02 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/624 @lvfangmin read the [doc](http://zookeeper.apache.org/doc/r3.5.1-alpha/zookeeperReconfig.html) and the code in the `QuorumPeerConfig.parseDynamicConfig()`,IMO,the` server.id` is only to be

Failed: ZOOKEEPER- PreCommit Build #2308

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2308/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 7.39 KB...] [exec] Testing

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2307/ ---

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2308/ ---

Failed: ZOOKEEPER- PreCommit Build #2307

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2307/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.30 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2309/ ---

Failed: ZOOKEEPER- PreCommit Build #2309

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2309/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 7.35 KB...] [exec] Testing

Failed: ZOOKEEPER- PreCommit Build #2310

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2310/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 7.40 KB...] [exec] Testing

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread nkalmar
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/633 A green build would be nice. I rebased, as it seems not perfectly, as there are build errors. Fixing them right now. ---

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2310/ ---

[jira] [Resolved] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time

2018-10-02 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-2933. - Resolution: Fixed > Ability to monitor the jute.maxBuffer usage in real-time >

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/633 Any plan for merging this ? Are we waiting for current patches under review for branch-3.5 stabilization ? ---

Failed: ZOOKEEPER- PreCommit Build #2311

2018-10-02 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2311/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.38 MB...] [exec]

[GitHub] zookeeper issue #633: ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, c...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/633 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2311/ ---

[GitHub] zookeeper pull request #650: ZOOKEEPER-1908: setAcl should be have a recursi...

2018-10-02 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/650#discussion_r221910075 --- Diff: src/java/test/org/apache/zookeeper/ZooKeeperTest.java --- @@ -566,4 +566,25 @@ public void testLsrNonexistantZnodeCommand() throws Exception {