[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-10-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/647 @lvfangmin Given that I've already provided a fix for the flakyness in #657 , do we still need this retry rule? ---

Re: ZooKeeper 3.5 blocker issues

2018-10-08 Thread Andor Molnar
Hi, Let me summarize and give a quick update on the outstanding issues for 3.5 GA: - ZOOKEEPER-1818 (Fix don't care for trunk) - ZOOKEEPER-2778 (Potential server deadlock between follower sync with leader and follower receiving external connection requests.) - ZOOKEEPER-3021 Migrate project

[jira] [Updated] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2979: -- Labels: pull-request-available (was: ) > Use dropwizard library histogram for

[GitHub] zookeeper pull request #440: ZOOKEEPER-2979 Use dropwizard library histogram...

2018-10-08 Thread anmolnar
Github user anmolnar closed the pull request at: https://github.com/apache/zookeeper/pull/440 ---

[GitHub] zookeeper issue #656: ZOOKEEPER-3032: MAVEN MIGRATION - branch-3.5 - move ja...

2018-10-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/656 This is merged. Thanks @nkalmar ! Please close this PR. ---

[jira] [Updated] (ZOOKEEPER-3161) Refactor QuorumPeerMainTest.java: move commonly used functions to base class

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3161: -- Labels: pull-request-available (was: ) > Refactor QuorumPeerMainTest.java: move

[GitHub] zookeeper pull request #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.jav...

2018-10-08 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/659 ZOOKEEPER-3161. Refactor QuorumPeerMainTest.java: move commonly used functions to base class Move the following methods to QuorumPeerTestBase.java: tearDown() LaunchServers()

ZooKeeper_branch35_jdk8 - Build # 1146 - Failure

2018-10-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1146/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68.99 KB...] [junit] Tests run: 1, Failures:

[jira] [Resolved] (ZOOKEEPER-3157) Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss

2018-10-08 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3157. - Resolution: Fixed Issue resolved by pull request 657

Failed: ZOOKEEPER- PreCommit Build #2383

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.96 MB...] [exec]

[GitHub] zookeeper issue #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 address...

2018-10-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/587 Committed to master. Thanks @maoling ! This patch doesn't apply to branch-3.5, but I think we should fix the issue on it too. Would you please open a separate pull request? ---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-10-08 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r223215411 --- Diff: zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java --- @@ -68,14 +71,16 @@ public

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/587 ---

[GitHub] zookeeper pull request #657: ZOOKEEPER-3157. Improve FuzzySnapshotRelatedTes...

2018-10-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/657 ---

[jira] [Created] (ZOOKEEPER-3161) Refactor QuorumPeerMainTest.java: move commonly used functions to base class

2018-10-08 Thread Andor Molnar (JIRA)
Andor Molnar created ZOOKEEPER-3161: --- Summary: Refactor QuorumPeerMainTest.java: move commonly used functions to base class Key: ZOOKEEPER-3161 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3161

Failed: ZOOKEEPER- PreCommit Build #2380

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 79.66 MB...] [exec]

[GitHub] zookeeper issue #655: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/655 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2380/ ---

[GitHub] zookeeper issue #655: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-10-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/655 retest this please ---

[GitHub] zookeeper issue #651: ZOOKEEPER-3113 EphemeralType.get() fails to verify eph...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/651 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382/ ---

Failed: ZOOKEEPER- PreCommit Build #2382

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2382/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.61 MB...] [exec]

[GitHub] zookeeper issue #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.java: move...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/659 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2383/ ---

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-10-08 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r223347154 --- Diff: zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java --- @@ -68,14 +71,16 @@ public

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-10-08 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r223346987 --- Diff: zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java --- @@ -68,14 +71,16 @@ public

[GitHub] zookeeper issue #657: ZOOKEEPER-3157. Improve FuzzySnapshotRelatedTest to av...

2018-10-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/657 Apologies, committed my own patch. Test fix, got 2 approvals, one from the original author. ---

Failed: ZOOKEEPER- PreCommit Build #2381

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 82.71 MB...] [exec]

[GitHub] zookeeper issue #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testCl...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/653 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2381/ ---

Failed: ZOOKEEPER- PreCommit Build #2384

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 80.55 MB...] [exec]

[GitHub] zookeeper issue #655: ZOOKEEPER-236: SSL Support for Atomic Broadcast protoc...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/655 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2384/ ---

ZooKeeper_branch35_jdk8 - Build # 1147 - Still Failing

2018-10-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1147/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 63.98 KB...] [junit] Running

[jira] [Commented] (ZOOKEEPER-3157) Improve FuzzySnapshotRelatedTest to avoid flaky due to issues like connection loss

2018-10-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642002#comment-16642002 ] Hudson commented on ZOOKEEPER-3157: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #223 (See

[jira] [Commented] (ZOOKEEPER-3106) Zookeeper client supports IPv6 address and document the "IPV6 feature"

2018-10-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642001#comment-16642001 ] Hudson commented on ZOOKEEPER-3106: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #223 (See

ZooKeeper-trunk - Build # 223 - Failure

2018-10-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/223/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 196.43 KB...] [junit] Tests run: 5, Failures: 0,

[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/632 retest this please ---

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223538616 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String path,

[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/647 I remember I commented in Jira ZOOKEEPER-3157, not sure why it didn't show up. I mentioned that we still need RetryRule, because there might be temporary quorum unstable issues like

ZooKeeper-trunk - Build # 224 - Still Failing

2018-10-08 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk/224/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 332.71 KB...] [exec] : elapsed 1001 : OK [exec]

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/660 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386/ ---

Failed: ZOOKEEPER- PreCommit Build #2386

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2386/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.25 MB...] [exec]

[GitHub] zookeeper pull request #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.jav...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/659#discussion_r223564880 --- Diff: zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java --- @@ -402,4 +421,129 @@ public File

[GitHub] zookeeper issue #659: ZOOKEEPER-3161. Refactor QuorumPeerMainTest.java: move...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/659 retest this please ---

[GitHub] zookeeper issue #658: ZOOKEEPER-3032 - MAVEN MIGRATION - branch 3.4 move jav...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/658 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391/ ---

Failed: ZOOKEEPER- PreCommit Build #2388

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.42 MB...] [exec]

[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/632 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2388/ ---

[GitHub] zookeeper pull request #632: [ZOOKEEPER-3150] Add tree digest check and veri...

2018-10-08 Thread edwardoliveira
Github user edwardoliveira commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/632#discussion_r223546118 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java --- @@ -1521,4 +1562,179 @@ public boolean removeWatch(String

[jira] [Commented] (ZOOKEEPER-2320) C-client crashes when removing watcher asynchronously in "local" mode

2018-10-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642802#comment-16642802 ] Hadoop QA commented on ZOOKEEPER-2320: -- -1 overall. Here are the results of testing the latest

Failed: ZOOKEEPER-2320 PreCommit Build #3705

2018-10-08 Thread Apache Jenkins Server
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2320 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3705/ ### ## LAST 60 LINES OF THE CONSOLE ###

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

2018-10-08 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/660 retest this please ---

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/660 @anmolnar do you know why it failing the check here? From the latest Jenkins build link I cannot find any failure. ---

[GitHub] zookeeper issue #658: ZOOKEEPER-3032 - MAVEN MIGRATION - branch 3.4 move jav...

2018-10-08 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/658 retest this please ---

Failed: ZOOKEEPER- PreCommit Build #2391

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2391/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 149.52 KB...] [exec]

[GitHub] zookeeper pull request #587: ZOOKEEPER-3106: Zookeeper client supports IPv6 ...

2018-10-08 Thread maoling
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/587#discussion_r223567109 --- Diff: zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java --- @@ -68,14 +71,16 @@ public

Success: ZOOKEEPER- PreCommit Build #2385

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 81.21 MB...] [exec] +1

Failed: ZOOKEEPER- PreCommit Build #2389

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2389/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 7.42 KB...] [exec] Testing

[GitHub] zookeeper issue #647: [ZOOKEEPER-3125] Fixing pzxid consistent issue when re...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/647 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2389/ ---

[GitHub] zookeeper pull request #660: ZOOKEEPER-2320. C-client crashes when removing ...

2018-10-08 Thread anmolnar
GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/660 ZOOKEEPER-2320. C-client crashes when removing watcher asynchronously in "local" mode Trying to fix invalid point issue happening intermittently in the PreCommit job. Looks like this old patch

[jira] [Updated] (ZOOKEEPER-2320) C-client crashes when removing watcher asynchronously in "local" mode

2018-10-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2320: -- Labels: pull-request-available (was: ) > C-client crashes when removing watcher

[GitHub] zookeeper issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/632 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2385/ ---

Failed: ZOOKEEPER- PreCommit Build #2387

2018-10-08 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 69.09 MB...] [exec]

[GitHub] zookeeper issue #660: ZOOKEEPER-2320. C-client crashes when removing watcher...

2018-10-08 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/660 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2387/ ---