date:20181106

[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

2018-11-06 Thread tumativ

Github user tumativ commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/684#discussion_r231194896
  
--- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java 
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.jute.Record;
+import org.apache.zookeeper.data.Stat;
+
+@SuppressWarnings("serial")
+public class ResponseCache {
+private static final int DEFAULT_RESPONSE_CACHE_SIZE = 400;
+
+private static class Entry {
+public Stat stat;
+public byte[] data;
+}
+
+private Map cache = Collections.synchronizedMap(
--- End diff --

Would be good if DEFAULT_INITIAL_CAPACITY of cache also defined


---

[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

2018-11-06 Thread tumativ

Github user tumativ commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/684#discussion_r231199414
  
--- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java 
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.jute.Record;
+import org.apache.zookeeper.data.Stat;
+
+@SuppressWarnings("serial")
+public class ResponseCache {
--- End diff --

How about updating the cache when watch event is triggered?


---

Failed: ZOOKEEPER- PreCommit Build #2596

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2596/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.68 MB...]
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=A17FEC12AD9968EBAF6B5CD8C17CA448.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1839:
 exec returned: 1

Total time: 12 minutes 55 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3176
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 120876683dbc8aa8ced6224005bf98e1002c4be9 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2596/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2596/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackErrorDoesNotCrashWatcherThread

Error Message:
expected:<2> but was:<3>

Stack Trace:
junit.framework.AssertionFailedError: expected:<2> but was:<3>
at 
org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackErrorDoesNotCrashWatcherThread(FileChangeWatcherTest.java:250)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/681
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2596/



---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-06 Thread ivmaykov

Github user ivmaykov closed the pull request at:

https://github.com/apache/zookeeper/pull/679


---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-06 Thread ivmaykov

GitHub user ivmaykov reopened a pull request:

https://github.com/apache/zookeeper/pull/679

ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades

Fix numerous problems with UnifiedServerSocket, such as hanging the 
accept() thread when the client doesn't send any data or crashing if less than 
5 bytes are read from the socket in the initial read.

Re-enable the "portUnification" config option.

Note that this is stacked on top of #678 and thus includes it. Please only 
consider the ZOOKEEPER-3172 commit when reviewing. Once the other PR is merged 
upstream, I will rebase this so it only contains one commit.

## Fixed networking issues/bugs in UnifiedServerSocket

- don't crash the `accept()` thread if the client closes the connection 
without sending any data
- don't corrupt the connection if the client sends fewer than 5 bytes for 
the initial read
- delay the detection of TLS vs. plaintext mode until a socket stream is 
read from or written to. This prevents the `accept()` thread from getting 
blocked on a `read()` operation from the newly connected socket.
- prepending 5 bytes to `PrependableSocket` and then trying to read >5 
bytes would only return the first 5 bytes, even if more bytes were available. 
This is fixed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ivmaykov/zookeeper ZOOKEEPER-3172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #679


commit 2122c8c23a0dbb27f9b2aff55e800e48d253f943
Author: Ilya Maykov 
Date:   2018-10-25T00:41:48Z

ZOOKEEPER-3173: Quorum TLS - support PEM trust/key stores
ZOOKEEPER-3175: Quorum TLS - test improvements

Add support for loading key and trust stores from PEM files.
Also added test utils for testing X509-related code, because it
was very difficult to untangle them from the PEM support code.

commit 514d48a26aeeca37290ad14ff8f0cdae69b53eb2
Author: Ilya Maykov 
Date:   2018-10-25T01:22:24Z

ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades




---

[GitHub] zookeeper issue #685: [ZOOKEEPER-3104] Fix potential data inconsistency due ...

2018-11-06 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/685
  
This is merged. Thanks @lvfangmin !
Please close this PR.


---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread ivmaykov

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
@anmolnar is there a way to reproduce the exact same steps that jenkins 
runs on my macbook?


---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread ivmaykov

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
@anmolnar it works for me as far as I can tell, I think the contbuild is 
flaky? The contbuild on #681, which includes the same commit, passes.


---

[jira] [Commented] (ZOOKEEPER-3155) Remove Forrest XMLs and their build process from the project

2018-11-06 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677219#comment-16677219
 ] 

Hudson commented on ZOOKEEPER-3155:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #96 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/96/])
ZOOKEEPER-3155: Remove Forrest XMLs and their build process from the … (andor: 
rev e5fc1228104410728646982eff84d4fb21b361ca)
* (delete) docs/skin/images/label.gif
* (delete) docs/skin/CommonMessages_fr.xml
* (delete) docs/zookeeperAdmin.html
* (delete) docs/skin/images/xmldoc.gif
* (delete) docs/skin/images/pdfdoc.gif
* (delete) docs/bookkeeperConfig.html
* (delete) docs/skin/images/poddoc.png
* (delete) docs/skin/getMenu.js
* (delete) docs/zookeeperProgrammers.pdf
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperInternals.xml
* (delete) docs/recipes.html
* (delete) docs/skin/images/forrest-credit-logo.png
* (delete) docs/bookkeeperOverview.pdf
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperOver.xml
* (delete) docs/skin/images/rc-t-l-5-1header-2tab-unselected-3tab-unselected.png
* (delete) docs/bookkeeperConfig.pdf
* (delete) docs/images/state_dia.jpg
* (delete) docs/images/zkperfreliability.jpg
* (delete) zookeeper-docs/src/documentation/conf/cli.xconf
* (delete) zookeeper-docs/status.xml
* (delete) docs/skin/profile.css
* (delete) docs/zookeeperObservers.pdf
* (delete) docs/skin/prototype.js
* (delete) docs/linkmap.html
* (delete) docs/zookeeperOtherInfo.html
* (delete) docs/zookeeperQuotas.html
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
* (edit) zookeeper-server/src/test/resources/test-patch.sh
* (delete) docs/skin/images/rc-t-r-5-1header-2tab-selected-3tab-selected.png
* (delete) docs/zookeeperObservers.html
* (delete) zookeeper-docs/src/documentation/resources/images/state_dia.jpg
* (delete) docs/zookeeperInternals.pdf
* (delete) docs/zookeeperAdmin.pdf
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperJMX.xml
* (delete) docs/bookkeeperStream.html
* (delete) docs/skin/images/update.jpg
* (delete) docs/skin/menu.js
* (delete) docs/skin/CommonMessages_en_US.xml
* (delete) docs/linkmap.pdf
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperObservers.xml
* (delete) zookeeper-docs/forrest.properties
* (delete) docs/javaExample.html
* (delete) docs/skin/print.css
* (delete) docs/images/favicon.ico
* (delete) docs/skin/images/txtdoc.png
* (delete) zookeeper-docs/src/documentation/content/xdocs/index.xml
* (delete) docs/skin/images/remove.jpg
* (delete) docs/zookeeperOtherInfo.pdf
* (delete) docs/bookkeeperOverview.html
* (delete) docs/skin/images/built-with-forrest-button.png
* (delete) docs/zookeeperProgrammers.html
* (delete) docs/skin/images/instruction_arrow.png
* (delete) zookeeper-docs/src/documentation/classes/CatalogManager.properties
* (delete) docs/skin/images/chapter.gif
* (delete) docs/skin/images/header_white_line.gif
* (edit) build.xml
* (delete) docs/skin/images/rss.png
* (delete) docs/zookeeperOver.pdf
* (delete) docs/skin/images/page.gif
* (delete) zookeeper-docs/src/documentation/resources/images/zookeeper_small.gif
* (delete) 
zookeeper-docs/src/documentation/content/xdocs/zookeeperHierarchicalQuorums.xml
* (edit) zookeeper-server/src/test/resources/test-github-pr.sh
* (delete) zookeeper-docs/src/documentation/resources/images/zkperfRW-3.2.jpg
* (delete) docs/bookkeeperStream.pdf
* (delete) docs/skin/note.txt
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperReconfig.xml
* (delete) docs/skin/images/rc-b-r-15-1body-2menu-3menu.png
* (delete) zookeeper-docs/src/documentation/content/xdocs/recipes.xml
* (delete) docs/bookkeeperStarted.html
* (delete) docs/releasenotes.html
* (delete) docs/skin/images/README.txt
* (delete) docs/images/zknamespace.jpg
* (delete) docs/zookeeperReconfig.html
* (delete) docs/skin/images/rc-b-r-5-1header-2tab-selected-3tab-selected.png
* (delete) docs/images/zkservice.jpg
* (delete) docs/skin/images/fix.jpg
* (delete) docs/skin/images/warning.png
* (delete) docs/skin/images/success.png
* (delete) docs/zookeeperReconfig.pdf
* (delete) docs/images/zookeeper_small.gif
* (delete) zookeeper-docs/src/documentation/resources/images/bk-overview.jpg
* (delete) docs/skin/images/info.png
* (delete) docs/bookkeeperProgrammer.html
* (delete) docs/skin/images/rc-t-l-5-1header-2tab-selected-3tab-selected.png
* (delete) docs/zookeeperOver.html
* (delete) docs/skin/images/rc-t-r-15-1body-2menu-3menu.png
* (delete) docs/bookkeeperStarted.pdf
* (delete) zookeeper-docs/src/documentation/resources/images/favicon.ico
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperQuotas.xml
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperOtherInfo.xml
* (delete) docs/skin/images/rc-t-l-5-1header-2searchbox-3searchbox.png
* (delete) docs/zookeeperHierarchicalQuorums.html

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread eolivelli

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
Maybe you should use docker.
As soon as possible I will copy the command line we are using in Jenkins 
job.
Maybe it is already available on the job log


---

[GitHub] zookeeper pull request #671: ZOOKEEPER-3155: Remove Forrest XMLs and their b...

2018-11-06 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/671


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

2018-11-06 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/671
  
Committed to master branch. Thanks @tamaashu !



---

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/680
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2595/



---

Failed: ZOOKEEPER- PreCommit Build #2595

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2595/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 38.14 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Ignore unexpected error logging out. Error: Invalid request: 
java.net.ProtocolException: Server redirected too many  times (20).
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1839:
 exec returned: 1

Total time: 2 minutes 49 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[Fast Archiver] Compressed 455.45 KB of artifacts by 42.2% relative to #2593
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3174
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of e0889bf258ece8459e1ba8ae83baf9fb4cab48cd to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2595/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2595/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #2594

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2594/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 37.83 KB...]
 [exec] 
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/zookeeper-server/src/test/resources/test-github-pr.sh:
 line 469: 32152 Killed  $ANT_HOME/bin/ant 
-DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes 
test-contrib
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=B362F7475280EA8A042D13B39C5A9F4F.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1839:
 exec returned: 2

Total time: 2 minutes 51 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[Fast Archiver] Compressed 832.60 KB of artifacts by 38.4% relative to #2593
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3172
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 514d48a26aeeca37290ad14ff8f0cdae69b53eb2 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2594/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2594/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/679
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2594/



---

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/679
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2597/



---

Failed: ZOOKEEPER- PreCommit Build #2597

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2597/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.66 MB...]
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=1D7E6E5C809D05E1BFC00F9510089776.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1839:
 exec returned: 1

Total time: 13 minutes 23 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3172
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 514d48a26aeeca37290ad14ff8f0cdae69b53eb2 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2597/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2597/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.server.quorum.QuorumSSLTest.testRollingUpgrade

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.server.quorum.QuorumSSLTest.stopAppendConfigRestartAll(QuorumSSLTest.java:488)
at 
org.apache.zookeeper.server.quorum.QuorumSSLTest.testRollingUpgrade(QuorumSSLTest.java:470)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
@ivmaykov It's in:
`zookeeper-server/src/test/resources/test-github-pr.sh`


---

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-06 Thread ivmaykov

Github user ivmaykov closed the pull request at:

https://github.com/apache/zookeeper/pull/680


---

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-11-06 Thread ivmaykov

GitHub user ivmaykov reopened a pull request:

https://github.com/apache/zookeeper/pull/680

ZOOKEEPER-3174: Quorum TLS - support reloading trust/key store

Allow reloading SSL trust stores and key stores from disk when the files on 
disk change.

Note that this is stacked on top of #678 and #679 and thus includes them. 
Please only consider the ZOOKEEPER-3174 commit when reviewing. Once the other 
PRs are merged upstream, I will rebase this so it only contains one commit.

## Added support for reloading key/trust stores when the file on disk 
changes
- new property `sslQuorumReloadCertFiles` which controls the behavior for 
reloading the key and trust store files for `QuorumX509Util`. Reloading of key 
and trust store for `ClientX509Util` is not in this PR but could be added easily
- this allows a ZK server to keep running on a machine that uses 
short-lived certs that refresh frequently without having to restart the ZK 
process.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ivmaykov/zookeeper ZOOKEEPER-3174

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/680.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #680


commit 2122c8c23a0dbb27f9b2aff55e800e48d253f943
Author: Ilya Maykov 
Date:   2018-10-25T00:41:48Z

ZOOKEEPER-3173: Quorum TLS - support PEM trust/key stores
ZOOKEEPER-3175: Quorum TLS - test improvements

Add support for loading key and trust stores from PEM files.
Also added test utils for testing X509-related code, because it
was very difficult to untangle them from the PEM support code.

commit 69f5185c8c14720e94c81f0147ee9cbc2ae42f89
Author: Ilya Maykov 
Date:   2018-10-25T01:22:24Z

ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades

commit d9e09dc73a42be079a6bd28b51c09635fff32e95
Author: Ilya Maykov 
Date:   2018-10-25T01:54:06Z

ZOOKEEPER-3174: Quorum TLS - support reloading trust/key store




---

Success: ZOOKEEPER- PreCommit Build #2593

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2593/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.03 MB...]
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=1C0735D8B920ED99739536BA8A3D5C73.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 31 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3174
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of d9e09dc73a42be079a6bd28b51c09635fff32e95 to SUCCESS with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2593/ and 
message: 'SUCCESS 
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2593/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/680
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2593/



---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
Now it's green. I'll merge it.
Previously the findbugs subprocess has been killed for some reason.


---

[jira] [Assigned] (ZOOKEEPER-3179) Add snapshot compression to reduce the disk IO

2018-11-06 Thread Yisong Yue (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yisong Yue reassigned ZOOKEEPER-3179:
-

Assignee: Yisong Yue

> Add snapshot compression to reduce the disk IO
> --
>
> Key: ZOOKEEPER-3179
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3179
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Fangmin Lv
>Assignee: Yisong Yue
>Priority: Major
> Fix For: 3.6.0
>
>
> When the snapshot becomes larger, the periodically snapshot after certain 
> number of txns will be more expensive. Which will in turn affect the maximum 
> throughput we can support within SLA, because of the disk contention between 
> snapshot and txn when they're on the same drive.
>  
> With compression like zstd/snappy/gzip, the actual snapshot size could be 
> much smaller, the compress ratio depends on the actual data. It might make 
> the recovery time (loading from disk) faster in some cases, but will take 
> longer sometimes because of the extra time used to compress/decompress.
>  
> Based on the production traffic, the performance various with different 
> compress method as well, that's why we provided different implementations, we 
> can select different compress method for different use cases.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-06 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/678


---

Failed: ZOOKEEPER- PreCommit Build #2600

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2600/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 85.67 MB...]
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=30DBE94CA78A935343E7D65D421ECA06.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1839:
 exec returned: 1

Total time: 12 minutes 51 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3172
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 4ee3868bcc80ebe027c88d8696a86bb52a34a033 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2600/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2600/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView(QuorumPeerMainTest.java:973)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/679
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2600/



---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread ivmaykov

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
I don't understand why this PR started failing Jenkins builds all of a 
sudden. The next 2 PRs stacked on this one (#678 and #680) also fail, but the 
last one (#681) passes.


---

ZooKeeper_branch35_jdk8 - Build # 1183 - Failure

2018-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1183/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 64.69 KB...]
[junit] Running org.apache.zookeeper.test.SaslClientTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.073 sec, Thread: 4, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 4
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.774 sec, Thread: 4, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.789 sec, Thread: 2, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.931 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.386 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.229 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.866 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.682 sec, Thread: 4, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.818 sec, Thread: 4, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 4
[junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.777 sec, Thread: 4, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.364 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.067 sec, Thread: 4, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 2
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.004 sec, Thread: 2, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.249 sec, Thread: 4, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.077 sec, Thread: 4, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.116 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 3
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.006 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.088 sec, Thread: 4, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.679 sec, Thread: 2, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.808 sec, Thread: 2, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.467 sec, Thread: 4, Class:

[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/679
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2598/



---

Success: ZOOKEEPER- PreCommit Build #2598

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2598/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.43 MB...]
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=A792365AF55B1E54217EF60350DE32AC.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 29 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3172
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 514d48a26aeeca37290ad14ff8f0cdae69b53eb2 to SUCCESS with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2598/ and 
message: 'SUCCESS 
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2598/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread ivmaykov

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
Jenkins claims there is a findbugs failure, but there is no actual output 
of findbugs failures, and findbugs passes on my machine. Â¯\_(ã)_/Â¯


---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-06 Thread enixon

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/628#discussion_r231359694
  
--- Diff: zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml 
---
@@ -764,6 +764,18 @@ server.3=zoo3:2888:3888
 
   
 
+  
+observerMasterPort
--- End diff --

That is correct, we will not be able to change this with a reconfig. I did 
not want to alter the format of the reconfig operation in this change since I 
felt it was significant enough to warrant its own patch. A more extensible 
configuration format would also benefit 
https://issues.apache.org/jira/browse/ZOOKEEPER-3166. 


---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-06 Thread enixon

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/628#discussion_r231364616
  
--- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java
 ---
@@ -0,0 +1,514 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server.quorum;
+
+import org.apache.zookeeper.jmx.MBeanRegistry;
+import org.apache.zookeeper.server.Request;
+import org.apache.zookeeper.server.ZKDatabase;
+
+import java.io.BufferedInputStream;
+import java.io.ByteArrayInputStream;
+import java.io.DataInputStream;
+import java.io.IOException;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.apache.zookeeper.server.quorum.auth.QuorumAuthServer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Used by Followers to host Observers. This reduces the network load on 
the Leader process by pushing
+ * the responsibility for keeping Observers in sync off the leading peer.
+ *
+ * It is expected that Observers will continue to perform the initial 
vetting of clients and requests.
+ * Observers send the request to the follower where it is received by an 
ObserverMaster.
+ *
+ * The ObserverMaster forwards a copy of the request to the ensemble 
Leader and inserts it into its own
+ * request processor pipeline where it can be matched with the response 
comes back. All commits received
+ * from the Leader will be forwarded along to every Learner connected to 
the ObserverMaster.
+ *
+ * New Learners connecting to a Follower will receive a LearnerHandler 
object and be party to its syncing logic
+ * to be brought up to date.
+ *
+ * The logic is quite a bit simpler than the corresponding logic in Leader 
because it only hosts observers.
+ */
+public class ObserverMaster implements LearnerMaster, Runnable {
+private static final Logger LOG = 
LoggerFactory.getLogger(ObserverMaster.class);
+
+//Follower counter
+private final AtomicLong followerCounter = new AtomicLong(-1);
--- End diff --

This copies the followerCounter of the Leader as used in the beginning of 
LearnerHandler::run. My understanding is that this provides backwards 
compatibility for when the first FOLLOWERINFO or OBSERVERINFO packet from the 
Learner does not supply a LearnerInfo and the Leader (or ObserverMaster here) 
needs to come up with a unique server id for the new Learner with which to 
refer to it in all internal collections.

It will also end up being used in #337 if/when that patch is accepted.

I'm happy to add explanatory comments for these counters in the Leader and 
ObserverMaster but am unsure of how much of the above should be included. What 
do you think of a simple "assigns unique server id for internal tracking of 
Learners that do not provide a unique id"?


---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-11-06 Thread enixon

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/628#discussion_r231364697
  
--- Diff: 
zookeeper-docs/src/documentation/content/xdocs/zookeeperObservers.xml ---
@@ -111,7 +111,41 @@
   the ZooKeeper service.
 
   
-  
+  
--- End diff --

Will address in a rebase that fixes the conflicts - thanks for raising to 
me!


---

[GitHub] zookeeper issue #628: ZOOKEEPER-3140: Allow Followers to host Observers

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/628
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2605/



---

Failed: ZOOKEEPER- PreCommit Build #2605

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2605/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 87.74 MB...]
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=5942CF5C25BE3B9D2B0D0B4F4B886255.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1839:
 exec returned: 1

Total time: 14 minutes 37 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3140
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 16702e942b5602dbddfffceb233584518bb25fa4 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2605/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2605/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest

Error Message:
test timed out after 60 milliseconds

Stack Trace:
org.junit.runners.model.TestTimedOutException: test timed out after 60 
milliseconds
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1518)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1501)
at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1453)
at 
org.apache.zookeeper.test.ReconfigTest.createZNode(ReconfigTest.java:194)
at 
org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:167)
at 
org.apache.zookeeper.server.quorum.StandaloneDisabledTest.testReconfig(StandaloneDisabledTest.java:243)
at 
org.apache.zookeeper.server.quorum.StandaloneDisabledTest.startSingleServerTest(StandaloneDisabledTest.java:113)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)

[jira] [Resolved] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

2018-11-06 Thread Andor Molnar (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar resolved ZOOKEEPER-3173.
-
   Resolution: Fixed
Fix Version/s: 3.5.5
   3.6.0

Issue resolved by pull request 678
[https://github.com/apache/zookeeper/pull/678]

> Quorum TLS - support PEM trust/key stores
> -
>
> Key: ZOOKEEPER-3173
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3173
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Assignee: Ilya Maykov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
>  Time Spent: 14h 10m
>  Remaining Estimate: 0h
>
> ZOOKEEPER-236 is landed so there is some TLS support in Zookeeper now, but 
> only JKS trust stores are supported. JKS is not really used by non-Java 
> software, where PKCS12 and PEM are more standard. Let's add support for PEM 
> trust / key stores to make Quorum TLS easier to use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
Merged to 3.5 and master branches. Thanks @ivmaykov !


---

[jira] [Commented] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

2018-11-06 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677753#comment-16677753
 ] 

Hudson commented on ZOOKEEPER-3173:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #259 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/259/])
ZOOKEEPER-3173: Quorum TLS - support PEM trust/key stores (andor: rev 
03286f29d29f4c1d3496ce87d1441df9140e)
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/JKSFileLoader.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/BaseX509ParameterizedTestCase.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509TestHelpers.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/JKSFileLoaderTest.java
* (add) zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509KeyType.java
* (edit) NOTICE.txt
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/PEMFileLoaderTest.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/FileKeyStoreLoaderBuilderProviderTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKConfig.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509TestContext.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/KeyStoreLoader.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoaderBuilderProvider.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/KeyStoreFileTypeTest.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/KeyStoreFileType.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/PEMFileLoader.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/util/PemReaderTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java


> Quorum TLS - support PEM trust/key stores
> -
>
> Key: ZOOKEEPER-3173
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3173
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Assignee: Ilya Maykov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
>  Time Spent: 14.5h
>  Remaining Estimate: 0h
>
> ZOOKEEPER-236 is landed so there is some TLS support in Zookeeper now, but 
> only JKS trust stores are supported. JKS is not really used by non-Java 
> software, where PKCS12 and PEM are more standard. Let's add support for PEM 
> trust / key stores to make Quorum TLS easier to use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #690: ZOOKEEPER-3179: Add snapshot compression to red...

2018-11-06 Thread yisong-yue

GitHub user yisong-yue opened a pull request:

https://github.com/apache/zookeeper/pull/690

 ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yisong-yue/zookeeper ZOOKEEPER-3179

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/690.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #690


commit 25ead63f620b99571850fdd7f827d685c79e3214
Author: Yisong Yue 
Date:   2018-11-07T05:04:32Z

ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO

commit 9fd3071e1487044f77172765222fe6f520961946
Author: Yisong Yue 
Date:   2018-11-07T07:24:34Z

small improvements




---

[jira] [Updated] (ZOOKEEPER-3179) Add snapshot compression to reduce the disk IO

2018-11-06 Thread ASF GitHub Bot (JIRA)



 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3179:
--
Labels: pull-request-available  (was: )

> Add snapshot compression to reduce the disk IO
> --
>
> Key: ZOOKEEPER-3179
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3179
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Fangmin Lv
>Assignee: Yisong Yue
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0
>
>
> When the snapshot becomes larger, the periodically snapshot after certain 
> number of txns will be more expensive. Which will in turn affect the maximum 
> throughput we can support within SLA, because of the disk contention between 
> snapshot and txn when they're on the same drive.
>  
> With compression like zstd/snappy/gzip, the actual snapshot size could be 
> much smaller, the compress ratio depends on the actual data. It might make 
> the recovery time (loading from disk) faster in some cases, but will take 
> longer sometimes because of the extra time used to compress/decompress.
>  
> Based on the production traffic, the performance various with different 
> compress method as well, that's why we provided different implementations, we 
> can select different compress method for different use cases.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3173) Quorum TLS - support PEM trust/key stores

2018-11-06 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677700#comment-16677700
 ] 

Hudson commented on ZOOKEEPER-3173:
---

SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #97 (See 
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/97/])
ZOOKEEPER-3173: Quorum TLS - support PEM trust/key stores (andor: rev 
03286f29d29f4c1d3496ce87d1441df9140e)
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509TestContext.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/PEMFileLoader.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/JKSFileLoaderTest.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKConfig.java
* (edit) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
* (add) zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509KeyType.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/util/PemReaderTest.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/KeyStoreFileTypeTest.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/KeyStoreLoader.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java
* (edit) 
zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/X509AuthenticationProvider.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/BaseX509ParameterizedTestCase.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/FileKeyStoreLoaderBuilderProviderTest.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/KeyStoreFileType.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/JKSFileLoader.java
* (add) 
zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoaderBuilderProvider.java
* (edit) NOTICE.txt
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/PEMFileLoaderTest.java
* (add) 
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509TestHelpers.java


> Quorum TLS - support PEM trust/key stores
> -
>
> Key: ZOOKEEPER-3173
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3173
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.6.0, 3.5.5
>Reporter: Ilya Maykov
>Assignee: Ilya Maykov
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
>  Time Spent: 14.5h
>  Remaining Estimate: 0h
>
> ZOOKEEPER-236 is landed so there is some TLS support in Zookeeper now, but 
> only JKS trust stores are supported. JKS is not really used by non-Java 
> software, where PKCS12 and PEM are more standard. Let's add support for PEM 
> trust / key stores to make Quorum TLS easier to use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #2606

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2606/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.48 MB...]
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=B37EAA1A1A556D0625CA3E62D1CD71C6.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1841:
 exec returned: 1

Total time: 18 minutes 42 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3179
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 9fd3071e1487044f77172765222fe6f520961946 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2606/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2606/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/690
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2606/



---

[GitHub] zookeeper issue #676: ZOOKEEPER-3181: ZOOKEEPER-2355 broke Curator TestingQu...

2018-11-06 Thread hanm

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/676
  
>> I'm not familiar with Apache Curator project, so I'm not sure how 
actually hard it is.

@lvfangmin is a Curator committer and could probably help here to push out 
a new release.


---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread enixon

Github user enixon commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
Yeah, there aren't findbugs reports in the artifacts as I would expect 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/artifact/patchprocess/
 , it's unclear what went wrong there. Maybe retrigger the build process 
('retest this please')?


---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-06 Thread ivmaykov

GitHub user ivmaykov reopened a pull request:

https://github.com/apache/zookeeper/pull/679

ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades

Fix numerous problems with UnifiedServerSocket, such as hanging the 
accept() thread when the client doesn't send any data or crashing if less than 
5 bytes are read from the socket in the initial read.

Re-enable the "portUnification" config option.

Note that this is stacked on top of #678 and thus includes it. Please only 
consider the ZOOKEEPER-3172 commit when reviewing. Once the other PR is merged 
upstream, I will rebase this so it only contains one commit.

## Fixed networking issues/bugs in UnifiedServerSocket

- don't crash the `accept()` thread if the client closes the connection 
without sending any data
- don't corrupt the connection if the client sends fewer than 5 bytes for 
the initial read
- delay the detection of TLS vs. plaintext mode until a socket stream is 
read from or written to. This prevents the `accept()` thread from getting 
blocked on a `read()` operation from the newly connected socket.
- prepending 5 bytes to `PrependableSocket` and then trying to read >5 
bytes would only return the first 5 bytes, even if more bytes were available. 
This is fixed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ivmaykov/zookeeper ZOOKEEPER-3172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #679


commit 2122c8c23a0dbb27f9b2aff55e800e48d253f943
Author: Ilya Maykov 
Date:   2018-10-25T00:41:48Z

ZOOKEEPER-3173: Quorum TLS - support PEM trust/key stores
ZOOKEEPER-3175: Quorum TLS - test improvements

Add support for loading key and trust stores from PEM files.
Also added test utils for testing X509-related code, because it
was very difficult to untangle them from the PEM support code.

commit 514d48a26aeeca37290ad14ff8f0cdae69b53eb2
Author: Ilya Maykov 
Date:   2018-10-25T01:22:24Z

ZOOKEEPER-3172: Quorum TLS - fix port unification to allow rolling upgrades




---

Failed: ZOOKEEPER- PreCommit Build #2601

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2601/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 78.04 MB...]
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=9774FEF76A649C6D3BD1ABAE741A4DE0.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1839:
 exec returned: 1

Total time: 16 minutes 19 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3174
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 33e04b893a2abc64f19d0538e5eff63382e0ee49 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2601/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2601/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackErrorDoesNotCrashWatcherThread

Error Message:
expected:<2> but was:<3>

Stack Trace:
junit.framework.AssertionFailedError: expected:<2> but was:<3>
at 
org.apache.zookeeper.common.FileChangeWatcherTest.testCallbackErrorDoesNotCrashWatcherThread(FileChangeWatcherTest.java:250)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/680
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2601/



---

Success: ZOOKEEPER- PreCommit Build #2603

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2603/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 80.54 MB...]
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=287E00CA6B769A7B3197D48E0DAAFE81.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 21 minutes 10 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3152
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 11c4b5a9067b4cbc1e1dbdb3fcfb2d4aedf32725 to SUCCESS with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2603/ and 
message: 'SUCCESS 
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2603/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/669
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2603/



---

[GitHub] zookeeper pull request #679: ZOOKEEPER-3172: Quorum TLS - fix port unificati...

2018-11-06 Thread ivmaykov

Github user ivmaykov closed the pull request at:

https://github.com/apache/zookeeper/pull/679


---

Re: Re: asfgit commenting on PRs

2018-11-06 Thread Michael Han

+1 on the idea of silencing the comments from asfgit bot.

Hi Enrico - I am still seeing the bot commenting on builds triggered by new
commits after you making the change.
An example just a second ago: https://github.com/apache/zookeeper/pull/679

On Tue, Nov 6, 2018 at 4:02 AM Enrico Olivelli  wrote:

> I have unchecked the "Add test result one liner" flag in the PR builder Job
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
>
> let's see how it feels now
>
> Enrico
>
>
> Il giorno mar 6 nov 2018 alle ore 03:44 毛蛤丝
>  ha scritto:
> >
> > +1,for removing the asfgit successful build comments.
> >
> > 
> >
> > Best regards
> > maoling
> > Beijing,China
> >
> >
> > - 原始邮件 -
> > 发件人：Enrico Olivelli 
> > 收件人：dev@zookeeper.apache.org
> > 主题：Re: asfgit commenting on PRs
> > 日期：2018年11月06日 04点57分
> >
> > Il lun 5 nov 2018, 21:28 Andor Molnar  ha scritto:
> > > I also feel the comments redundant.
> > > Enrico - shall we remove this?
> > >
> > I will check, it should be a flag on job config
> > Enrico
> > > Andor
> > >
> > >
> > >
> > > > On 2018. Nov 5., at 12:24, Norbert Kalmar
> 
> > > wrote:
> > > >
> > > > Hi all,
> > > >
> > > > One of the recent development was that asfgit now comments on the PRs
> > > every
> > > > successful builds.
> > > > But we do have the same information under "Show all checks". (This
> might
> > > be
> > > > gone after closing the PR though).
> > > >
> > > > I wouldn't mind the extra commit, but on github, in
> > > > https://github.com/apache/zookeeper/pulls, we have multiple comments
> > > > showing under every PR. Before this, for me at least, I used this to
> > > > quickly identify the PRs which haven't been reviewed by anyone
> (having 0
> > > or
> > > > 1 comments). Or to see quickly if something is getting a lot of
> attention
> > > > lately, or getting updates etc.
> > > >
> > > > This was a convenient thing for me, of course not a feature I can't
> live
> > > > without. I just wanted to ask other devs view on this.
> > > >
> > > > So, what's your view? :)
> > > >
> > > > Regards,
> > > > Norbert
> > >
> > > --
> > -- Enrico Olivelli
>

[GitHub] zookeeper issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/681
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2602/



---

Success: ZOOKEEPER- PreCommit Build #2602

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2602/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 86.11 MB...]
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=2EB2EB238F42E809501748CCBA38EF5A.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 37 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3176
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 0ec1627f0d4f1b632de48e431531a4a07d3d661f to SUCCESS with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2602/ and 
message: 'SUCCESS 
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2602/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

Success: ZOOKEEPER- PreCommit Build #2604

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2604/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 77.99 MB...]
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=6D04ABD8E2085E0DC114B6E795801934.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 16 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3173
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 76f0b8f69b8b9f786d50c56e52fdbee017b86195 to SUCCESS with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2604/ and 
message: 'SUCCESS 
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2604/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/678
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2604/



---

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread asfgit

Github user asfgit commented on the issue:

https://github.com/apache/zookeeper/pull/678
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/



---

Failed: ZOOKEEPER- PreCommit Build #2599

2018-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 77.05 MB...]
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] Error: No value specified for option "issue"
 [exec] Session logged out. Session was 
JSESSIONID=65C37CB2C6F4E646C1EF3EA457E841BB.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1839:
 exec returned: 1

Total time: 18 minutes 4 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
[description-setter] Description set: ZOOKEEPER-3173
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting status of 76f0b8f69b8b9f786d50c56e52fdbee017b86195 to FAILURE with url 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/ and 
message: 'FAILURE
 '
Using context: Jenkins

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/

Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting MAVEN_3_LATEST__HOME=/home/jenkins/tools/maven/latest3/



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
It's not findbugs, core and contrib tests are failing, but I cannot see why:
``` 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 ```


---

Re: Re: asfgit commenting on PRs

2018-11-06 Thread Enrico Olivelli

I am not sure what is adding that comment.
I will dig

Enrico

Il mar 6 nov 2018, 21:04 Michael Han  ha scritto:

> +1 on the idea of silencing the comments from asfgit bot.
>
> Hi Enrico - I am still seeing the bot commenting on builds triggered by new
> commits after you making the change.
> An example just a second ago: https://github.com/apache/zookeeper/pull/679
>
> On Tue, Nov 6, 2018 at 4:02 AM Enrico Olivelli 
> wrote:
>
> > I have unchecked the "Add test result one liner" flag in the PR builder
> Job
> > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
> >
> > let's see how it feels now
> >
> > Enrico
> >
> >
> > Il giorno mar 6 nov 2018 alle ore 03:44 毛蛤丝
> >  ha scritto:
> > >
> > > +1,for removing the asfgit successful build comments.
> > >
> > > 
> > >
> > > Best regards
> > > maoling
> > > Beijing,China
> > >
> > >
> > > - 原始邮件 -
> > > 发件人：Enrico Olivelli 
> > > 收件人：dev@zookeeper.apache.org
> > > 主题：Re: asfgit commenting on PRs
> > > 日期：2018年11月06日 04点57分
> > >
> > > Il lun 5 nov 2018, 21:28 Andor Molnar  ha scritto:
> > > > I also feel the comments redundant.
> > > > Enrico - shall we remove this?
> > > >
> > > I will check, it should be a flag on job config
> > > Enrico
> > > > Andor
> > > >
> > > >
> > > >
> > > > > On 2018. Nov 5., at 12:24, Norbert Kalmar
> > 
> > > > wrote:
> > > > >
> > > > > Hi all,
> > > > >
> > > > > One of the recent development was that asfgit now comments on the
> PRs
> > > > every
> > > > > successful builds.
> > > > > But we do have the same information under "Show all checks". (This
> > might
> > > > be
> > > > > gone after closing the PR though).
> > > > >
> > > > > I wouldn't mind the extra commit, but on github, in
> > > > > https://github.com/apache/zookeeper/pulls, we have multiple
> comments
> > > > > showing under every PR. Before this, for me at least, I used this
> to
> > > > > quickly identify the PRs which haven't been reviewed by anyone
> > (having 0
> > > > or
> > > > > 1 comments). Or to see quickly if something is getting a lot of
> > attention
> > > > > lately, or getting updates etc.
> > > > >
> > > > > This was a convenient thing for me, of course not a feature I can't
> > live
> > > > > without. I just wanted to ask other devs view on this.
> > > > >
> > > > > So, what's your view? :)
> > > > >
> > > > > Regards,
> > > > > Norbert
> > > >
> > > > --
> > > -- Enrico Olivelli
> >
>
-- 


-- Enrico Olivelli

ZooKeeper-trunk - Build # 257 - Failure

2018-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk/257/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 174.09 KB...]
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 4
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.939 sec, Thread: 1, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.034 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 1
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.557 sec, Thread: 4, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.853 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
4
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.102 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 4
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.74 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.454 sec, Thread: 3, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3
[junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.893 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.065 sec, Thread: 3, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.158 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 3
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.896 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.193 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.109 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.809 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 4
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.957 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.129 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.373 sec, Thread: 1, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.943 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.924 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Running org.apache.jute.BinaryInputArchiveTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.075 sec, Thread: 3, Class: org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.485 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
269.872 sec,

[jira] [Commented] (ZOOKEEPER-3155) Remove Forrest XMLs and their build process from the project

2018-11-06 Thread Hudson (JIRA)



[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677273#comment-16677273
 ] 

Hudson commented on ZOOKEEPER-3155:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #257 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/257/])
ZOOKEEPER-3155: Remove Forrest XMLs and their build process from the … (andor: 
rev e5fc1228104410728646982eff84d4fb21b361ca)
* (delete) docs/zookeeperAdmin.html
* (delete) docs/zookeeperStarted.html
* (delete) docs/javaExample.pdf
* (delete) docs/zookeeperObservers.pdf
* (delete) docs/skin/getBlank.js
* (delete) docs/skin/CommonMessages_es.xml
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperOver.xml
* (delete) docs/zookeeperReconfig.pdf
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperQuotas.xml
* (delete) zookeeper-docs/src/documentation/content/xdocs/javaExample.xml
* (delete) docs/bookkeeperOverview.pdf
* (delete) docs/images/built-with-forrest-button.png
* (delete) zookeeper-docs/src/documentation/resources/images/state_dia.dia
* (delete) docs/skin/images/chapter.gif
* (delete) docs/index.html
* (delete) docs/images/zknamespace.jpg
* (delete) docs/zookeeperJMX.html
* (delete) zookeeper-docs/src/documentation/content/xdocs/tabs.xml
* (delete) docs/skin/images/rc-t-r-5-1header-2searchbox-3searchbox.png
* (delete) docs/skin/menu.js
* (delete) docs/skin/images/instruction_arrow.png
* (delete) docs/releasenotes.pdf
* (delete) docs/skin/images/spacer.gif
* (delete) docs/skin/images/rc-t-r-5-1header-2tab-unselected-3tab-unselected.png
* (delete) zookeeper-docs/src/documentation/resources/images/hadoop-logo.jpg
* (delete) docs/skin/images/pdfdoc.gif
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperOtherInfo.xml
* (delete) docs/skin/basic.css
* (delete) 
zookeeper-docs/src/documentation/resources/images/zkperfreliability.jpg
* (delete) docs/skin/images/forrest-credit-logo.png
* (delete) docs/bookkeeperConfig.html
* (edit) zookeeper-server/src/test/resources/test-patch.sh
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperStarted.xml
* (delete) docs/images/2pc.jpg
* (delete) docs/skin/images/warning.png
* (delete) zookeeper-docs/src/documentation/resources/images/zkarch.jpg
* (delete) docs/zookeeperStarted.pdf
* (delete) zookeeper-docs/src/documentation/resources/images/2pc.jpg
* (delete) docs/zookeeperHierarchicalQuorums.pdf
* (delete) docs/images/favicon.ico
* (delete) zookeeper-docs/src/documentation/content/xdocs/recipes.xml
* (delete) docs/bookkeeperProgrammer.html
* (delete) docs/recipes.html
* (delete) docs/skin/images/built-with-forrest-button.png
* (delete) docs/skin/CommonMessages_fr.xml
* (delete) docs/skin/print.css
* (delete) docs/zookeeperOver.html
* (delete) docs/skin/images/external-link.gif
* (delete) docs/skin/breadcrumbs.js
* (delete) docs/skin/images/rc-b-l-15-1body-2menu-3menu.png
* (delete) docs/zookeeperTutorial.pdf
* (delete) zookeeper-docs/src/documentation/resources/images/zkperfRW.jpg
* (delete) zookeeper-docs/src/documentation/resources/images/zknamespace.jpg
* (delete) docs/zookeeperObservers.html
* (delete) docs/skin/images/rc-t-r-5-1header-2tab-selected-3tab-selected.png
* (delete) docs/skin/images/rss.png
* (delete) docs/zookeeperQuotas.pdf
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperAdmin.xml
* (delete) docs/zookeeperReconfig.html
* (delete) zookeeper-docs/src/documentation/content/xdocs/site.xml
* (delete) docs/skin/images/success.png
* (delete) docs/skin/images/remove.jpg
* (delete) zookeeper-docs/src/documentation/skinconf.xml
* (delete) docs/zookeeperOtherInfo.html
* (delete) zookeeper-docs/status.xml
* (delete) docs/skin/images/fix.jpg
* (delete) docs/zookeeperAdmin.pdf
* (delete) docs/linkmap.pdf
* (delete) docs/bookkeeperStarted.html
* (delete) docs/images/zookeeper_small.gif
* (delete) zookeeper-docs/src/documentation/README.txt
* (delete) docs/skin/images/txtdoc.png
* (delete) docs/javaExample.html
* (delete) docs/images/state_dia.jpg
* (delete) zookeeper-docs/src/documentation/content/xdocs/zookeeperTutorial.xml
* (delete) docs/zookeeperInternals.pdf
* (delete) docs/zookeeperProgrammers.html
* (delete) docs/skin/images/chapter_open.gif
* (delete) docs/skin/images/rc-b-r-5-1header-2tab-selected-3tab-selected.png
* (edit) build.xml
* (delete) 
zookeeper-docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
* (delete) docs/images/zkcomponents.jpg
* (delete) docs/images/instruction_arrow.png
* (edit) zookeeper-server/src/test/resources/test-github-pr.sh
* (delete) docs/skin/images/rc-b-r-15-1body-2menu-3menu.png
* (delete) zookeeper-docs/forrest.properties
* (delete) zookeeper-docs/src/documentation/resources/images/favicon.ico
* (delete) zookeeper-docs/src/documentation/TODO.txt
* (delete) docs/skin/getMenu.js
* (delete) docs/bookkeeperConfig.pdf
* (delete) zookeeper-docs/src/documentation/resources/images/zkservice.jpg
*

[GitHub] zookeeper issue #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/key sto...

2018-11-06 Thread ivmaykov

Github user ivmaykov commented on the issue:

https://github.com/apache/zookeeper/pull/678
  
@anmolnar the latest attempt does not have test failures, but claims a 
findbugs failure.

>[exec] -1 overall.  GitHub Pull Request  Build
>[exec]   
>[exec] 
>[exec] +1 @author.  The patch does not contain any @author tags.
>[exec] 
>[exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
>[exec] 
>[exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
>[exec] 
>[exec] +1 javac.  The applied patch does not increase the total 
number of javac compiler warnings.
>[exec] 
>[exec] -1 findbugs.  The patch appears to cause Findbugs (version 
3.0.1) to fail.
>[exec] 
>[exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
>[exec] 
>[exec] +1 core tests.  The patch passed core unit tests.
>[exec] 
>[exec] +1 contrib tests.  The patch passed contrib unit tests.

Link to full output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2599/console


---

Build failed in Jenkins: ZooKeeper-trunk-owasp #163

2018-11-06 Thread Apache Jenkins Server

See 


Changes:

[andor] ZOOKEEPER-3156: Add in option to canonicalize host name

--
[...truncated 15.99 KB...]
-
|  javacc  |   1   |   0   |   0   |   0   ||   1   |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [javacc]
[ivy:retrieve]  1 artifacts copied, 0 already retrieved (291kB/3ms)

generate_jute_parser:
[mkdir] Created dir: 

[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 

 [move] Moving 1 file to 

   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 

 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:
[javac] Compiling 39 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 1 warning

compile_jute_uptodate:

compile_jute:
[mkdir] Created dir: 

[mkdir] Created dir: 

 [java] ../../../src/main/resources/zookeeper.jute Parsed Successfully
 [java] ../../../zookeeper-jute/src/main/resources/zookeeper.jute Parsed 
Successfully
[touch] Creating 


ver-gen:
[javac] Compiling 1 source file to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 1 warning

git-revision:
[mkdir] Created dir: 


version-info:

process-template:

build-generated:
[javac] Compiling 63 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 1 warning

compile:
[javac] Compiling 291 source files to 

[javac] warning: [options] bootstrap class path not set in conjunction with 
-source 8
[javac] 
:37:
 warning: [deprecation] newInstance() in Class has been deprecated
[javac] true, 
Thread.currentThread().getContextClassLoader()).newInstance();
[javac] 
 ^
[javac]   where T is a type-variable:
[javac] T extends Object declared in class Class
[javac] 
:254:
 warning: [cast] redundant cast to ByteBuffer
[javac] b = (ByteBuffer) b.slice().limit(
[javac] ^
[javac] 
:78:
 warning: [cast] redundant cast to ByteBuffer
[javac] fileChannel.write((ByteBuffer) fill.position(0), 
newFileSize - fill.remaining());
[javac]   ^
[javac] 
:42:
 warning: [deprecation] newInstance() in Class has been deprecated
[javac] (IWatchManager) 
Class.forName(watchManagerName).newInstance();
[javac]^
[javac]   where T

ZooKeeper_branch34_openjdk8 - Build # 112 - Failure

2018-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/112/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 43.43 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.811 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.596 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.714 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.613 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.077 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.705 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.239 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.915 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.956 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.904 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.743 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.669 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.524 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.934 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.084 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.318 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.107 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.647 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.746 sec
[junit] Running org.apache.jute.BinaryInputArchiveTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.08 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1426:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1429:
 Tests failed!

Total time: 39 minutes 46 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Recording test results
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/
Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testNewFollowerRestartAfterNewEpoch

Error Message:
Waiting too long

Stack Trace:
java.lang.RuntimeException: Waiting too long
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:449)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:439)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.LaunchServers(QuorumPeerMainTest.java:547)
at

Re: Re: asfgit commenting on PRs

2018-11-06 Thread Enrico Olivelli

I have unchecked the "Add test result one liner" flag in the PR builder Job
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/

let's see how it feels now

Enrico


Il giorno mar 6 nov 2018 alle ore 03:44 毛蛤丝
 ha scritto:
>
> +1,for removing the asfgit successful build comments.
>
> 
>
> Best regards
> maoling
> Beijing,China
>
>
> - 原始邮件 -
> 发件人：Enrico Olivelli 
> 收件人：dev@zookeeper.apache.org
> 主题：Re: asfgit commenting on PRs
> 日期：2018年11月06日 04点57分
>
> Il lun 5 nov 2018, 21:28 Andor Molnar  ha scritto:
> > I also feel the comments redundant.
> > Enrico - shall we remove this?
> >
> I will check, it should be a flag on job config
> Enrico
> > Andor
> >
> >
> >
> > > On 2018. Nov 5., at 12:24, Norbert Kalmar 
> > wrote:
> > >
> > > Hi all,
> > >
> > > One of the recent development was that asfgit now comments on the PRs
> > every
> > > successful builds.
> > > But we do have the same information under "Show all checks". (This might
> > be
> > > gone after closing the PR though).
> > >
> > > I wouldn't mind the extra commit, but on github, in
> > > https://github.com/apache/zookeeper/pulls, we have multiple comments
> > > showing under every PR. Before this, for me at least, I used this to
> > > quickly identify the PRs which haven't been reviewed by anyone (having 0
> > or
> > > 1 comments). Or to see quickly if something is getting a lot of attention
> > > lately, or getting updates etc.
> > >
> > > This was a convenient thing for me, of course not a feature I can't live
> > > without. I just wanted to ask other devs view on this.
> > >
> > > So, what's your view? :)
> > >
> > > Regards,
> > > Norbert
> >
> > --
> -- Enrico Olivelli

[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

2018-11-06 Thread tumativ

Github user tumativ commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/684#discussion_r231110582
  
--- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java 
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.jute.Record;
+import org.apache.zookeeper.data.Stat;
+
+@SuppressWarnings("serial")
+public class ResponseCache {
+private static final int DEFAULT_RESPONSE_CACHE_SIZE = 400;
+
+private static class Entry {
+public Stat stat;
+public byte[] data;
+}
+
+private Map cache = Collections.synchronizedMap(
+new LRUCache(getResponseCacheSize()));
+
+public ResponseCache() {
+}
+
+public void put(String path, byte[] data, Stat stat) {
+Entry entry = new Entry();
+entry.data = data;
+entry.stat = stat;
+cache.put(path, entry);
+}
+
+public byte[] get(String key, Stat stat) {
+Entry entry = cache.get(key);
+if (entry == null) {
+return null;
+}
+if (!stat.equals(entry.stat)) {
+// The node has been modified, invalidate cache.
+cache.remove(key);
+return null;
+} else {
+return entry.data;
+}
+}
+
+private static int getResponseCacheSize() {
+String value = 
System.getProperty("zookeeper.maxResponseCacheSize");
+return value == null ? DEFAULT_RESPONSE_CACHE_SIZE : 
Integer.parseInt(value);
+}
+
+public static boolean isEnabled() {
+return getResponseCacheSize() != 0;
+}
+
+private static class LRUCache extends LinkedHashMap {
--- End diff --

Can we provide the  Eviction Policy like FIFO,LRU,LFU  etc to cache and 
behave accordingly?


---

[GitHub] zookeeper issue #648: ZOOKEEPER-3156: Add in option to canonicalize host nam...

2018-11-06 Thread revans2

Github user revans2 commented on the issue:

https://github.com/apache/zookeeper/pull/648
  
Thanks


---

[GitHub] zookeeper pull request #648: ZOOKEEPER-3156: Add in option to canonicalize h...

2018-11-06 Thread revans2

Github user revans2 closed the pull request at:

https://github.com/apache/zookeeper/pull/648


---

[GitHub] zookeeper issue #671: ZOOKEEPER-3155: Remove Forrest XMLs and their build pr...

2018-11-06 Thread anmolnar

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/671
  
Sorry @tamaashu , I missed your comment.
I'm @anmolnar btw, somebody has already stolen "andor". :)


---

[GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...

2018-11-06 Thread tumativ

Github user tumativ commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/684#discussion_r231189992
  
--- Diff: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java 
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+import org.apache.jute.Record;
+import org.apache.zookeeper.data.Stat;
+
+@SuppressWarnings("serial")
+public class ResponseCache {
+private static final int DEFAULT_RESPONSE_CACHE_SIZE = 400;
+
+private static class Entry {
+public Stat stat;
+public byte[] data;
+}
+
+private Map cache = Collections.synchronizedMap(
--- End diff --

Can LRUcache compose the LinkedHashMap rather extending? Can we use 
read-write locks for better synchronization? The read lock on reads will give 
better results rather locking on the map.


---

75 matches

Mail list logo