I provided technical objections, multiple times here and on the doc, based
on the fact that you propose a major extension that will further complicate
an already brittle configuration format, which multiple people are
similarly and concurrently also trying to extend in incompatible ways.
The
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233659698
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233659921
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -316,16 +251,17 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233663529
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233663197
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/689
@anmolnar that's a good point, I think the reason we didn't use
ZooKeeperThread or ZooKeeperCriticalThread is because we don't expect to exit
abnormally from the WatcherCleaner thread, which is
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233657773
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233656201
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -350,14 +389,22 @@ public static X509TrustManager
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233656740
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233657163
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233656579
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/PrependableSocket.java
---
@@ -18,32 +18,47 @@
package
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233661987
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233661888
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233661917
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233664524
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233647195
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233643417
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233633340
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/PrependableSocket.java
---
@@ -18,32 +18,47 @@
package
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233645255
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233632959
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -350,14 +389,22 @@ public static X509TrustManager
Hi All,
I've done a few changes on the ZooKeeper website to eliminate any need of
installed additional software when generating the static web content.
In the meantime I've thought it's a good idea to refresh the site's design.
First I've tried to apply a similar styling as Apache HBase site
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233661570
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/PrependableSocket.java
---
@@ -18,32 +18,47 @@
package
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233668370
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/701
[ZOOKEEPER-3125] Only patching the pzxid when it's larger than the current
pzxid
This previous fix in #605 has a corner case which might revert the pzxid,
it's being fixed when port to 3.5 in
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233652712
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233653584
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233649908
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233651730
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/TestByteBufAllocator.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233650367
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233651445
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -316,16 +251,17 @@ public void
For 1), I posted this 3 or 4 years ago:
https://timmahnator.tumblr.com/post/115073121775/zoo-keepers-and-dock-workers
In the intervening time, with lots more "cloud" and "container" floating
around,
I can only imagine the need has gotten greater.
And No, spinning up a DNS server inside and
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233661093
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/PrependableSocket.java
---
@@ -18,32 +18,47 @@
package
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/679#discussion_r233662723
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/UnifiedServerSocketTest.java
---
@@ -17,156 +17,644 @@
*/
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3028:
Fix Version/s: 3.4.14
3.5.5
3.6.0
> Create
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3029:
Affects Version/s: 3.5.4
3.4.13
> Create pom.xml for jute and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3028:
Affects Version/s: 3.5.4
3.4.13
> Create assembly in pom.xml
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3029:
Fix Version/s: 3.4.14
3.5.5
3.6.0
> Create
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3028:
Priority: Blocker (was: Major)
> Create assembly in pom.xml
>
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/692
Hi @eolivelli, could you please check it again? Since I changed it
fundamentally, I think it needs a new review.
@anmolnar, @hanm could you please review these changes?
Thanks.
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1195/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 65.92 KB...]
[junit] Tests run: 1, Failures:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3171:
Fix Version/s: 3.4.14
3.5.5
3.6.0
> Create
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3171:
Priority: Blocker (was: Major)
> Create pom.xml for recipes and contrib
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3171:
Affects Version/s: 3.5.4
3.4.13
> Create pom.xml for recipes
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r233723629
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -181,7 +181,7 @@ protected void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r233723763
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -209,6 +209,8 @@ public void run() {
Thank you Tamaas,
Do you have a staging site for easy preview?
Enrico
Il mer 14 nov 2018, 23:36 Tamas Penzes ha
scritto:
> Hi All,
>
> I've done a few changes on the ZooKeeper website to eliminate any need of
> installed additional software when generating the static web content.
>
> In the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Penzes updated ZOOKEEPER-3029:
Priority: Blocker (was: Major)
> Create pom.xml for jute and server
>
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/692
@tamaashu Have you changed the design of the website intentionally?
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/692#discussion_r233605749
--- Diff: src/main/resources/markdown/bylaws.md ---
@@ -1,7 +1,19 @@
-layout: page
-title: Project Bylaws
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/692
Do you have a preview in some staging site?
---
Github user tamaashu commented on the issue:
https://github.com/apache/zookeeper/pull/692
@anmolnar yes. This design is responsive, adopts to the screen size,
simple, easy to read, but still modern. It's close to HBase's design, but since
I've used 2 version newer bootstrap it
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/689
@tumativ I tend to agree with @lvfangmin in adding `interrupt()` call to
shutdown would be the easiest solution here.
In which case I would also add `break;` to the InterruptedException
52 matches
Mail list logo
