[GitHub] zookeeper pull request #722: [ZOOKEEPER-3203] Tracking the number of non vot...
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/722#discussion_r236150403
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderBean.java
---
@@ -51,6 +51,15 @@ public String followerInfo() {
return sb.toString();
}
+@Override
+public String nonVotingFollowerInfo() {
+StringBuilder sb = new StringBuilder();
+for (LearnerHandler handler : leader.getNonVotingFollowers()) {
+sb.append(handler.toString()).append("\n");
--- End diff --
Wouldn't it be better to have a specific toStringForJMX method.
In the future people will change the toString method without thinking that
they are changing the output of a public endpoint
---
[jira] [Created] (ZOOKEEPER-3204) Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
Andor Molnar created ZOOKEEPER-3204: --- Summary: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix Key: ZOOKEEPER-3204 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3204 Project: ZooKeeper Issue Type: Test Components: tests Affects Versions: 3.5.5 Reporter: Andor Molnar Assignee: Andor Molnar Fix For: 3.5.5 The following Reconfig tests failing since we've committed to fix for Java 11. The fix which was intended to fix the problems with port binding issues on Java 11. Tests are not flaky, they've failed in all builds since #15. https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper_branch35_java11/15/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3199) Unable to produce verbose logs of Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698659#comment-16698659 ] Ankit Kothana commented on ZOOKEEPER-3199: -- Closing issue. Resolved. > Unable to produce verbose logs of Zookeeper > --- > > Key: ZOOKEEPER-3199 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3199 > Project: ZooKeeper > Issue Type: Bug >Reporter: Ankit Kothana >Priority: Major > Attachments: log4j.properties, zookeeper.log > > > We are using Zookeeper in our system along with Apache Kafka. However, > Zookeeper is not producing any relevant logs (even with lower log levels > specified in log4j.properties) in the log file that could help us in > identifying what is currently going on in ZK or Kafka cluster. > Please let us know how to retrieve proper logs from ZK cluster. > Version of ZK : 3.4.13 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3199) Unable to produce verbose logs of Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Kothana resolved ZOOKEEPER-3199. -- Resolution: Fixed Found a bug in our script. > Unable to produce verbose logs of Zookeeper > --- > > Key: ZOOKEEPER-3199 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3199 > Project: ZooKeeper > Issue Type: Bug >Reporter: Ankit Kothana >Priority: Major > Attachments: log4j.properties, zookeeper.log > > > We are using Zookeeper in our system along with Apache Kafka. However, > Zookeeper is not producing any relevant logs (even with lower log levels > specified in log4j.properties) in the log file that could help us in > identifying what is currently going on in ZK or Kafka cluster. > Please let us know how to retrieve proper logs from ZK cluster. > Version of ZK : 3.4.13 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
ZooKeeper_branch34_openjdk8 - Build # 135 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/135/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.80 KB...] [junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.491 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.594 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.671 sec [junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.601 sec [junit] Running org.apache.zookeeper.test.SaslClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.077 sec [junit] Running org.apache.zookeeper.test.SessionInvalidationTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.739 sec [junit] Running org.apache.zookeeper.test.SessionTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.538 sec [junit] Running org.apache.zookeeper.test.SessionTimeoutTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.84 sec [junit] Running org.apache.zookeeper.test.StandaloneTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.947 sec [junit] Running org.apache.zookeeper.test.StatTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.913 sec [junit] Running org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.727 sec [junit] Running org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.671 sec [junit] Running org.apache.zookeeper.test.TruncateTest [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.509 sec [junit] Running org.apache.zookeeper.test.UpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.963 sec [junit] Running org.apache.zookeeper.test.WatchedEventTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.083 sec [junit] Running org.apache.zookeeper.test.WatcherFuncTest [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.304 sec [junit] Running org.apache.zookeeper.test.WatcherTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.375 sec [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.552 sec [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.732 sec [junit] Running org.apache.jute.BinaryInputArchiveTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.077 sec fail.build.on.test.failure: BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1408: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1411: Tests failed! Total time: 39 minutes 25 seconds Build step 'Invoke Ant' marked build as failure Archiving artifacts Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Recording test results Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testNewFollowerRestartAfterNewEpoch Error Message: Waiting too long Stack Trace: java.lang.RuntimeException: Waiting too long at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:449) at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.waitForAll(QuorumPeerMainTest.java:439) at org.apache.zookeeper.server.quorum.QuorumPeerMainTest.LaunchServers(QuorumPeerMainTest.java:547) at
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/679 @anmolnar renamed the tests and cleaned them up quite a bit too (the formerly-DoS tests don't actually need a background thread for the bad client socket, which simplifies things). ---
ZooKeeper-trunk - Build # 284 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/284/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 322.20 KB...] [exec] 7fb17df0a000-7fb17df0b000 rw-p b000 08:03 10223806 /lib/x86_64-linux-gnu/libnss_files-2.23.so [exec] 7fb17df0b000-7fb17df11000 rw-p 00:00 0 [exec] 7fb17df11000-7fb17e0d1000 r-xp 08:03 10223790 /lib/x86_64-linux-gnu/libc-2.23.so [exec] 7fb17e0d1000-7fb17e2d1000 ---p 001c 08:03 10223790 /lib/x86_64-linux-gnu/libc-2.23.so [exec] 7fb17e2d1000-7fb17e2d5000 r--p 001c 08:03 10223790 /lib/x86_64-linux-gnu/libc-2.23.so [exec] 7fb17e2d5000-7fb17e2d7000 rw-p 001c4000 08:03 10223790 /lib/x86_64-linux-gnu/libc-2.23.so [exec] 7fb17e2d7000-7fb17e2db000 rw-p 00:00 0 [exec] 7fb17e2db000-7fb17e2f1000 r-xp 08:03 10223681 /lib/x86_64-linux-gnu/libgcc_s.so.1 [exec] 7fb17e2f1000-7fb17e4f ---p 00016000 08:03 10223681 /lib/x86_64-linux-gnu/libgcc_s.so.1 [exec] 7fb17e4f-7fb17e4f1000 rw-p 00015000 08:03 10223681 /lib/x86_64-linux-gnu/libgcc_s.so.1 [exec] 7fb17e4f1000-7fb17e5f9000 r-xp 08:03 10223781 /lib/x86_64-linux-gnu/libm-2.23.so [exec] 7fb17e5f9000-7fb17e7f8000 ---p 00108000 08:03 10223781 /lib/x86_64-linux-gnu/libm-2.23.so [exec] 7fb17e7f8000-7fb17e7f9000 r--p 00107000 08:03 10223781 /lib/x86_64-linux-gnu/libm-2.23.so [exec] 7fb17e7f9000-7fb17e7fa000 rw-p 00108000 08:03 10223781 /lib/x86_64-linux-gnu/libm-2.23.so [exec] 7fb17e7fa000-7fb17e96c000 r-xp 08:03 2622487 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21 [exec] 7fb17e96c000-7fb17eb6c000 ---p 00172000 08:03 2622487 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21 [exec] 7fb17eb6c000-7fb17eb76000 r--p 00172000 08:03 2622487 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21 [exec] 7fb17eb76000-7fb17eb78000 rw-p 0017c000 08:03 2622487 /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.21 [exec] 7fb17eb78000-7fb17eb7c000 rw-p 00:00 0 [exec] 7fb17eb7c000-7fb17eb7f000 r-xp 08:03 10223792 /lib/x86_64-linux-gnu/libdl-2.23.so [exec] 7fb17eb7f000-7fb17ed7e000 ---p 3000 08:03 10223792 /lib/x86_64-linux-gnu/libdl-2.23.so [exec] 7fb17ed7e000-7fb17ed7f000 r--p 2000 08:03 10223792 /lib/x86_64-linux-gnu/libdl-2.23.so [exec] 7fb17ed7f000-7fb17ed8 rw-p 3000 08:03 10223792 /lib/x86_64-linux-gnu/libdl-2.23.so [exec] 7fb17ed8-7fb17edba000 r-xp 08:03 2640294 /usr/lib/x86_64-linux-gnu/libcppunit-1.13.so.0.0.2 [exec] 7fb17edba000-7fb17efba000 ---p 0003a000 08:03 2640294 /usr/lib/x86_64-linux-gnu/libcppunit-1.13.so.0.0.2 [exec] 7fb17efba000-7fb17efbc000 r--p 0003a000 08:03 2640294 /usr/lib/x86_64-linux-gnu/libcppunit-1.13.so.0.0.2 [exec] 7fb17efbc000-7fb17efbd000 rw-p 0003c000 08:03 2640294 /usr/lib/x86_64-linux-gnu/libcppunit-1.13.so.0.0.2 [exec] 7fb17efbd000-7fb17efd5000 r-xp 08:03 10223788 /lib/x86_64-linux-gnu/libpthread-2.23.so [exec] 7fb17efd5000-7fb17f1d4000 ---p 00018000 08:03 10223788 /lib/x86_64-linux-gnu/libpthread-2.23.so [exec] 7fb17f1d4000-7fb17f1d5000 r--p 00017000 08:03 10223788 /lib/x86_64-linux-gnu/libpthread-2.23.so [exec] 7fb17f1d5000-7fb17f1d6000 rw-p 00018000 08:03 10223788 /lib/x86_64-linux-gnu/libpthread-2.23.so [exec] 7fb17f1d6000-7fb17f1da000 rw-p 00:00 0 [exec] 7fb17f1da000-7fb17f20 r-xp 08:03 10223786 /lib/x86_64-linux-gnu/ld-2.23.so [exec] 7fb17f3e6000-7fb17f3ed000 rw-p 00:00 0 [exec] 7fb17f3fe000-7fb17f3ff000 rw-p 00:00 0 [exec] 7fb17f3ff000-7fb17f40 r--p 00025000 08:03 10223786 /lib/x86_64-linux-gnu/ld-2.23.so [exec] 7fb17f40-7fb17f401000 rw-p 00026000 08:03 10223786 /lib/x86_64-linux-gnu/ld-2.23.so [exec] 7fb17f401000-7fb17f402000 rw-p 00:00 0 [exec] 7ffc4952c000-7ffc4954d000 rw-p 00:00 0 [stack] [exec] 7ffc495ac000-7ffc495af000 r--p 00:00 0 [vvar] [exec] 7ffc495af000-7ffc495b1000 r-xp 00:00 0 [vdso] [exec] ff60-ff601000 r-xp 00:00 0 [vsyscall] [exec] /bin/bash: line 5: 31067 Aborted
[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 Hi, @anmolnar @eolivelli . Is there anything I need to do before we merge this PR? ---
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.jute.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3205: -- Labels: pull-request-available (was: ) > Jute - o.a.jute.BinaryInputArchive Test cases > - > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Labels: pull-request-available > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.jute.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #726: ZOOKEEPER-3205: o.a.jute test cases
GitHub user akkumar opened a pull request: https://github.com/apache/zookeeper/pull/726 ZOOKEEPER-3205: o.a.jute test cases Adding some test cases for o.a.jute BinaryInputArchive . Issue ZOOKEEPER-3205 contains the patch as well. You can merge this pull request into a Git repository by running: $ git pull https://github.com/akkumar/zookeeper jutetest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/726.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #726 commit 771d1d545dd0ef9799cbc1cdf7fcdbc48d675369 Author: Karthik K Date: 2018-11-26T16:21:43Z ZOOKEEPER-3205: o.a.jute test cases ---
[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/294 @anmolnar green lights from CI This is a trivial patch, do you need another committer ? ---
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.jute.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik K updated ZOOKEEPER-3205: - Attachment: (was: ZOOKEEPER-3205.patch) > Jute - o.a.jute.BinaryInputArchive Test cases > - > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Labels: pull-request-available > Fix For: 3.5.5 > > Time Spent: 10m > Remaining Estimate: 0h > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.jute.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3180) Add response cache to improve the throughput of read heavy traffic
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698826#comment-16698826
]
Rakesh R commented on ZOOKEEPER-3180:
-
[~lvfangmin], Feature looks pretty interesting and thanks for the patch. I will
try to review it when I get a chance.
I'd like to understand scaling of this cache in the production env. Appreciate
if you could help me, adding more details about the memory usage:
# How much is the java heap size of ZooKeeper server and the possible number
of znodes (am assuming 4MB data per znode).
# Based on your experiment, what would be the ideal number of elements to be
kept into the cache for a better read performance gain.
Since you have mentioned that the intention of read cache feature is to reduce
the GC overhead, I would also like to explore the option of enabling the cache
backed by {{off heap}} memory. Again, you have {{4MB}} data in a single zNode
and it would occupy good amount of {{on heap}} memory area if the number of
zNode grows(in future). The off heap implementation uses {{DirectByteByffers}}
to manage cache outside of the JVM heap and provides scalability to a large
memory sizes without GC overhead.
One option could be to provide different cache modes (onheap or offheap) to the
users to efficiently utilize the heap area. Does this make sense to you?
> Add response cache to improve the throughput of read heavy traffic
> ---
>
> Key: ZOOKEEPER-3180
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3180
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: Fangmin Lv
>Assignee: Brian Nixon
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> On read heavy use case with large response data size, the serialization of
> response takes time and added overhead to the GC.
> Add response cache helps improving the throughput we can support, which also
> reduces the latency in general.
> This Jira is going to implement a LRU cache for the response, which shows
> some performance gain on some of our production ensembles.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
ZooKeeper_branch34_openjdk8 - Build # 134 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/134/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 43.44 KB...] [junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.763 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.731 sec [junit] Running org.apache.zookeeper.test.SaslAuthFailTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.818 sec [junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.769 sec [junit] Running org.apache.zookeeper.test.SaslClientTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.113 sec [junit] Running org.apache.zookeeper.test.SessionInvalidationTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.828 sec [junit] Running org.apache.zookeeper.test.SessionTest [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.342 sec [junit] Running org.apache.zookeeper.test.SessionTimeoutTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.224 sec [junit] Running org.apache.zookeeper.test.StandaloneTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.016 sec [junit] Running org.apache.zookeeper.test.StatTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.233 sec [junit] Running org.apache.zookeeper.test.StaticHostProviderTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.876 sec [junit] Running org.apache.zookeeper.test.SyncCallTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.81 sec [junit] Running org.apache.zookeeper.test.TruncateTest [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.622 sec [junit] Running org.apache.zookeeper.test.UpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.256 sec [junit] Running org.apache.zookeeper.test.WatchedEventTest [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec [junit] Running org.apache.zookeeper.test.WatcherFuncTest [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.588 sec [junit] Running org.apache.zookeeper.test.WatcherTest [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.303 sec [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.234 sec [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.897 sec [junit] Running org.apache.jute.BinaryInputArchiveTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec fail.build.on.test.failure: BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1408: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk8/build.xml:1411: Tests failed! Total time: 55 minutes 47 seconds Build step 'Invoke Ant' marked build as failure Archiving artifacts Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Recording test results Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Email was triggered for: Failure - Any Sending email for trigger: Failure - Any Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ Setting OPENJDK_8_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-8-openjdk-amd64/ ### ## FAILED TESTS (if any) ## 1 tests failed. FAILED: org.apache.zookeeper.server.PurgeTxnTest.testPurgeWhenLogRollingInProgress Error Message: ZkClient ops is not finished! Stack Trace: junit.framework.AssertionFailedError: ZkClient ops is not finished! at org.apache.zookeeper.server.PurgeTxnTest.manyClientOps(PurgeTxnTest.java:591) at org.apache.zookeeper.server.PurgeTxnTest.testPurgeWhenLogRollingInProgress(PurgeTxnTest.java:152) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)
[GitHub] zookeeper pull request #725: Zookeeper-3188: Improve resilience to network
GitHub user ArtemChernatsky opened a pull request: https://github.com/apache/zookeeper/pull/725 Zookeeper-3188: Improve resilience to network According to issue [ZOOKEEPER-3188](https://issues.apache.org/jira/browse/ZOOKEEPER-3188) added ability to specify several addresses for quorum operations. Also added reconnection attempts if connection to leader lost. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mapr-demos/zookeeper ZOOKEEPER-3188 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/725.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #725 commit 966618740777c55eb1af040ab447845c42402284 Author: ArtemChernatsky Date: 2018-11-23T16:31:59Z added multiple addresses support for quorum ---
[jira] [Updated] (ZOOKEEPER-3188) Improve resilience to network
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3188: -- Labels: pull-request-available (was: ) > Improve resilience to network > - > > Key: ZOOKEEPER-3188 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3188 > Project: ZooKeeper > Issue Type: Bug >Reporter: Ted Dunning >Priority: Major > Labels: pull-request-available > > We propose to add network level resiliency to Zookeeper. The ideas that we > have on the topic have been discussed on the mailing list and via a > specification document that is located at > [https://docs.google.com/document/d/1iGVwxeHp57qogwfdodCh9b32P2_kOQaJZ2GDo7j36fI/edit?usp=sharing] > That document is copied to this issue which is being created to report the > results of experimental implementations. > h1. Zookeeper Network Resilience > h2. Background > Zookeeper is designed to help in building distributed systems. It provides a > variety of operations for doing this and all of these operations have rather > strict guarantees on semantics. Zookeeper itself is a distributed system made > up of cluster containing a leader and a number of followers. The leader is > designated in a process known as leader election in which a majority of all > nodes in the cluster must agree on a leader. All subsequent operations are > initiated by the leader and completed when a majority of nodes have confirmed > the operation. Whenever an operation cannot be confirmed by a majority or > whenever the leader goes missing for a time, a new leader election is > conducted and normal operations proceed once a new leader is confirmed. > > The details of this are not important relative to this discussion. What is > important is that the semantics of the operations conducted by a Zookeeper > cluster and the semantics of how client processes communicate with the > cluster depend only on the basic fact that messages sent over TCP connections > will never appear out of order or missing. Central to the design of ZK is > that a server to server network connection is used as long as it works to use > it and a new connection is made when it appears that the old connection isn't > working. > > As currently implemented, however, each member of a Zookeeper cluster can > have only a single address as viewed from some other process. This means, > absent network link bonding, that the loss of a single switch or a few > network connections could completely stop the operations of a the Zookeeper > cluster. It is the goal of this work to address this issue by allowing each > server to listen on multiple network interfaces and to connect to other > servers any of several addresses. The effect will be to allow servers to > communicate over redundant network paths to improve resiliency to network > failures without changing any core algorithms. > h2. Proposed Change > Interestingly, the correct operations of a Zookeeper cluster do not depend on > _how_ a TCP connection was made. There is no reason at all not to advertise > multiple addresses for members of a Zookeeper cluster. > > Connections between members of a Zookeeper cluster and between a client and a > cluster member are established by referencing a configuration file (for > cluster members) that specifies the address of all of the nodes in a cluster > or by using a connection string containing possible addresses of Zookeeper > cluster members. As soon as a connection is made, any desired authentication > or encryption layers are added and the connection is handed off to the client > communications layer or the server to server logic. > This means that the only thing that actually needs to change to allow > Zookeeper servers to be accessible on multiple networks is a change in the > server configuration file format to allow the multiple addresses to be > specified and to update the code that establishes the TCP connection to make > use of these multiple addresses. No code changes are actually needed on the > client since we can simply supply all possible server addresses. The client > already has logic for selecting a server address at random and it doesn’t > really matter if these addresses represent synonyms for the same server. All > that matters is that _some_ connection to a server is established. > h2. Configuration File Syntax Change > The current Zookeeper syntax looks like this: > > tickTime=2000 > dataDir=/var/zookeeper > clientPort=2181 > initLimit=5 > syncLimit=2 > server.1=zoo1:2888:3888 > server.2=zoo2:2888:3888 > server.3=zoo3:2888:3888 > > The only lines that matter for this discussion are the last three. These > specify the addresses for each of the servers that are part of the Zookeeper > cluster as well as the port
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.jute.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik K updated ZOOKEEPER-3205: - Summary: Jute - o.a.jute.BinaryInputArchive Test cases (was: Jute - o.a.j.BinaryInputArchive Test cases) > Jute - o.a.jute.BinaryInputArchive Test cases > - > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.j.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.jute.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik K updated ZOOKEEPER-3205: - Description: o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / deserialization for various types. It would be good to have a bunch of test cases to assert them as currently they exist almost none. Attaching the patch herewith. Also , added test cases for o.a.jute.Utils(Test) as well was: o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / deserialization for various types. It would be good to have a bunch of test cases to assert them as currently they exist almost none. Attaching the patch herewith. Also , added test cases for o.a.j.Utils(Test) as well > Jute - o.a.jute.BinaryInputArchive Test cases > - > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.jute.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.j.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik K updated ZOOKEEPER-3205: - Description: o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / deserialization for various types. It would be good to have a bunch of test cases to assert them as currently they exist almost none. Attaching the patch herewith. Also , added test cases for o.a.j.Utils(Test) as well was: o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / deserialization for various types. It would be good to have a bunch of test cases to assert them as currently they exist almost none. Attaching the patch herewith. > Jute - o.a.j.BinaryInputArchive Test cases > -- > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.j.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.jute.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik K updated ZOOKEEPER-3205: - Attachment: ZOOKEEPER-3205.patch > Jute - o.a.jute.BinaryInputArchive Test cases > - > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch, ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.jute.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.jute.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik K updated ZOOKEEPER-3205: - Attachment: (was: ZOOKEEPER-3205.patch) > Jute - o.a.jute.BinaryInputArchive Test cases > - > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.jute.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper pull request #692: ZOOKEEPER-3184: Use the same method to generate...
Github user tamaashu commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/692#discussion_r236299105 --- Diff: README.md --- @@ -1,49 +1,24 @@ ## Generating the static Apache ZooKeeper website -In this directory you will find text files formatted using Markdown, with an `.md` suffix. +In the `src/main/resources/markdown` directory you will find text files formatted using Markdown, with an `.md` suffix. -Building the site requires [Jekyll](http://jekyllrb.com/docs) 3.6.2 or newer. -The easiest way to install jekyll is via a Ruby Gem. Jekyll will create a directory called `_site` -containing `index.html` as well as the rest of the compiled directories and files. _site should not -be committed to git as this is the generated content. - -To install Jekyll and its required dependencies, execute `sudo gem install jekyll pygments.rb` -and `sudo pip install Pygments`. See the Jekyll installation page for more details. +Building the site requires [Maven](http://maven.apache.org/) 3.5.0 or newer. +The easiest way to [install Maven](http://maven.apache.org/install.html) depends on your OS. +The build process will create a directory called `target/html` containing `index.html` as well as the rest of the +compiled directories and files. `target` should not be committed to git as it is generated content. You can generate the static ZooKeeper website by running: -1. `jekyll build` in this directory. -2. `cp -RP _released_docs _site/doc` - this will include the documentation (see "sub-dir" section below) in the generated site. +1. `mvn clean install` in this directory. +2. `cp -RP _released_docs _target/html` - this will include the documentation (see "sub-dir" section below) in the generated site. --- End diff -- Hi @lvfangmin, done. I've set the header and the footer to the same width as the content, and also added a new @media set for larger screens. Also updated the README.md with step-by-step guide to update the website. ---
[jira] [Commented] (ZOOKEEPER-3205) Jute - o.a.jute.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699223#comment-16699223 ] Karthik K commented on ZOOKEEPER-3205: -- Revised version attached testing float and double serialization > Jute - o.a.jute.BinaryInputArchive Test cases > - > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. > Also , added test cases for o.a.jute.Utils(Test) as well -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3205) Jute - o.a.j.BinaryInputArchive Test cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik K updated ZOOKEEPER-3205: - Attachment: ZOOKEEPER-3205.patch > Jute - o.a.j.BinaryInputArchive Test cases > -- > > Key: ZOOKEEPER-3205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 > Project: ZooKeeper > Issue Type: Test > Components: jute >Affects Versions: 3.5.4 >Reporter: Karthik K >Assignee: Karthik K >Priority: Minor > Fix For: 3.5.5 > > Attachments: ZOOKEEPER-3205.patch > > > o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / > deserialization for various types. > It would be good to have a bunch of test cases to assert them as currently > they exist almost none. > > Attaching the patch herewith. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3205) Jute - o.a.j.BinaryInputArchive Test cases
Karthik K created ZOOKEEPER-3205: Summary: Jute - o.a.j.BinaryInputArchive Test cases Key: ZOOKEEPER-3205 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3205 Project: ZooKeeper Issue Type: Test Components: jute Affects Versions: 3.5.4 Reporter: Karthik K Assignee: Karthik K Fix For: 3.5.5 o.a.j. BinaryInput(Output)Archive handles a bunch of serialization / deserialization for various types. It would be good to have a bunch of test cases to assert them as currently they exist almost none. Attaching the patch herewith. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/679 @anmolnar removed DoS tests from `UnifiedServerSocketTest.java`. Added a new unit test `UnifiedServerSocketModeDetectionTest.java` which checks that calling certain methods on the server side of a unified socket connection does not trigger mode detection. Also rebased on latest master to fix merge conflict. ---
[GitHub] zookeeper issue #703: [ZOOKEEPER-1818] Correctly handle potential inconsiste...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/703 @lvfangmin Thanks for the clarification! Still testing your patch, should be done by tomorrow. ---
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/679 @ivmaykov Gosh! I just did another round of review with your tests today and was tending to accept the DoS tests with just renaming and amending the comment. :) Sorry for not responding earlier, I'll check your new code tomorrow and give feedback. ---
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/679 I like the old DoS tests, I'm happy to restore them. The new unit test I added can stay too. ---
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user ivmaykov commented on the issue: https://github.com/apache/zookeeper/pull/679 @anmolnar put the DoS tests back in. If you decide that you're ok with keeping them, let me know what you'd like me to rename / comment. ---
[GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/679 @ivmaykov I'm not a fan of them, but understand the intention and can't figure out a more straightforward way to test the behaviour. So let's go with them. What do you think of renaming them to something like `testTLSDetectionNonBlocking(Non)StrictServer`? I would also rephrase the comment to emphasize that the tests are intended to validate that TLS detection is non-blocking, so it's safe to getInputStream() on the accept thread. These are not really denial-of-service tests IMHO. Thoughts? ---
[GitHub] zookeeper issue #724: ZOOKEEPER-2488: Synchronized access to shuttingDownLE ...
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/724 retest this please ---
