[GitHub] zookeeper issue #715: Rollup of blocker/critical fixes for 3.5 (to trigger C...

2018-12-05 Thread nkalmar
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/715 Oh, so it's basically an aggregation of the flaky test fixes, I already seen some of your PR on them. This is awesome, thanks for this! ---

[GitHub] zookeeper pull request #730: Zookeeper-3188: Improve resilience to network

2018-12-05 Thread ArtemChernatsky
GitHub user ArtemChernatsky opened a pull request: https://github.com/apache/zookeeper/pull/730 Zookeeper-3188: Improve resilience to network According to issue [ZOOKEEPER-3188](https://issues.apache.org/jira/browse/ZOOKEEPER-3188) added ability to specify several addresses for

ZooKeeper_branch35_jdk8 - Build # 1218 - Failure

2018-12-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1218/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 66.18 KB...] [junit] Running

[GitHub] zookeeper pull request #725: Zookeeper-3188: Improve resilience to network

2018-12-05 Thread ArtemChernatsky
Github user ArtemChernatsky closed the pull request at: https://github.com/apache/zookeeper/pull/725 ---

[jira] [Comment Edited] (ZOOKEEPER-3188) Improve resilience to network

2018-12-05 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710015#comment-16710015 ] Ted Dunning edited comment on ZOOKEEPER-3188 at 12/5/18 12:37 PM: --

[jira] [Commented] (ZOOKEEPER-3188) Improve resilience to network

2018-12-05 Thread Ted Dunning (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710015#comment-16710015 ] Ted Dunning commented on ZOOKEEPER-3188: Taking the questions in order: bq. Did we consider

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-12-05 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r239144917 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -446,4 +458,119 @@ private void

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-12-05 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r239143301 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java --- @@ -0,0 +1,253 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-12-05 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r239130075 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -446,4 +458,119 @@ private void

[GitHub] zookeeper pull request #680: ZOOKEEPER-3174: Quorum TLS - support reloading ...

2018-12-05 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/680#discussion_r239138642 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -446,4 +458,119 @@ private void

[jira] [Created] (ZOOKEEPER-3208) Remove the SSLTest.java.orig introduced in ZOOKEEPER-3032

2018-12-05 Thread Fangmin Lv (JIRA)
Fangmin Lv created ZOOKEEPER-3208: - Summary: Remove the SSLTest.java.orig introduced in ZOOKEEPER-3032 Key: ZOOKEEPER-3208 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3208 Project: ZooKeeper

[jira] [Updated] (ZOOKEEPER-3208) Remove the SSLTest.java.orig introduced in ZOOKEEPER-3032

2018-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3208: -- Labels: pull-request-available (was: ) > Remove the SSLTest.java.orig introduced

[GitHub] zookeeper pull request #731: [ZOOKEEPER-3208] Remove the SSLTest.java.orig i...

2018-12-05 Thread lvfangmin
GitHub user lvfangmin opened a pull request: https://github.com/apache/zookeeper/pull/731 [ZOOKEEPER-3208] Remove the SSLTest.java.orig introduced in ZOOKEEPER-3032 You can merge this pull request into a Git repository by running: $ git pull

Leader election

2018-12-05 Thread Michael Borokhovich
Hello, We have a service that runs on 3 hosts for high availability. However, at any given time, exactly one instance must be active. So, we are thinking to use Leader election using Zookeeper. To this goal, on each service host we also start a ZK server, so we have a 3-nodes ZK cluster and each

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
GitHub user enixon reopened a pull request: https://github.com/apache/zookeeper/pull/628 ZOOKEEPER-3140: Allow Followers to host Observers Creates a new abstraction, LearnerMaster, to represent the portions of the Leader logic that are used in LearnerHandler. Leader implements

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
Github user enixon closed the pull request at: https://github.com/apache/zookeeper/pull/628 ---

回复:Leader election

2018-12-05 Thread 毛蛤丝
suggest you use the ready-made implements of curator: http://curator.apache.org/curator-recipes/leader-election.html - 原始邮件 - 发件人:Michael Borokhovich 收件人:"dev@zookeeper.apache.org" 主题:Leader election 日期:2018年12月06日 07点29分 Hello, We have a service that runs on 3 hosts for high

[GitHub] zookeeper issue #731: [ZOOKEEPER-3208] Remove the SSLTest.java.orig introduc...

2018-12-05 Thread dineshappavoo
Github user dineshappavoo commented on the issue: https://github.com/apache/zookeeper/pull/731 This LGTM 👍 ---

Re: Leader election

2018-12-05 Thread Michael Borokhovich
Thanks, I will check it out. However, do you know if it gives any better guarantees? Can it happen that we end up with 2 leaders or 0 leader for some period of time (for example, during network delays/partitions)? On Wed, Dec 5, 2018 at 10:54 PM 毛蛤丝 wrote: > suggest you use the ready-made

[GitHub] zookeeper pull request #703: [ZOOKEEPER-1818] Correctly handle potential inc...

2018-12-05 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/703#discussion_r239309222 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java --- @@ -1023,9 +1016,9 @@ else if (validVoter(n.sid) &&

[GitHub] zookeeper issue #703: [ZOOKEEPER-1818] Correctly handle potential inconsiste...

2018-12-05 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/703 @lvfangmin lgtm, thanks! ---

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
GitHub user enixon reopened a pull request: https://github.com/apache/zookeeper/pull/628 ZOOKEEPER-3140: Allow Followers to host Observers Creates a new abstraction, LearnerMaster, to represent the portions of the Leader logic that are used in LearnerHandler. Leader implements

[GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...

2018-12-05 Thread enixon
Github user enixon closed the pull request at: https://github.com/apache/zookeeper/pull/628 ---

Re: Leader election

2018-12-05 Thread Enrico Olivelli
Michael, Leader election is not enough. You must have some mechanism to fence off the partitioned leader. If you are building a replicated state machine Apache Zookeeper + Apache Bookkeeper can be a good choice See this just an example: https://github.com/ivankelly/bookkeeper-tutorial This is