[GitHub] eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4

eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#issuecomment-454775677 @anmolnar thank you for your review You are suggesting me to add a bunch of SuppressFBWarnings and do not add so many

ZooKeeper-trunk - Build # 353 - Failure

See https://builds.apache.org/job/ZooKeeper-trunk/353/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 9.94 KB...] [javacc] (type "javacc" with no arguments

[jira] [Commented] (ZOOKEEPER-3209) New `getEphemerals` api to get all the ephemeral nodes created by the session

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744084#comment-16744084 ] Hudson commented on ZOOKEEPER-3209: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #353 (See

[GitHub] nkalmar commented on issue #776: WIP - MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

nkalmar commented on issue #776: WIP - MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-454800700 retest this please This is an automated message from

[GitHub] asfgit closed pull request #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session

asfgit closed pull request #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session URL: https://github.com/apache/zookeeper/pull/735 This is an automated message from the Apache

[GitHub] anmolnar commented on issue #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session

anmolnar commented on issue #735: ZOOKEEPER-3209: New `getEphemerals` api to get all the ephemeral nodes created by the session URL: https://github.com/apache/zookeeper/pull/735#issuecomment-454776601 Committed to master branch. Thanks @dineshappavoo !

[jira] [Resolved] (ZOOKEEPER-3209) New `getEphemerals` api to get all the ephemeral nodes created by the session

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3209. - Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 735

[GitHub] anmolnar commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4

anmolnar commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4 URL: https://github.com/apache/zookeeper/pull/764#issuecomment-454777080 @eolivelli Just drop all of them in the server's code to be on the safe side.

[jira] [Commented] (ZOOKEEPER-3209) New `getEphemerals` api to get all the ephemeral nodes created by the session

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744074#comment-16744074 ] Hudson commented on ZOOKEEPER-3209: --- FAILURE: Integrated in Jenkins build

ZooKeeper_branch34_openjdk7 - Build # 2182 - Still Failing

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2182/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 8.71 KB...] hudson.plugins.git.GitException:

[GitHub] anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error

anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778#issuecomment-454966996 Merged. This is an automated message from the Apache Git Service. To respond to

[GitHub] asfgit closed pull request #778: ZOOKEEPER-3209: Fix compilation error

asfgit closed pull request #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] anmolnar opened a new pull request #778: ZOOKEEPER-3209: Fix compilation error

anmolnar opened a new pull request #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] dineshappavoo commented on issue #778: ZOOKEEPER-3209: Fix compilation error

dineshappavoo commented on issue #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778#issuecomment-454957210 LGTM  . Just wondering if I could have caught this in the pull request. Somehow it didn't show any issues in the original PR#735 CI run.

[GitHub] anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error

anmolnar commented on issue #778: ZOOKEEPER-3209: Fix compilation error URL: https://github.com/apache/zookeeper/pull/778#issuecomment-454966015 The response cache patch has tricked us. 9828685d20bc99272ec0689a590d27b0f8f7ebb6

[GitHub] vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types …

vivekpatani commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of covariant return types … URL: https://github.com/apache/zookeeper/pull/760#issuecomment-454982760 @anmolnar looks like it works for me. We can close this PR out and just comment on the issue if anyone comes

[jira] [Commented] (ZOOKEEPER-3209) New `getEphemerals` api to get all the ephemeral nodes created by the session

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744559#comment-16744559 ] Hudson commented on ZOOKEEPER-3209: --- SUCCESS: Integrated in Jenkins build

[GitHub] ivmaykov commented on issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options

ivmaykov commented on issue #681: ZOOKEEPER-3176: Quorum TLS - add SSL config options URL: https://github.com/apache/zookeeper/pull/681#issuecomment-455003558 @anmolnar done This is an automated message from the Apache Git

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513820 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512925 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -220,6 +224,24

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513947 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java ## @@

[jira] [Commented] (ZOOKEEPER-3209) New `getEphemerals` api to get all the ephemeral nodes created by the session

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744607#comment-16744607 ] Hudson commented on ZOOKEEPER-3209: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #354 (See

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455006285 @anmolnar how can I reproduce the reconfig failures? Just checkout branch-3.5 and run

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512738 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ## @@ -90,6 +89,7 @@

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248512821 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKClientSSLContext.java ## @@ -0,0

[GitHub] ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext

ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#discussion_r248513615 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java ## @@ -389,6

[GitHub] ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455010472 @anmolnar we kept seeing `ReconfigTest` failures on our internal fork when it was run as part

[GitHub] ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

ivmaykov edited a comment on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455010472 @anmolnar we kept seeing `ReconfigTest` failures on our internal fork when it was run

[GitHub] eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix

eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455060339 @ivmaykov unfortunately Netty 3 is not maintained and it does not deal well with the new way

[jira] [Created] (ZOOKEEPER-3248) EmbeddedZookeeper does not delete temp directory on shutdown in Windows

Dmitrii Apanasevich created ZOOKEEPER-3248: -- Summary: EmbeddedZookeeper does not delete temp directory on shutdown in Windows Key: ZOOKEEPER-3248 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3248

[GitHub] yaojingguo opened a new pull request #777: Fix typos in ZooKeeper.java

yaojingguo opened a new pull request #777: Fix typos in ZooKeeper.java URL: https://github.com/apache/zookeeper/pull/777 I think that this change is too trivial to need a JIRA issue. If a JIRA issue is needed, i can create it.

Re: Maven pom - scm connection is not good

Thanks for reporting! I think it should be the gitbox one. I figured there will be some bugs in maven, so I used this task for the contrib fix already, and plan to use it for the fixes to come: ZOOKEEPER-3122 You can create quick-fixes on this ticket, or just let me know and I can do the fix. I

[GitHub] nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

nkalmar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#issuecomment-454703335 > I think we don't need so much assemblies. > Using plain Maven deployment features will result in a consistent artifact

[jira] [Updated] (ZOOKEEPER-3122) Verify build after maven migration and the end artifact

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norbert Kalmar updated ZOOKEEPER-3122: -- Description: Verify maven build works as expected, scripts (release, precommit,

[GitHub] nkalmar commented on a change in pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly

nkalmar commented on a change in pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly URL: https://github.com/apache/zookeeper/pull/776#discussion_r248197284 ## File path: src/assembly/jar.xml ## @@ -0,0 +1,65 @@