anmolnar commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248768571
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
##
@@ -389,6
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248804344
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java
##
anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of
covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-455260317
@eolivelli Sure. I like the idea.
This is an
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248803778
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -220,6
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248803849
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
##
@@ -389,6
anmolnar commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly
failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455234431
Thanks @ivmaykov for your efforts. Please take a quick look, but my opinion
is pretty much the
eolivelli commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions
of covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-455237059
@anmolnar the 'release' flag is available only from JDK9+
we need to put a bunch of "if/else" in
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248781573
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java
##
@@
ivmaykov commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly
failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455271738
@eolivelli @anmolnar after trying to get netty3 to work on OpenJDK11 for
over an hour last
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/2183/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 8.71 KB...]
hudson.plugins.git.GitException:
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248781133
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java
##
@@
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248803778
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -220,6
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#issuecomment-455303614
@ivmaykov - Updated the PR to resolve the comments. I stuck with the nested
classes in the tests since package-private classes couldn't be
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848163
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/ZKConfig.java
##
@@ -18,6 +18,12
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248847815
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -238,18
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248849244
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -238,18
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248851355
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -238,18
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248810192
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -220,6
enixon commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly
failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-455304304
thanks @ivmaykov !
This is an
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248804741
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -220,6 +224,24
ivmaykov commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#issuecomment-455342423
+1 (non-binding), but please address nits from my last review pass. Great
work :)
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248850022
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
##
@@ -406,26
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848936
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
##
@@ -513,4
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248848580
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/X509UtilTest.java
##
@@ -406,26
jhuan31 commented on issue #769: ZOOKEEPER-3242: Add server side connecting
throttling
URL: https://github.com/apache/zookeeper/pull/769#issuecomment-455374564
added doc
This is an automated message from the Apache Git
anmolnar commented on issue #760: ZOOKEEPER-3215: Handle Java 9/11 additions of
covariant return types …
URL: https://github.com/apache/zookeeper/pull/760#issuecomment-455232025
Thanks @vivekpatani . I think a patch is needed anyway to modify ant/maven
scripts to use release flag instead
eolivelli closed pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration
file
URL: https://github.com/apache/zookeeper/pull/751
This is an automated message from the Apache Git Service.
To respond to the message,
eolivelli opened a new pull request #751: ZOOKEEPER-3234: Add Travis-CI
configuration file
URL: https://github.com/apache/zookeeper/pull/751
This is an automated message from the Apache Git Service.
To respond to the
eolivelli opened a new pull request #751: ZOOKEEPER-3234: Add Travis-CI
configuration file
URL: https://github.com/apache/zookeeper/pull/751
This is an automated message from the Apache Git Service.
To respond to the
eolivelli closed pull request #751: ZOOKEEPER-3234: Add Travis-CI configuration
file
URL: https://github.com/apache/zookeeper/pull/751
This is an automated message from the Apache Git Service.
To respond to the message,
eolivelli commented on issue #751: ZOOKEEPER-3234: Add Travis-CI configuration
file
URL: https://github.com/apache/zookeeper/pull/751#issuecomment-455261293
seems that master is still broken
This is an automated message from
ivmaykov commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248780258
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -220,6 +224,24
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248640955
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTestClientSSLContext.java
##
arankin-irl commented on a change in pull request #728: ZOOKEEPER-3160: Custom
User SSLContext
URL: https://github.com/apache/zookeeper/pull/728#discussion_r248630588
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java
##
@@ -220,6
Hi Norbert,
I'd be as close to other Apache projects as possible and I think HBase is a
good example.
They create two deliverables, one to run the app, and one to develop (the
Apache way).
Since this part was copied from HBase's main pom (I did it) I'd like to
advertise that they have updated
nkalmar commented on issue #776: WIP - MAVEN MIGRATION - ZOOKEEPER-3028 -
Create maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-455121201
> I think that in the base apache apache parent pom there is already a
configuration for gpg and source plugin, but it
Hi Devs!
I uploaded the PR for the assembly. I tried to recreate the tarball ant
does, as the initial statement was to recreate the tarball as much as
possible. But maven has its own build mechanism, which works well with
Apache release standards.
As Enrico pointed out to me, Apache top-level
AFAIK From ASF perspective the only important thing in the release is to
release a buildable source tarball, the other stuff are to be considered
'convenience binaries'.
I lean toward doing a Maven style release:
- multiple jars to Maven central (think about zookeeper-jute as an example)
- source
eolivelli commented on a change in pull request #764: ZOOKEEPER-3223: Configure
Spotbugs - on branch 3.4
URL: https://github.com/apache/zookeeper/pull/764#discussion_r248853664
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java
eolivelli opened a new pull request #779: ZOOKEEPER-3223: Configure spotbugs -
part 2
URL: https://github.com/apache/zookeeper/pull/779
- move to spotbugs 3.1.9
- disable spotbugs on contrib package
- fix spotbugs warnings on recipes
- add commons-lang 2.6 dependency in order to
eolivelli commented on issue #779: ZOOKEEPER-3223: Configure spotbugs - part 2
URL: https://github.com/apache/zookeeper/pull/779#issuecomment-455360071
@anmolnar @nkalmar @hanm this is the patch.
There is also a fix for the build on Maven
Fangmin Lv created ZOOKEEPER-3249:
-
Summary: Avoid reverting the cversion and pzxid during replaying
txns with fuzzy snapshot
Key: ZOOKEEPER-3249
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3249
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745788#comment-16745788
]
Hudson commented on ZOOKEEPER-3218:
---
SUCCESS: Integrated in Jenkins build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745825#comment-16745825
]
Hudson commented on ZOOKEEPER-3232:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #356 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3249:
--
Labels: pull-request-available (was: )
> Avoid reverting the cversion and pzxid
lvfangmin opened a new pull request #780: [ZOOKEEPER-3249] Avoid reverting the
cversion and pzxid during replaying txns with fuzzy snapshot
URL: https://github.com/apache/zookeeper/pull/780
This is an automated message from
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745789#comment-16745789
]
Hudson commented on ZOOKEEPER-3232:
---
SUCCESS: Integrated in Jenkins build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745824#comment-16745824
]
Hudson commented on ZOOKEEPER-3218:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #356 (See
lvfangmin commented on issue #767: ZOOKEEPER-3240: Close socket on Learner
shutdown to avoid dangling so…
URL: https://github.com/apache/zookeeper/pull/767#issuecomment-455403201
retest this please
This is an automated
lvfangmin commented on issue #777: Fix typos
URL: https://github.com/apache/zookeeper/pull/777#issuecomment-455406531
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/2192/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 43.69 KB...]
[junit] Running
lvfangmin commented on a change in pull request #768: ZOOKEEPER-3239: Adding
EnsembleAuthProvider to verify the ensemble name
URL: https://github.com/apache/zookeeper/pull/768#discussion_r248908615
##
File path:
lvfangmin commented on issue #771: ZOOKEEPER-3245: Add useful metrics for ZK
pipeline and request/server…
URL: https://github.com/apache/zookeeper/pull/771#issuecomment-455406359
@jhuan31 can you help separate this patch a few smaller ones, things like
pipeline related one, watches,
asfgit closed pull request #747: ZOOKEEPER-3218: zk server reopened，the
interval for observer connect …
URL: https://github.com/apache/zookeeper/pull/747
This is an automated message from the Apache Git Service.
To respond
asfgit closed pull request #749: ZOOKEEPER-3232:make the log of notification
about LE more readable
URL: https://github.com/apache/zookeeper/pull/749
This is an automated message from the Apache Git Service.
To respond to
lvfangmin commented on issue #622: [ZOOKEEPER-3145] Fix potential watch missing
issue due to stale pzxid when replaying CloseSession txn with fuzzy snapshot
URL: https://github.com/apache/zookeeper/pull/622#issuecomment-455413226
Rebase onto latest master. We've been enabling this code on
jhuan31 opened a new pull request #771: ZOOKEEPER-3245: Add useful metrics for
ZK pipeline and request/server…
URL: https://github.com/apache/zookeeper/pull/771
This is an automated message from the Apache Git Service.
To
jhuan31 closed pull request #771: ZOOKEEPER-3245: Add useful metrics for ZK
pipeline and request/server…
URL: https://github.com/apache/zookeeper/pull/771
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3232:
--
Labels: pull-request-available (was: )
> make the log of notification about LE
lvfangmin commented on issue #749: ZOOKEEPER-3232:make the log of notification
about LE more readable
URL: https://github.com/apache/zookeeper/pull/749#issuecomment-455402825
retest this please
This is an automated message
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv resolved ZOOKEEPER-3218.
---
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 747
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv resolved ZOOKEEPER-3232.
---
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 749
62 matches
Mail list logo
