Re: Release procedure for 3.6.0 - new ideas with maven release plugin

2020-01-23 Thread Enrico Olivelli
I think it is better to continue to create a specific branch for each release. There is no strong motivation for changing this part of the procedure. I would say that we should clean up and drop such branches after the completion of the release process, only the signed git tag will stay. I will

Jenkins build became unstable: zookeeper-master-maven #636

2020-01-23 Thread Apache Jenkins Server
See

Re: 3.5.7

2020-01-23 Thread Norbert Kalmar
Thanks Patrick, I'll review and preferably commit your patch, which should negate the CVE warning. Regards, Norbert On Wed, Jan 22, 2020 at 5:31 PM Patrick Hunt wrote: > owasp is failing on branch-3.5, > [ERROR] jackson-databind-2.9.10.1.jar: CVE-2019-20330 > > seems the same as: >

Jenkins build is unstable: zookeeper-master-maven #633

2020-01-23 Thread Apache Jenkins Server
See

Build failed in Jenkins: zookeeper-master-maven-owasp #338

2020-01-23 Thread Apache Jenkins Server
See Changes: -- [...truncated 266.42 KB...] Generating

ZooKeeper_branch34_openjdk8 - Build # 578 - Still Failing

2020-01-23 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/578/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 48.29 KB...] [junit] Tests run: 1,

Jenkins build is still unstable: zookeeper-branch36-java8 #16

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build is still unstable: zookeeper-branch36-java11 #17

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build became unstable: zookeeper-master-maven-jdk12 #338

2020-01-23 Thread Apache Jenkins Server
See

Re: Release procedure for 3.6.0 - new ideas with maven release plugin

2020-01-23 Thread Norbert Kalmar
I also agree that branching for a release makes the process easier. Especially if we are talking about the active branch. For example, I wouldn't do a branch for a new 3.4 release, as it's pretty much EOL and hardly anything makes it there. My opinion, if it makes sense to branch out for a

Re: 3.5.7

2020-01-23 Thread Norbert Kalmar
The patch fixed the CVE warning https://builds.apache.org/job/zookeeper-master-maven-owasp/339/ Norbert On Thu, Jan 23, 2020 at 11:07 AM Norbert Kalmar wrote: > Thanks Patrick, I'll review and preferably commit your patch, which should > negate the CVE warning. > > Regards, > Norbert > > On

Jenkins build is back to normal : zookeeper-master-maven-owasp #339

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build is still unstable: zookeeper-branch36-java8 #17

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build is still unstable: zookeeper-branch36-java11 #18

2020-01-23 Thread Apache Jenkins Server
See

Build failed in Jenkins: PreCommit-ZOOKEEPER-github-pr-build-maven #1821

2020-01-23 Thread Apache Jenkins Server
See Changes: -- [...truncated 741.32 KB...] Generating

[jira] [Created] (ZOOKEEPER-3705) Filtering unreachable hosts without using ICMP

2020-01-23 Thread Mate Szalay-Beko (Jira)
Mate Szalay-Beko created ZOOKEEPER-3705: --- Summary: Filtering unreachable hosts without using ICMP Key: ZOOKEEPER-3705 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3705 Project: ZooKeeper

Build failed in Jenkins: PreCommit-ZOOKEEPER-github-pr-build-maven #1820

2020-01-23 Thread Apache Jenkins Server
See Changes: [andor] ZOOKEEPER-3701. Initial commit with the suggested fixes [andor] ZOOKEEPER-3701. Some code review improvements --

Jenkins build is still unstable: zookeeper-master-maven #634

2020-01-23 Thread Apache Jenkins Server
See

Build failed in Jenkins: zookeeper-branch36-java8 #18

2020-01-23 Thread Apache Jenkins Server
See Changes: -- [...truncated 394.88 KB...] checking for egrep... /bin/grep -E checking for ANSI C header files... yes checking for sys/types.h... yes checking for sys/stat.h...

Jenkins build is still unstable: zookeeper-master-maven-jdk12 #339

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build is still unstable: zookeeper-branch36-java11 #19

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build is back to stable : zookeeper-master-maven #635

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build is back to normal : PreCommit-ZOOKEEPER-github-pr-build-maven #1822

2020-01-23 Thread Apache Jenkins Server
See

Re: RC failure root cause: ICMP throttling settings on mac

2020-01-23 Thread Ted Dunning
I think that this is far outside the normal operation bounds and has an easy work-around. First, it is very uncommon to run more than 5 ZK nodes. Running 23 on a single host is bizarre (viewed from an operational lens). Second, there is a simple configuration change that makes the strange

Jenkins build is back to stable : zookeeper-master-maven-jdk12 #340

2020-01-23 Thread Apache Jenkins Server
See

Jenkins build is back to normal : zookeeper-branch36-java8 #19

2020-01-23 Thread Apache Jenkins Server
See

Re: RC failure root cause: ICMP throttling settings on mac

2020-01-23 Thread Patrick Hunt
Agree with both folks (ted/michael) - I view this as a "chaos monkey" of sorts. If it runs with 5 shouldn't it run with 7 and so on I don't remember why I chose 23, it's been 10 years or so that I've been running this test. Don't do this at home folks. ;-) Also I just don't try starting the

Jenkins build is back to stable : zookeeper-branch36-java11 #20

2020-01-23 Thread Apache Jenkins Server
See

Re: RC failure root cause: ICMP throttling settings on mac

2020-01-23 Thread Enrico Olivelli
I feel that Option 2 is more conservative, the multi address feature is new in 3.6 and in my opinion it won't we used by current users of 3.4 and 3.5, at least not immediately after an upgrade because it needs a different network architecture. If you do not use the multi address property with

Re: RC failure root cause: ICMP throttling settings on mac

2020-01-23 Thread Michael K. Edwards
While I agree that this is not a very production-like configuration, I think it's good to recognize that there are plenty of clusters out there where more than five zookeeper nodes are called for. I run systems routinely with seven voting members plus three or more observers, for reasons having

Re: RC failure root cause: ICMP throttling settings on mac

2020-01-23 Thread Ted Dunning
I was not advocating an avoidance of the issue. I was suggesting that it isn't a stop-ship issue. On Thu, Jan 23, 2020 at 11:05 AM Michael K. Edwards wrote: > While I agree that this is not a very production-like configuration, I > think it's good to recognize that there are plenty of

Re: RC failure root cause: ICMP throttling settings on mac

2020-01-23 Thread Patrick Hunt
Option 1 sounds good to me. However i'd recommend documenting it (setting net.inet.icmp.icmplim if the error is hit) within ZK itself. Also happy to update zkconf with the detail. https://github.com/phunt/zkconf/commit/281ad019e1d497a94f7168aa1c74053687667225 Thanks for digging into this!

Re: Release procedure for 3.6.0 - new ideas with maven release plugin

2020-01-23 Thread Patrick Hunt
On Thu, Jan 23, 2020 at 2:02 AM Norbert Kalmar wrote: > I also agree that branching for a release makes the process easier. > Especially if we are talking about the active branch. For example, I > wouldn't do a branch for a new 3.4 release, as it's pretty much EOL and > hardly anything makes it