[jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075972#comment-16075972 ] ASF GitHub Bot commented on ZOOKEEPER-2819: --- Github user shralex commented on the issue:

[GitHub] zookeeper issue #292: ZOOKEEPER-2819:Changing membership configuration via r...

2017-07-05 Thread shralex
Github user shralex commented on the issue: https://github.com/apache/zookeeper/pull/292 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075969#comment-16075969 ] ASF GitHub Bot commented on ZOOKEEPER-2819: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #292: ZOOKEEPER-2819:Changing membership configuration via r...

2017-07-05 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/292 Thanks @shralex for review. Good catch on the "3", "4" server issue. PR updated that addresses latest comments. The failed test is a known flaky one. --- If your project is set up for it, you can

[jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.

2017-07-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075964#comment-16075964 ] Hadoop QA commented on ZOOKEEPER-2819: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #863

2017-07-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/863/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 70.93 MB...] [exec] +1

[GitHub] zookeeper pull request #:

2017-07-05 Thread jainbhupendra24
Github user jainbhupendra24 commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22943164 In src/java/test/org/apache/zookeeper/test/ACLTest.java: In src/java/test/org/apache/zookeeper/test/ACLTest.java on

[jira] [Commented] (ZOOKEEPER-2811) PurgeTxnLog#validateAndGetFile: return tag has no arguments.

2017-07-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075921#comment-16075921 ] Hadoop QA commented on ZOOKEEPER-2811: -- +1 overall. GitHub Pull Request Build +1

Success: ZOOKEEPER- PreCommit Build #862

2017-07-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/862/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.70 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075896#comment-16075896 ] ASF GitHub Bot commented on ZOOKEEPER-2819: --- Github user hanm commented on the issue:

[GitHub] zookeeper issue #292: ZOOKEEPER-2819:Changing membership configuration via r...

2017-07-05 Thread hanm
Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/292 @shralex The snapshot and sync tests will be covered in ZOOKEEPER-2828. I will update the PR shortly to address other comments. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (ZOOKEEPER-2811) PurgeTxnLog#validateAndGetFile: return tag has no arguments.

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075891#comment-16075891 ] ASF GitHub Bot commented on ZOOKEEPER-2811: --- GitHub user hanm opened a pull request:

[GitHub] zookeeper pull request #305: ZOOKEEPER-2811: PurgeTxnLog#validateAndGetFile:...

2017-07-05 Thread hanm
GitHub user hanm opened a pull request: https://github.com/apache/zookeeper/pull/305 ZOOKEEPER-2811: PurgeTxnLog#validateAndGetFile: return tag has no argument. With this fix branch-3.4 pre-commit should generate a green build when all unit tests pass. You can merge this pull

[jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075879#comment-16075879 ] ASF GitHub Bot commented on ZOOKEEPER-2819: --- Github user shralex commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075880#comment-16075880 ] ASF GitHub Bot commented on ZOOKEEPER-2819: --- Github user shralex commented on a diff in the

[GitHub] zookeeper pull request #292: ZOOKEEPER-2819:Changing membership configuratio...

2017-07-05 Thread shralex
Github user shralex commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/292#discussion_r125805265 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java --- @@ -0,0 +1,263 @@ +/** + * Licensed

[jira] [Commented] (ZOOKEEPER-2819) Changing membership configuration via rolling restart does not work on 3.5.x.

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075881#comment-16075881 ] ASF GitHub Bot commented on ZOOKEEPER-2819: --- Github user shralex commented on a diff in the

[GitHub] zookeeper pull request #292: ZOOKEEPER-2819:Changing membership configuratio...

2017-07-05 Thread shralex
Github user shralex commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/292#discussion_r125806082 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java --- @@ -0,0 +1,263 @@ +/** + * Licensed

[GitHub] zookeeper pull request #292: ZOOKEEPER-2819:Changing membership configuratio...

2017-07-05 Thread shralex
Github user shralex commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/292#discussion_r125806125 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java --- @@ -0,0 +1,263 @@ +/** + * Licensed

ZooKeeper_branch34_jdk7 - Build # 1578 - Failure

2017-07-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1578/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 31.59 MB...] [junit] 2017-07-06 02:51:18,439

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

2017-07-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075825#comment-16075825 ] Hadoop QA commented on ZOOKEEPER-2355: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #861

2017-07-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/861/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 34.88 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075804#comment-16075804 ] ASF GitHub Bot commented on ZOOKEEPER-2355: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #304: ZOOKEEPER-2355: Ephemeral node is never deleted...

2017-07-05 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/304#discussion_r125798689 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/EphemeralNodeDeletionTest.java --- @@ -0,0 +1,219 @@ +/** + * Licensed to the Apache

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075802#comment-16075802 ] ASF GitHub Bot commented on ZOOKEEPER-2355: --- Github user asdf2014 commented on a diff in the

[GitHub] zookeeper pull request #304: ZOOKEEPER-2355: Ephemeral node is never deleted...

2017-07-05 Thread asdf2014
Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/304#discussion_r125798526 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/EphemeralNodeDeletionTest.java --- @@ -0,0 +1,219 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #304: ZOOKEEPER-2355: Ephemeral node is never deleted...

2017-07-05 Thread hanm
GitHub user hanm opened a pull request: https://github.com/apache/zookeeper/pull/304 ZOOKEEPER-2355: Ephemeral node is never deleted if follower fails while reading the proposal packet. This commit is a port of the commit ca22b3db19371f6b0f5507b7dd80b283cddc7700 from branch-3.5 to

[jira] [Commented] (ZOOKEEPER-2355) Ephemeral node is never deleted if follower fails while reading the proposal packet

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075797#comment-16075797 ] ASF GitHub Bot commented on ZOOKEEPER-2355: --- GitHub user hanm opened a pull request:

Success: ZOOKEEPER- PreCommit Build #860

2017-07-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/860/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 63.50 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2840) Should using `System.nanoTime() ^ this.hashCode()` for StaticHostProvider

2017-07-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074692#comment-16074692 ] Hadoop QA commented on ZOOKEEPER-2840: -- +1 overall. GitHub Pull Request Build +1

ZooKeeper_branch35_jdk8 - Build # 590 - Failure

2017-07-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/590/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.95 MB...] [junit] 2017-07-05 12:31:26,000

[jira] [Commented] (ZOOKEEPER-2840) Should using `System.nanoTime() ^ this.hashCode()` for StaticHostProvider

2017-07-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074674#comment-16074674 ] ASF GitHub Bot commented on ZOOKEEPER-2840: --- GitHub user asdf2014 opened a pull request:

[GitHub] zookeeper pull request #303: ZOOKEEPER-2840: Should using `System.nanoTime()...

2017-07-05 Thread asdf2014
GitHub user asdf2014 opened a pull request: https://github.com/apache/zookeeper/pull/303 ZOOKEEPER-2840: Should using `System.nanoTime() ^ this.hashCode()` fo… Should using `System.nanoTime() ^ this.hashCode()` for StaticHostProvider instead of `System.currentTimeMillis()`.

[jira] [Updated] (ZOOKEEPER-2840) Should using `System.nanoTime() ^ this.hashCode()` for StaticHostProvider

2017-07-05 Thread Benedict Jin (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benedict Jin updated ZOOKEEPER-2840: Fix Version/s: 3.5.4 > Should using `System.nanoTime() ^ this.hashCode()` for

[jira] [Created] (ZOOKEEPER-2840) Should using `System.nanoTime() ^ this.hashCode()` for StaticHostProvider

2017-07-05 Thread Benedict Jin (JIRA)
Benedict Jin created ZOOKEEPER-2840: --- Summary: Should using `System.nanoTime() ^ this.hashCode()` for StaticHostProvider Key: ZOOKEEPER-2840 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2840

[jira] [Created] (ZOOKEEPER-2839) Race condition between AcceptThread and SelectorThread may allow connections beyond the max client connection limit

2017-07-05 Thread Bhupendra Kumar Jain (JIRA)
Bhupendra Kumar Jain created ZOOKEEPER-2839: --- Summary: Race condition between AcceptThread and SelectorThread may allow connections beyond the max client connection limit Key: ZOOKEEPER-2839 URL:

ZooKeeper_branch35_openjdk7 - Build # 590 - Still Failing

2017-07-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/590/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 65.44 MB...] [junit]

[jira] [Commented] (ZOOKEEPER-2763) Utils.toCsvBuffer() omits leading 0 for bytes < 0x10

2017-07-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074452#comment-16074452 ] Hadoop QA commented on ZOOKEEPER-2763: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #859

2017-07-05 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/859/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 62.07 MB...] [exec]

[jira] [Assigned] (ZOOKEEPER-2818) Improve the ZooKeeper#setACL java doc

2017-07-05 Thread Rakesh R (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R reassigned ZOOKEEPER-2818: --- Assignee: Brahma Reddy Battula > Improve the ZooKeeper#setACL java doc >

[jira] [Created] (ZOOKEEPER-2838) race-condition when shutting down NIOServerCnxnFactory yields CancelledKeyException

2017-07-05 Thread Paul Millar (JIRA)
Paul Millar created ZOOKEEPER-2838: -- Summary: race-condition when shutting down NIOServerCnxnFactory yields CancelledKeyException Key: ZOOKEEPER-2838 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2838