[jira] [Commented] (ZOOKEEPER-2824) `FileChannel#size` info should be added to `FileTxnLog#commit` to solve the confuse that reason is too large log or too busy disk I/O

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323642#comment-16323642 ] ASF GitHub Bot commented on ZOOKEEPER-2824: --- Github user asdf2014 commented on the issue:

[GitHub] zookeeper issue #296: ZOOKEEPER-2824: `FileChannel#size` info should be adde...

2018-01-11 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/296 Hi, @anmolnar . Thanks, would you approve this PR? ---

[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323604#comment-16323604 ] ASF GitHub Bot commented on ZOOKEEPER-2901: --- Github user lvfangmin commented on a diff in

[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323605#comment-16323605 ] ASF GitHub Bot commented on ZOOKEEPER-2901: --- Github user lvfangmin commented on a diff in

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-01-11 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r161147063 --- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java --- @@ -40,19 +39,40 @@ TTL; public static final long

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-01-11 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r161146799 --- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java --- @@ -40,19 +39,40 @@ TTL; public static final long

ZooKeeper-trunk-openjdk7 - Build # 1764 - Still Failing

2018-01-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1764/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 60.58 KB...] [junit] Tests run: 1, Failures:

[jira] [Commented] (ZOOKEEPER-2824) `FileChannel#size` info should be added to `FileTxnLog#commit` to solve the confuse that reason is too large log or too busy disk I/O

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322543#comment-16322543 ] ASF GitHub Bot commented on ZOOKEEPER-2824: --- Github user anmolnar commented on the issue:

[GitHub] zookeeper issue #296: ZOOKEEPER-2824: `FileChannel#size` info should be adde...

2018-01-11 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/296 Hi @asdf2014 I'm happy with the change if it has any help to you for debugging. ---

[jira] [Commented] (ZOOKEEPER-2926) Data inconsistency issue due to the flaw in the session management

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322341#comment-16322341 ] ASF GitHub Bot commented on ZOOKEEPER-2926: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2926) Data inconsistency issue due to the flaw in the session management

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322342#comment-16322342 ] ASF GitHub Bot commented on ZOOKEEPER-2926: --- Github user anmolnar commented on a diff in the

[jira] [Commented] (ZOOKEEPER-2926) Data inconsistency issue due to the flaw in the session management

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322340#comment-16322340 ] ASF GitHub Bot commented on ZOOKEEPER-2926: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...

2018-01-11 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/447#discussion_r160972325 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -1187,13 +1187,8 @@ private ProcessTxnResult processTxn(Request request,

[GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...

2018-01-11 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/447#discussion_r160976160 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java --- @@ -102,32 +101,42 @@ public boolean isGlobalSession(long

[jira] [Commented] (ZOOKEEPER-2926) Data inconsistency issue due to the flaw in the session management

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322343#comment-16322343 ] ASF GitHub Bot commented on ZOOKEEPER-2926: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...

2018-01-11 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/447#discussion_r160970304 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -579,13 +579,8 @@ protected void pRequest2Txn(int type, long zxid,

[GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...

2018-01-11 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/447#discussion_r160971106 --- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java --- @@ -280,6 +278,12 @@ public synchronized boolean addSession(long id, int

Success: ZOOKEEPER- PreCommit Build #1409

2018-01-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1409/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.31 MB...] [exec]

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322282#comment-16322282 ] Hadoop QA commented on ZOOKEEPER-2939: -- +1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1408

2018-01-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1408/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 76.54 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322175#comment-16322175 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1

ZooKeeper_branch35_jdk8 - Build # 806 - Still Failing

2018-01-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/806/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 59.06 KB...] [junit] Tests run: 1, Failures: 0,

ZooKeeper-trunk-jdk8 - Build # 1335 - Still Failing

2018-01-11 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1335/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 55.80 KB...] [junit] Tests run: 1, Failures: 0,

Failed: ZOOKEEPER- PreCommit Build #1407

2018-01-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1407/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 77.31 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322001#comment-16322001 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1406

2018-01-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1406/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78.94 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321921#comment-16321921 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1

Failed: ZOOKEEPER- PreCommit Build #1405

2018-01-11 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1405/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 71.83 MB...] [exec] +1

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2018-01-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321889#comment-16321889 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321861#comment-16321861 ] ASF GitHub Bot commented on ZOOKEEPER-2939: --- Github user anmolnar commented on a diff in the

[GitHub] zookeeper pull request #440: ZOOKEEPER-2939 Deal with maxbuffer as it relate...

2018-01-11 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/440#discussion_r160891125 --- Diff: build.xml --- @@ -198,7 +198,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> - +

[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals

2018-01-11 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321857#comment-16321857 ] ASF GitHub Bot commented on ZOOKEEPER-2939: --- Github user afine commented on a diff in the

[GitHub] zookeeper pull request #440: ZOOKEEPER-2939 Deal with maxbuffer as it relate...

2018-01-11 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/440#discussion_r160889741 --- Diff: build.xml --- @@ -198,7 +198,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> - + ---