[jira] [Created] (ZOOKEEPER-2990) Implement probabilistic tracing

[Bogdan Kanivets (JIRA)]

Bogdan Kanivets created ZOOKEEPER-2990:
--

 Summary: Implement probabilistic tracing
 Key: ZOOKEEPER-2990
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2990
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Reporter: Bogdan Kanivets
Assignee: Bogdan Kanivets


It would be nice to have an ability to do probabilistic tracing similar to 
Cassandra  
[nodetool|https://docs.datastax.com/en/dse/5.1/dse-admin/datastax_enterprise/tools/nodetool/toolsSetTraceProbability.html]

This will help debug issues in prod systems.

I'd like to contribute if everyone is ok with the feature.

My suggestion is to add an extra parameter to ZooTrace to handle it. Questions:
 * should it be one global param or per each ZooTrace mask? I'm thinking per 
mask
 * should it be a new 4lw or part of 'stmk'? Leaning towards new word and 
refactoring param passing to words (stmk is a special case right now).
 * there are places in the code that use LOG.trace directly. That will have to 
change to ZooTrace

I can make some initial implementation for demo/review.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: 3.4.12

[Patrick Hunt]

There are 19 resolved issues http://bit.ly/2oK9aTx
and 14 unresolved http://bit.ly/2oFWywS
ZOOKEEPER-2184 is the only unresolved blocker, however that's not a
regression and was pushed from 3.4.11, we could do so again given it's
still being worked on.

Abe are you interested in taking a turn as RM?

Patrick

On Thu, Mar 1, 2018 at 4:38 PM, Andor Molnar  wrote:

> Hi dev,
>
> User has recently run into the regression of 3.4.11 (ZOOKEEPER-2960
> ) (again?)
> Are we good to cut 3.4.12 soon or still waiting for something to be
> committed?
>
> Andor
>

[jira] [Commented] (ZOOKEEPER-2936) Duplicate Keys in log4j.properties config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383158#comment-16383158
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2936:
---

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/473
  
@afine please take a look, I think this is ready to commit. thanks.


> Duplicate Keys in log4j.properties config files
> ---
>
> Key: ZOOKEEPER-2936
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2936
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: contrib, other
>Affects Versions: 3.4.8
> Environment: Apache ZooKeeper source tarball
>Reporter: Hari Sekhon
>Priority: Trivial
>
> Recent versions of ZooKeeper have introduced the following duplicate keys in 
> to the contrib log4j.properties files.
> In this file:
> {code}
> ./zookeeper-3.4.8/contrib/rest/conf/log4j.properties
> {code}
> and this file:
> {code}
> ./zookeeper-3.4.8/src/contrib/rest/conf/log4j.properties
> {code}
> the following duplicate keys are found:
> {code}
> log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
> log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p 
> [%t:%C{1}@%L] - %m%n
> {code}
> This was discovered because I've written file validators for most major 
> formats which recurse all my github repos and this was failing my integration 
> tests when pulling ZooKeeper source code. I actually added --exclude and 
> --ignore-duplicate-keys switches to {code}validate_ini.py{code} to work 
> around this and fix my builds for now but just remembered to raise this to 
> you guys.
> The validator tools if you're interested can be found at:
> https://github.com/harisekhon/pytools
> Cheers
> Hari



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/473
  
@afine please take a look, I think this is ready to commit. thanks.


---

[jira] [Commented] (ZOOKEEPER-2936) Duplicate Keys in log4j.properties config files

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383060#comment-16383060
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2936:
---

Github user asutosh936 commented on the issue:

https://github.com/apache/zookeeper/pull/473
  
@anmolnar - Could You or someone from Your team please merge this PR?


> Duplicate Keys in log4j.properties config files
> ---
>
> Key: ZOOKEEPER-2936
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2936
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: contrib, other
>Affects Versions: 3.4.8
> Environment: Apache ZooKeeper source tarball
>Reporter: Hari Sekhon
>Priority: Trivial
>
> Recent versions of ZooKeeper have introduced the following duplicate keys in 
> to the contrib log4j.properties files.
> In this file:
> {code}
> ./zookeeper-3.4.8/contrib/rest/conf/log4j.properties
> {code}
> and this file:
> {code}
> ./zookeeper-3.4.8/src/contrib/rest/conf/log4j.properties
> {code}
> the following duplicate keys are found:
> {code}
> log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
> log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p 
> [%t:%C{1}@%L] - %m%n
> {code}
> This was discovered because I've written file validators for most major 
> formats which recurse all my github repos and this was failing my integration 
> tests when pulling ZooKeeper source code. I actually added --exclude and 
> --ignore-duplicate-keys switches to {code}validate_ini.py{code} to work 
> around this and fix my builds for now but just remembered to raise this to 
> you guys.
> The validator tools if you're interested can be found at:
> https://github.com/harisekhon/pytools
> Cheers
> Hari



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #473: ZOOKEEPER-2936 - Removed duplicate code

[asutosh936]

Github user asutosh936 commented on the issue:

https://github.com/apache/zookeeper/pull/473
  
@anmolnar - Could You or someone from Your team please merge this PR?


---

ZooKeeper_branch34 - Build # 2260 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/2260/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 125.41 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.473 sec
[junit] Running org.apache.zookeeper.test.RepeatStartupTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.078 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.69 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.677 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.61 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.587 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.481 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.594 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.506 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.073 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.655 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
32.905 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.874 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.843 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.391 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.577 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.371 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.308 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.092 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.65 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
31.145 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.838 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.795 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1474: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1382: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1385: Tests 
failed!

Total time: 40 minutes 3 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.test.FollowerResyncConcurrencyTest.testResyncByDiffAfterFollowerCrashes

Error Message:
Forked Java VM exited abnormally. Please note the time in the report does not 
reflect the time until the VM exit.

Stack Trace:
junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please 
note the time in the report does not reflect the time until the VM exit.

3.4.12

[Andor Molnar]

Hi dev,

User has recently run into the regression of 3.4.11 (ZOOKEEPER-2960
) (again?)
Are we good to cut 3.4.12 soon or still waiting for something to be
committed?

Andor

[jira] [Commented] (ZOOKEEPER-2960) The dataDir and dataLogDir are used opposingly

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382933#comment-16382933
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2960:
---

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/475
  
I know what the problem is. 3.4.11 has a bug that swaps dataDir and 
dataLogDir from config file.
Sorry, it's only mentioned briefly on the release page:
http://zookeeper.apache.org/releases.html
> WARNING: ZOOKEEPER-2960 was recently identified as a regression in 3.4.11 
...

Please wait for 3.4.12 for the fix and in the meantime you can probably 
workaround it with your fix, but it should not be merged in the codebase.


> The dataDir and dataLogDir are used opposingly
> --
>
> Key: ZOOKEEPER-2960
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2960
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.11
> Environment: Not relevant.
>Reporter: Dan Milon
>Assignee: Andor Molnar
>Priority: Critical
> Fix For: 3.4.12
>
>
> _emphasized text_After upgrading from zookeeper 3.4.5, to 3.4.11, without 
> editing {{zoo.cfg}}, the new version of the server tries to use the 
> {{dataDir}} as the {{dataLogDir}}, and the {{dataLogDir}} as the {{dataDir}}. 
> Or at least some parts of the server.
> Configuration file has:
> {noformat}
> $ grep -i data /etc/zookeeper/zoo.cfg 
> dataLogDir=/var/lib/zookeeper/datalog
> dataDir=/var/lib/zookeeper/data
> {noformat}
> But runtime configuration has:
> {noformat}
> $ echo conf | nc localhost 2181 | grep -i data
> dataDir=/var/lib/zookeeper/datalog/version-2
> dataLogDir=/var/lib/zookeeper/data/version-2
> {noformat}
> Also, I got this in the debug logs, so clearly some parts of the server 
> confuse things.
> {noformat}
> [PurgeTask:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/datalog 
> snapDir:/var/lib/zookeeper/data
> [main:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/data 
> snapDir:/var/lib/zookeeper/datalog
> {noformat}
> I tried to look in the code for wrong uses of the directories. I only found 
> [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L227]
>  is passing the arguments to {{FileTxnSnapLog}} in the wrong order, but the 
> code comment says that this is legacy only for tests, so I assume it isn't 
> the cause for my case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/475
  
I know what the problem is. 3.4.11 has a bug that swaps dataDir and 
dataLogDir from config file.
Sorry, it's only mentioned briefly on the release page:
http://zookeeper.apache.org/releases.html
> WARNING: ZOOKEEPER-2960 was recently identified as a regression in 3.4.11 
...

Please wait for 3.4.12 for the fix and in the meantime you can probably 
workaround it with your fix, but it should not be merged in the codebase.


---

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/475
  
How does your ZooKeeper config file look like?


---

ZooKeeper-trunk - Build # 3746 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3746/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 11.24 KB...]
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused by: hudson.plugins.git.GitException: Command "git clean -fdx" returned 
status code 1:
stdout: 
stderr: warning: failed to remove 
build/test/tmp/test7299294491915492585.junit.dir/data/version-2/snapshot.0

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1964)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1960)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1597)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:1609)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.clean(CliGitAPIImpl.java:787)
at hudson.plugins.git.GitAPI.clean(GitAPI.java:311)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:922)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:896)
at 
hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:853)
at hudson.remoting.UserRequest.perform(UserRequest.java:207)
at hudson.remoting.UserRequest.perform(UserRequest.java:53)
at hudson.remoting.Request$2.run(Request.java:358)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to 
H12
at 
hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1693)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:310)
at hudson.remoting.Channel.call(Channel.java:908)
at 
hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:281)
at com.sun.proxy.$Proxy110.clean(Unknown Source)
at 
org.jenkinsci.plugins.gitclient.RemoteGitImpl.clean(RemoteGitImpl.java:450)
at 
hudson.plugins.git.extensions.impl.CleanBeforeCheckout.decorateFetchCommand(CleanBeforeCheckout.java:30)
at hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:858)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1129)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1160)
at hudson.scm.SCM.checkout(SCM.java:495)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1202)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1724)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error fetching remote repo 'origin'
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Recording fingerprints
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Publishing Javadoc
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper_branch34_jdk8 - Build # 1311 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1311/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 38.43 KB...]
[junit] Running org.apache.zookeeper.test.RecoveryTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.847 sec
[junit] Running org.apache.zookeeper.test.RepeatStartupTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.131 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.363 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.7 
sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.581 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.879 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.583 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.692 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.616 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.063 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.119 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.971 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.927 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.327 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.253 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.595 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.731 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.889 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.087 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.355 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.864 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.782 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.793 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1382: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1385: 
Tests failed!

Total time: 40 minutes 4 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1210)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

Success: ZOOKEEPER- PreCommit Build #1523

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1523/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 37.46 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1523//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1523//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1523//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 39 minutes 35 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2988
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Success: ZOOKEEPER- PreCommit Build #1524

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1524/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.46 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1524//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1524//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1524//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 21 minutes 28 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2988
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

Success: ZOOKEEPER- PreCommit Build #1522

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1522/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 77.86 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1522//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1522//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1522//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Unable to log in to server: 
https://issues.apache.org/jira/rpc/soap/jirasoapservice-v2 with user: hadoopqa.
 [exec]  Cause: ; nested exception is: 
 [exec] javax.net.ssl.SSLException: Received fatal alert: 
protocol_version
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 18 minutes 43 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2988
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Created] (ZOOKEEPER-2989) IPv6 literal address causes problems for Quorum members

[Rick Trudeau (JIRA)]

Rick Trudeau created ZOOKEEPER-2989:
---

 Summary: IPv6 literal address causes problems for Quorum members
 Key: ZOOKEEPER-2989
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2989
 Project: ZooKeeper
  Issue Type: Bug
  Components: quorum
Affects Versions: 3.5.3
Reporter: Rick Trudeau


We're using ZK 3.5.3-beta.

When using literal IPv6 addresses in the zoo.cfg.dynamic file, ZK fails to come 
up with the connection to the peer ZKs keeps getting reset.

zookeeper.log indicates a badly formed address is the cause.
{noformat}
<2018.03.01 15:14:30 163 
-0500>
 
org.apache.zookeeper.server.quorum.QuorumCnxManager$InitialMessage$InitialMessageException:
 Badly formed address: 2001:db8:0:0:0:0:0:2:3888{noformat}
Our zoo.cfg.dynamic uses literal IPv6 addresses which according to 
ZOOKEEPER-1460 is supported.
{noformat}
server.1=[2001:db8::2]:2888:3888;2181
server.2=[2001:db8::3]:2888:3888;2181
server.3=[2001:db8::4]:2888:3888;2181{noformat}
 

Digging into QuorumCnxManager.java, InitialMessage.parse attemps to seperate 
the host portion from the port portion using ":" as a delimeter, which is a 
problem for IPv6 IPs.  And there's this comment:
{code:java}
// FIXME: IPv6 is not supported. Using something like Guava's HostAndPort
// parser would be good.{code}
So it looks like peers address:port is failing to be parsed if they are 
specified as literal IPv6 addresses.  To confirm a workaround, I replaced my 
zoo.cfg.dynamic with hostnames instead, and everything worked as expected.

 

 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2988) NPE triggered if server receives a vote for a server id not in their voting view

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382604#comment-16382604
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2988:
---

GitHub user enixon opened a pull request:

https://github.com/apache/zookeeper/pull/477

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server …

…id not in their voting view

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-2988-3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #477


commit a1364d8c4ec9fdf1c4210b6485a6a143c1e14f5f
Author: Brian Nixon 
Date:   2018-03-01T19:21:47Z

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server id not 
in their voting view




> NPE triggered if server receives a vote for a server id not in their voting 
> view
> 
>
> Key: ZOOKEEPER-2988
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2988
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Brian Nixon
>Priority: Minor
>
> We've observed the following behavior in elections when a node is lagging 
> behind the quorum in its view of the ensemble topology.
> - Node A is operating with node B in its voting view, but without view of 
> node C.
> - B votes for C.
> - A then switches its vote to C, but throws a NPE when attempting to connect.
> This causes the QuorumPeer to spin up a Follower only to immediately have it 
> shutdown by the exception.
> Ideally, A would not advertise a vote for a server that it will not follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2988) NPE triggered if server receives a vote for a server id not in their voting view

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382605#comment-16382605
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2988:
---

GitHub user enixon opened a pull request:

https://github.com/apache/zookeeper/pull/478

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server …

…id not in their voting view

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-2988-3.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #478


commit 6fc857a1cfe97a46a4f453613b95f9682adcce96
Author: Brian Nixon 
Date:   2018-03-01T19:19:51Z

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server id not 
in their voting view




> NPE triggered if server receives a vote for a server id not in their voting 
> view
> 
>
> Key: ZOOKEEPER-2988
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2988
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Brian Nixon
>Priority: Minor
>
> We've observed the following behavior in elections when a node is lagging 
> behind the quorum in its view of the ensemble topology.
> - Node A is operating with node B in its voting view, but without view of 
> node C.
> - B votes for C.
> - A then switches its vote to C, but throws a NPE when attempting to connect.
> This causes the QuorumPeer to spin up a Follower only to immediately have it 
> shutdown by the exception.
> Ideally, A would not advertise a vote for a server that it will not follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #478: ZOOKEEPER-2988: NPE triggered if server receive...

[enixon]

GitHub user enixon opened a pull request:

https://github.com/apache/zookeeper/pull/478

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server …

…id not in their voting view

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-2988-3.4

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/478.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #478


commit 6fc857a1cfe97a46a4f453613b95f9682adcce96
Author: Brian Nixon 
Date:   2018-03-01T19:19:51Z

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server id not 
in their voting view




---

[GitHub] zookeeper pull request #477: ZOOKEEPER-2988: NPE triggered if server receive...

[enixon]

GitHub user enixon opened a pull request:

https://github.com/apache/zookeeper/pull/477

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server …

…id not in their voting view

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-2988-3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #477


commit a1364d8c4ec9fdf1c4210b6485a6a143c1e14f5f
Author: Brian Nixon 
Date:   2018-03-01T19:21:47Z

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server id not 
in their voting view




---

[jira] [Commented] (ZOOKEEPER-2988) NPE triggered if server receives a vote for a server id not in their voting view

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382603#comment-16382603
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2988:
---

GitHub user enixon opened a pull request:

https://github.com/apache/zookeeper/pull/476

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server …

…id not in their voting view

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-2988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit 1862a718168ee07287d0b9769a0f4ce20bd1bd32
Author: Brian Nixon 
Date:   2018-03-01T19:19:51Z

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server id not 
in their voting view




> NPE triggered if server receives a vote for a server id not in their voting 
> view
> 
>
> Key: ZOOKEEPER-2988
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2988
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: leaderElection
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Brian Nixon
>Priority: Minor
>
> We've observed the following behavior in elections when a node is lagging 
> behind the quorum in its view of the ensemble topology.
> - Node A is operating with node B in its voting view, but without view of 
> node C.
> - B votes for C.
> - A then switches its vote to C, but throws a NPE when attempting to connect.
> This causes the QuorumPeer to spin up a Follower only to immediately have it 
> shutdown by the exception.
> Ideally, A would not advertise a vote for a server that it will not follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #476: ZOOKEEPER-2988: NPE triggered if server receive...

[enixon]

GitHub user enixon opened a pull request:

https://github.com/apache/zookeeper/pull/476

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server …

…id not in their voting view

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/enixon/zookeeper ZOOKEEPER-2988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit 1862a718168ee07287d0b9769a0f4ce20bd1bd32
Author: Brian Nixon 
Date:   2018-03-01T19:19:51Z

ZOOKEEPER-2988: NPE triggered if server receives a vote for a server id not 
in their voting view




---

[jira] [Created] (ZOOKEEPER-2988) NPE triggered if server receives a vote for a server id not in their voting view

[Brian Nixon (JIRA)]

Brian Nixon created ZOOKEEPER-2988:
--

 Summary: NPE triggered if server receives a vote for a server id 
not in their voting view
 Key: ZOOKEEPER-2988
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2988
 Project: ZooKeeper
  Issue Type: Bug
  Components: leaderElection
Affects Versions: 3.4.11, 3.5.3
Reporter: Brian Nixon


We've observed the following behavior in elections when a node is lagging 
behind the quorum in its view of the ensemble topology.

- Node A is operating with node B in its voting view, but without view of node 
C.

- B votes for C.

- A then switches its vote to C, but throws a NPE when attempting to connect.

This causes the QuorumPeer to spin up a Follower only to immediately have it 
shutdown by the exception.

Ideally, A would not advertise a vote for a server that it will not follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper_branch34_openjdk7 - Build # 1832 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1832/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 39.10 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.27 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.535 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.503 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.727 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.475 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.625 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.513 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.09 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.692 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
32.625 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.879 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.073 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.373 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.582 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.964 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.635 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.089 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.806 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
30.623 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.621 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.23 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1382:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1385:
 Tests failed!

Total time: 29 minutes 27 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Recording test results
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1210)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

[hamsterready]

Github user hamsterready commented on the issue:

https://github.com/apache/zookeeper/pull/475
  
See report here: https://github.com/31z4/zookeeper-docker/issues/30

Original version:

```
bash-4.4# ./bin/zkCleanup.sh
Usage:
PurgeTxnLog dataLogDir [snapDir] -n count
dataLogDir -- path to the txn log directory
snapDir -- path to the snapshot directory
count -- the number of old snaps/logs you want to keep, value 
should be greater than or equal to 3
bash-4.4# ./bin/zkCleanup.sh  -n 4
bash-4.4# echo $?
0
bash-4.4#
```

And here is after the change:
```
bash-4.4# vi bin/zkCleanup.sh
bash-4.4# ./bin/zkCleanup.sh  -n 4
2018-03-01 14:51:42,420 [myid:] - INFO  [main:PurgeTxnLog@156] - Removing 
file: Mar 1, 2018 2:08:30 PM  /data/version-2/log.203c92a69
Removing file: Mar 1, 2018 2:08:30 PM   /data/version-2/log.203c92a69
2018-03-01 14:51:42,448 [myid:] - INFO  [main:PurgeTxnLog@156] - Removing 
file: Mar 1, 2018 2:19:10 PM  /data/version-2/log.203cce100
Removing file: Mar 1, 2018 2:19:10 PM   /data/version-2/log.203cce100
[.. cut for clarity...]
Removing file: Mar 1, 2018 2:19:11 PM   
/datalog/version-2/snapshot.203ce21e8
2018-03-01 14:51:42,910 [myid:] - INFO  [main:PurgeTxnLog@156] - Removing 
file: Mar 1, 2018 2:22:10 PM  /datalog/version-2/snapshot.203cf2928
Removing file: Mar 1, 2018 2:22:10 PM   
/datalog/version-2/snapshot.203cf2928

```


---

[GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/475
  
I had a look at the code and it seems to me that previous ordering of 
parameters was right. 

`FileTxnSnapLog` class is instantiated from `PurgeTxnLog` by parsing the 0. 
cli arg to `dataDir` (== txn log dir) and 1. cli arg to `snapDir` (==snapshot 
dir). 

So, basically the right order of cli args is _logdir_ and _snapdir_.

Would you please clarify what have you experienced exactly when you said 
_without that it did nothing_?


---

ZooKeeper_branch35_jdk8 - Build # 869 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/869/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.59 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.075 sec, Thread: 4, Class: org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.781 sec, Thread: 3, Class: 
org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.587 sec, Thread: 2, Class: 
org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 4
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
2
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.613 sec, Thread: 4, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.591 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 4
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
137.991 sec, Thread: 5, Class: 
org.apache.zookeeper.test.FollowerResyncConcurrencyTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.099 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.453 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.588 sec, Thread: 5, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.827 sec, Thread: 3, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 5
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.065 sec, Thread: 3, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.674 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.936 sec, Thread: 5, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 3
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 5
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.181 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.095 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.968 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.726 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.088 sec, Thread: 2, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
68.936 sec, Thread: 6, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 2
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
80.971 sec, Thread: 1, Class: org.apache.zookeeper.test.QuorumTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.785 sec, Thread: 6, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.651 sec, Thread: 5, Class: 

ZooKeeper-trunk-jdk8 - Build # 1393 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1393/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.95 KB...]
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 5
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.319 sec, Thread: 5, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.61 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.575 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 5
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.125 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
17.445 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.787 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.312 sec, Thread: 3, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.129 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec, Thread: 3, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.138 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 3
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
35.178 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
142.487 sec, Thread: 4, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.151 sec, Thread: 4, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 4
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.682 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.307 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.153 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
93.994 sec, Thread: 2, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.416 sec, Thread: 2, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
25.083 sec, Thread: 5, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
14.766 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.318 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
282.132 sec, Thread: 1, Class: org.apache.zookeeper.test.ReconfigTest

Failed: ZOOKEEPER-2977 PreCommit Build #3658

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2977
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3658/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1.25 KB...]
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision 722ba9409a44a35d287aac803813f508cff2420a 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 722ba9409a44a35d287aac803813f508cff2420a
Commit message: "ZOOKEEPER-2845: Apply commit log when restarting server."
 > git rev-list --no-walk e129e7a0b64d6555460d240be2d79e53aaa1bef9 # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-Build] $ /bin/bash /tmp/jenkins6778026224445121367.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386172
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Exception in thread "main" java.lang.UnsupportedClassVersionError: 
org/apache/tools/ant/launch/Launcher : Unsupported major.minor version 52.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:482)
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2845
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2977) Concurrency for addAuth corrupts quorum packets

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381841#comment-16381841
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2977:
---

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/474
  
@sumitagrawl Good analysis and fix. Few minor comments,
- Please take care indentation in the tests.  Presently, it uses tab.
- Please add comments in test as a quick reference to the issue to show the 
expectations and background of this test,  something like, 
https://github.com/apache/zookeeper/blob/master/src/java/test/org/apache/zookeeper/server/DataTreeTest.java#L70
- break; is not needed in loop, pls remove.



> Concurrency for addAuth corrupts quorum packets
> ---
>
> Key: ZOOKEEPER-2977
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2977
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.4.9
> Environment: Affects all version in 3.4.x
>Reporter: sumit agrawal
>Assignee: sumit agrawal
>Priority: Critical
> Fix For: 3.4.12
>
> Attachments: 2977.patch
>
>
> When client performs multiple times addAuth with different credential at 
> follower concurrently, the communication between follower gets corrupt. This 
> causes shutdown of Follower due to the failure.
> Analysis:
> In org.apache.zookeeper.server.quorum.QuorumPacket.serialize method,
>  * call a_.startVector(authinfo,"authinfo"); which write the length of 
> authinfo to packet (suppose it writes length 1)
>  * get length of authinfo to write all details in loop (here gets length as 2)
> <-- Here in concurrency scenario, buffer gets corrupt having extra bytes in 
> channel for additional authinfo.
>  
> So When Leader reads next quorum packet, it reads previous extra bytes 
> (incorrect) and possibly identify greater size of message (as corrupt byte 
> pattern) causes exception...
> Coordination > Unexpected exception causing shutdown while sock still open 
> (LearnerHandler.java:633)
>  java.io.IOException: Unreasonable length = 1885430131
>  
>  
> ServerCnxn.getAuthInfo returns Unmodifiable list, but while addAuthInfo, 
> there is no check. So this causes concurrency issue.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #474: ZOOKEEPER-2977: Concurrency for addAuth corrupts quoru...

[rakeshadr]

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/474
  
@sumitagrawl Good analysis and fix. Few minor comments,
- Please take care indentation in the tests.  Presently, it uses tab.
- Please add comments in test as a quick reference to the issue to show the 
expectations and background of this test,  something like, 
https://github.com/apache/zookeeper/blob/master/src/java/test/org/apache/zookeeper/server/DataTreeTest.java#L70
- break; is not needed in loop, pls remove.



---

[jira] [Assigned] (ZOOKEEPER-2977) Concurrency for addAuth corrupts quorum packets

[Rakesh R (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R reassigned ZOOKEEPER-2977:
---

Assignee: sumit agrawal

> Concurrency for addAuth corrupts quorum packets
> ---
>
> Key: ZOOKEEPER-2977
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2977
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.4.9
> Environment: Affects all version in 3.4.x
>Reporter: sumit agrawal
>Assignee: sumit agrawal
>Priority: Critical
> Fix For: 3.4.12
>
> Attachments: 2977.patch
>
>
> When client performs multiple times addAuth with different credential at 
> follower concurrently, the communication between follower gets corrupt. This 
> causes shutdown of Follower due to the failure.
> Analysis:
> In org.apache.zookeeper.server.quorum.QuorumPacket.serialize method,
>  * call a_.startVector(authinfo,"authinfo"); which write the length of 
> authinfo to packet (suppose it writes length 1)
>  * get length of authinfo to write all details in loop (here gets length as 2)
> <-- Here in concurrency scenario, buffer gets corrupt having extra bytes in 
> channel for additional authinfo.
>  
> So When Leader reads next quorum packet, it reads previous extra bytes 
> (incorrect) and possibly identify greater size of message (as corrupt byte 
> pattern) causes exception...
> Coordination > Unexpected exception causing shutdown while sock still open 
> (LearnerHandler.java:633)
>  java.io.IOException: Unreasonable length = 1885430131
>  
>  
> ServerCnxn.getAuthInfo returns Unmodifiable list, but while addAuthInfo, 
> there is no check. So this causes concurrency issue.
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)