ZooKeeper_branch34_jdk8 - Build # 1363 - Still Failing

2018-04-20 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1363/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 38.38 KB...]
[junit] Running org.apache.zookeeper.test.RecoveryTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
51.939 sec
[junit] Running org.apache.zookeeper.test.RepeatStartupTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.639 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
41.981 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.864 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.729 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.935 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.667 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.827 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.695 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.073 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.314 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.451 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.95 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.007 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.257 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.715 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
14.29 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.921 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.101 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.358 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
31.191 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.811 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.093 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1382: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1385: 
Tests failed!

Total time: 43 minutes 19 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1210)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-20 Thread Patrick Hunt 
The voting timeline for releases is a minimum to ensure everyone has the
opportunity to participate, it's not a max. The vote can run for as long as
necessary.

Patrick

On Fri, Apr 20, 2018 at 7:50 AM, Ted Yu  wrote:

> The original email said:
>
> bq. vote by March 31st 2018,
>
> IMHO Apr 30th is not far ahead :-)
>
> If you think RC1 should receive more vote, please extend the voting
> deadline.
>
> On Wed, Apr 18, 2018 at 1:29 PM, Abraham Fine  wrote:
>
> > I'm waiting for one more additional vote on the release. When that is
> done
> > it will be available.
> >
> > On Wed, Apr 18, 2018, at 12:38, Ted Yu wrote:
> > > I don't see 3.4.12 artifact under
> > > https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper
> > >
> > > Abraham:
> > > Can you clarify ?
> > >
> > > Thanks
> > >
> > > On Mon, Apr 16, 2018 at 9:35 AM, Ted Yu  wrote:
> > >
> > > > Hi,
> > > > If I understand correctly, zookeeper users can expect maven artifacts
> > for
> > > > 3.4.12 to be posted soon.
> > > >
> > > > Thanks
> > > >
> >
>

ZooKeeper-trunk-windows-cmake - Build # 2723 - Still Failing

2018-04-20 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2723/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 18.44 KB...]
  Creating "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.
CustomBuild:
  Checking Build System
  CMake does not need to re-run because 
F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/src/c/CMakeFiles/generate.stamp
 is up-to-date.
FinalizeBuildStatus:
  Deleting file "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild".
  Touching "Win32\Debug\ZERO_CHECK\ZERO_CHECK.tlog\ZERO_CHECK.lastbuildstate".
Done Building Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\ZERO_CHECK.vcxproj"
 (default targets).
The target "_ConvertPdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,37)" does not exist in the project, and will be ignored.
The target "_CollectPdbFiles" listed in an AfterTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,70)" does not exist in the project, and will be ignored.
The target "_CollectMdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,38)" does not exist in the project, and will be ignored.
The target "_CopyMdbFiles" listed in an AfterTargets attribute at "C:\Program 
Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,71)" does not exist in the project, and will be ignored.
The target "_ConvertPdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,37)" does not exist in the project, and will be ignored.
The target "_CollectPdbFiles" listed in an AfterTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(34,70)" does not exist in the project, and will be ignored.
The target "_CollectMdbFiles" listed in a BeforeTargets attribute at 
"C:\Program Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,38)" does not exist in the project, and will be ignored.
The target "_CopyMdbFiles" listed in an AfterTargets attribute at "C:\Program 
Files 
(x86)\MSBuild\14.0\Microsoft.Common.targets\ImportAfter\Xamarin.Common.targets 
(41,71)" does not exist in the project, and will be ignored.
Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\ALL_BUILD.vcxproj"
 (1) is building 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\cli.vcxproj"
 (3) on node 1 (default targets).
Project 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\cli.vcxproj"
 (3) is building 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj"
 (4) on node 1 (default targets).
PrepareForBuild:
  Creating directory "hashtable.dir\Debug\".
  Creating directory "hashtable.dir\Debug\hashtable.tlog\".
InitializeBuildStatus:
  Creating "hashtable.dir\Debug\hashtable.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.
CustomBuild:
  Building Custom Rule 
F:/jenkins/jenkins-slave/workspace/ZooKeeper-trunk-windows-cmake/src/c/CMakeLists.txt
  CMake does not need to re-run because 
F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\CMakeFiles\generate.stamp
 is up-to-date.
ClCompile:
  F:\Microsoft\Visual Studio CE 2015\VC\bin\CL.exe /c /Zi /nologo /W3 /WX- /Od 
/Ob0 /Oy- /D WIN32 /D _WINDOWS /D _DEBUG /D USE_STATIC_LIB /D THREADED /D 
"CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /RTC1 /MDd /GS /fp:precise /Zc:wchar_t 
/Zc:forScope /Zc:inline /Fo"hashtable.dir\Debug\\" 
/Fd"hashtable.dir\Debug\hashtable.pdb" /Gd /TC /analyze- /errorReport:queue 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable_itr.c"
 
"F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.c"
  hashtable_itr.c
f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
 fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
directory 
[F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
  hashtable.c
f:\jenkins\jenkins-slave\workspace\zookeeper-trunk-windows-cmake\src\c\src\hashtable\hashtable.h(6):
 fatal error C1083: Cannot open include file: 'winconfig.h': No such file or 
directory 
[F:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-windows-cmake\src\c\hashtable.vcxproj]
  Generating Code...
Done Building Project

Re: [VOTE] Migrate ZK to Maven build

2018-04-20 Thread Michelle Tan 
Sounds great +1

On Fri, Apr 20, 2018 at 4:06 PM, Enrico Olivelli 
wrote:

> +1 thank you (non binding)
>
> Enrico
>
> 2018-04-20 16:36 GMT+02:00 Rakesh Radhakrishnan :
>
> > I really appreciate your initiative!
> >
> > +1
> >
> > On Fri, Apr 20, 2018 at 7:36 PM, Flavio Junqueira 
> wrote:
> >
> > > Definitely +1
> > >
> > > > On 20 Apr 2018, at 16:06, Norbert Kalmar 
> wrote:
> > > >
> > > > Hi,
> > > >
> > > > Let's start a vote on migrating to maven instead of ant.
> > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> > > >
> > > > *Shall we migrate ZooKeeper build from ant to Maven?*
> > > >
> > > > Please reply with [Yes / +1] or [No / -1] to this thread.
> > > >
> > > > Thanks,
> > > > Norbert
> > >
> > >
> >
>

Re: [VOTE] Migrate ZK to Maven build

2018-04-20 Thread Enrico Olivelli 
+1 thank you (non binding)

Enrico

2018-04-20 16:36 GMT+02:00 Rakesh Radhakrishnan :

> I really appreciate your initiative!
>
> +1
>
> On Fri, Apr 20, 2018 at 7:36 PM, Flavio Junqueira  wrote:
>
> > Definitely +1
> >
> > > On 20 Apr 2018, at 16:06, Norbert Kalmar  wrote:
> > >
> > > Hi,
> > >
> > > Let's start a vote on migrating to maven instead of ant.
> > > https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> > >
> > > *Shall we migrate ZooKeeper build from ant to Maven?*
> > >
> > > Please reply with [Yes / +1] or [No / -1] to this thread.
> > >
> > > Thanks,
> > > Norbert
> >
> >
>

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-20 Thread Ted Yu 
The original email said:

bq. vote by March 31st 2018,

IMHO Apr 30th is not far ahead :-)

If you think RC1 should receive more vote, please extend the voting
deadline.

On Wed, Apr 18, 2018 at 1:29 PM, Abraham Fine  wrote:

> I'm waiting for one more additional vote on the release. When that is done
> it will be available.
>
> On Wed, Apr 18, 2018, at 12:38, Ted Yu wrote:
> > I don't see 3.4.12 artifact under
> > https://mvnrepository.com/artifact/org.apache.zookeeper/zookeeper
> >
> > Abraham:
> > Can you clarify ?
> >
> > Thanks
> >
> > On Mon, Apr 16, 2018 at 9:35 AM, Ted Yu  wrote:
> >
> > > Hi,
> > > If I understand correctly, zookeeper users can expect maven artifacts
> for
> > > 3.4.12 to be posted soon.
> > >
> > > Thanks
> > >
>

[jira] [Commented] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-20 Thread Rakesh R (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445844#comment-16445844
 ] 

Rakesh R commented on ZOOKEEPER-3021:
-

[~nkalmar] appreciate your efforts. Glad to see, you are identifying sub-tasks 
and pushing small review-able chunks.

Another critical part in the migration is adding dependencies in the POM, we 
have to make sure adding right version of the jars.

> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
>  
>  First iteration: separate project structure
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  With this kind of structure, the code change could be kept to a bare 
> minimum, if any at all.
>  Just change the ant script to conform to the new structure. 
>   
>  Second iteration: code changes:
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-jute
> |-zk-client
> | |-zk-client-c
> | |-zk-client-java
> | \-zk-client-go (or any other language)
> |-zk-common
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  Here, java client code is separated from the server code (and any other 
> supported languages client code).
>   
>  Third iteration: maven structure
> {noformat}
> zk-something
> |-src
> | |-main
> | | |-java
> | | | \org...
> | | \resources
> | \test (unit tests only?)
> | |-java
> | | \org...
> | \resources
> \pom.xml (build.xml, build.gradle?)
> {noformat}
> There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
> proxy on top of ant. 
> The main idea here is to replace ant with "pure" maven, and update the 
> project structure accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Migrate ZK to Maven build

2018-04-20 Thread Rakesh Radhakrishnan 
I really appreciate your initiative!

+1

On Fri, Apr 20, 2018 at 7:36 PM, Flavio Junqueira  wrote:

> Definitely +1
>
> > On 20 Apr 2018, at 16:06, Norbert Kalmar  wrote:
> >
> > Hi,
> >
> > Let's start a vote on migrating to maven instead of ant.
> > https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> >
> > *Shall we migrate ZooKeeper build from ant to Maven?*
> >
> > Please reply with [Yes / +1] or [No / -1] to this thread.
> >
> > Thanks,
> > Norbert
>
>

Re: [VOTE] Migrate ZK to Maven build

2018-04-20 Thread Flavio Junqueira 
Definitely +1

> On 20 Apr 2018, at 16:06, Norbert Kalmar  wrote:
> 
> Hi,
> 
> Let's start a vote on migrating to maven instead of ant.
> https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> 
> *Shall we migrate ZooKeeper build from ant to Maven?*
> 
> Please reply with [Yes / +1] or [No / -1] to this thread.
> 
> Thanks,
> Norbert

[VOTE] Migrate ZK to Maven build

2018-04-20 Thread Norbert Kalmar 
Hi,

Let's start a vote on migrating to maven instead of ant.
https://issues.apache.org/jira/browse/ZOOKEEPER-3021

*Shall we migrate ZooKeeper build from ant to Maven?*

Please reply with [Yes / +1] or [No / -1] to this thread.

Thanks,
Norbert

[jira] [Created] (ZOOKEEPER-3023) Flaky test: org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff

2018-04-20 Thread Pravin Dsilva (JIRA) 
Pravin Dsilva created ZOOKEEPER-3023:


 Summary: Flaky test: 
org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff
 Key: ZOOKEEPER-3023
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3023
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.6.0
Reporter: Pravin Dsilva


Getting the following error on master branch:

Error Message
{code:java}
expected:<4294967298> but was:<0>{code}
Stacktrace
{code:java}
junit.framework.AssertionFailedError: expected:<4294967298> but was:<0> at 
org.apache.zookeeper.server.quorum.Zab1_0Test$5.converseWithFollower(Zab1_0Test.java:876)
 at 
org.apache.zookeeper.server.quorum.Zab1_0Test.testFollowerConversation(Zab1_0Test.java:523)
 at 
org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalFollowerRunWithDiff(Zab1_0Test.java:791)
 at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-20 Thread Enrico Olivelli (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445631#comment-16445631
 ] 

Enrico Olivelli commented on ZOOKEEPER-3021:


No INFRA support is needed, PMCs and other committers are able to change CI 
config.
Maybe we will have a transition period and we will be running both CI jobs (ant 
based and maven based)

> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
>  
>  First iteration: separate project structure
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  With this kind of structure, the code change could be kept to a bare 
> minimum, if any at all.
>  Just change the ant script to conform to the new structure. 
>   
>  Second iteration: code changes:
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-jute
> |-zk-client
> | |-zk-client-c
> | |-zk-client-java
> | \-zk-client-go (or any other language)
> |-zk-common
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  Here, java client code is separated from the server code (and any other 
> supported languages client code).
>   
>  Third iteration: maven structure
> {noformat}
> zk-something
> |-src
> | |-main
> | | |-java
> | | | \org...
> | | \resources
> | \test (unit tests only?)
> | |-java
> | | \org...
> | \resources
> \pom.xml (build.xml, build.gradle?)
> {noformat}
> There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
> proxy on top of ant. 
> The main idea here is to replace ant with "pure" maven, and update the 
> project structure accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [SUGGESTION] Migrate project structure to Maven build

2018-04-20 Thread Norbert Kalmar 
Quick update: I created the umbrella jira and the first step sub-jira:
https://issues.apache.org/jira/browse/ZOOKEEPER-3021

Please feel free to pitch in, share your ideas and doubts.

I will start working on the first step.

Regards,
Norbert

On Fri, Apr 20, 2018 at 12:00 PM, Norbert Kalmar 
wrote:

> Hi All,
>
> Thanks for the feedbacks.
> @Enrico: I checked https://issues.apache.org/jira/browse/ZOOKEEPER-1078 .
> It is very hard to keep track with the patch files, it should be committed.
> But looking at the changes, it is more of a Maven proxy layer for ant with
> lots of copy commands.
>
> If we do change to maven, I think we should do so with getting rid of ant.
> (Of course this will be one of the last steps). ZOOKEEPER-1078 approaches
> the task to add support for Maven build via just a proxy layer over ant.
>
> As @Mohammad mentiend, we could create an umbrella Jira, and start small
> (or at least small in the sense of coda change/impact).
>
> Looking at the reactions here, comments on ZOOKEEPER-1078 and other
> forums, I think people would be positive to the change.
>
> I will create the Umbrella Jira, so that we can start working on the first
> steps, while waiting for other feedbacks.
>
> Thanks,
> Norbert
>
> On Thu, Apr 19, 2018 at 2:53 PM, Ted Yu  wrote:
>
>>  +1 for migrating to maven build.
>>  Original message From: Mohammad arshad <
>> mohammad.ars...@huawei.com> Date: 4/19/18  5:23 AM  (GMT-08:00) To:
>> dev@zookeeper.apache.org Subject: RE: [SUGGESTION] Migrate project
>> structure to Maven build
>> Thanks Norbert for the good initiative. I am +1 on migrating to maven
>> I think it would be good to start with master branch. After changing and
>> stabilizing it, we can backport changes to other branches.
>> May be we can create an umbrella JIRA and create independent tasks under
>> it. There will be many things which can be handled independently
>>
>> Thanks & Regards
>> Arshad
>> -Original Message-
>> From: Enrico Olivelli [mailto:eolive...@gmail.com]
>> Sent: Thursday, April 19, 2018 8:03 PM
>> To: DevZooKeeper 
>> Subject: Re: [SUGGESTION] Migrate project structure to Maven build
>>
>> Hi Norbert,
>> thank you for your suggestiion
>>
>> there is a long standing patch for migration to Maven
>> https://issues.apache.org/jira/browse/ZOOKEEPER-1078
>>
>> personally I am using that pom.xml in order to speed up work
>>
>> I really would like this change, but we need support from some committer.
>> It is an important change and it cannot be done without full consensus in
>> the community
>>
>> Cheers
>> Enrico
>>
>>
>> 2018-04-19 13:28 GMT+02:00 Norbert Kalmar :
>>
>> > Hi ZooKeeper community,
>> >
>> > As the vast majority of the components in the Hadoop ecosystem is
>> > built with Maven, what do you think of moving Zookeeper to a Maven
>> > structure as well?
>> >
>> > This would bring the benefit of a more consistent project structure,
>> > better dependency management and more possibilities for future changes
>> > (i.e.: we could separate java client code so that projects like HDFS
>> > that only needs the client doesn't have to import the whole ZooKeeper).
>> >
>> > This could be done as a multi-step change.
>> >
>> > The change would also include the separation of unit tests from
>> > integration and/or functional tests.
>> >
>> > In the first iteration, the project structure could be separated
>> > something
>> > like:
>> >
>> > zookeeper
>> > |-bin
>> > |-conf
>> > |-zk-client-c
>> > |-zk-contrib
>> > | |-zk-contrib-fatjar
>> > | |-zk-contrib-huebrowser
>> > | |-zk-contrib-loggraph
>> > | |-zk-contrib-monitoring
>> > | |-zk-contrib-rest
>> > | |-zk-contrib-zkfuse
>> > | |-zk-contrib-zkperl
>> > | |-zk-contrib-zkpython
>> > | |-zk-contrib-zktreeutil
>> > | \-zk-contrib-zooinspector
>> > |-zk-docs
>> > |-zk-it (integration tests)
>> > |-zk-server
>> > |-zk-recipes
>> > | |-zk-recipes-election
>> > | |-zk-recipes-lock
>> > \ \-zk-recipes-queue
>> >
>> >
>> > With this kind of structure, the code change could be kept to a bare
>> > minimum, if any at all.
>> > Just change the ant script to conform to the new structure.
>> >
>> > In a second iteration, we could start the changes that require code
>> > changes as well:
>> >
>> > zookeeper
>> > |-bin
>> > |-conf
>> > |-jute
>> > |-zk-client
>> > | |-zk-client-c
>> > | |-zk-client-java
>> > | \-zk-client-go (or any other language) -zk-common -zk-contrib
>> > | |-zk-contrib-fatjar
>> > | |-zk-contrib-huebrowser
>> > | |-zk-contrib-loggraph
>> > | |-zk-contrib-monitoring
>> > | |-zk-contrib-rest
>> > | |-zk-contrib-zkfuse
>> > | |-zk-contrib-zkperl
>> > | |-zk-contrib-zkpython
>> > | |-zk-contrib-zktreeutil
>> > | \-zk-contrib-zooinspector
>> > |-zk-docs
>> > |-zk-it (integration tests)
>> > |-zk-server
>> > |-zk-recipes
>> > | |-zk-recipes-election
>> > | |-zk-recipes-lock
>> > \ \-zk-recipes-queue
>> >
>> >
>> > Here, java

[jira] [Assigned] (ZOOKEEPER-3022) Step 1 to maven - Separate project structure

2018-04-20 Thread Norbert Kalmar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar reassigned ZOOKEEPER-3022:
-

Assignee: Norbert Kalmar

> Step 1 to maven - Separate project structure
> 
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> This first step should not impact Jenkins QA.
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-20 Thread Norbert Kalmar (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445624#comment-16445624
 ] 

Norbert Kalmar commented on ZOOKEEPER-3021:
---

Yes, you're right Enrico. When we start migrating the build scripts, we will 
most probably need INFRA's help.
During the first and second step, I think we are fine, it will be still an ant 
build. We just have to take care to update the ant scripts to the new package 
structure.

And of course we have to make sure the final package structure remains the same 
in the artifacts.

Thanks for bringing it to attention!

> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
>  
>  First iteration: separate project structure
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  With this kind of structure, the code change could be kept to a bare 
> minimum, if any at all.
>  Just change the ant script to conform to the new structure. 
>   
>  Second iteration: code changes:
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-jute
> |-zk-client
> | |-zk-client-c
> | |-zk-client-java
> | \-zk-client-go (or any other language)
> |-zk-common
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  Here, java client code is separated from the server code (and any other 
> supported languages client code).
>   
>  Third iteration: maven structure
> {noformat}
> zk-something
> |-src
> | |-main
> | | |-java
> | | | \org...
> | | \resources
> | \test (unit tests only?)
> | |-java
> | | \org...
> | \resources
> \pom.xml (build.xml, build.gradle?)
> {noformat}
> There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
> proxy on top of ant. 
> The main idea here is to replace ant with "pure" maven, and update the 
> project structure accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3022) Step 1 to maven - Separate project structure

2018-04-20 Thread Norbert Kalmar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3022:
--
Description: 
Create a project structure that separates the different parts of ZooKeeper into 
a more meaningful packages for the future maven build.

This first step should not impact Jenkins QA.

{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}

  was:
Create a project structure that separates the different parts of ZooKeeper into 
a more meaningful packages for the future maven build.

{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}


> Step 1 to maven - Separate project structure
> 
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> This first step should not impact Jenkins QA.
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3022) Separate project structure

2018-04-20 Thread Norbert Kalmar (JIRA) 
Norbert Kalmar created ZOOKEEPER-3022:
-

 Summary: Separate project structure
 Key: ZOOKEEPER-3022
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
 Project: ZooKeeper
  Issue Type: Sub-task
  Components: build, scripts
Affects Versions: 3.6.0
Reporter: Norbert Kalmar






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3022) Step 1 to maven - Separate project structure

2018-04-20 Thread Norbert Kalmar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3022:
--
Summary: Step 1 to maven - Separate project structure  (was: Step 1. to 
maven - Separate project structure)

> Step 1 to maven - Separate project structure
> 
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3022) Step 1. to maven - Separate project structure

2018-04-20 Thread Norbert Kalmar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3022:
--
Summary: Step 1. to maven - Separate project structure  (was: Separate 
project structure)

> Step 1. to maven - Separate project structure
> -
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3022) Separate project structure

2018-04-20 Thread Norbert Kalmar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3022:
--
Description: 
Create a project structure that separates the different parts of ZooKeeper into 
a more meaningful packages for the future maven build.

{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}

> Separate project structure
> --
>
> Key: ZOOKEEPER-3022
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3022
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: build, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> Create a project structure that separates the different parts of ZooKeeper 
> into a more meaningful packages for the future maven build.
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1078) add maven build support to ZooKeeper

2018-04-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445610#comment-16445610
 ] 

Hadoop QA commented on ZOOKEEPER-1078:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12814865/ZOOKEEPER-1078-05.patch
  against trunk revision 519db3f5c585f63a0a55e9f7929a07f9715bd729.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 27 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3664//console

This message is automatically generated.

> add maven build support to ZooKeeper
> 
>
> Key: ZOOKEEPER-1078
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1078
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build
>Reporter: Patrick Hunt
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1078-04.patch, ZOOKEEPER-1078-05.patch, 
> ZOOKEEPER-1078.patch, ZOOKEEPER-1078.patch, ZOOKEEPER-1078.patch
>
>
> I've taken a stab at creating a maven build for ZooKeeper. (attachment to 
> follow).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-1078 PreCommit Build #3664

2018-04-20 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1078
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3664/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.80 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12814865/ZOOKEEPER-1078-05.patch
 [exec]   against trunk revision 519db3f5c585f63a0a55e9f7929a07f9715bd729.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 27 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3664//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16445610 added to ZOOKEEPER-1078.
 [exec] Session logged out. Session was 
JSESSIONID=E9C11037D377931C9C8FEB97DEFE6E89.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1701: 
exec returned: 1

Total time: 48 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3002
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-20 Thread Enrico Olivelli (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445612#comment-16445612
 ] 

Enrico Olivelli commented on ZOOKEEPER-3021:


I like this roadmap ! Thank you

 

I think that the bigger pain will be the change of the QA robot, now it 
launches ANT and it does a lot of things.

The release procedure needs to be changed and it will be very important to keep 
the structure of poms and artifacts published to Maven Central as the current 
one.

 

> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
>  
>  First iteration: separate project structure
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  With this kind of structure, the code change could be kept to a bare 
> minimum, if any at all.
>  Just change the ant script to conform to the new structure. 
>   
>  Second iteration: code changes:
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-jute
> |-zk-client
> | |-zk-client-c
> | |-zk-client-java
> | \-zk-client-go (or any other language)
> |-zk-common
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  Here, java client code is separated from the server code (and any other 
> supported languages client code).
>   
>  Third iteration: maven structure
> {noformat}
> zk-something
> |-src
> | |-main
> | | |-java
> | | | \org...
> | | \resources
> | \test (unit tests only?)
> | |-java
> | | \org...
> | \resources
> \pom.xml (build.xml, build.gradle?)
> {noformat}
> There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
> proxy on top of ant. 
> The main idea here is to replace ant with "pure" maven, and update the 
> project structure accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-20 Thread Norbert Kalmar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3021:
--
Description: 
In multiple steps, Maven should replace current ant build in ZooKeeper.

 
 First iteration: separate project structure
{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 With this kind of structure, the code change could be kept to a bare minimum, 
if any at all.
 Just change the ant script to conform to the new structure. 
  
 Second iteration: code changes:
{noformat}
zookeeper
|-bin
|-conf
|-jute
|-zk-client
| |-zk-client-c
| |-zk-client-java
| \-zk-client-go (or any other language)
|-zk-common
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
 Here, java client code is separated from the server code (and any other 
supported languages client code).
  
 Third iteration: maven structure
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}

There is already ZOOKEEPER-1078, but it's main approach is to create a maven 
proxy on top of ant. 
The main idea here is to replace ant with "pure" maven, and update the project 
structure accordingly.

  was:
In multiple steps, Maven should replace current ant build in ZooKeeper.

 
First iteration: separate project structure
{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
With this kind of structure, the code change could be kept to a bare minimum, 
if any at all.
Just change the ant script to conform to the new structure. 
 
Second iteration: code changes:
{noformat}
zookeeper
|-bin
|-conf
|-jute
|-zk-client
| |-zk-client-c
| |-zk-client-java
| \-zk-client-go (or any other language)
|-zk-common
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
Here, java client code is separated from the server code (and any other 
supported languages client code).
 
Third iteration: maven structure
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}


> Umbrella: Migrate project structure to Maven build
> --
>
> Key: ZOOKEEPER-3021
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: build, build-infrastructure, scripts
>Affects Versions: 3.6.0
>Reporter: Norbert Kalmar
>Priority: Major
>
> In multiple steps, Maven should replace current ant build in ZooKeeper.
>  
>  First iteration: separate project structure
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-zk-client-c
> |-zk-contrib
> | |-zk-contrib-fatjar
> | |-zk-contrib-huebrowser
> | |-zk-contrib-loggraph
> | |-zk-contrib-monitoring
> | |-zk-contrib-rest
> | |-zk-contrib-zkfuse
> | |-zk-contrib-zkperl
> | |-zk-contrib-zkpython
> | |-zk-contrib-zktreeutil
> | \-zk-contrib-zooinspector
> |-zk-docs
> |-zk-it (integration tests)
> |-zk-server
> |-zk-recipes
> | |-zk-recipes-election
> | |-zk-recipes-lock
> \ \-zk-recipes-queue
> {noformat}
>  
>  With this kind of structure, the code change could be kept to a bare 
> minimum, if any at all.
>  Just change the ant script to conform to the new structure. 
>   
>  Second iteration: code changes:
> {noformat}
> zookeeper
> |-bin
> |-conf
> |-jute
>

[jira] [Created] (ZOOKEEPER-3021) Umbrella: Migrate project structure to Maven build

2018-04-20 Thread Norbert Kalmar (JIRA) 
Norbert Kalmar created ZOOKEEPER-3021:
-

 Summary: Umbrella: Migrate project structure to Maven build
 Key: ZOOKEEPER-3021
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3021
 Project: ZooKeeper
  Issue Type: Improvement
  Components: build, build-infrastructure, scripts
Affects Versions: 3.6.0
Reporter: Norbert Kalmar


In multiple steps, Maven should replace current ant build in ZooKeeper.

 
First iteration: separate project structure
{noformat}
zookeeper
|-bin
|-conf
|-zk-client-c
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
With this kind of structure, the code change could be kept to a bare minimum, 
if any at all.
Just change the ant script to conform to the new structure. 
 
Second iteration: code changes:
{noformat}
zookeeper
|-bin
|-conf
|-jute
|-zk-client
| |-zk-client-c
| |-zk-client-java
| \-zk-client-go (or any other language)
|-zk-common
|-zk-contrib
| |-zk-contrib-fatjar
| |-zk-contrib-huebrowser
| |-zk-contrib-loggraph
| |-zk-contrib-monitoring
| |-zk-contrib-rest
| |-zk-contrib-zkfuse
| |-zk-contrib-zkperl
| |-zk-contrib-zkpython
| |-zk-contrib-zktreeutil
| \-zk-contrib-zooinspector
|-zk-docs
|-zk-it (integration tests)
|-zk-server
|-zk-recipes
| |-zk-recipes-election
| |-zk-recipes-lock
\ \-zk-recipes-queue
{noformat}
 
Here, java client code is separated from the server code (and any other 
supported languages client code).
 
Third iteration: maven structure
{noformat}
zk-something
|-src
| |-main
| | |-java
| | | \org...
| | \resources
| \test (unit tests only?)
| |-java
| | \org...
| \resources
\pom.xml (build.xml, build.gradle?)
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [SUGGESTION] Migrate project structure to Maven build

2018-04-20 Thread Norbert Kalmar 
Hi All,

Thanks for the feedbacks.
@Enrico: I checked https://issues.apache.org/jira/browse/ZOOKEEPER-1078 .
It is very hard to keep track with the patch files, it should be committed.
But looking at the changes, it is more of a Maven proxy layer for ant with
lots of copy commands.

If we do change to maven, I think we should do so with getting rid of ant.
(Of course this will be one of the last steps). ZOOKEEPER-1078 approaches
the task to add support for Maven build via just a proxy layer over ant.

As @Mohammad mentiend, we could create an umbrella Jira, and start small
(or at least small in the sense of coda change/impact).

Looking at the reactions here, comments on ZOOKEEPER-1078 and other forums,
I think people would be positive to the change.

I will create the Umbrella Jira, so that we can start working on the first
steps, while waiting for other feedbacks.

Thanks,
Norbert

On Thu, Apr 19, 2018 at 2:53 PM, Ted Yu  wrote:

>  +1 for migrating to maven build.
>  Original message From: Mohammad arshad <
> mohammad.ars...@huawei.com> Date: 4/19/18  5:23 AM  (GMT-08:00) To:
> dev@zookeeper.apache.org Subject: RE: [SUGGESTION] Migrate project
> structure to Maven build
> Thanks Norbert for the good initiative. I am +1 on migrating to maven
> I think it would be good to start with master branch. After changing and
> stabilizing it, we can backport changes to other branches.
> May be we can create an umbrella JIRA and create independent tasks under
> it. There will be many things which can be handled independently
>
> Thanks & Regards
> Arshad
> -Original Message-
> From: Enrico Olivelli [mailto:eolive...@gmail.com]
> Sent: Thursday, April 19, 2018 8:03 PM
> To: DevZooKeeper 
> Subject: Re: [SUGGESTION] Migrate project structure to Maven build
>
> Hi Norbert,
> thank you for your suggestiion
>
> there is a long standing patch for migration to Maven
> https://issues.apache.org/jira/browse/ZOOKEEPER-1078
>
> personally I am using that pom.xml in order to speed up work
>
> I really would like this change, but we need support from some committer.
> It is an important change and it cannot be done without full consensus in
> the community
>
> Cheers
> Enrico
>
>
> 2018-04-19 13:28 GMT+02:00 Norbert Kalmar :
>
> > Hi ZooKeeper community,
> >
> > As the vast majority of the components in the Hadoop ecosystem is
> > built with Maven, what do you think of moving Zookeeper to a Maven
> > structure as well?
> >
> > This would bring the benefit of a more consistent project structure,
> > better dependency management and more possibilities for future changes
> > (i.e.: we could separate java client code so that projects like HDFS
> > that only needs the client doesn't have to import the whole ZooKeeper).
> >
> > This could be done as a multi-step change.
> >
> > The change would also include the separation of unit tests from
> > integration and/or functional tests.
> >
> > In the first iteration, the project structure could be separated
> > something
> > like:
> >
> > zookeeper
> > |-bin
> > |-conf
> > |-zk-client-c
> > |-zk-contrib
> > | |-zk-contrib-fatjar
> > | |-zk-contrib-huebrowser
> > | |-zk-contrib-loggraph
> > | |-zk-contrib-monitoring
> > | |-zk-contrib-rest
> > | |-zk-contrib-zkfuse
> > | |-zk-contrib-zkperl
> > | |-zk-contrib-zkpython
> > | |-zk-contrib-zktreeutil
> > | \-zk-contrib-zooinspector
> > |-zk-docs
> > |-zk-it (integration tests)
> > |-zk-server
> > |-zk-recipes
> > | |-zk-recipes-election
> > | |-zk-recipes-lock
> > \ \-zk-recipes-queue
> >
> >
> > With this kind of structure, the code change could be kept to a bare
> > minimum, if any at all.
> > Just change the ant script to conform to the new structure.
> >
> > In a second iteration, we could start the changes that require code
> > changes as well:
> >
> > zookeeper
> > |-bin
> > |-conf
> > |-jute
> > |-zk-client
> > | |-zk-client-c
> > | |-zk-client-java
> > | \-zk-client-go (or any other language) -zk-common -zk-contrib
> > | |-zk-contrib-fatjar
> > | |-zk-contrib-huebrowser
> > | |-zk-contrib-loggraph
> > | |-zk-contrib-monitoring
> > | |-zk-contrib-rest
> > | |-zk-contrib-zkfuse
> > | |-zk-contrib-zkperl
> > | |-zk-contrib-zkpython
> > | |-zk-contrib-zktreeutil
> > | \-zk-contrib-zooinspector
> > |-zk-docs
> > |-zk-it (integration tests)
> > |-zk-server
> > |-zk-recipes
> > | |-zk-recipes-election
> > | |-zk-recipes-lock
> > \ \-zk-recipes-queue
> >
> >
> > Here, java client code is separated from the server code (and any
> > other supported languages client code).
> >
> > The final iteration would be something like:
> >
> > zk-something
> > |-src
> > | |-main
> > | |  |-java
> > | |  | \org...
> > | |   \resources
> > | \test (unit tests only?)
> > |  |-java
> > |  |  \org...
> > |  \resources
> > \pom.xml
> >
> >
> > But this is just to give a high level example/vision.
> >
> > Of course, with all the iteration, even at the end when possibly
>

Success: ZOOKEEPER- PreCommit Build #1609

2018-04-20 Thread Apache Jenkins Server 
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1609/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 79.59 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 15 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1609//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1609//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1609//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16445561 added to ZOOKEEPER-3019.
 [exec] Session logged out. Session was 
JSESSIONID=6D2E2C3B2534A248B6A3A93568E6DF7F.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 35 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3019
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

2018-04-20 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445561#comment-16445561
 ] 

Hadoop QA commented on ZOOKEEPER-3019:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 15 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1609//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1609//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1609//console

This message is automatically generated.

> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)