[
https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509199#comment-16509199
]
Michael Han commented on ZOOKEEPER-3056:
{quote}It's a trade-off between admin time and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509181#comment-16509181
]
Michael Han commented on ZOOKEEPER-2421:
A side note is the test was commented out as part of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509180#comment-16509180
]
Michael Han commented on ZOOKEEPER-2421:
{quote}If we close a client, won't the session be
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509098#comment-16509098
]
Song Jun edited comment on ZOOKEEPER-1908 at 6/12/18 2:46 AM:
--
I want
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509098#comment-16509098
]
Song Jun commented on ZOOKEEPER-1908:
-
I want this function too.
when I kerbernized a storm
See https://builds.apache.org/job/ZooKeeper-trunk/59/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 142.68 KB...]
[junit] Running
See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1426/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 40.65 KB...]
[junit] Running
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/529
A commiter needs to review your change and merge it.
Of course anyone can review the pull requests - I did have a look on your
PR, looks good to me, but I couldn't review it in detail
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194539816
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/474#discussion_r194529403
--- Diff: src/java/test/org/apache/zookeeper/server/ServerCnxnTest.java ---
@@ -0,0 +1,130 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194527693
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194523369
--- Diff: src/java/main/org/apache/zookeeper/common/ZKConfig.java ---
@@ -107,14 +99,33 @@ private void init() {
* this configuration.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508595#comment-16508595
]
Andor Molnar commented on ZOOKEEPER-3059:
-
[~abhishek.chouhan] Thanks for the contribution.
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194501452
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -64,6 +66,8 @@
protected InetSocketAddress
Github user breed commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194498695
--- Diff: src/java/main/org/apache/zookeeper/common/ZKConfig.java ---
@@ -107,14 +99,33 @@ private void init() {
* this configuration.
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
@nkalmar is there anything more I need to do with this before it can be
merged?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508448#comment-16508448
]
Matteo Merli commented on ZOOKEEPER-3056:
-
The main case is with ZK 3.4.x, for example with a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508441#comment-16508441
]
Benjamin Reed commented on ZOOKEEPER-3056:
--
how are you getting in a state where you have
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1826/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 77.45 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508431#comment-16508431
]
Hadoop QA commented on ZOOKEEPER-3059:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3059:
--
Labels: pull-request-available (was: )
> EventThread leak in case of Sasl
GitHub user abhishek-chouhan opened a pull request:
https://github.com/apache/zookeeper/pull/541
ZOOKEEPER-3059 EventThread leak in case of Sasl AuthFailed
Since authFailed is similar to session expired and is considered a fatal
event, we should clean up after ourselves once we get
Abhishek Singh Chouhan created ZOOKEEPER-3059:
-
Summary: EventThread leak in case of Sasl AuthFailed
Key: ZOOKEEPER-3059
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3059
Project:
Github user sumitagrawl commented on the issue:
https://github.com/apache/zookeeper/pull/474
@maoling @afine Comments are fixed, please check
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1825/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 90.08 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508293#comment-16508293
]
Hadoop QA commented on ZOOKEEPER-236:
-
+1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1824/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 89.75 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508287#comment-16508287
]
Hadoop QA commented on ZOOKEEPER-236:
-
+1 overall. GitHub Pull Request Build
+1
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194460371
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194460585
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194461322
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +214,120 @@ public static X509KeyManager createKeyManager(String
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1823/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 40.25 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508281#comment-16508281
]
Hadoop QA commented on ZOOKEEPER-2977:
--
+1 overall. GitHub Pull Request Build
+1
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194458091
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194456601
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194451677
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508213#comment-16508213
]
Hadoop QA commented on ZOOKEEPER-236:
-
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1822/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 89.87 MB...]
[exec]
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194442041
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194441963
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194438668
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194438427
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194437578
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -292,8 +298,20 @@ protected void connectToLeader(InetSocketAddress addr,
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194405375
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/PrependableSocket.java ---
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194404893
--- Diff:
src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java ---
@@ -348,20 +347,20 @@ public ChannelPipeline getPipeline() throws
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194404621
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -160,43 +214,120 @@ public static X509KeyManager createKeyManager(String
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194395807
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507991#comment-16507991
]
Hadoop QA commented on ZOOKEEPER-2977:
--
-1 overall. Here are the results of testing the latest
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2977
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3693/
###
## LAST 60 LINES OF THE CONSOLE
###
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-2977:
--
Labels: pull-request-available (was: )
> Concurrency for addAuth corrupts quorum
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Can we move on?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3000:
--
Labels: pull-request-available (was: )
> Use error-prone compiler
>
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/490
@leventov Can we move on?
---
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1000/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 62.02 KB...]
[junit] Tests run: 1, Failures:
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/530#discussion_r194383541
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1218,6 +1294,79 @@ public ZooKeeper(String connectString, int
sessionTimeout, Watcher
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194378274
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,64 +18,119 @@
package org.apache.zookeeper.common;
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194372536
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -292,8 +298,20 @@ protected void connectToLeader(InetSocketAddress addr,
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194371329
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -632,37 +639,46 @@ synchronized private boolean connectOne(long
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194369924
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194368166
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194366505
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194365408
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194365379
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,144 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r194365328
--- Diff: src/java/main/org/apache/zookeeper/common/ClientX509Util.java ---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation
Hi team,
Just a quick heads-up that we need your feedback in this doc even if it's
only +1 would be appreciated.
Please share your thoughts.
Thanks,
Andor
On Tue, May 29, 2018 at 4:16 PM, Norbert Kalmar
wrote:
> Sorry, one important clarification: These are not decided yet, in the
>
Thanks everyone!!
On Fri, Jun 8, 2018 at 11:44 PM, Michael Han wrote:
> Congrats Andor, welcome aboard, and keep up the good work!
>
> On Fri, Jun 8, 2018 at 1:38 PM, Tamas Penzes wrote:
>
> > Congrats Andor, well deserved!
> >
> > On Fri, Jun 8, 2018 at 3:48 PM Patrick Hunt wrote:
> >
> > >
66 matches
Mail list logo
