Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/605#discussion_r215849976
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java
---
@@ -0,0 +1,254 @@
+/**
+ * Licensed to the Apache
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/184
@hanm Sure thing. If you look back the comment history, you'll see that he
had a lot of comments, suggestions which I addressed and discussed. This PR is
now basically a joint effort of @afine
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606682#comment-16606682
]
Hadoop QA commented on ZOOKEEPER-2977:
--
-1 overall. Here are the results of testing the latest
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Are you still working on this?
or someone else can pick up this?
---
waiting for the release of branch3.5 at end of this year!(grin)
- 原始邮件 -
发件人：Michael Han
收件人：DevZooKeeper
主题：Re: Re: ZooKeeper 3.5 blocker issues
日期：2018年09月07日 09点24分
I haven't went through the entire list, but looks like lots of the JIRA
issues listed in this thread, such as
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606636#comment-16606636
]
Hudson commented on ZOOKEEPER-3131:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #180 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606637#comment-16606637
]
Hudson commented on ZOOKEEPER-3136:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #180 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606608#comment-16606608
]
Michael Han commented on ZOOKEEPER-3129:
I think it's a good ida. I am leaning towards using
I haven't went through the entire list, but looks like lots of the JIRA
issues listed in this thread, such as ZOOKEEPER-1549, 2846, also affects
3.4 releases. Should we scope these issues out?
I think historically the single outstanding blocking issue for a stable 3.5
release is the reconfig
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/184
Sorry for lag, I am resuming my review on this.
On a side note - I remember @ivmaykov mentioned to me offline that he made
a couple of security improvements (related to port unification
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/614
merged to master, thanks @eolivelli
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3136.
Resolution: Fixed
Issue resolved by pull request 614
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/614
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/611
#612 is now merged. @wangchaod Do you know what was the root cause of your
OOM issue? Were you using Netty instead of NIO? Would #612 fix your case? I am
curious if #612 does not fix your case
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606573#comment-16606573
]
Hadoop QA commented on ZOOKEEPER-3124:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3131.
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 612
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/612
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/612
I just triggered a build through "Rebuild", it's passing. So I am
committing this patch.
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2130/
I am not sure why the
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/545
I suggest we move test refactoring part of this patch to a separate JIRA /
PR. My main concern is mix these will create confusions for those who check the
commit history of this patch and wondering
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3124:
--
Description:
The old comment about setCversionPzxid is not valid, the scenario it
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3124:
--
Summary: Add the correct comment to show why we need the special logic to
handle cversion
Github user suyogmapara commented on the issue:
https://github.com/apache/zookeeper/pull/567
Hi @maoling
I tested the patch with following parameters:
1. PreAllocSize = 100 KB, TxnLogSizeLimit = 200 KB, 100 transactions of
little over 10 KBs. Outcome: 5
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606361#comment-16606361
]
Hadoop QA commented on ZOOKEEPER-2261:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606346#comment-16606346
]
Hadoop QA commented on ZOOKEEPER-2261:
--
+1 overall. GitHub Pull Request Build
+1
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/545
@hanm @enixon Back to the roots: created separate getter for the secure
server cnxn factory and fixed the logic of Cons command handler.
Additionally some unit test refactor (move
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606331#comment-16606331
]
Hadoop QA commented on ZOOKEEPER-2261:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606226#comment-16606226
]
Hadoop QA commented on ZOOKEEPER-3124:
--
+1 overall. GitHub Pull Request Build
+1
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/612
Thanks @hanm @anmolnar, I like the "Rebuild" button, it's more convenient
than check out the branch (maybe you're working on other branch and need to
stash), do amend, and force push.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv reopened ZOOKEEPER-3124:
---
> Update the comment of special logic to handle cversion and pzxid in
> DataTree.processTxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv updated ZOOKEEPER-3124:
--
Summary: Update the comment of special logic to handle cversion and pzxid
in
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/610
I forgot but actually I think I've considered the children of children case
when I created this diff, it actually won't cause the cversion and pzxid
mismatch issue.
The tricky scenario
GitHub user lvfangmin reopened a pull request:
https://github.com/apache/zookeeper/pull/610
[ZOOKEEPER-3124] Remove special logic to handle cversion and pzxid in
DataTree.processTxn
There is special logic in the DataTree.processTxn to handle the NODEEXISTS
when createNode, which
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/530
@timothyjward Okay, I hear you.
I'll check the Jira, because I think this should go to master too and
commit soon.
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/605#discussion_r215614171
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java
---
@@ -0,0 +1,254 @@
+/**
+ * Licensed to the Apache
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/590
systest will go to src/test/java , from my side, you can put the bench in
org.apache.zookeeper.test.system . Thinking about it, that's a pretty good
place.
No need to create main
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/530
@timothyjward
Some inspirations can be found at the
[old-patch](https://issues.apache.org/jira/secure/attachment/12822755/ZOOKEEPER-2474-01.patch).
This patch LGTM and I had tested it.
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/613
@anmolnar
Yes,I will try to transport this improment to `TxnLogToolkit`.
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605500#comment-16605500
]
Hadoop QA commented on ZOOKEEPER-2474:
--
-1 overall. Here are the results of testing the latest
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/613
@maoling I intended to create TxnLogToolkit as a replacement for
LogFormatter with some extra functionality. Do you mind checking that tool as
well and see that this patch could be easily
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/530
I'm still not sure what additional testing is possible. The way the patch
is constructed the changed code (all three lines of it) is already exercised by
the existing ZooKeeper tests. The
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/612
I usually amend the latest commit and do a force push.
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/530
@timothyjward Are you still working on this?
Or could someone else pick up this?
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fangmin Lv resolved ZOOKEEPER-3124.
---
Resolution: Won't Do
After revisiting the logic, I found it's not possible that the
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/610
After revisiting the logic, I found it's not possible that the direct
children is being creating and serialized after the parent is serialized, but
the children of children might be added
Github user lvfangmin closed the pull request at:
https://github.com/apache/zookeeper/pull/610
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grzegorz Grzybek updated ZOOKEEPER-3138:
Component/s: security
leaderElection
> Potential race
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/587
@anmolnar rebased
the flaky test: `ClientPortBindTest.testBindByAddress` is not related
---
47 matches
Mail list logo
