Il gio 20 set 2018, 01:17 Michael Han ha scritto:
> We've seen lots of confusions recently around Jenkins pre-commit check
> status on github pull request as well as questions like how to trigger
> Jenkins job to get a green build. I added a section "Jenkins Pre-commit
> Check" to our wiki page
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/628#discussion_r219036460
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java ---
@@ -196,6 +224,10 @@ protected long getLastQueued() {
return
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/628#discussion_r219034842
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/DelayRequestProcessor.java ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software
We have a gitter chat room: https://gitter.im/apache/apache-zookeeper. We
also have https://zookeeper.apache.org/irc.html, which is less active these
days.
On Wed, Sep 19, 2018 at 8:09 PM, 岭秀 wrote:
> Slack.Hi zk guys:Do we hava a slack for communication?then we can have
> some talks except
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/633
I think github web interface does not support `--follow` at the moment,
unfortunately, but there is a chrome extension that seems working
Slack.Hi zk guys:Do we hava a slack for communication?then we can have some
talks except codes!
Best regards
maoling
Beijing,China
Github user nkalmar commented on the issue:
https://github.com/apache/zookeeper/pull/633
How can I do that? I tried a few things like git mv, but didn't work either.
As far as I know, this is how git works unfortunately. But it did not loose
the history, it's just that git is
See https://builds.apache.org/job/ZooKeeper-trunk/197/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 146.40 KB...]
[junit] Tests run: 1, Failures: 0,
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/633
Can we make sure to preserve the file commit history while moving these
files around? I noticed recently after `src/c` was moved the entire commit
history was lost. The commit history is a priceless
We've seen lots of confusions recently around Jenkins pre-commit check
status on github pull request as well as questions like how to trigger
Jenkins job to get a green build. I added a section "Jenkins Pre-commit
Check" to our wiki page about this matter:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han resolved ZOOKEEPER-3151.
Resolution: Workaround
Provided work around in
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/634
---
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/635
---
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2209/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.50 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621203#comment-16621203
]
Hadoop QA commented on ZOOKEEPER-3151:
--
+1 overall. GitHub Pull Request Build
+1
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/635
---
GitHub user hanm reopened a pull request:
https://github.com/apache/zookeeper/pull/635
ZOOKEEPER-3151: Test build bot 2. Don't merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-3151-2
Alternatively
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621156#comment-16621156
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2208/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 47.21 KB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621148#comment-16621148
]
Hadoop QA commented on ZOOKEEPER-3151:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2205/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.49 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621135#comment-16621135
]
Hadoop QA commented on ZOOKEEPER-3032:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2207/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 47.31 KB...]
[exec]
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2206/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.64 KB...]
[exec]
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2204/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.64 KB...]
[exec] Pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621115#comment-16621115
]
Hadoop QA commented on ZOOKEEPER-3151:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2202/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.62 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621110#comment-16621110
]
Hadoop QA commented on ZOOKEEPER-3151:
--
-1 overall. GitHub Pull Request Build
+1
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/635
ZOOKEEPER-3151: Test build bot 2. Don't merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-3151-2
Alternatively
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3151:
--
Labels: pull-request-available (was: )
> Jenkins github integration is broken if
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/634
ZOOKEEPER-3151: Test build bot 1. Don't merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-3151-1
Alternatively
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2200/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 6.65 KB...]
[exec] Pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3032:
--
Labels: pull-request-available (was: )
> Step 1.6 - Create zk-server maven
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/633
ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nkalmar/zookeeper ZOOKEEPER-3032
See https://builds.apache.org/job/ZooKeeper-trunk-windows-cmake/2943/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 9.74 KB...]
[ivy:retrieve] confs: [javacc]
Michael Han created ZOOKEEPER-3151:
--
Summary: Jenkins github integration is broken if retriggering the
precommit job through Jenkins admin web page.
Key: ZOOKEEPER-3151
URL:
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/623
The [job I triggered on Sep
14](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2168/)
actually succeeded. It's the github integration that's broken. I suspect it's
some
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620889#comment-16620889
]
Hadoop QA commented on ZOOKEEPER-1177:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2199/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 80.88 MB...]
[exec] +1
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/590
Rebased to resolve conflict. @anmolnar @hanm @maoling @nkalmar please
revisit this PR when you have time.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/610
With #622, we may actually not need the setCVersionPzxid logic anymore, any
opinions on this?
---
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/622#discussion_r218880876
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -1861,6 +1862,76 @@ public void
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/623
@hanm looks like the Jenkins job is pending there since you triggered it 5
days ago, it doesn't likely will be run, can you trigger it again?
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/605
@anmolnar after #631 being merged into 3.5, this patch can be cherry-picked
back to 3.5 without conflict, can you help cherry-pick it back?
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/631
Thanks @anmolnar, close after merged.
---
Github user lvfangmin closed the pull request at:
https://github.com/apache/zookeeper/pull/631
---
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620709#comment-16620709
]
Hadoop QA commented on ZOOKEEPER-2641:
--
-1 overall. GitHub Pull Request Build
+1
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2198/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 41.75 MB...]
[exec]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620512#comment-16620512
]
maoling commented on ZOOKEEPER-3139:
[~nitish.kulkarni] it may be a issue about your environment?
See https://builds.apache.org/job/ZooKeeper_branch34_openjdk8/60/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 16.83 KB...]
at
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1123/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 63.08 KB...]
[junit] Running
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620402#comment-16620402
]
Andor Molnar commented on ZOOKEEPER-3127:
-
[~lvfangmin] I'm sorry, I didn't notice your
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar updated ZOOKEEPER-3127:
Fix Version/s: 3.5.5
> Fixing potential data inconsistency due to update last
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/631
Merged to branch-3.5 Thanks @lvfangmin !
Please close this PR.
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/630#discussion_r218679868
--- Diff: src/java/test/org/apache/zookeeper/ZKUtilTest.java ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2197/
###
## LAST 60 LINES OF THE CONSOLE
###
[...truncated 81.55 MB...]
[exec] +1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620152#comment-16620152
]
Hadoop QA commented on ZOOKEEPER-3150:
--
+1 overall. GitHub Pull Request Build
+1
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/629#discussion_r218674973
--- Diff: src/java/test/org/apache/zookeeper/server/ServerStatsTest.java ---
@@ -61,7 +62,7 @@ public void testPacketsMetrics() {
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/629#discussion_r218676843
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -599,7 +599,7 @@ public void commandRun() {
}
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/629#discussion_r218676806
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -819,7 +819,7 @@ public void commandRun() {
}
Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/629#discussion_r218676907
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -35,7 +35,7 @@
private long totalLatency = 0;
private long
61 matches
Mail list logo
