Re: Test failure on branch-3.4 Java 11 build
Il giorno mer 20 feb 2019, 07:43 Andor Molnar ha scritto: > "That patch seems unrelated." - Why do you think that? > This one I mean https://github.com/apache/zookeeper/commit/e22883c6d2f6e9068e2105fc072d9b6a39ac9a2d It's about build.xml No change around network/jmx/java Enrico > > On Tue, Feb 19, 2019 at 10:30 PM Enrico Olivelli > wrote: > > > Can we read JMX beans without using the network ? > > > > Btw That patch seems unrelated. > > > > Enrico > > > > Il giorno mar 19 feb 2019, 22:26 Andor Molnár ha > > scritto: > > > > > The build was successful (red, but different error) on H31 again > without > > > any modification. > > > > > > Now what? :) > > > > > > > > > Andor > > > > > > > > > > > > > > > On 2/18/19 11:40, Andor Molnar wrote: > > > > Infra ticket raised: > > > > > > > > https://issues.apache.org/jira/browse/INFRA-17866 > > > > > > > > I'll continue with the release procedure, since the build works for > me > > > > locally. > > > > > > > > Andor > > > > > > > > > > > > > > > > On Mon, Feb 18, 2019 at 11:30 AM Andor Molnar > > > wrote: > > > > > > > >> Not my patch. Something has been misconfigured on H31: > > > >> > > > >> Build DurationAgent > > > >> Failed #231 1 hr 9 min H31 > > > >> Failed #230 1 hr 10 min H31 > > > >> Failed #229 1 hr 10 min H31 > > > >> Success #228 30 min H14 > > > >> Success #227 30 min H2 > > > >> Failed #226 1 hr 9 min H31 > > > >> Success #225 32 min H2 > > > >> Failed #224 31 min H39 > > > >> Success #223 42 min H31 > > > >> ... > > > >> > > > >> It worked with #223 on 9 Feb and failed with #226 on 12 Feb. > > > >> > > > >> Andor > > > >> > > > >> > > > >> > > > >> On Mon, Feb 18, 2019 at 11:20 AM Andor Molnar > > > wrote: > > > >> > > > >>> Hi team, > > > >>> > > > >>> I cannot repro the build error which has been happening since I > > applied > > > >>> the following patch: > > > >>> > > > >>> > > > > > > https://github.com/apache/zookeeper/commit/e22883c6d2f6e9068e2105fc072d9b6a39ac9a2d > > > >>> > > > >>> It should not have anything to do with testing and the error > message > > > >>> doesn't make sense to me either: > > > >>> > > > >>> java.rmi.ConnectException: Connection refused to host: > 67.195.81.178; > > > nested exception is: > > > >>> java.net.ConnectException: Connection refused (Connection > > refused) > > > >>> > > > >>> > > > >>> It looks like somehow related to JMX connection in the tearDown() > > > method > > > >>> of various tests. > > > >>> However, tests work just fine for me on my Mac and CentOS 7.5. > > > >>> > > > >>> Regards, > > > >>> Andor > > > >>> > > > >>> > > > >>> > > > >>> > > > > > >
Re: Test failure on branch-3.4 Java 11 build
"That patch seems unrelated." - Why do you think that? On Tue, Feb 19, 2019 at 10:30 PM Enrico Olivelli wrote: > Can we read JMX beans without using the network ? > > Btw That patch seems unrelated. > > Enrico > > Il giorno mar 19 feb 2019, 22:26 Andor Molnár ha > scritto: > > > The build was successful (red, but different error) on H31 again without > > any modification. > > > > Now what? :) > > > > > > Andor > > > > > > > > > > On 2/18/19 11:40, Andor Molnar wrote: > > > Infra ticket raised: > > > > > > https://issues.apache.org/jira/browse/INFRA-17866 > > > > > > I'll continue with the release procedure, since the build works for me > > > locally. > > > > > > Andor > > > > > > > > > > > > On Mon, Feb 18, 2019 at 11:30 AM Andor Molnar > > wrote: > > > > > >> Not my patch. Something has been misconfigured on H31: > > >> > > >> Build DurationAgent > > >> Failed #231 1 hr 9 min H31 > > >> Failed #230 1 hr 10 min H31 > > >> Failed #229 1 hr 10 min H31 > > >> Success #228 30 min H14 > > >> Success #227 30 min H2 > > >> Failed #226 1 hr 9 min H31 > > >> Success #225 32 min H2 > > >> Failed #224 31 min H39 > > >> Success #223 42 min H31 > > >> ... > > >> > > >> It worked with #223 on 9 Feb and failed with #226 on 12 Feb. > > >> > > >> Andor > > >> > > >> > > >> > > >> On Mon, Feb 18, 2019 at 11:20 AM Andor Molnar > > wrote: > > >> > > >>> Hi team, > > >>> > > >>> I cannot repro the build error which has been happening since I > applied > > >>> the following patch: > > >>> > > >>> > > > https://github.com/apache/zookeeper/commit/e22883c6d2f6e9068e2105fc072d9b6a39ac9a2d > > >>> > > >>> It should not have anything to do with testing and the error message > > >>> doesn't make sense to me either: > > >>> > > >>> java.rmi.ConnectException: Connection refused to host: 67.195.81.178; > > nested exception is: > > >>> java.net.ConnectException: Connection refused (Connection > refused) > > >>> > > >>> > > >>> It looks like somehow related to JMX connection in the tearDown() > > method > > >>> of various tests. > > >>> However, tests work just fine for me on my Mac and CentOS 7.5. > > >>> > > >>> Regards, > > >>> Andor > > >>> > > >>> > > >>> > > >>> > > >
[GitHub] maoling commented on issue #825: ZOOKEEPER-2474:add a way for client to reattach to a session when using ZKClientConfig
maoling commented on issue #825: ZOOKEEPER-2474:add a way for client to reattach to a session when using ZKClientConfig URL: https://github.com/apache/zookeeper/pull/825#issuecomment-465395210 @eolivelli Why the ` travis-ci ` always physiological disorder ？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maoling commented on a change in pull request #825: ZOOKEEPER-2474:add a way for client to reattach to a session when using ZKClientConfig
maoling commented on a change in pull request #825: ZOOKEEPER-2474:add a way
for client to reattach to a session when using ZKClientConfig
URL: https://github.com/apache/zookeeper/pull/825#discussion_r258311354
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java
##
@@ -1140,17 +1140,94 @@ public ZooKeeper(String connectString, int
sessionTimeout, Watcher watcher,
public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher,
long sessionId, byte[] sessionPasswd, boolean canBeReadOnly,
HostProvider aHostProvider) throws IOException {
-LOG.info("Initiating client connection, connectString=" + connectString
-+ " sessionTimeout=" + sessionTimeout
-+ " watcher=" + watcher
-+ " sessionId=" + Long.toHexString(sessionId)
-+ " sessionPasswd="
-+ (sessionPasswd == null ? "" : ""));
+ this(connectString, sessionTimeout, watcher, sessionId, sessionPasswd,
+ canBeReadOnly, aHostProvider, null);
+}
+
+/**
+ * To create a ZooKeeper client object, the application needs to pass a
+ * connection string containing a comma separated list of host:port pairs,
+ * each corresponding to a ZooKeeper server.
+ *
+ * Session establishment is asynchronous. This constructor will initiate
+ * connection to the server and return immediately - potentially (usually)
+ * before the session is fully established. The watcher argument specifies
+ * the watcher that will be notified of any changes in state. This
+ * notification can come at any point before or after the constructor call
+ * has returned.
+ *
+ * The instantiated ZooKeeper client object will pick an arbitrary server
+ * from the connectString and attempt to connect to it. If establishment of
+ * the connection fails, another server in the connect string will be tried
+ * (the order is non-deterministic, as we random shuffle the list), until a
+ * connection is established. The client will continue attempts until the
+ * session is explicitly closed (or the session is expired by the server).
+ *
+ * Added in 3.2.0: An optional "chroot" suffix may also be appended to the
+ * connection string. This will run the client commands while interpreting
+ * all paths relative to this root (similar to the unix chroot command).
+ *
+ * Use {@link #getSessionId} and {@link #getSessionPasswd} on an
established
+ * client connection, these values must be passed as sessionId and
+ * sessionPasswd respectively if reconnecting. Otherwise, if not
+ * reconnecting, use the other constructor which does not require these
+ * parameters.
+ *
+ * For backward compatibility, there is another version
+ * {@link #ZooKeeper(String, int, Watcher, long, byte[], boolean)} which
uses
+ * default {@link StaticHostProvider}
+ *
+ * @param connectString
+ *comma separated host:port pairs, each corresponding to a zk
+ *server. e.g. "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002"
+ *If the optional chroot suffix is used the example would look
+ *like: "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002/app/a"
+ *where the client would be rooted at "/app/a" and all paths
+ *would be relative to this root - ie getting/setting/etc...
+ *"/foo/bar" would result in operations being run on
+ *"/app/a/foo/bar" (from the server perspective).
+ * @param sessionTimeout
+ *session timeout in milliseconds
+ * @param watcher
+ *a watcher object which will be notified of state changes, may
+ *also be notified for node events
+ * @param sessionId
+ *specific session id to use if reconnecting
+ * @param sessionPasswd
+ *password for this session
+ * @param canBeReadOnly
+ *(added in 3.4) whether the created client is allowed to go to
+ *read-only mode in case of partitioning. Read-only mode
+ *basically means that if the client can't find any majority
+ *servers but there's partitioned server it could reach, it
+ *connects to one in read-only mode, i.e. read requests are
+ *allowed while write requests are not. It continues seeking
for
+ *majority in the background.
+ * @param aHostProvider
+ *use this as HostProvider to enable custom behaviour.
+ * @param clientConfig
+ *(added in 3.5.2) passing this conf object gives each client
the flexibility of
Review comment:
> nit:3.5.2, is should be 3.5.3
Look around the code in the `zookeeper.java`,all the info shows that the
clientConfig was added
[jira] [Updated] (ZOOKEEPER-3283) add the new doc:Clients.md
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3283: --- Summary: add the new doc:Clients.md (was: add the doc:) > add the new doc:Clients.md > -- > > Key: ZOOKEEPER-3283 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3283 > Project: ZooKeeper > Issue Type: Sub-task > Components: documentation >Reporter: maoling >Assignee: maoling >Priority: Major > > 1.2 write Clients[2.4], which includes the: > 1.2.1 C client > 1.2.2 zk-python, kazoo > 1.2.3 Curator etc... > look at an example from: https://redis.io/clients -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ArneBachmann closed pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts
ArneBachmann closed pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts URL: https://github.com/apache/zookeeper/pull/801 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ArneBachmann commented on a change in pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts
ArneBachmann commented on a change in pull request #801: Fix ZOOKEEPER-2625: Introduce explicit end-of-line setting for shell scripts URL: https://github.com/apache/zookeeper/pull/801#discussion_r258247554 ## File path: bin/.gitattributes ## @@ -0,0 +1 @@ +*.sh eol=lf Review comment: I don't think that's the issue here, but when I rechecked today, the line endings in the archive seem to match the respective OS's conventions. Probably the issue is gone, nobody else complained anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Test failure on branch-3.4 Java 11 build
Can we read JMX beans without using the network ? Btw That patch seems unrelated. Enrico Il giorno mar 19 feb 2019, 22:26 Andor Molnár ha scritto: > The build was successful (red, but different error) on H31 again without > any modification. > > Now what? :) > > > Andor > > > > > On 2/18/19 11:40, Andor Molnar wrote: > > Infra ticket raised: > > > > https://issues.apache.org/jira/browse/INFRA-17866 > > > > I'll continue with the release procedure, since the build works for me > > locally. > > > > Andor > > > > > > > > On Mon, Feb 18, 2019 at 11:30 AM Andor Molnar > wrote: > > > >> Not my patch. Something has been misconfigured on H31: > >> > >> Build DurationAgent > >> Failed #231 1 hr 9 min H31 > >> Failed #230 1 hr 10 min H31 > >> Failed #229 1 hr 10 min H31 > >> Success #228 30 min H14 > >> Success #227 30 min H2 > >> Failed #226 1 hr 9 min H31 > >> Success #225 32 min H2 > >> Failed #224 31 min H39 > >> Success #223 42 min H31 > >> ... > >> > >> It worked with #223 on 9 Feb and failed with #226 on 12 Feb. > >> > >> Andor > >> > >> > >> > >> On Mon, Feb 18, 2019 at 11:20 AM Andor Molnar > wrote: > >> > >>> Hi team, > >>> > >>> I cannot repro the build error which has been happening since I applied > >>> the following patch: > >>> > >>> > https://github.com/apache/zookeeper/commit/e22883c6d2f6e9068e2105fc072d9b6a39ac9a2d > >>> > >>> It should not have anything to do with testing and the error message > >>> doesn't make sense to me either: > >>> > >>> java.rmi.ConnectException: Connection refused to host: 67.195.81.178; > nested exception is: > >>> java.net.ConnectException: Connection refused (Connection refused) > >>> > >>> > >>> It looks like somehow related to JMX connection in the tearDown() > method > >>> of various tests. > >>> However, tests work just fine for me on my Mac and CentOS 7.5. > >>> > >>> Regards, > >>> Andor > >>> > >>> > >>> > >>> >
Re: Test failure on branch-3.4 Java 11 build
The build was successful (red, but different error) on H31 again without any modification. Now what? :) Andor On 2/18/19 11:40, Andor Molnar wrote: > Infra ticket raised: > > https://issues.apache.org/jira/browse/INFRA-17866 > > I'll continue with the release procedure, since the build works for me > locally. > > Andor > > > > On Mon, Feb 18, 2019 at 11:30 AM Andor Molnar wrote: > >> Not my patch. Something has been misconfigured on H31: >> >> Build DurationAgent >> Failed #231 1 hr 9 min H31 >> Failed #230 1 hr 10 min H31 >> Failed #229 1 hr 10 min H31 >> Success #228 30 min H14 >> Success #227 30 min H2 >> Failed #226 1 hr 9 min H31 >> Success #225 32 min H2 >> Failed #224 31 min H39 >> Success #223 42 min H31 >> ... >> >> It worked with #223 on 9 Feb and failed with #226 on 12 Feb. >> >> Andor >> >> >> >> On Mon, Feb 18, 2019 at 11:20 AM Andor Molnar wrote: >> >>> Hi team, >>> >>> I cannot repro the build error which has been happening since I applied >>> the following patch: >>> >>> https://github.com/apache/zookeeper/commit/e22883c6d2f6e9068e2105fc072d9b6a39ac9a2d >>> >>> It should not have anything to do with testing and the error message >>> doesn't make sense to me either: >>> >>> java.rmi.ConnectException: Connection refused to host: 67.195.81.178; >>> nested exception is: >>> java.net.ConnectException: Connection refused (Connection refused) >>> >>> >>> It looks like somehow related to JMX connection in the tearDown() method >>> of various tests. >>> However, tests work just fine for me on my Mac and CentOS 7.5. >>> >>> Regards, >>> Andor >>> >>> >>> >>>
[jira] [Commented] (ZOOKEEPER-3280) ClientCnxn xid rollover can break sessions
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772346#comment-16772346
]
Jonathan Park commented on ZOOKEEPER-3280:
--
I'm afraid I don't know enough to help out.
> ClientCnxn xid rollover can break sessions
> --
>
> Key: ZOOKEEPER-3280
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3280
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.4.6, 3.4.12
>Reporter: Jonathan Park
>Priority: Major
> Attachments: ZKOutOfOrder.java
>
>
>
> {code:java}
> 2019-02-15 13:40:21,471 [myid:] - DEBUG
> [main-SendThread(localhost:2181):ClientCnxn$SendThread@759] - Got auth
> sessionid:0x168f2c5e9c60017
> 2019-02-15 13:40:21,472 [myid:] - WARN
> [main-SendThread(localhost:2181):ClientCnxn$SendThread@1166] - Session
> 0x168f2c5e9c60017 for server localhost/0:0:0:0:0:0:0:1:2181, unexpected
> error, closing socket connection and attempting reconnect
> java.io.IOException: Xid out of order. Got Xid -3 with err 0 expected Xid -4
> for a packet with details: clientPath:null serverPath:null finished:false
> header:: -4,8 replyHeader:: 0,0,-4 request:: '/,F response:: v{}
> at
> org.apache.zookeeper.ClientCnxn$SendThread.readResponse(ClientCnxn.java:828)
> at org.apache.zookeeper.ClientCnxnSocketNIO.doIO(ClientCnxnSocketNIO.java:94)
> at
> org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:366)
> at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1143)
> 2019-02-15 13:40:22,520 [myid:] - INFO
> [main-SendThread(localhost:2181):ClientCnxn$SendThread@1027] - Opening socket
> connection to server localhost/127.0.0.1:2181. Will not attempt to
> authenticate using SASL (unknown error)
> 2019-02-15 13:40:22,521 [myid:] - INFO
> [main-SendThread(localhost:2181):ClientCnxn$SendThread@877] - Socket
> connection established to localhost/127.0.0.1:2181, initiating session
> 2019-02-15 13:40:22,521 [myid:] - DEBUG
> [main-SendThread(localhost:2181):ClientCnxn$SendThread@950] - Session
> establishment request sent on localhost/127.0.0.1:2181
> 2019-02-15 13:40:22,522 [myid:] - INFO
> [main-SendThread(localhost:2181):ClientCnxn$SendThread@1301] - Session
> establishment complete on server localhost/127.0.0.1:2181, sessionid =
> 0x168f2c5e9c60017, negotiated timeout = 3
> 2019-02-15 13:40:22,525 [myid:] - DEBUG
> [main-SendThread(localhost:2181):ClientCnxn$SendThread@742] - Got ping
> response for sessionid: 0x168f2c5e9c60017 after 235329552ms
> {code}
> ClientCnxn xid's are tracked as java int's. For long-lived ZK clients this
> can lead to rollover into the negative xid space. Xid = -4 is treated as a
> special xid reserved for auth requests. With xid rollover, a normal ZK
> request can also have xid = -4 but the response will be treated as an auth
> response making subsequent packet processing error with the exception above.
> We can reproduce this more readily by changing the starting xid in ClientCnxn
> from 1 to -100. The ZK client will transparently reconnect and establish a
> new session but features that depended on the same session persisting will
> unnecessarily experience a disconnected event.
>
> I've attached simple class with a main() method that reproduces the failure
> quickly against a local ZK server after modifying the initial value of
> ClientCnxn.xid from 1 to -100.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] joshelser commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba…
joshelser commented on issue #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba… URL: https://github.com/apache/zookeeper/pull/784#issuecomment-465258523 Thanks Andor! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-2122) Impplement SSL support in the Zookeeper C client library
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772049#comment-16772049 ] Sean March commented on ZOOKEEPER-2122: --- [~hanm], [~asamarna], [~rgs] is this patch for Windows likely to be available and reviewed soon? It's been four years since Ashish has posted this I'm guessing it has gotten lost? [~hanm], [~roodkcab], [~rgs] same question for shuoshi's SSL C Client Connect for Linux and MacOS? As [~ctr] and [~abuschka] have mentioned recently in ZOOKEEPER-2125 it would be good to have TLS fully working. And once working would it be possible to backport it to the current stable release? > Impplement SSL support in the Zookeeper C client library > > > Key: ZOOKEEPER-2122 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2122 > Project: ZooKeeper > Issue Type: Sub-task > Components: c client >Affects Versions: 3.5.0 >Reporter: Ashish Amarnath >Assignee: shuoshi >Priority: Trivial > Labels: build, pull-request-available, security > Fix For: 3.6.0, 3.5.5 > > Time Spent: 5h 40m > Remaining Estimate: 0h > > Implement SSL support in the Zookeeper C client library to work with the > secure server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar opened a new pull request #827: Fix package target: need to copy src/packages folder on 3.4
anmolnar opened a new pull request #827: Fix package target: need to copy src/packages folder on 3.4 URL: https://github.com/apache/zookeeper/pull/827 This was removed by mistake, but it's only needed on 3.4 On master and 3.5 we don't ship redhat/debian files anymore. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] anmolnar commented on issue #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol
anmolnar commented on issue #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol URL: https://github.com/apache/zookeeper/pull/826#issuecomment-465167154 @ivmaykov PTAL and let me know if there's anything else should be added here. I remember you implemented the support for non-JKS key- and truststore. If you can give me a short description on it, I will add it to the docs. Is there any other feature which should be covered here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-2750) Document SSL Support for Atomic Broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-2750: -- Labels: pull-request-available (was: ) > Document SSL Support for Atomic Broadcast protocol > -- > > Key: ZOOKEEPER-2750 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2750 > Project: ZooKeeper > Issue Type: Bug >Reporter: Abraham Fine >Assignee: Andor Molnar >Priority: Major > Labels: pull-request-available > Attachments: ZooKeeperSSLUserGuide.pdf > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar opened a new pull request #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol
anmolnar opened a new pull request #826: ZOOKEEPER-2750. Document SSL Support for Atomic Broadcast protocol URL: https://github.com/apache/zookeeper/pull/826 Patch is twofold: 1. Added documentation and guideline to enable Quorum TLS communication including management of certificates 2. Added extra logging intentionally at `info` level to support TLS-enabled clusters which hopefully makes the validation of secured communication a lot easier. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Apache ZooKeeper release 3.4.14 candidate 2
Thanks Andor! Unfortunately, I had a new issue when running bin-package. I had no issue with this file with the last RC. After copying the file, the ant target completes fine. I’m hesitant to give a +1 as someone might be using the target? I know we don’t, but it’s there. Signatures: OK ant package : OK ant bin-package - ERROR - src/packages/update-zookeeper-env.sh missing: The whole src/packages directory is missing from the src tar. I think these files are used to build linux packages. ant tar : OK Tests (test-core): OK So if we're OK shipping 3.4.14 without the packages file it's fine for me (although fixing the bin-package target would be still desirable I guess). 3.5 and master does not ship the packages. Regards, Norbert On Mon, Feb 18, 2019 at 4:00 PM Enrico Olivelli wrote: > great work Andor ! > > +1 (non binding) > - checked signatures and checsums (of the tarball and of the binaries > included) > - run java tests on jdk8 on Linux (Fedora 28), all is okay > - run "ant tar" and checked that the repackaged and compiled source are > working > > Enrico > > > Il giorno lun 18 feb 2019 alle ore 14:46 Andor Molnar > ha scritto: > > > > This is a bugfix release candidate for 3.4.14. It fixes 8 issues, mostly > build / unit tests issues, > > dependency updates flagged by OWASP, NPE and a name resolution problem. > Among these it also supports > > experimental Maven build and Markdown based documentation generation. > > > > The full release notes is available at: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343587 > > > > *** Please download, test and vote by February 24th 2019, 23:59 UTC+0. > *** > > > > Source files: > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.4.14-rc2/ > > > > Maven staging repo: > > > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.4.14/ > > > > The release candidate tag in git to be voted upon: release-3.4.14-rc2 > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > http://www.apache.org/dist/zookeeper/KEYS > > > > Should we release this candidate? > > > > Regards, > > Andor > > > > >
[GitHub] eolivelli commented on a change in pull request #825: ZOOKEEPER-2474:add a way for client to reattach to a session when using ZKClientConfig
eolivelli commented on a change in pull request #825: ZOOKEEPER-2474:add a way
for client to reattach to a session when using ZKClientConfig
URL: https://github.com/apache/zookeeper/pull/825#discussion_r258022324
##
File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java
##
@@ -1140,17 +1140,94 @@ public ZooKeeper(String connectString, int
sessionTimeout, Watcher watcher,
public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher,
long sessionId, byte[] sessionPasswd, boolean canBeReadOnly,
HostProvider aHostProvider) throws IOException {
-LOG.info("Initiating client connection, connectString=" + connectString
-+ " sessionTimeout=" + sessionTimeout
-+ " watcher=" + watcher
-+ " sessionId=" + Long.toHexString(sessionId)
-+ " sessionPasswd="
-+ (sessionPasswd == null ? "" : ""));
+ this(connectString, sessionTimeout, watcher, sessionId, sessionPasswd,
+ canBeReadOnly, aHostProvider, null);
+}
+
+/**
+ * To create a ZooKeeper client object, the application needs to pass a
+ * connection string containing a comma separated list of host:port pairs,
+ * each corresponding to a ZooKeeper server.
+ *
+ * Session establishment is asynchronous. This constructor will initiate
+ * connection to the server and return immediately - potentially (usually)
+ * before the session is fully established. The watcher argument specifies
+ * the watcher that will be notified of any changes in state. This
+ * notification can come at any point before or after the constructor call
+ * has returned.
+ *
+ * The instantiated ZooKeeper client object will pick an arbitrary server
+ * from the connectString and attempt to connect to it. If establishment of
+ * the connection fails, another server in the connect string will be tried
+ * (the order is non-deterministic, as we random shuffle the list), until a
+ * connection is established. The client will continue attempts until the
+ * session is explicitly closed (or the session is expired by the server).
+ *
+ * Added in 3.2.0: An optional "chroot" suffix may also be appended to the
+ * connection string. This will run the client commands while interpreting
+ * all paths relative to this root (similar to the unix chroot command).
+ *
+ * Use {@link #getSessionId} and {@link #getSessionPasswd} on an
established
+ * client connection, these values must be passed as sessionId and
+ * sessionPasswd respectively if reconnecting. Otherwise, if not
+ * reconnecting, use the other constructor which does not require these
+ * parameters.
+ *
+ * For backward compatibility, there is another version
+ * {@link #ZooKeeper(String, int, Watcher, long, byte[], boolean)} which
uses
+ * default {@link StaticHostProvider}
+ *
+ * @param connectString
+ *comma separated host:port pairs, each corresponding to a zk
+ *server. e.g. "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002"
+ *If the optional chroot suffix is used the example would look
+ *like: "127.0.0.1:3000,127.0.0.1:3001,127.0.0.1:3002/app/a"
+ *where the client would be rooted at "/app/a" and all paths
+ *would be relative to this root - ie getting/setting/etc...
+ *"/foo/bar" would result in operations being run on
+ *"/app/a/foo/bar" (from the server perspective).
+ * @param sessionTimeout
+ *session timeout in milliseconds
+ * @param watcher
+ *a watcher object which will be notified of state changes, may
+ *also be notified for node events
+ * @param sessionId
+ *specific session id to use if reconnecting
+ * @param sessionPasswd
+ *password for this session
+ * @param canBeReadOnly
+ *(added in 3.4) whether the created client is allowed to go to
+ *read-only mode in case of partitioning. Read-only mode
+ *basically means that if the client can't find any majority
+ *servers but there's partitioned server it could reach, it
+ *connects to one in read-only mode, i.e. read requests are
+ *allowed while write requests are not. It continues seeking
for
+ *majority in the background.
+ * @param aHostProvider
+ *use this as HostProvider to enable custom behaviour.
+ * @param clientConfig
+ *(added in 3.5.2) passing this conf object gives each client
the flexibility of
Review comment:
nit: 3.5.2, is should be 3.5.3
we could also add a @since 3.5.3 javadoc tag
[jira] [Assigned] (ZOOKEEPER-3259) create a separate document:client.md about the usage of the client.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling reassigned ZOOKEEPER-3259: -- Assignee: maoling > create a separate document:client.md about the usage of the client. > --- > > Key: ZOOKEEPER-3259 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3259 > Project: ZooKeeper > Issue Type: New Feature > Components: documentation >Reporter: maoling >Assignee: maoling >Priority: Major > > 1.1 write API[2.1], which includes the： > 1.1.1 original API Docs which is a Auto-generated java doc,just give a > link. > 1.1.2. Restful-api (the apis under the > /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3282) a big refactor for the documetations
maoling created ZOOKEEPER-3282: -- Summary: a big refactor for the documetations Key: ZOOKEEPER-3282 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3282 Project: ZooKeeper Issue Type: New Feature Components: documentation Reporter: maoling Assignee: maoling Hi guys: I'am working on doing a big refactor for the documetations.it aims to - 1.make a better reading experiences and help users know more about zookeeper quickly,as good as other projects' doc(e.g redis,hbase). - 2.have less changes to diff with the original docs as far as possible. - 3.solve the problem when we have some new features or improvements,but cannot find a good place to doc it. The new catalog may looks kile this: * is new one added. ** is the one to keep unchanged as far as possible. *** is the one modified. -- |---Overview |---Welcome ** [1.1] |---Overview ** [1.2] |---Getting Started ** [1.3] |---Release Notes ** [1.4] |---Developer |---API *** [2.1] |---Programmer's Guide ** [2.2] |---Recipes *** [2.3] |---Clients * [2.4] |---Use Cases * [2.5] |---Admin & Ops |---Administrator's Guide ** [3.1] |---Quota Guide ** [3.2] |---JMX ** [3.3] |---Observers Guide ** [3.4] |---Dynamic Reconfiguration ** [3.5] |---Zookeeper CLI * [3.6] |---Shell * [3.7] |---Configuration flags * [3.8] |---Troubleshooting & Tuning * [3.9] |---Contributor Guidelines |---General Guidelines * [4.1] |---ZooKeeper Internals ** [4.2] |---Miscellaneous |---Wiki ** [5.1] |---Mailing Lists ** [5.2] -- The Roadmap is: 1.(I pick up it : D) 1.1 write API[2.1], which includes the： 1.1.1 original API Docs which is a Auto-generated java doc,just give a link. 1.1.2. Restful-api (the apis under the /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources) 1.2 write Clients[2.4], which includes the: 1.2.1 C client 1.2.2 zk-python, kazoo 1.2.3 Curator etc... look at an example from: https://redis.io/clients # write Recipes[2.3], which includes the: - integrate "Java Example" and "Barrier and Queue Tutorial"(Since some bugs in the examples and they are obsolete，we may delete something) into it. - suggest users to use the recipes implements of Curator and link to the Curator's recipes doc. # write Zookeeper CLI[3.6], which includes the: - about how to use the zk command line interface [./zkCli.sh] e.g ls /; get ; rmr;create -e -p etc... - look at an example from redis: https://redis.io/topics/rediscli # write shell[3.7], which includes the: - list all usages of the shells under the zookeeper/bin. (e.g zkTxnLogToolkit.sh,zkCleanup.sh) # write Configuration flags[3.8], which includes the: - list all usages of configurations properties(e.g zookeeper.snapCount): - move the original Advanced Configuration part of zookeeperAdmin.md into it. look at an example from:https://coreos.com/etcd/docs/latest/op-guide/configuration.html # write Troubleshooting & Tuning[3.9], which includes the: - move the original "Gotchas: Common Problems and Troubleshooting" part of Administrator's Guide.md into it. - move the original "FAQ" into into it. - add some new contents （e.g https://www.yumpu.com/en/document/read/29574266/building-an-impenetrable-zookeeper-pdf-github）. look at an example from:https://redis.io/topics/problems https://coreos.com/etcd/docs/latest/tuning.html # write General Guidelines[4.1], which includes the: - move the original "Logging" part of ZooKeeper Internals into it as the logger specification. - write specifications about code, git commit messages,github PR etc ... look at an example from: http://hbase.apache.org/book.html#hbase.commit.msg.format # write Use Cases[2.5], which includes the: - just move the context from: https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy into it. - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb) -- BTW: - Any insights or suggestions are very welcomed.After the dicussions,I will create a series of tickets(An umbrella) - Since these works can be done parallelly, if you are interested in them, please don't hesitate,just assign to yourself, pick it up. (Notice: give me a ping to avoid the duplicated work). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3259) create a separate document:client.md about the usage of the client.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3259: --- Description: 1.1 write API[2.1], which includes the： 1.1.1 original API Docs which is a Auto-generated java doc,just give a link. 1.1.2. Restful-api (the apis under the /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources) was: * java client (the api in the zookeeper.java) * c client and restful api. > create a separate document:client.md about the usage of the client. > --- > > Key: ZOOKEEPER-3259 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3259 > Project: ZooKeeper > Issue Type: New Feature > Components: documentation >Reporter: maoling >Priority: Major > > 1.1 write API[2.1], which includes the： > 1.1.1 original API Docs which is a Auto-generated java doc,just give a > link. > 1.1.2. Restful-api (the apis under the > /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3282) a big refactor for the documetations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3282: --- Labels: newbie (was: ) > a big refactor for the documetations > > > Key: ZOOKEEPER-3282 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3282 > Project: ZooKeeper > Issue Type: New Feature > Components: documentation >Reporter: maoling >Assignee: maoling >Priority: Major > Labels: newbie > > Hi guys: > I'am working on doing a big refactor for the documetations.it aims to > - 1.make a better reading experiences and help users know more about > zookeeper quickly,as good as other projects' doc(e.g redis,hbase). > - 2.have less changes to diff with the original docs as far as possible. > - 3.solve the problem when we have some new features or improvements,but > cannot find a good place to doc it. > > The new catalog may looks kile this: > * is new one added. > ** is the one to keep unchanged as far as possible. > *** is the one modified. > -- > |---Overview > |---Welcome ** [1.1] > |---Overview ** [1.2] > |---Getting Started ** [1.3] > |---Release Notes ** [1.4] > |---Developer > |---API *** [2.1] > |---Programmer's Guide ** [2.2] > |---Recipes *** [2.3] > |---Clients * [2.4] > |---Use Cases * [2.5] > |---Admin & Ops > |---Administrator's Guide ** [3.1] > |---Quota Guide ** [3.2] > |---JMX ** [3.3] > |---Observers Guide ** [3.4] > |---Dynamic Reconfiguration ** [3.5] > |---Zookeeper CLI * [3.6] > |---Shell * [3.7] > |---Configuration flags * [3.8] > |---Troubleshooting & Tuning * [3.9] > |---Contributor Guidelines > |---General Guidelines * [4.1] > |---ZooKeeper Internals ** [4.2] > |---Miscellaneous > |---Wiki ** [5.1] > |---Mailing Lists ** [5.2] > -- > The Roadmap is: > 1.(I pick up it : D) > 1.1 write API[2.1], which includes the： > 1.1.1 original API Docs which is a Auto-generated java doc,just give a > link. > 1.1.2. Restful-api (the apis under the > /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources) > 1.2 write Clients[2.4], which includes the: > 1.2.1 C client > 1.2.2 zk-python, kazoo > 1.2.3 Curator etc... > look at an example from: https://redis.io/clients > # write Recipes[2.3], which includes the: > - integrate "Java Example" and "Barrier and Queue Tutorial"(Since some bugs > in the examples and they are obsolete，we may delete something) into it. > - suggest users to use the recipes implements of Curator and link to the > Curator's recipes doc. > > # write Zookeeper CLI[3.6], which includes the: > - about how to use the zk command line interface [./zkCli.sh] > e.g ls /; get ; rmr;create -e -p etc... > - look at an example from redis: https://redis.io/topics/rediscli > > # write shell[3.7], which includes the: > - list all usages of the shells under the zookeeper/bin. (e.g > zkTxnLogToolkit.sh,zkCleanup.sh) > > # write Configuration flags[3.8], which includes the: > - list all usages of configurations properties(e.g zookeeper.snapCount): > - move the original Advanced Configuration part of zookeeperAdmin.md into > it. > look at an example > from:https://coreos.com/etcd/docs/latest/op-guide/configuration.html > > # write Troubleshooting & Tuning[3.9], which includes the: > - move the original "Gotchas: Common Problems and Troubleshooting" part of > Administrator's Guide.md into it. > - move the original "FAQ" into into it. > - add some new contents （e.g > https://www.yumpu.com/en/document/read/29574266/building-an-impenetrable-zookeeper-pdf-github）. > look at an example from:https://redis.io/topics/problems > https://coreos.com/etcd/docs/latest/tuning.html > > # write General Guidelines[4.1], which includes the: > - move the original "Logging" part of ZooKeeper Internals into it as the > logger specification. > - write specifications about code, git commit messages,github PR etc ... > look at an example from: > http://hbase.apache.org/book.html#hbase.commit.msg.format > > # write Use Cases[2.5], which includes the: > - just move the context from: > https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy into it. > - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb) > > -- > BTW: > - Any insights or suggestions are very welcomed.After the dicussions,I will > create a series of tickets(An umbrella) > - Since these works can be done parallelly, if
[jira] [Updated] (ZOOKEEPER-3282) a big refactor for the documetations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] maoling updated ZOOKEEPER-3282: --- Labels: (was: newbie) > a big refactor for the documetations > > > Key: ZOOKEEPER-3282 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3282 > Project: ZooKeeper > Issue Type: New Feature > Components: documentation >Reporter: maoling >Assignee: maoling >Priority: Major > > Hi guys: > I'am working on doing a big refactor for the documetations.it aims to > - 1.make a better reading experiences and help users know more about > zookeeper quickly,as good as other projects' doc(e.g redis,hbase). > - 2.have less changes to diff with the original docs as far as possible. > - 3.solve the problem when we have some new features or improvements,but > cannot find a good place to doc it. > > The new catalog may looks kile this: > * is new one added. > ** is the one to keep unchanged as far as possible. > *** is the one modified. > -- > |---Overview > |---Welcome ** [1.1] > |---Overview ** [1.2] > |---Getting Started ** [1.3] > |---Release Notes ** [1.4] > |---Developer > |---API *** [2.1] > |---Programmer's Guide ** [2.2] > |---Recipes *** [2.3] > |---Clients * [2.4] > |---Use Cases * [2.5] > |---Admin & Ops > |---Administrator's Guide ** [3.1] > |---Quota Guide ** [3.2] > |---JMX ** [3.3] > |---Observers Guide ** [3.4] > |---Dynamic Reconfiguration ** [3.5] > |---Zookeeper CLI * [3.6] > |---Shell * [3.7] > |---Configuration flags * [3.8] > |---Troubleshooting & Tuning * [3.9] > |---Contributor Guidelines > |---General Guidelines * [4.1] > |---ZooKeeper Internals ** [4.2] > |---Miscellaneous > |---Wiki ** [5.1] > |---Mailing Lists ** [5.2] > -- > The Roadmap is: > 1.(I pick up it : D) > 1.1 write API[2.1], which includes the： > 1.1.1 original API Docs which is a Auto-generated java doc,just give a > link. > 1.1.2. Restful-api (the apis under the > /zookeeper-contrib-rest/src/main/java/org/apache/zookeeper/server/jersey/resources) > 1.2 write Clients[2.4], which includes the: > 1.2.1 C client > 1.2.2 zk-python, kazoo > 1.2.3 Curator etc... > look at an example from: https://redis.io/clients > # write Recipes[2.3], which includes the: > - integrate "Java Example" and "Barrier and Queue Tutorial"(Since some bugs > in the examples and they are obsolete，we may delete something) into it. > - suggest users to use the recipes implements of Curator and link to the > Curator's recipes doc. > > # write Zookeeper CLI[3.6], which includes the: > - about how to use the zk command line interface [./zkCli.sh] > e.g ls /; get ; rmr;create -e -p etc... > - look at an example from redis: https://redis.io/topics/rediscli > > # write shell[3.7], which includes the: > - list all usages of the shells under the zookeeper/bin. (e.g > zkTxnLogToolkit.sh,zkCleanup.sh) > > # write Configuration flags[3.8], which includes the: > - list all usages of configurations properties(e.g zookeeper.snapCount): > - move the original Advanced Configuration part of zookeeperAdmin.md into > it. > look at an example > from:https://coreos.com/etcd/docs/latest/op-guide/configuration.html > > # write Troubleshooting & Tuning[3.9], which includes the: > - move the original "Gotchas: Common Problems and Troubleshooting" part of > Administrator's Guide.md into it. > - move the original "FAQ" into into it. > - add some new contents （e.g > https://www.yumpu.com/en/document/read/29574266/building-an-impenetrable-zookeeper-pdf-github）. > look at an example from:https://redis.io/topics/problems > https://coreos.com/etcd/docs/latest/tuning.html > > # write General Guidelines[4.1], which includes the: > - move the original "Logging" part of ZooKeeper Internals into it as the > logger specification. > - write specifications about code, git commit messages,github PR etc ... > look at an example from: > http://hbase.apache.org/book.html#hbase.commit.msg.format > > # write Use Cases[2.5], which includes the: > - just move the context from: > https://cwiki.apache.org/confluence/display/ZOOKEEPER/PoweredBy into it. > - add some new contents.(e.g Apache Projects:Spark;Companies:twitter,fb) > > -- > BTW: > - Any insights or suggestions are very welcomed.After the dicussions,I will > create a series of tickets(An umbrella) > - Since these works can be done parallelly, if you are interested in them,
[jira] [Created] (ZOOKEEPER-3283) add the doc:
maoling created ZOOKEEPER-3283: -- Summary: add the doc: Key: ZOOKEEPER-3283 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3283 Project: ZooKeeper Issue Type: Sub-task Components: documentation Reporter: maoling Assignee: maoling 1.2 write Clients[2.4], which includes the: 1.2.1 C client 1.2.2 zk-python, kazoo 1.2.3 Curator etc... look at an example from: https://redis.io/clients -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-2572) Potential resource leak in FileTxnLog.truncate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
maoling reassigned ZOOKEEPER-2572:
--
Assignee: maoling (was: gaoshu)
> Potential resource leak in FileTxnLog.truncate
> --
>
> Key: ZOOKEEPER-2572
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2572
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.9, 3.5.2, 3.4.11
>Reporter: Michael Han
>Assignee: maoling
>Priority: Major
>
> In FileTxnLog.truncate, we have:
> {code}
> public boolean truncate(long zxid) throws IOException {
> FileTxnIterator itr = null;
> try {
> itr = new FileTxnIterator(this.logDir, zxid);
> PositionInputStream input = itr.inputStream;
> if(input == null) {
> throw new IOException("No log files found to truncate! This
> could " +
> "happen if you still have snapshots from an old setup
> or " +
> "log files were deleted accidentally or dataLogDir
> was changed in zoo.cfg.");
> }
> long pos = input.getPosition();
> // now, truncate at the current position
> RandomAccessFile raf=new RandomAccessFile(itr.logFile,"rw");
> raf.setLength(pos);
> raf.close();
> while(itr.goToNextLog()) {
> if (!itr.logFile.delete()) {
> LOG.warn("Unable to truncate {}", itr.logFile);
> }
> }
> } finally {
> close(itr);
> }
> return true;
> }
> {code}
> {{raf}} here can be potentially in a state of not closed after leaving the
> method, if there is an (IO) exception thrown from setLength.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] maoling opened a new pull request #825: ZOOKEEPER-2474:add a way for client to reattach to a session when using ZKClientConfig
maoling opened a new pull request #825: ZOOKEEPER-2474:add a way for client to reattach to a session when using ZKClientConfig URL: https://github.com/apache/zookeeper/pull/825 - Thanks the original work from [arshad.mohammad](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=arshad.mohammad) and [timothyjward](https://github.com/timothyjward). Plz call me code-carrier(:D). - more details in [ZOOKEEPER-2474](https://issues.apache.org/jira/browse/ZOOKEEPER-2474).if cannot backport to branch-3.5 successfully,I will give another hit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-1815) Tolerate incorrectly set system hostname in tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-1815: -- Labels: pull-request-available (was: ) > Tolerate incorrectly set system hostname in tests > - > > Key: ZOOKEEPER-1815 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1815 > Project: ZooKeeper > Issue Type: Improvement > Components: tests >Reporter: some one >Priority: Trivial > Labels: pull-request-available > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1815.patch, ZOOKEEPER-1815.patch, > ZOOKEEPER-1815.patch > > > A bunch of tests will fail with UnknownHostException errors when the hostname > is incorrectly set on the system that you are running tests on. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] anmolnar opened a new pull request #824: ZOOKEEPER-1815. Tolerate incorrectly set system hostname in tests (3.4)
anmolnar opened a new pull request #824: ZOOKEEPER-1815. Tolerate incorrectly set system hostname in tests (3.4) URL: https://github.com/apache/zookeeper/pull/824 Inspired by the following commit: https://github.com/apache/zookeeper/commit/23852655a6d41f675b8a9cca66387fca9bfe4e12 in order to fix build problems on H31 Jenkins slave. Infra reported that nothing has been changed in name resolution, but the patch still looks reasonable and hopefully fix the JMX connection problem. This "backport" is JMX-only and doesn't try to fully backport the original patch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] maoling closed pull request #667: ZOOKEEPER-3158:firstConnect.countDown() will not be executed where sendThread.primeConnection() has thrown an exception
maoling closed pull request #667: ZOOKEEPER-3158:firstConnect.countDown() will not be executed where sendThread.primeConnection() has thrown an exception URL: https://github.com/apache/zookeeper/pull/667 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
