[jira] [Commented] (ZOOKEEPER-3356) Request throttling in Netty is not working as expected and could cause direct buffer OOM issue
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814043#comment-16814043 ] Enrico Olivelli commented on ZOOKEEPER-3356: Can this be a blocker for 3.5.5?l as 'stable'? I think this affects 3.5.5 and not 3.5.4 > Request throttling in Netty is not working as expected and could cause direct > buffer OOM issue > --- > > Key: ZOOKEEPER-3356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3356 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.4, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Fix For: 3.6.0 > > > The current implementation of Netty enable/disable recv logic may cause the > direct buffer OOM because we may enable read a large chunk of packets and > disabled again after consuming a single ZK request. We have seen this problem > on prod occasionally. > > Need a more advanced flow control in Netty instead of using AUTO_READ. Have > improved it internally by enable/disable recv based on the queuedBuffer size, > will upstream this soon. > > With this implementation, the max Netty queued buffer size (direct memory > usage) will be 2 * recv_buffer size. It's not the per message size because in > epoll ET mode it will try to read until the socket is empty, and because of > SslHandler will trigger another read when it's not a full encrypt packet and > haven't issued any decrypt message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3352) Use LevelDB For Backend
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814023#comment-16814023 ] Michael Han commented on ZOOKEEPER-3352: I don't see an obvious gain of using a LSM tree backend just for snapshot and txn log. For zk clients, the read path will be served directly from memory (think zk data tree as a 'memtable' that never flushes); the write path is already sequential for both snapshot and txn log. Reading snapshot and txn log out of LSM tree instead of flat files might reduce recovery time, but I doubt the difference is substantial. That said, having a LSM tree backend and build the zk data tree on top of it will make it possible to store a much larger scale of data set per single node, as we will not store all data in memory only. > Use LevelDB For Backend > --- > > Key: ZOOKEEPER-3352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > Fix For: 4.0.0 > > > Use LevelDB for managing data stored in ZK (transaction logs and snapshots). > https://stackoverflow.com/questions/6779669/does-leveldb-support-java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] hanm commented on issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk
hanm commented on issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk URL: https://github.com/apache/zookeeper/pull/632#issuecomment-481520300 @lvfangmin sure, please take time to get this right. I'll help landing this once it's ready (and I understand the pain of rebasing such a big feature:) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-3314) Document the possibility of MultiCallback receiving a null pointer
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813930#comment-16813930
]
Hudson commented on ZOOKEEPER-3314:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See
[https://builds.apache.org/job/ZooKeeper-trunk/469/])
ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a (andor:
rev 9a7cebb96a8fe810fbeea18d911212076424feaa)
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java
> Document the possibility of MultiCallback receiving a null pointer
> --
>
> Key: ZOOKEEPER-3314
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3314
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 3.5.3,
> 3.4.11, 3.5.4, 3.4.12, 3.4.13
>Reporter: Steven McDonald
>Assignee: Steven McDonald
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments:
> 0001-Document-the-case-where-opResults-is-null-in-multi-c.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A {{MultiCallback}} can receive a null pointer on failure, rather than a list
> of {{org.apache.zookeeper.OpResult.ErrorResult}} as documented. This is
> evident from [the
> implementation|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java#L689].
> This causes NullPointerExceptions in Kafka 2.1.x (see
> [KAFKA-7898|https://issues.apache.org/jira/browse/KAFKA-7898]). Kafka 2.0.x
> does not use the async multi interface, and Kafka 2.2.x handles the null
> pointer case.
> However, this is enough of a hazard that it should be documented. I have a
> patch for that which I will try to attach in a moment (JIRA won't allow me to
> attach it now for some reason).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3335) Improve the usage of Collections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813931#comment-16813931 ] Hudson commented on ZOOKEEPER-3335: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See [https://builds.apache.org/job/ZooKeeper-trunk/469/]) ZOOKEEPER-3335: Improve the usage of Collections (andor: rev 57e8318bc98dd3563085e08b0fcfcbc6a1c5fbcc) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNIO.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java > Improve the usage of Collections > > > Key: ZOOKEEPER-3335 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3335 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h > Remaining Estimate: 0h > > bq. This class is likely to be faster than Stack when used as a stack, and > faster than LinkedList when used as a queue. > https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3122) Verify build after maven migration and the end artifact
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813928#comment-16813928 ] Hudson commented on ZOOKEEPER-3122: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See [https://builds.apache.org/job/ZooKeeper-trunk/469/]) ZOOKEEPER-3122: fix files included in tarballs (andor: rev 1e8286faed13e8d8abb2d5205f99440853e4b47d) * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml * (edit) zookeeper-assembly/src/main/assembly/source-package.xml ZOOKEEPER-3122: add missing pom to source tarball (andor: rev 915c6acaea3f5c01d26f0bff93d1897a4da3e32c) * (edit) zookeeper-assembly/src/main/assembly/source-package.xml > Verify build after maven migration and the end artifact > --- > > Key: ZOOKEEPER-3122 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3122 > Project: ZooKeeper > Issue Type: Sub-task > Components: build, scripts >Affects Versions: 3.6.0 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Fix For: 3.4.14 > > Time Spent: 11.5h > Remaining Estimate: 0h > > Verify maven build works as expected, scripts (release, precommit, jenkins, > reports etc) work with maven. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
ZooKeeper-trunk - Build # 469 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/469/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 187.23 KB...] [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.713 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StatTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.236 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1 [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.692 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.063 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.982 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.708 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest [junit] Running org.apache.zookeeper.test.TruncateTest in thread 4 [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 1 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.982 sec, Thread: 4, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 4 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.076 sec, Thread: 4, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 4 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.144 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 4 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.696 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 1 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec, Thread: 1, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 1 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.961 sec, Thread: 1, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.794 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Running org.apache.zookeeper.util.PemReaderTest in thread 1 [junit] Tests run: 64, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.65 sec, Thread: 1, Class: org.apache.zookeeper.util.PemReaderTest [junit] Running org.apache.jute.BinaryInputArchiveTest in thread 1 [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.156 sec, Thread: 1, Class: org.apache.jute.BinaryInputArchiveTest [junit] Running org.apache.jute.UtilsTest in thread 1 [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.084 sec, Thread: 1, Class: org.apache.jute.UtilsTest [junit] Running org.apache.jute.XmlInputArchiveTest in thread 1 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.172 sec, Thread: 1, Class: org.apache.jute.XmlInputArchiveTest [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.048 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherTest [junit] Tests run: 108, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 351.671 sec, Thread: 2, Class: org.apache.zookeeper.test.NioNettySuiteTest [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 254.283 sec, Thread: 3, Class: org.apache.zookeeper.test.ReconfigTest fail.build.on.test.failure: BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1487: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1340: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/build.xml:1344: Tests failed! Total time: 18 minutes 38 seconds Build step 'Execute shell' marked build as failure [FINDBUGS] Skipping publisher since build result is FAILURE [WARNINGS]
[jira] [Commented] (ZOOKEEPER-3341) Remove Superfluous ByteBuffer Duplicate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813932#comment-16813932
]
Hudson commented on ZOOKEEPER-3341:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See
[https://builds.apache.org/job/ZooKeeper-trunk/469/])
ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate (andor: rev
6dc61adbe41c712fbce930e598b3556da54e0667)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
> Remove Superfluous ByteBuffer Duplicate
> ---
>
> Key: ZOOKEEPER-3341
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code:java|title=QuorumCnxManager.java}
> byte[] msgArray = new byte[length];
> din.readFully(msgArray, 0, length);
> ByteBuffer message = ByteBuffer.wrap(msgArray);
> addToRecvQueue(new Message(message.duplicate(), sid));
> {code}
> The {{message}} is being duplicated and the original is GC'ed. Just pass the
> {{message}}; do not bother with making a duplicate. I think this is a
> copy+paste bug.
> https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3302) ZooKeeper C client does not compile on Fedora 29
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813927#comment-16813927
]
Hudson commented on ZOOKEEPER-3302:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See
[https://builds.apache.org/job/ZooKeeper-trunk/469/])
ZOOKEEPER-3302: ZooKeeper C client does not compile on Fedora 29 (andor: rev
450869006e0f62790e974305eb079e1b0450dbfd)
* (edit) zookeeper-client/zookeeper-client-c/src/cli.c
> ZooKeeper C client does not compile on Fedora 29
> -
>
> Key: ZOOKEEPER-3302
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3302
> Project: ZooKeeper
> Issue Type: Wish
> Components: c client
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I cannot build current master (git sha
> 372e713a9d2d9264417313e5d68e9437ffddd0f5) with Fedora 29
>
> {noformat}
> gcc --version
> gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
> {noformat}
>
> This is the error:
> {code:java}
> [exec] gcc -DHAVE_CONFIG_H -I.
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/include
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/tests
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/generated
> -Wall -Werror -Wdeclaration-after-statement -fprofile-arcs -ftest-coverage
> -g -O2 -D_GNU_SOURCE -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test -f
> 'src/cli.c' || echo
> '/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/'`src/cli.c
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:
> In function ‘main’:
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:689:9:
> error: ‘strncpy’ specified bound 1024 equals destination size
> [-Werror=stringop-truncation]
> [exec] strncpy(cmd, argv[2]+4, sizeof(cmd));
> [exec] ^~~~
> [exec] cc1: all warnings being treated as errors
> [exec] make: *** [Makefile:1155: cli.o] Error 1{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2609) Add TTL Node APIs to C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813929#comment-16813929 ] Hudson commented on ZOOKEEPER-2609: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See [https://builds.apache.org/job/ZooKeeper-trunk/469/]) ZOOKEEPER-2609: Add TTL Node APIs to C client (andor: rev 3b93f7671464bef1824288b13ee66dec547bb97e) * (edit) zookeeper-client/zookeeper-client-c/src/zookeeper.c * (edit) zookeeper-client/zookeeper-client-c/include/zookeeper.h * (edit) zookeeper-client/zookeeper-client-c/tests/zkServer.sh * (edit) zookeeper-client/zookeeper-client-c/src/cli.c * (edit) zookeeper-client/zookeeper-client-c/tests/TestClient.cc * (edit) zookeeper-client/zookeeper-client-c/include/proto.h > Add TTL Node APIs to C client > - > > Key: ZOOKEEPER-2609 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2609 > Project: ZooKeeper > Issue Type: Sub-task > Components: c client, java client, jute, server >Reporter: Jordan Zimmerman >Assignee: Balazs Meszaros >Priority: Major > Labels: pull-request-available, ttl_nodes > Fix For: 3.6.0, 3.5.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Need to update the C lib to have the TTL node option -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3335) Improve the usage of Collections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813840#comment-16813840 ] Hudson commented on ZOOKEEPER-3335: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/]) ZOOKEEPER-3335: Improve the usage of Collections (andor: rev 57e8318bc98dd3563085e08b0fcfcbc6a1c5fbcc) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNIO.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java > Improve the usage of Collections > > > Key: ZOOKEEPER-3335 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3335 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h > Remaining Estimate: 0h > > bq. This class is likely to be faster than Stack when used as a stack, and > faster than LinkedList when used as a queue. > https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2609) Add TTL Node APIs to C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813838#comment-16813838 ] Hudson commented on ZOOKEEPER-2609: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/]) ZOOKEEPER-2609: Add TTL Node APIs to C client (andor: rev 3b93f7671464bef1824288b13ee66dec547bb97e) * (edit) zookeeper-client/zookeeper-client-c/src/zookeeper.c * (edit) zookeeper-client/zookeeper-client-c/tests/TestClient.cc * (edit) zookeeper-client/zookeeper-client-c/include/proto.h * (edit) zookeeper-client/zookeeper-client-c/include/zookeeper.h * (edit) zookeeper-client/zookeeper-client-c/src/cli.c * (edit) zookeeper-client/zookeeper-client-c/tests/zkServer.sh > Add TTL Node APIs to C client > - > > Key: ZOOKEEPER-2609 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2609 > Project: ZooKeeper > Issue Type: Sub-task > Components: c client, java client, jute, server >Reporter: Jordan Zimmerman >Assignee: Balazs Meszaros >Priority: Major > Labels: pull-request-available, ttl_nodes > Fix For: 3.6.0, 3.5.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Need to update the C lib to have the TTL node option -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3122) Verify build after maven migration and the end artifact
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813837#comment-16813837 ] Hudson commented on ZOOKEEPER-3122: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/]) ZOOKEEPER-3122: fix files included in tarballs (andor: rev 1e8286faed13e8d8abb2d5205f99440853e4b47d) * (edit) zookeeper-assembly/src/main/assembly/source-package.xml * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml ZOOKEEPER-3122: add missing pom to source tarball (andor: rev 915c6acaea3f5c01d26f0bff93d1897a4da3e32c) * (edit) zookeeper-assembly/src/main/assembly/source-package.xml > Verify build after maven migration and the end artifact > --- > > Key: ZOOKEEPER-3122 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3122 > Project: ZooKeeper > Issue Type: Sub-task > Components: build, scripts >Affects Versions: 3.6.0 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Fix For: 3.4.14 > > Time Spent: 11.5h > Remaining Estimate: 0h > > Verify maven build works as expected, scripts (release, precommit, jenkins, > reports etc) work with maven. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3314) Document the possibility of MultiCallback receiving a null pointer
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813839#comment-16813839
]
Hudson commented on ZOOKEEPER-3314:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/])
ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a (andor:
rev 9a7cebb96a8fe810fbeea18d911212076424feaa)
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java
> Document the possibility of MultiCallback receiving a null pointer
> --
>
> Key: ZOOKEEPER-3314
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3314
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 3.5.3,
> 3.4.11, 3.5.4, 3.4.12, 3.4.13
>Reporter: Steven McDonald
>Assignee: Steven McDonald
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments:
> 0001-Document-the-case-where-opResults-is-null-in-multi-c.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A {{MultiCallback}} can receive a null pointer on failure, rather than a list
> of {{org.apache.zookeeper.OpResult.ErrorResult}} as documented. This is
> evident from [the
> implementation|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java#L689].
> This causes NullPointerExceptions in Kafka 2.1.x (see
> [KAFKA-7898|https://issues.apache.org/jira/browse/KAFKA-7898]). Kafka 2.0.x
> does not use the async multi interface, and Kafka 2.2.x handles the null
> pointer case.
> However, this is enough of a hazard that it should be documented. I have a
> patch for that which I will try to attach in a moment (JIRA won't allow me to
> attach it now for some reason).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3341) Remove Superfluous ByteBuffer Duplicate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813841#comment-16813841
]
Hudson commented on ZOOKEEPER-3341:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/])
ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate (andor: rev
6dc61adbe41c712fbce930e598b3556da54e0667)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
> Remove Superfluous ByteBuffer Duplicate
> ---
>
> Key: ZOOKEEPER-3341
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code:java|title=QuorumCnxManager.java}
> byte[] msgArray = new byte[length];
> din.readFully(msgArray, 0, length);
> ByteBuffer message = ByteBuffer.wrap(msgArray);
> addToRecvQueue(new Message(message.duplicate(), sid));
> {code}
> The {{message}} is being duplicated and the original is GC'ed. Just pass the
> {{message}}; do not bother with making a duplicate. I think this is a
> copy+paste bug.
> https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3302) ZooKeeper C client does not compile on Fedora 29
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813836#comment-16813836
]
Hudson commented on ZOOKEEPER-3302:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/])
ZOOKEEPER-3302: ZooKeeper C client does not compile on Fedora 29 (andor: rev
450869006e0f62790e974305eb079e1b0450dbfd)
* (edit) zookeeper-client/zookeeper-client-c/src/cli.c
> ZooKeeper C client does not compile on Fedora 29
> -
>
> Key: ZOOKEEPER-3302
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3302
> Project: ZooKeeper
> Issue Type: Wish
> Components: c client
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I cannot build current master (git sha
> 372e713a9d2d9264417313e5d68e9437ffddd0f5) with Fedora 29
>
> {noformat}
> gcc --version
> gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
> {noformat}
>
> This is the error:
> {code:java}
> [exec] gcc -DHAVE_CONFIG_H -I.
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/include
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/tests
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/generated
> -Wall -Werror -Wdeclaration-after-statement -fprofile-arcs -ftest-coverage
> -g -O2 -D_GNU_SOURCE -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test -f
> 'src/cli.c' || echo
> '/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/'`src/cli.c
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:
> In function ‘main’:
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:689:9:
> error: ‘strncpy’ specified bound 1024 equals destination size
> [-Werror=stringop-truncation]
> [exec] strncpy(cmd, argv[2]+4, sizeof(cmd));
> [exec] ^~~~
> [exec] cc1: all warnings being treated as errors
> [exec] make: *** [Makefile:1155: cli.o] Error 1{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3352) Use LevelDB For Backend
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813824#comment-16813824
]
David Mollitor commented on ZOOKEEPER-3352:
---
Thanks Brian,
Interesting to note that:
{quote}It is built on earlier work on LevelDB
{quote}
> Use LevelDB For Backend
> ---
>
> Key: ZOOKEEPER-3352
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Fix For: 4.0.0
>
>
> Use LevelDB for managing data stored in ZK (transaction logs and snapshots).
> https://stackoverflow.com/questions/6779669/does-leveldb-support-java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [zookeeper] BELUGABEHR commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide
BELUGABEHR commented on issue #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide URL: https://github.com/apache/zookeeper/pull/903#issuecomment-481440784 I somehow don't think a doc change broke unit tests :) Please consider for inclusion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-3352) Use LevelDB For Backend
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813760#comment-16813760 ] Brian Nixon commented on ZOOKEEPER-3352: We've been curious whether wiring ZooKeeper on top of RocksDB could give similar performance benefits that Instagram saw with putting Apache Cassandra on top of RocksDB ([https://instagram-engineering.com/open-sourcing-a-10x-reduction-in-apache-cassandra-tail-latency-d64f86b43589] for some details). Something like this ticket that involves abstracting out the data storage components would be useful for us. > Use LevelDB For Backend > --- > > Key: ZOOKEEPER-3352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > Fix For: 4.0.0 > > > Use LevelDB for managing data stored in ZK (transaction logs and snapshots). > https://stackoverflow.com/questions/6779669/does-leveldb-support-java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3
Thanks Enrico for testing. I think both checks are valid and should be added to the release verification procedure. None of the issues are showstopper for the RC, but let's fix them to get a clean sheet. - Spotbugs issue can be ignored - null-check is valid when the version has qualifier: e.g. -SNAPSHOT, which is not the case for releases. - Rat check has found 27 files with missing license headers for me (attached). Let's add them to the exclusion list. Regards, Andor On 4/9/19 16:49, Enrico Olivelli wrote: > I am testing this RC, before casting my vote I would like to share > these problems, I am not sure they are blockers: > > 1) spotbugs is not passing (tested both with jdk11 and jdk8) > > mvn clean install -DskipTests spotbugs:check > > [INFO] --- spotbugs-maven-plugin:3.1.9:check (default-cli) @ zookeeper --- > [INFO] BugInstance size is 1 > [INFO] Error size is 0 > [INFO] Total bugs: 1 > [ERROR] Redundant nullcheck of > org.apache.zookeeper.version.Info.QUALIFIER which is known to be null > in org.apache.zookeeper.Version.getVersion() > [org.apache.zookeeper.Version] Redundant null check at > Version.java:[line 44] RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE > [INFO] > > 2) Apache RAT check is not passing > mvn clean apache-rat:check > > Those checks need to be added to the release procedure and in CI > checks (I have filed an issue yesterday to improve CI checks > https://issues.apache.org/jira/browse/ZOOKEEPER-3351) > > > Enrico > > Il giorno mar 9 apr 2019 alle ore 11:01 Andor Molnar > ha scritto: >> This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 >> issues, including Maven migration, Quorum TLS, TTL nodes and lots of other >> performance and stability improvements. >> >> The full release notes is available at: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 >> >> *** Please download, test and vote by April 16th 2019, 23:59 UTC+0. *** >> >> Source files: >> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc3/ >> >> Maven staging repos: >> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ >> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ >> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ >> >> The release candidate tag in git to be voted upon: release-3.5.5-rc3 >> >> ZooKeeper's KEYS file containing PGP keys we use to sign the release: >> http://www.apache.org/dist/zookeeper/KEYS >> >> Should we release this candidate? >> >> rat.txt.gz Description: application/gzip
[jira] [Updated] (ZOOKEEPER-3357) Remove Dead Link from ZooKeeper Programmer's Guide
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3357: -- Labels: pull-request-available (was: ) > Remove Dead Link from ZooKeeper Programmer's Guide > -- > > Key: ZOOKEEPER-3357 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3357 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.5.4, 3.6.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > > Remove dead link to _ZooKeeper Talk at the Hadoup Summit 2008_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] BELUGABEHR opened a new pull request #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide
BELUGABEHR opened a new pull request #903: ZOOKEEPER-3357: Remove Dead Link from ZooKeeper Programmer Guide URL: https://github.com/apache/zookeeper/pull/903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZOOKEEPER-3357) Remove Dead Link from ZooKeeper Programmer's Guide
David Mollitor created ZOOKEEPER-3357: - Summary: Remove Dead Link from ZooKeeper Programmer's Guide Key: ZOOKEEPER-3357 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3357 Project: ZooKeeper Issue Type: Improvement Components: documentation Affects Versions: 3.5.4, 3.6.0 Reporter: David Mollitor Assignee: David Mollitor Fix For: 3.6.0, 3.5.5 Remove dead link to _ZooKeeper Talk at the Hadoup Summit 2008_ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] lvfangmin commented on issue #848: ZOOKEEPER-3306: Fixing node not accessible issue due the inconsistent ACL reference map after SNAP sync
lvfangmin commented on issue #848: ZOOKEEPER-3306: Fixing node not accessible issue due the inconsistent ACL reference map after SNAP sync URL: https://github.com/apache/zookeeper/pull/848#issuecomment-481325274 @anmolnar it's here: https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java#L1290. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] lvfangmin commented on issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk
lvfangmin commented on issue #632: [ZOOKEEPER-3150] Add tree digest check and verify data integrity when loading from disk URL: https://github.com/apache/zookeeper/pull/632#issuecomment-481324731 @hanm thanks for coming back to this, I'll rebase this asap. But keep in mind, there are lots of changes recently (internally or externally), since digest feature touches a lot of codebase, the rebase won't be trivial, also it needs to be carefully tested again, so leave me some time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZOOKEEPER-3356) Request throttling in Netty is not working as expected and could cause direct buffer OOM issue
Fangmin Lv created ZOOKEEPER-3356: - Summary: Request throttling in Netty is not working as expected and could cause direct buffer OOM issue Key: ZOOKEEPER-3356 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3356 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.4, 3.6.0 Reporter: Fangmin Lv Assignee: Fangmin Lv Fix For: 3.6.0 The current implementation of Netty enable/disable recv logic may cause the direct buffer OOM because we may enable read a large chunk of packets and disabled again after consuming a single ZK request. We have seen this problem on prod occasionally. Need a more advanced flow control in Netty instead of using AUTO_READ. Have improved it internally by enable/disable recv based on the queuedBuffer size, will upstream this soon. With this implementation, the max Netty queued buffer size (direct memory usage) will be 2 * recv_buffer size. It's not the per message size because in epoll ET mode it will try to read until the socket is empty, and because of SslHandler will trigger another read when it's not a full encrypt packet and haven't issued any decrypt message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3355) Remove 'tbd' From Docs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ZOOKEEPER-3355: -- Labels: pull-request-available (was: ) > Remove 'tbd' From Docs > -- > > Key: ZOOKEEPER-3355 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3355 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Affects Versions: 3.5.4, 3.6.0 >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > > For years, there have been lots of 'tbd' recorded in the documentation. It > does not look very polished and there is no one working on these. I think > it's time to finally remove them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] BELUGABEHR opened a new pull request #902: ZOOKEEPER-3355: Remove 'tbd' From Docs
BELUGABEHR opened a new pull request #902: ZOOKEEPER-3355: Remove 'tbd' From Docs URL: https://github.com/apache/zookeeper/pull/902 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZOOKEEPER-3355) Remove 'tbd' From Docs
David Mollitor created ZOOKEEPER-3355: - Summary: Remove 'tbd' From Docs Key: ZOOKEEPER-3355 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3355 Project: ZooKeeper Issue Type: Improvement Components: documentation Affects Versions: 3.5.4, 3.6.0 Reporter: David Mollitor Assignee: David Mollitor Fix For: 3.6.0, 3.5.5 For years, there have been lots of 'tbd' recorded in the documentation. It does not look very polished and there is no one working on these. I think it's time to finally remove them. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 3
I am testing this RC, before casting my vote I would like to share these problems, I am not sure they are blockers: 1) spotbugs is not passing (tested both with jdk11 and jdk8) mvn clean install -DskipTests spotbugs:check [INFO] --- spotbugs-maven-plugin:3.1.9:check (default-cli) @ zookeeper --- [INFO] BugInstance size is 1 [INFO] Error size is 0 [INFO] Total bugs: 1 [ERROR] Redundant nullcheck of org.apache.zookeeper.version.Info.QUALIFIER which is known to be null in org.apache.zookeeper.Version.getVersion() [org.apache.zookeeper.Version] Redundant null check at Version.java:[line 44] RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE [INFO] 2) Apache RAT check is not passing mvn clean apache-rat:check Those checks need to be added to the release procedure and in CI checks (I have filed an issue yesterday to improve CI checks https://issues.apache.org/jira/browse/ZOOKEEPER-3351) Enrico Il giorno mar 9 apr 2019 alle ore 11:01 Andor Molnar ha scritto: > > This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 > issues, including Maven migration, Quorum TLS, TTL nodes and lots of other > performance and stability improvements. > > The full release notes is available at: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 > > *** Please download, test and vote by April 16th 2019, 23:59 UTC+0. *** > > Source files: > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc3/ > > Maven staging repos: > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ > https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ > > The release candidate tag in git to be voted upon: release-3.5.5-rc3 > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > http://www.apache.org/dist/zookeeper/KEYS > > Should we release this candidate? > >
[GitHub] [zookeeper] nkalmar closed pull request #901: Zookeeper 3037 - Add JVMPauseMonitor
nkalmar closed pull request #901: Zookeeper 3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #901: Zookeeper 3037 - Add JVMPauseMonitor
nkalmar commented on issue #901: Zookeeper 3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/901#issuecomment-481277867 Whops, ZooKeeperServerMainTest test is unfinished, closing PR for now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar opened a new pull request #901: Zookeeper 3037 - Add JVMPauseMonitor
nkalmar opened a new pull request #901: Zookeeper 3037 - Add JVMPauseMonitor URL: https://github.com/apache/zookeeper/pull/901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (ZOOKEEPER-3342) Use StandardCharsets
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor reassigned ZOOKEEPER-3342:
-
Assignee: David Mollitor
> Use StandardCharsets
>
>
> Key: ZOOKEEPER-3342
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3342
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {quote}
> Encodes this String into a sequence of bytes using the platform's default
> charset, storing the result into a new byte array. The behavior of this
> method when this string cannot be encoded in the default charset is
> unspecified.
> https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#getBytes--
> {quote}
> Since this is a distributed system, it is always possible that different
> nodes have different default charsets defined. I think it's most safe to
> specify it explicitly across all nodes for safety sake. You could for example
> see a situation where an upgrade JVM uses a different default and during a
> rolling upgrade of the JVM, different nodes now have a different default.
> * The default charset is usually "ISO-8859-1". UTF-8 covers more of our
> international friends.
> * Explicitly specifying the CharSet yields slight performance gains
> * Explicitly specifying the CharSet removes the need for try/catch blocks of
> UnsupportedEncodingException
> https://blog.codecentric.de/en/2014/04/faster-cleaner-code-since-java-7/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3339) Improve Debug and Trace Log Statements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor reassigned ZOOKEEPER-3339: - Assignee: David Mollitor > Improve Debug and Trace Log Statements > -- > > Key: ZOOKEEPER-3339 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3339 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > SLF4J supports an advanced feature called parameterized logging which can > significantly boost logging performance for disabled logging statement. > Review all logging and ensure that it adheres to parameterized logging. > https://www.slf4j.org/faq.html#logging_performance -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3338) Review of BufferStats Class
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor reassigned ZOOKEEPER-3338: - Assignee: David Mollitor > Review of BufferStats Class > --- > > Key: ZOOKEEPER-3338 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3338 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > * Faster to use StringBuilder than String Format > * Tidy up -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3352) Use LevelDB For Backend
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor reassigned ZOOKEEPER-3352: - Assignee: David Mollitor > Use LevelDB For Backend > --- > > Key: ZOOKEEPER-3352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Major > Fix For: 4.0.0 > > > Use LevelDB for managing data stored in ZK (transaction logs and snapshots). > https://stackoverflow.com/questions/6779669/does-leveldb-support-java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor reassigned ZOOKEEPER-3348: - Assignee: David Mollitor > Make TxnLog and TxnLog Iterator Closable > > > Key: ZOOKEEPER-3348 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3348 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > [https://docs.oracle.com/javase/7/docs/api/java/io/Closeable.html] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3347) Improve PathTrie Consistency
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor reassigned ZOOKEEPER-3347:
-
Assignee: David Mollitor
> Improve PathTrie Consistency
> -
>
> Key: ZOOKEEPER-3347
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3347
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There is a bunch of synchronization that occurs in the {{PathTrie}}. Each
> node in the tree requires a lock to view its children, so to traverse a tree
> that is 8 nodes deep, it is required to lock 8 different times. Also, I'm
> not really sure that the locking is consistent; a node deep in the tree can
> be negatively impacted by another thread deleting the node's parent at the
> same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3340) Improve Queue Usage in QuorumCnxManager.java
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor reassigned ZOOKEEPER-3340:
-
Assignee: David Mollitor
> Improve Queue Usage in QuorumCnxManager.java
>
>
> Key: ZOOKEEPER-3340
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3340
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> I was recently profiling a on a ZK Quorum Leader in a low-volume environment
> and noticed that most of its time was spent in
> {{QuorumCnxManager#RecvWorker}}. Nothing wrong with that, but it did draw my
> attention to it. I noticed that {{Queue}} interactions are a bit... verbose.
> I would like to propose that we streamline this area of the code.
>
> [https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1291-L1309]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3341) Remove Superfluous ByteBuffer Duplicate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3341.
-
Resolution: Fixed
Fix Version/s: (was: 3.5.6)
Issue resolved by pull request 881
[https://github.com/apache/zookeeper/pull/881]
> Remove Superfluous ByteBuffer Duplicate
> ---
>
> Key: ZOOKEEPER-3341
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code:java|title=QuorumCnxManager.java}
> byte[] msgArray = new byte[length];
> din.readFully(msgArray, 0, length);
> ByteBuffer message = ByteBuffer.wrap(msgArray);
> addToRecvQueue(new Message(message.duplicate(), sid));
> {code}
> The {{message}} is being duplicated and the original is GC'ed. Just pass the
> {{message}}; do not bother with making a duplicate. I think this is a
> copy+paste bug.
> https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [zookeeper] anmolnar commented on issue #881: ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate
anmolnar commented on issue #881: ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate URL: https://github.com/apache/zookeeper/pull/881#issuecomment-481267790 Committed to master branch. Thanks @BELUGABEHR ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #881: ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate
asfgit closed pull request #881: ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate URL: https://github.com/apache/zookeeper/pull/881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #884: ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer
anmolnar commented on issue #884: ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer URL: https://github.com/apache/zookeeper/pull/884#issuecomment-481262362 Committed to master branch. Thanks @stevenjm ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
ZooKeeper_branch35_jdk8 - Build # 1370 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1370/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 67.47 KB...] [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.149 sec, Thread: 3, Class: org.apache.zookeeper.test.SaslSuperUserTest [junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.479 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest [junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.783 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionInvalidationTest [junit] Running org.apache.zookeeper.test.SessionTest in thread 3 [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.092 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest [junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.148 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTimeoutTest [junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 3 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.101 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTrackerCheckTest [junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 3 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 74.663 sec, Thread: 1, Class: org.apache.zookeeper.test.RestoreCommittedLogTest [junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 82.705 sec, Thread: 2, Class: org.apache.zookeeper.test.RecoveryTest [junit] Running org.apache.zookeeper.test.StatTest in thread 2 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.763 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest [junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.187 sec, Thread: 2, Class: org.apache.zookeeper.test.StatTest [junit] Tests run: 26, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.948 sec, Thread: 1, Class: org.apache.zookeeper.test.StaticHostProviderTest [junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.069 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest [junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1 [junit] Running org.apache.zookeeper.test.TruncateTest in thread 2 [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.795 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest [junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in thread 1 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.164 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionUpgradeTest [junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.15 sec, Thread: 3, Class: org.apache.zookeeper.test.WatchedEventTest [junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 3 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.789 sec, Thread: 2, Class: org.apache.zookeeper.test.TruncateTest [junit] Running org.apache.zookeeper.test.WatcherTest in thread 2 [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.609 sec, Thread: 3, Class: org.apache.zookeeper.test.WatcherFuncTest [junit] Running org.apache.zookeeper.test.X509AuthTest in thread 3 [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.1 sec, Thread: 3, Class: org.apache.zookeeper.test.X509AuthTest [junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in thread 3 [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.365 sec, Thread: 1, Class: org.apache.zookeeper.test.WatchEventWhenAutoResetTest [junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1 [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 14.146 sec, Thread: 3, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.139 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest [junit] Running org.apache.zookeeper.util.PemReaderTest in thread 3 [junit] Running org.apache.jute.BinaryInputArchiveTest in thread 1
[jira] [Assigned] (ZOOKEEPER-3341) Remove Superfluous ByteBuffer Duplicate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar reassigned ZOOKEEPER-3341:
---
Assignee: David Mollitor
> Remove Superfluous ByteBuffer Duplicate
> ---
>
> Key: ZOOKEEPER-3341
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code:java|title=QuorumCnxManager.java}
> byte[] msgArray = new byte[length];
> din.readFully(msgArray, 0, length);
> ByteBuffer message = ByteBuffer.wrap(msgArray);
> addToRecvQueue(new Message(message.duplicate(), sid));
> {code}
> The {{message}} is being duplicated and the original is GC'ed. Just pass the
> {{message}}; do not bother with making a duplicate. I think this is a
> copy+paste bug.
> https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3335) Improve the usage of Collections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar resolved ZOOKEEPER-3335. - Resolution: Fixed Issue resolved by pull request 870 [https://github.com/apache/zookeeper/pull/870] > Improve the usage of Collections > > > Key: ZOOKEEPER-3335 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3335 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > bq. This class is likely to be faster than Stack when used as a stack, and > faster than LinkedList when used as a queue. > https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3335) Improve the usage of Collections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andor Molnar reassigned ZOOKEEPER-3335: --- Assignee: David Mollitor > Improve the usage of Collections > > > Key: ZOOKEEPER-3335 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3335 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > bq. This class is likely to be faster than Stack when used as a stack, and > faster than LinkedList when used as a queue. > https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [zookeeper] anmolnar commented on issue #870: ZOOKEEPER-3335: Improve the usage of Collections
anmolnar commented on issue #870: ZOOKEEPER-3335: Improve the usage of Collections URL: https://github.com/apache/zookeeper/pull/870#issuecomment-481254980 Committed to master branch. Thanks @BELUGABEHR ! (I added you to contributors list in Jira, so from now on you can be assigned to Jira tickets.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #870: ZOOKEEPER-3335: Improve the usage of Collections
asfgit closed pull request #870: ZOOKEEPER-3335: Improve the usage of Collections URL: https://github.com/apache/zookeeper/pull/870 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ZOOKEEPER-3352) Use LevelDB For Backend
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated ZOOKEEPER-3352: -- Priority: Major (was: Critical) > Use LevelDB For Backend > --- > > Key: ZOOKEEPER-3352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Priority: Major > Fix For: 4.0.0 > > > Use LevelDB for managing data stored in ZK (transaction logs and snapshots). > https://stackoverflow.com/questions/6779669/does-leveldb-support-java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3352) Use LevelDB For Backend
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mollitor updated ZOOKEEPER-3352: -- Fix Version/s: 4.0.0 Description: Use LevelDB for managing data stored in ZK (transaction logs and snapshots). https://stackoverflow.com/questions/6779669/does-leveldb-support-java was: Use LevelDB for managing data stored in ZK (transaction logs and snapshots). https://stackoverflow.com/questions/6779669/does-leveldb-support-java Target 2.0 > Use LevelDB For Backend > --- > > Key: ZOOKEEPER-3352 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3352 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Priority: Critical > Fix For: 4.0.0 > > > Use LevelDB for managing data stored in ZK (transaction logs and snapshots). > https://stackoverflow.com/questions/6779669/does-leveldb-support-java -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-102) Need to replace Jute with supported code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813362#comment-16813362 ] David Mollitor commented on ZOOKEEPER-102: -- [~maoling] Instead of sinking even more time into jute, may I recommend that ZK simply replace the jute framework with something else? Protobufs is perhaps the best replacement, but ZK, being part of Apache, should probably use an Apache serialization library (eat Apache dog food / drink Apache champagne). * Apache Avro * Apache Thrift * Google Protobufs I have recently put some of my own time into improving Avro and Thrift. If you would like to improve performance of serialization, best that everyone focuses their energy on these libraries. > Need to replace Jute with supported code > > > Key: ZOOKEEPER-102 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-102 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Benjamin Reed >Priority: Major > Fix For: 4.0.0 > > > ZooKeeper currently uses Jute to serialize objects to put on the wire and on > disk. We pulled Jute out of Hadoop and added a C binding. Both versions of > Jute have evolved (although Hadoop still doesn't have a C binding). It would > be nice to use a more standard serialization library. Some options include > Thrift or Google's protocol buffers. > Our main requirements would be Java and C bindings and good performance. (For > example, serializing to XML would give us incredibly bad performance and > would not be acceptible!) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ZOOKEEPER-3314) Document the possibility of MultiCallback receiving a null pointer
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar reassigned ZOOKEEPER-3314:
---
Assignee: Steven McDonald
> Document the possibility of MultiCallback receiving a null pointer
> --
>
> Key: ZOOKEEPER-3314
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3314
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 3.5.3,
> 3.4.11, 3.5.4, 3.4.12, 3.4.13
>Reporter: Steven McDonald
>Assignee: Steven McDonald
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments:
> 0001-Document-the-case-where-opResults-is-null-in-multi-c.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A {{MultiCallback}} can receive a null pointer on failure, rather than a list
> of {{org.apache.zookeeper.OpResult.ErrorResult}} as documented. This is
> evident from [the
> implementation|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java#L689].
> This causes NullPointerExceptions in Kafka 2.1.x (see
> [KAFKA-7898|https://issues.apache.org/jira/browse/KAFKA-7898]). Kafka 2.0.x
> does not use the async multi interface, and Kafka 2.2.x handles the null
> pointer case.
> However, this is enough of a hazard that it should be documented. I have a
> patch for that which I will try to attach in a moment (JIRA won't allow me to
> attach it now for some reason).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [zookeeper] asfgit closed pull request #884: ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer
asfgit closed pull request #884: ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer URL: https://github.com/apache/zookeeper/pull/884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #330: ZOOKEEPER-2471: ZK Java client should not count sleep time as connect time
anmolnar commented on issue #330: ZOOKEEPER-2471: ZK Java client should not count sleep time as connect time URL: https://github.com/apache/zookeeper/pull/330#issuecomment-481232289 Thanks @hanm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar closed pull request #330: ZOOKEEPER-2471: ZK Java client should not count sleep time as connect time
anmolnar closed pull request #330: ZOOKEEPER-2471: ZK Java client should not count sleep time as connect time URL: https://github.com/apache/zookeeper/pull/330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-481222724 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed
maoling commented on issue #839: ZOOKEEPER-3290: Throw detailed KeeperException when a transaction failed URL: https://github.com/apache/zookeeper/pull/839#issuecomment-481222826 ping @anmolnar This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-102) Need to replace Jute with supported code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813299#comment-16813299 ] maoling commented on ZOOKEEPER-102: --- Let me revisit this issue. I will test the lasted the protobuf（[https://github.com/protocolbuffers/protobuf/releases/tag/v3.7.1)] to see how big is the gap. e.g pick one api(getData()) to change to protobuf to test. After testing,if the perfermance gap is obvious,we can absorb the experience from other serialization assembly to improve the existing jute to close them up. > Need to replace Jute with supported code > > > Key: ZOOKEEPER-102 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-102 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Benjamin Reed >Priority: Major > Fix For: 4.0.0 > > > ZooKeeper currently uses Jute to serialize objects to put on the wire and on > disk. We pulled Jute out of Hadoop and added a C binding. Both versions of > Jute have evolved (although Hadoop still doesn't have a C binding). It would > be nice to use a more standard serialization library. Some options include > Thrift or Google's protocol buffers. > Our main requirements would be Java and C bindings and good performance. (For > example, serializing to XML would give us incredibly bad performance and > would not be acceptible!) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813212#comment-16813212
]
maoling commented on ZOOKEEPER-3350:
*DATA_TREE_KEY*,*STANDALONE_SERVER_KEY* was never used any more.
Maybe we can do a refactor for this class.
give her a better name: JMXConstants.
remove the useless fields.
WDYT? [~Tison]
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Priority: Major
> Fix For: 3.5.5
>
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Maven migration - last steps - CI precommit advanced checks
Hi, we are going to release the first version of ZooKeeper with Maven in order to drop ant we have to drop the QA precommit job based on BASH + ANT. I have created a plan here https://issues.apache.org/jira/browse/ZOOKEEPER-3351 Please take a look. I will e happy to start sending patches as soon as I have a "sponsor" among committers/commnity. Regards Enrico
[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813193#comment-16813193
]
Norbert Kalmar commented on ZOOKEEPER-3337:
---
Sorry [~eolivelli], so it was totally the other way around as I said.
This can be changed, but as Andor mentioned, please create a PR Andrew.
I also forgot about this change before the current RC :(
> Maven build failed with user or group id is too big
>
>
> Key: ZOOKEEPER-3337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3337
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.13
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Attachments: ZOOKEEPER-3337-branch-3.4.patch
>
>
> Maven assembly plugin configuration must specify tarLongFileMode of "posix",
> not "gnu".
> Otherwise if the user or group id is too large the build will fail. For
> example:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single
> (source-package) on project zookeeper: Execution source-package of goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single failed: user id
> '1754762210'
> is too big ( > 2097151 ). -> [Help 1]
> {noformat}
> A very common problem, many other projects here have had to fix this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [zookeeper] anmolnar commented on issue #891: ZOOKEEPER-2609: Add TTL Node APIs to C client
anmolnar commented on issue #891: ZOOKEEPER-2609: Add TTL Node APIs to C client URL: https://github.com/apache/zookeeper/pull/891#issuecomment-481179422 Committed to master and 3.5 branches. Thanks @meszibalu ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813178#comment-16813178
]
Andor Molnar commented on ZOOKEEPER-3337:
-
[~apurtell] Please create pull request on GitHub.
> Maven build failed with user or group id is too big
>
>
> Key: ZOOKEEPER-3337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3337
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.13
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Attachments: ZOOKEEPER-3337-branch-3.4.patch
>
>
> Maven assembly plugin configuration must specify tarLongFileMode of "posix",
> not "gnu".
> Otherwise if the user or group id is too large the build will fail. For
> example:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single
> (source-package) on project zookeeper: Execution source-package of goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single failed: user id
> '1754762210'
> is too big ( > 2097151 ). -> [Help 1]
> {noformat}
> A very common problem, many other projects here have had to fix this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [zookeeper] asfgit closed pull request #891: ZOOKEEPER-2609: Add TTL Node APIs to C client
asfgit closed pull request #891: ZOOKEEPER-2609: Add TTL Node APIs to C client URL: https://github.com/apache/zookeeper/pull/891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[VOTE] Apache ZooKeeper release 3.5.5 candidate 3
This is the first stable release of 3.5 branch: 3.5.5. It resolves 117 issues, including Maven migration, Quorum TLS, TTL nodes and lots of other performance and stability improvements. The full release notes is available at: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12343268 *** Please download, test and vote by April 16th 2019, 23:59 UTC+0. *** Source files: https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc3/ Maven staging repos: https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/ https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/ https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/ The release candidate tag in git to be voted upon: release-3.5.5-rc3 ZooKeeper's KEYS file containing PGP keys we use to sign the release: http://www.apache.org/dist/zookeeper/KEYS Should we release this candidate?
[GitHub] [zookeeper] anmolnar commented on issue #900: ZOOKEEPER-3122 - add missing pom to source tarball
anmolnar commented on issue #900: ZOOKEEPER-3122 - add missing pom to source tarball URL: https://github.com/apache/zookeeper/pull/900#issuecomment-481159269 Committed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #900: ZOOKEEPER-3122 - add missing pom to source tarball
asfgit closed pull request #900: ZOOKEEPER-3122 - add missing pom to source tarball URL: https://github.com/apache/zookeeper/pull/900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] nkalmar opened a new pull request #900: ZOOKEEPER-3122 - add missing pom to source tarball
nkalmar opened a new pull request #900: ZOOKEEPER-3122 - add missing pom to source tarball URL: https://github.com/apache/zookeeper/pull/900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #897: ZOOKEEPER-3122 - fix files included in tarballs
anmolnar commented on issue #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897#issuecomment-481149494 Committed to master and 3.5 branches. Thanks @nkalmar ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #897: ZOOKEEPER-3122 - fix files included in tarballs
asfgit closed pull request #897: ZOOKEEPER-3122 - fix files included in tarballs URL: https://github.com/apache/zookeeper/pull/897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (ZOOKEEPER-3302) ZooKeeper C client does not compile on Fedora 29
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andor Molnar resolved ZOOKEEPER-3302.
-
Resolution: Fixed
Issue resolved by pull request 846
[https://github.com/apache/zookeeper/pull/846]
> ZooKeeper C client does not compile on Fedora 29
> -
>
> Key: ZOOKEEPER-3302
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3302
> Project: ZooKeeper
> Issue Type: Wish
> Components: c client
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> I cannot build current master (git sha
> 372e713a9d2d9264417313e5d68e9437ffddd0f5) with Fedora 29
>
> {noformat}
> gcc --version
> gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
> {noformat}
>
> This is the error:
> {code:java}
> [exec] gcc -DHAVE_CONFIG_H -I.
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/include
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/tests
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/generated
> -Wall -Werror -Wdeclaration-after-statement -fprofile-arcs -ftest-coverage
> -g -O2 -D_GNU_SOURCE -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test -f
> 'src/cli.c' || echo
> '/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/'`src/cli.c
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:
> In function ‘main’:
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:689:9:
> error: ‘strncpy’ specified bound 1024 equals destination size
> [-Werror=stringop-truncation]
> [exec] strncpy(cmd, argv[2]+4, sizeof(cmd));
> [exec] ^~~~
> [exec] cc1: all warnings being treated as errors
> [exec] make: *** [Makefile:1155: cli.o] Error 1{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [zookeeper] anmolnar commented on issue #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29
anmolnar commented on issue #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29 URL: https://github.com/apache/zookeeper/pull/846#issuecomment-481148287 Committed to master. Thanks @eolivelli ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29
asfgit closed pull request #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29 URL: https://github.com/apache/zookeeper/pull/846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
