Re: Implement checksum against malformed packets

2020-04-08 Thread Enrico Olivelli
Il Gio 9 Apr 2020, 05:36 Michael Han ha scritto: > >> Why? > > A packet can be captured, altered its payload, and recomputed its > checksum(s) while transmitting, that's why encryption is needed. This > example sounds pedantic but serving the purpose of the argument. > With encryption the data

Re: Does ZK use protobuf?

2020-04-08 Thread Enrico Olivelli
Il Gio 9 Apr 2020, 05:42 Christopher ha scritto: > Okay, I can do a PR. However, it might make more sense to do a full > review of the LICENSE/NOTICE files to ensure everything is up-to-date > all at once. I'll create a JIRA for that. > > Speaking of LICENSE/NOTICE files, I noticed: > 1. The

Re: Does ZK use protobuf?

2020-04-08 Thread Christopher
Okay, I can do a PR. However, it might make more sense to do a full review of the LICENSE/NOTICE files to ensure everything is up-to-date all at once. I'll create a JIRA for that. Speaking of LICENSE/NOTICE files, I noticed: 1. The .txt suffix (ASF prefers bare names, and lots of tools assume

Re: Implement checksum against malformed packets

2020-04-08 Thread Michael Han
>> Why? A packet can be captured, altered its payload, and recomputed its checksum(s) while transmitting, that's why encryption is needed. This example sounds pedantic but serving the purpose of the argument. With encryption the data integrity is ensured during transmission at least, but data can

Re: Contribs as separate git repos

2020-04-08 Thread Christopher
On Wed, Apr 8, 2020 at 2:01 PM Damien Diederen wrote: > > > Hi Christopher, > > > I am just curious if anybody has thought about, or perhaps discussed, > > the idea that the projects in the zookeeper-contrib folder should be > > in their own separate git repos? > > We were discussing this a few

Re: Contribs as separate git repos

2020-04-08 Thread Christopher
On Wed, Apr 8, 2020 at 11:32 AM Norbert Kalmar wrote: > > Hi Christopher, > > Yes, moving (most, not all actually) contrib projects to it's own repo is a > long standing discussion. As far as I can tell/remember, the community > agrees that we should move it. > Want to take up the task? :) I am

[jira] [Created] (ZOOKEEPER-3789) fix the build warnings about useless @return found by IDEA

2020-04-08 Thread maoling (Jira)
maoling created ZOOKEEPER-3789: -- Summary: fix the build warnings about useless @return found by IDEA Key: ZOOKEEPER-3789 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3789 Project: ZooKeeper

Re: Contribs as separate git repos

2020-04-08 Thread Damien Diederen
Hi Christopher, > I am just curious if anybody has thought about, or perhaps discussed, > the idea that the projects in the zookeeper-contrib folder should be > in their own separate git repos? We were discussing this a few days ago:

Re: Contribs as separate git repos

2020-04-08 Thread Norbert Kalmar
Hi Christopher, Yes, moving (most, not all actually) contrib projects to it's own repo is a long standing discussion. As far as I can tell/remember, the community agrees that we should move it. Want to take up the task? :) - Norbert On Wed, Apr 8, 2020 at 9:36 AM Christopher wrote: > Hi ZK

Re: [DISCUSS] Sending 3.4 release line to End-Of-Life status

2020-04-08 Thread Enrico Olivelli
Il Mer 8 Apr 2020, 12:34 Andor Molnar ha scritto: > Hi, > > I’ve finished my quick testing on compatibility and all combinations are > working fine in both ways: higher version clients are able to connect and > run basic commands on older servers and vica versa. > > Tested latest released

Re: [DISCUSS] Sending 3.4 release line to End-Of-Life status

2020-04-08 Thread Andor Molnar
Hi, I’ve finished my quick testing on compatibility and all combinations are working fine in both ways: higher version clients are able to connect and run basic commands on older servers and vica versa. Tested latest released versions of 3.4, 3.5 and 3.6 branches with all possible

Re: Implement checksum against malformed packets

2020-04-08 Thread Ted Dunning
The only way to corrupt a message transmitted on an encrypted link is to break the encryption. There is a tiny argument to be made that messages should be checksummed for protection even without the encryption, but these links should always be encrypted. The chance of a 160 bit checksum being

Re: Implement checksum against malformed packets

2020-04-08 Thread Andor Molnar
Hi Michael, "Checksum itself (even cryptographic checksum) can’t guarantee data integrity as packet in flight can be altered along with the new checksum.” Why? If either checksum or the payload was altered, the packet will be retransmitted. Furthermore we could implement error correction

Contribs as separate git repos

2020-04-08 Thread Christopher
Hi ZK Devs, I am just curious if anybody has thought about, or perhaps discussed, the idea that the projects in the zookeeper-contrib folder should be in their own separate git repos? I'm asking because I've been looking a lot at the build, trying to find ways to improve it, and I think this

[jira] [Created] (ZOOKEEPER-3788) Add m2e configuration in pom.xml for Eclipse developers

2020-04-08 Thread Christopher Tubbs (Jira)
Christopher Tubbs created ZOOKEEPER-3788: Summary: Add m2e configuration in pom.xml for Eclipse developers Key: ZOOKEEPER-3788 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3788