Re: Contribs as separate git repos

2020-04-10 Thread Christopher
On Fri, Apr 10, 2020 at 12:56 PM Benjamin Reed wrote: > > did you mean to mention the c client in the list of things to move to > another repo? it's not in contribs right now. No. That was a mistake of mine, based on my understanding of a previous response in this thread. However, it might still

Re: Cutting 3.6.1 HEADS UP !

2020-04-10 Thread Enrico Olivelli
Thank you Micheal I will pick up the patch. Enrico Il Ven 10 Apr 2020, 20:12 Michael Han ha scritto: > would be good to get ZOOKEEPER-3793 in this release. Without ZOOKEEPER-3793 > zk will not throttle requests at all, given RequestThrottler is disabled by > default (and requires some

Re: Cutting 3.6.1 HEADS UP !

2020-04-10 Thread Michael Han
would be good to get ZOOKEEPER-3793 in this release. Without ZOOKEEPER-3793 zk will not throttle requests at all, given RequestThrottler is disabled by default (and requires some understanding to configure it correctly). On Thu, Apr 9, 2020 at 10:04 PM Enrico Olivelli wrote: > Il Ven 10 Apr

[jira] [Created] (ZOOKEEPER-3793) Request throttling is broken when RequestThrottler is disabled or configured incorrectly.

2020-04-10 Thread Michael Han (Jira)
Michael Han created ZOOKEEPER-3793: -- Summary: Request throttling is broken when RequestThrottler is disabled or configured incorrectly. Key: ZOOKEEPER-3793 URL:

Re: Contribs as separate git repos

2020-04-10 Thread Benjamin Reed
did you mean to mention the c client in the list of things to move to another repo? it's not in contribs right now. i think it would be nice to clean the contrib a bit. i don't really support moving it to a separate repo. the nice thing about keeping it in the same repo is that when there is a

NullPointerException while shutting down ZK server

2020-04-10 Thread Enrico Olivelli
Hi, while testing 3.6.1 RC we have found an issue during the shutdown of ZooKeeper Server it is an NPE, below the stacktrace of the error. The problem is related to https://issues.apache.org/jira/browse/ZOOKEEPER-2845 Data inconsistency issue due to retain database in leader election The issue

[jira] [Created] (ZOOKEEPER-3792) Reconcile document site in 3.5.7 & 3.6.0

2020-04-10 Thread Zili Chen (Jira)
Zili Chen created ZOOKEEPER-3792: Summary: Reconcile document site in 3.5.7 & 3.6.0 Key: ZOOKEEPER-3792 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3792 Project: ZooKeeper Issue

Request For Review: ZOOKEEPER-3579

2020-04-10 Thread tison
Hi ZK Devs, A few months ago I create a PR for gracefully handling null default watcher[1]. After some discussion it seems we reach a consensus that 1. Forbid require default watcher (boolean watcher=true) if default watcher is null. 2. Exclude null default watcher from materialize watches which