Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/201
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/195#discussion_r106797356
--- Diff:
src/java/test/org/apache/zookeeper/server/MultiOpSessionUpgradeTest.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/195#discussion_r106797374
--- Diff:
src/java/test/org/apache/zookeeper/server/MultiOpSessionUpgradeTest.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/195#discussion_r106797340
--- Diff:
src/java/test/org/apache/zookeeper/server/MultiOpSessionUpgradeTest.java ---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
@skamille OK, for some reasons I can't even get a single repro with this
patch now on Apache Jenkins. I've kicked 10+ builds on apache jenkins and all
of them pass this test. Unfortunately the link
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
@skamille Interesting, curious to see what you find out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
>> if that creation is failing due to connection loss, shouldn't the places
that check the watcher connection fail there instead of in your check?
ConnectionLossException can happen
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/200
I tested this patch, it works good for my local Linux environment. The
previous test cases that failed deterministically now pass consistently. I've
left a comment here and a couple of comments
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/200#discussion_r106792170
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java
---
@@ -87,7 +87,7 @@ public void testValidCredentials() throws
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/200#discussion_r106792158
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java
---
@@ -83,7 +83,7 @@ public void testNullAuthLearnerServer
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/195#discussion_r107051228
--- Diff:
src/java/test/org/apache/zookeeper/server/MultiOpSessionUpgradeTest.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/200
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/195
LGTM, except it does not build with JDK 7. Will merge after the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/195#discussion_r107051170
--- Diff:
src/java/test/org/apache/zookeeper/server/MultiOpSessionUpgradeTest.java ---
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/192
LGTM. I did some testing using CLI and it works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
So what happened chronically on Jenkins for this test could be:
* ZK client connect to server. Watcher received connected (read only)
events.
* For some reasons when invoke zk.create we
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
>> So are we saying that the watcher.waitForConnected(CONNECTION_TIMEOUT)
is not working correctly?
I believe this works as expected. I don't see any of the flaky / normal
test r
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/198
merged, please close the pull request @knusbaum.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
Let me also check the Apache Jenkins logs on the failed cases see what
happened there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
I think we support running concurrent JUNIT tests and the number of
parallel tests is controlled by test.junit.threads - which has default value of
1 in build.xml. The Jenkins log indicates
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/197
merged, please close the pull request @knusbaum.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
That's a good one, it sounds possible. We can force the watcher only wait
for SyncConnected event (rather than both SyncConnectedEvent and
ConnectedReadyOnly event), so we will guarantee the client
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
I think this does not quite work still
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/434/testReport/junit/org.apache.zookeeper.test/ReadOnlyModeTest/testSessionEstablishment
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/191#discussion_r107259910
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -96,24 +96,34 @@ public void process(WatchedEvent event) { /* nada
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/191
ZOOKEEPER-2722: fix flaky testSessionEstablishment test.
Use retry with timeouts to deal with ConnectionLossException in flaky
apache test environment.
You can merge this pull request into a Git
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/194
ZOOKEEPER-2724: Skip cert files for releaseaudit target.
Skip the cert files as they are not source files, plus we already do the
same for master branch..
You can merge this pull request
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/191
@skamille
Implementing the idea of waiting for sync connected event to make sure we
wait until a quorum is formed before prematurely trying a write operation. Made
some comments in the test
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/211
ZOOKEEPER-2743: Netty connection leaks JMX connection bean.
See https://issues.apache.org/jira/browse/ZOOKEEPER-2743 for details on the
symptom and diagnostic.
There are many ways
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/213
ZOOKEEPER-2746: remove the check on the new leader after a dynamic reâ¦
â¦config operation.
This check might not always hold because the nominated leader could fail to
lead the quorum
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/211#discussion_r110711280
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -87,6 +87,12 @@ public void close() {
LOG.debug("
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/224
ZOOKEEPER-2573: Introduce a python script that generates flaky tests report.
The script is self explaining, here are some notes:
* The original work is done by Appy at Cloudera HBase team
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110057806
--- Diff: src/java/main/org/apache/zookeeper/common/X509UtilTest.java ---
@@ -0,0 +1,231 @@
+/**
--- End diff --
This is supposed
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/211#discussion_r110082136
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -87,6 +87,12 @@ public void close() {
LOG.debug("
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110057980
--- Diff: src/java/main/org/apache/zookeeper/common/X509UtilTest.java ---
@@ -0,0 +1,231 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110061068
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -253,7 +255,10 @@ protected void connectToLeader(InetSocketAddress addr
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110060990
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -193,21 +198,18 @@ void request(Request request) throws IOException
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r110061229
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
@@ -230,15 +232,15 @@ protected void sockConnect(Socket sock,
InetSocketAddress
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/211#discussion_r110081828
--- Diff: src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java ---
@@ -87,6 +87,12 @@ public void close() {
LOG.debug("
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/218
lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/216
lgtm. Pending commit to branch-3.5 until after 3.5.3 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/219
merged, please close PR @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/221
>> We should also cherrypick this to 3.5
branch 3.5 is find bug clean... did you observe something bad in 3.5?
---
If your project is set up for it, you can reply to this email an
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/214
lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/220
merged, please close pr @afine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/221
merged please close pr @afine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/221
lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111486323
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -51,6 +53,8 @@
import org.slf4j.Logger;
import
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111485824
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111486010
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Follower.java ---
@@ -71,7 +71,7 @@ void followLeader() throws InterruptedException
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111484712
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -150,7 +196,7 @@ public static X509KeyManager createKeyManager(String
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111487159
--- Diff: src/java/test/org/apache/zookeeper/test/QuorumSSLTest.java ---
@@ -0,0 +1,668 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111483464
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java
---
@@ -31,6 +31,7 @@
import javax.net.ssl.SSLSocket;
import
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111483370
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java ---
@@ -21,6 +21,7 @@
import
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111486591
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java ---
@@ -383,6 +387,7 @@ public void run
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/235
ZOOKEEPER-2722: fix flaky testSessionEstablishment test.
Make sure client is connected to a quorum before issuing a write operation
to avoid possible race condition between connected to a RO server
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111483819
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -18,63 +18,110 @@
package org.apache.zookeeper.common;
+import
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/234#discussion_r112275679
--- Diff: src/contrib/cppclient/DelegatingSessionEventWatcher.h ---
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/187
I think this is a fairly obvious one - anyone want to review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/187
ZOOKEEPER-2716: fix flaky test testAddSessionAfterSessionExpiry.
We can't let the gate open until we increase the closed session count.
Otherwise depends on timing, the test thread might see old
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/181
Patch look good. Defer to @rakeshadr for another look and commit (since we
are in the middle of 3.4 release.).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/83
Thanks for the patch and detailed tech reports @gnethercutt.
As @rgs1 commented on ZOOKEEPER-1748 JIRA we should have a feature switch
that controls on / off of the keep alive option
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r104245364
--- Diff: src/java/test/org/apache/zookeeper/ZKTestCase.java ---
@@ -51,6 +51,12 @@ public void starting(FrameworkMethod method
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/182
Thanks @joshelser! Latest update looks great.
Patch committed to master and branch-3.5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/187
@rakeshadr any chance you can take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/190#discussion_r105830547
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java ---
@@ -102,6 +102,8 @@ public void startSingleServerTest() throws
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/190
ZOOKEEPER-2178: fix flaky StandaloneDisabledTest
The flaky (that existing for a long time) is caused by a ghost server that
although not appear in the quorum's config but still up and running
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/190
@shralex You might want to take a look at this one :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user hanm reopened a pull request:
https://github.com/apache/zookeeper/pull/190
ZOOKEEPER-2718: fix flaky StandaloneDisabledTest
The flaky (that existing for a long time) is caused by a ghost server that
although not appear in the quorum's config but still up and running
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/190
Thanks for review, Alex! Committed and closing PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/165
@eolivelli - can you please also closing this pull request?
On a side note, this patch works, I see my PR to branch 3.5 is now kicking
build bots.
---
If your project is set up for it, you can
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/183
ZOOKEEPER-2693: DOS attack on wchp/wchc four letter words (4lw).
Similar as pull request 179, this PR introduces new property
zookeeper.4lw.commands.whitelist to branch-3.4.
Unlike branch-3.5
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/165
I think it is fine to leave the names as they are for now and later update
scripts for all branches all together.
@eolivelli - are there any specific changes you made on top of
ZOOKEEPER
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/183#discussion_r104579958
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1042,6 +1042,40 @@ server.3=zoo3:2888:3888
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/182#discussion_r104595517
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
---
@@ -899,9 +899,12 @@
single id, anyone, that represents
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/179
>> Can we introduce some keyword to include all the commands?
Sounds reasonable. Will add 4lw.commands.whitelist=* as an option.
---
If your project is set up for it, you can
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/179
Another stab to address comments from @arshadmohammad
* Introduced 4lw.commands.whitelist=* as a convient configuration option to
enable all 4lw, with new test.
* Remove dead code
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/179#discussion_r104096586
--- Diff: src/java/test/org/apache/zookeeper/ZKTestCase.java ---
@@ -51,6 +51,12 @@ public void starting(FrameworkMethod method
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/165
Thanks @eolivelli, this is merged in 3.4. and 3.5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/182
Thanks for the quick update @joshelser ! The latest doc looks perfect
minors what Abe pointed out. Do you mind to address Abe's comment regarding the
id / expression clarification?
---
If your
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r104819835
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -303,15 +305,38 @@ public void loadData() throws IOException
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/184#discussion_r111613841
--- Diff: src/java/main/org/apache/zookeeper/common/ZKTrustManager.java ---
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/151
@Randgalt : This is merged, please close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/157
@revans2 Please close this pull request; it's merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/232#discussion_r113011930
--- Diff: src/java/main/org/apache/jute/compiler/JType.java ---
@@ -27,7 +27,7 @@
private String mCName;
private String mCppName
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r113008904
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,23 @@ public synchronized void close() throws
InterruptedException
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/222
Someone can correct me if I were wrong but I don't think we can cherry pick
this to branch-3.5, which is in beta state now. A beta state means API is
locked down: no addition, removal, or change
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r113008830
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,23 @@ public synchronized void close() throws
InterruptedException
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/222#discussion_r113008213
--- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java ---
@@ -1325,6 +1325,23 @@ public synchronized void close() throws
InterruptedException
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/235
Merge and close pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/223#discussion_r113069120
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -724,6 +724,8 @@ synchronized public boolean tryToCommit(Proposal p,
long zxid
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/312#discussion_r130233880
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -1001,25 +1010,14 @@ public String toString() {
@Override
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/312#discussion_r130233860
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -1001,25 +1010,14 @@ public String toString() {
@Override
GitHub user hanm reopened a pull request:
https://github.com/apache/zookeeper/pull/304
ZOOKEEPER-2355: Ephemeral node is never deleted if follower fails while
reading the proposal packet.
This commit is a port of the commit
ca22b3db19371f6b0f5507b7dd80b283cddc7700 from branch-3.5
Github user hanm closed the pull request at:
https://github.com/apache/zookeeper/pull/304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/312#discussion_r131049051
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -1001,25 +1010,14 @@ public String toString() {
@Override
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/322#discussion_r131049142
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -118,7 +118,7 @@
fsyncWarningThresholdMS
201 - 300 of 839 matches
Mail list logo
