GitHub user timothyjward opened a pull request:
https://github.com/apache/zookeeper/pull/48
Use fake host names to avoid test failures
Some of the ZooKeeper tests use "fake" hostnames to trigger host resolution
failures. The problem with this is that it uses valid hostn
Github user timothyjward closed the pull request at:
https://github.com/apache/zookeeper/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
The run went through fine once the Apache infrastructure became less busy!
---
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
I'm not sure why the Jenkins build is still marked as pending, it seems to
have passed.
---
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
> Perhaps you could try to re-run the build? You can do this easily with
git commit --amend
Done
---
GitHub user timothyjward opened a pull request:
https://github.com/apache/zookeeper/pull/530
[ZOOKEEPER-2474] Support session reconnection when using ZKClientConfig
Signed-off-by: Tim Ward <timothyjw...@apache.org>
This PR simply adds constructors which support s
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
Now the build appears to fail without running any tests at all!
---
GitHub user timothyjward opened a pull request:
https://github.com/apache/zookeeper/pull/531
[ZOOKEEPER-2317] Ensure that OSGi versions are valid
Signed-off-by: Tim Ward <timothyjw...@apache.org>
You can merge this pull request into a Git repository by running:
$ gi
Github user timothyjward commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196102971
--- Diff: src/java/main/org/apache/zookeeper/Watcher.java ---
@@ -84,7 +84,14 @@
* client connection (the session) is no longer
Github user timothyjward commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196090467
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1260,10 +1260,8 @@ public void run() {
cleanup
Github user timothyjward commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196119877
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1438,6 +1436,11 @@ public void disconnect
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
> * why have you created the patch against branch-3.5? jira is targeted to
trunk too, don't you want to merge it to that branch?
I work against the 3.5 release branch, which is ho
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
* All tabs on changed lines are now spaces
* Reordered imports have been moved back
I rebased and squashed the changes so that it would be as easy as possible
to merge this PR
---
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
@nkalmar is there anything more I need to do with this before it can be
merged?
---
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/529
Retriggered. Overall +1 from Jenkins now.
---
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/530
I'm still not sure what additional testing is possible. The way the patch
is constructed the changed code (all three lines of it) is already exercised by
the existing ZooKeeper tests
Github user timothyjward commented on the issue:
https://github.com/apache/zookeeper/pull/530
I'm happy for this to be merged. The code paths are tested already because
of the way the constructors delegate. Is there anything further?
---
Github user timothyjward commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/529#discussion_r196731884
--- Diff: src/java/test/org/apache/zookeeper/test/WatcherTest.java ---
@@ -140,6 +142,55 @@ public void processResult(int rc, String path, Object
18 matches
Mail list logo
