[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-02-22 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r170009123 --- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java --- @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-02-22 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r169985373 --- Diff: src/java/main/org/apache/zookeeper/server/EphemeralType.java --- @@ -37,41 +77,152 @@ /** * TTL node

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-02-22 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r169984867 --- Diff: src/java/main/org/apache/zookeeper/server/OldEphemeralType.java --- @@ -0,0 +1,74 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2018-01-26 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 FYI - I just pushed a change that adds yet-another-flag that allows 3.5.4 ZKs to read the old 3.5.3 TTL nodes. I think we must have this. The docs are updated too. ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2018-01-26 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 IMPORTANT NOTE: TTL Nodes created in 3.5.3 will revert to EPHEMERAL with this change. We need to discuss the impact of this and consider workarounds, etc. ---

[GitHub] zookeeper issue #378: [ZOOKEEPER-2903] Backport of ZOOKEEPER-2901 changes

2018-01-26 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/378 Attn: @phunt - I just pushed two changes: Better docs and new reserved bits in the EphemeralType enum. Better implementation of the testable serverId in ZooKeeperServer. ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2018-01-26 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 Attn: @phunt - I just pushed two changes: - Better docs and new reserved bits in the `EphemeralType` enum. - Better implementation of the testable `serverId` in ZooKeeperServer. ---

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-01-24 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r163747537 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -476,9 +474,12 @@ public ZooKeeperServerListener

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-01-24 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r163746348 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -476,9 +474,12 @@ public ZooKeeperServerListener

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2018-01-24 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r163671234 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -476,9 +474,12 @@ public ZooKeeperServerListener

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-12-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r159091495 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml --- @@ -949,14 +949,15 @@ server.3=zoo3:2888:3888

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-12-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r159091284 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -476,9 +474,12 @@ public ZooKeeperServerListener

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-12-03 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 Controlling TTL Nodes via zoo.cfg turned out to be untennable. There are too many parts of the code that need to know about TTLs being enabled or not. The previous PR had several holes relating

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-11-03 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 > I used the sample zoo.cfg file as my config and started via bin/zkServer.sh - however I can still create a ttl based node even though "ttlNodesEnabled=false" in the zoo.cfg. I

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-10-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 @phunt it's back to default false now. So, I hope this can be merged. ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-10-12 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 @phunt you reviewed this PR originally so I was hoping you'd merge. @rgs1 can you merge if Pat can't? ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-10-09 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 @phunt Can we get this merged please? ---

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-10-03 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 re: ACL and recursive watches... ZooKeeper.exists() does not check ACLs so I assert that the current behavior of this PR doesn't violate the current behavior. i.e. in ZooKeeper you can

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-10-03 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 One of our devs, @alexbrasetvik, asked about ACLs and recursive watches. It turns out this PR is not handling that and needs to. I'll submit support for this soon. ---

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-10-02 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 This PR and #332 are ready. How can we get this merged? @skamille ? ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-10-02 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 This feature is ready to merge (along with #378) ---

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-09-28 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 The integration above doesn't seem to update, but the build passes now. ---

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-09-27 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r141521002 --- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java --- @@ -84,6 +84,9 @@ public static long initializeNextSession(long id

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-09-27 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r141521029 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -125,6 +125,8 @@ private final ZooKeeperServerListener listener

[GitHub] zookeeper issue #380: Develeper shonminh

2017-09-26 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/380 Is this some kind of spam? ---

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-09-25 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 As promised - here's the project with the benchmarking stuff: https://github.com/Randgalt/zkbench ---

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-09-25 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 > does the new map in the watch structure break rolling upgrades It would depend how you did it. If you upgraded all the ZK servers before adding any persistent watches you'd be OK. ---

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-09-25 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r140815418 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,50 +40,110 @@ class WatchManager { private static final

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-09-23 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 FYI - I did some local ad-hoc testing with server IDs 254/255 and the config value true/false in zoo.cfg and everything works as expected. ---

[GitHub] zookeeper pull request #378: [ZOOKEEPER-2903] Backport of ZOOKEEPER-2901 cha...

2017-09-23 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/378 [ZOOKEEPER-2903] Backport of ZOOKEEPER-2901 changes See https://github.com/apache/zookeeper/pull/377 There was a major oversight when TTL nodes were implemented. The session ID

[GitHub] zookeeper issue #377: [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs ...

2017-09-23 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/377 There are 4 tests with this line of code and it's failing because the logger is not there (NullPointerException). Any ideas? ``` Layout layout

[GitHub] zookeeper pull request #377: [ZOOKEEPER-2901] TTL Nodes don't work with Serv...

2017-09-22 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/377 [ZOOKEEPER-2901] TTL Nodes don't work with Server IDs > 127 There was a major oversight when TTL nodes were implemented. The session ID generator for each server is seeded with the configu

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 Another goal is feature parity with other consensus tools such as etcd/consul. I added TTL nodes with this (and other) goals earlier in the year (or was it last year?). Watches in consul

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-16 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 Per 1. I posted some performance numbers in the issue. There's a definite hit but it's worth it in my view. We should discuss this. Per 2. What this PR is aimed at is users of Curator's

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-10 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132592200 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-10 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132579217 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher

[GitHub] zookeeper pull request #332: Port of ZOOKEEPER-1416 Persistent Recursive Wat...

2017-08-09 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/332 Port of ZOOKEEPER-1416 Persistent Recursive Watches You can merge this pull request into a Git repository by running: $ git pull https://github.com/Randgalt/zookeeper ZOOKEEPER-2871

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-09 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @afine issues addressed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034244 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,18 @@ synchronized void dumpWatches(PrintWriter pwriter

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034154 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132034008 --- Diff: src/java/main/org/apache/zookeeper/ZooDefs.java --- @@ -74,12 +74,16 @@ public final int createTTL = 21

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r132027605 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-08-03 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @hanm done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zookeeper pull request #249: [ZOOKEEPER-2779] Branch 3.5 backport

2017-06-01 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/249#discussion_r119611508 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml --- @@ -338,7 +338,10 @@ server.3=125.23.63.25:2782:2785:participant

[GitHub] zookeeper pull request #248: [ZOOKEEPER-2779] Provide a means to disable set...

2017-05-30 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/248#discussion_r119179974 --- Diff: src/java/test/org/apache/zookeeper/test/ReconfigExceptionTestCase.java --- @@ -0,0 +1,122 @@ +/** + * Licensed to the Apache Software

[GitHub] zookeeper pull request #249: [ZOOKEEPER-2779] Branch 3.5 backport

2017-05-09 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/249 [ZOOKEEPER-2779] Branch 3.5 backport Branch 3.5 backport of https://github.com/apache/zookeeper/pull/248 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] zookeeper pull request #248: [ZOOKEEPER-2779} Provide a means to disable set...

2017-05-09 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/248 [ZOOKEEPER-2779} Provide a means to disable setting of the Read Only ACL for the reconfig node Provide a means to disable setting of the Read Only ACL for the reconfig node added in ZOOKEEPER

[GitHub] zookeeper pull request #222: ZOOKEEPER-2697 Handle graceful stop of ZookKeep...

2017-04-11 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/222#discussion_r110944401 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -1325,6 +1325,23 @@ public synchronized void close() throws InterruptedException

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-03-23 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @stuhood - FYI - here's a new version of Curator's cache recipes consolidated into one-recipe-to-rule-them-all that relies on this new Persistent Recursive Watch implementation. https

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2017-03-22 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 Thanks @eribeiro - at minimum it would be good to get feedback. This feature will really help the community. --- If your project is set up for it, you can reply to this email and have your

[GitHub] zookeeper pull request #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into...

2017-03-17 Thread Randgalt
Github user Randgalt closed the pull request at: https://github.com/apache/zookeeper/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper issue #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 br...

2017-03-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/192 merged into `branch-3.5` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zookeeper pull request #193: ZOOKEEPER-2608: CLI option for TTL nodes

2017-03-15 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/193 ZOOKEEPER-2608: CLI option for TTL nodes This PR adds support for TTL nodes to the CLI You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] zookeeper pull request #192: ZOOKEEPER-2719: Pull changes for TTL Nodes into...

2017-03-15 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/192 ZOOKEEPER-2719: Pull changes for TTL Nodes into 3.5 branch This PR cherry-picks changes for TTL nodes (ZOOKEEPER-2169) and the CLI for it (ZOOKEEPER-2608) into branch-3.5. You can merge

[GitHub] zookeeper issue #152: [ZOOKEEPER-2642] reconfig() is now named reconfigure()...

2017-01-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/152 Do I need to create a new patch file or is that no longer necessary? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zookeeper pull request #152: [ZOOKEEPER-2642] reconfig() is now named reconf...

2017-01-17 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/152 [ZOOKEEPER-2642] reconfig() is now named reconfigure() due to ZOOKEEPER-2642 Was #122 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] zookeeper pull request #122: [ZOOKEEPER-2642] Resurrect the reconfig() metho...

2017-01-17 Thread Randgalt
Github user Randgalt closed the pull request at: https://github.com/apache/zookeeper/pull/122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

2017-01-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/122 OK - to be clear, I have PR #151 which applies the legacy API to branch-3.5. Then, I'll rework _this_ PR (against master) to only have the Admin API, right? --- If your project is set up

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

2017-01-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/122 Do we need a separate issue for the 3.6 change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

2017-01-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/122 See #151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zookeeper pull request #151: Applying ZOOKEEPER-2642 patch to a 3.5 base

2017-01-17 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/151 Applying ZOOKEEPER-2642 patch to a 3.5 base New PR that applies ZOOKEEPER-2642 to `branch-3.5` You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

2017-01-17 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/122 Will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zookeeper issue #122: [ZOOKEEPER-2642] Resurrect the reconfig() methods that...

2017-01-16 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/122 > Are you OK with us removing the deprecated methods when 3.5 becomes GA? No. I'd vote against that. Breaking changes should be in a 3.6 version. That was the genesis of this issue to be

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-27 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @stuhood I'll end up writing one for Apache Curator. The short answer is that large ZK users end up with 100s of thousands or millions of watchers when a few dozen would suffice. The use case

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93893162 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -40,47 +40,52 @@ class WatchManager { private static final

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 > it is required to add a C client change in this patch too? @eribeiro C client work is separate. I usually add a new Jira for them. If/when this patch is accepted I'll

[GitHub] zookeeper issue #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/136 @eribeiro Have a look at the change to `PathIterator` I think this solves your desire while not breaking implicit contracts. --- If your project is set up for it, you can reply to this email

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886810 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -181,11 +206,19 @@ synchronized void dumpWatches(PrintWriter pwriter

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886806 --- Diff: src/java/main/org/apache/zookeeper/server/WatchManager.java --- @@ -97,23 +102,44 @@ synchronized void removeWatcher(Watcher watcher

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886802 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886789 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886801 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886805 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -522,6 +566,15 @@ protected boolean removeWatches(Map<String, Set> pathVsW

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886777 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886440 --- Diff: src/java/test/org/apache/zookeeper/test/PathIteratorTest.java --- @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/136#discussion_r93886426 --- Diff: src/java/main/org/apache/zookeeper/server/PathIterator.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #136: [ZOOKEEPER-1416] Persistent Recursive Watch

2016-12-26 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/136 [ZOOKEEPER-1416] Persistent Recursive Watch Here is a completed implementation for a persistent, recursive watch addition for ZK. These watches are set via a new method, `addPersistentWatch

[GitHub] zookeeper pull request #122: [ZOOKEEPER-2642] Resurrect the reconfig() metho...

2016-12-15 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/122#discussion_r92597471 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -2910,4 +2923,49 @@ private ClientCnxnSocket getClientCnxnSocket() throws IOException

[GitHub] zookeeper pull request #122: [ZOOKEEPER-2642] Resurrect the reconfig() metho...

2016-12-15 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/122#discussion_r92597402 --- Diff: src/java/main/org/apache/zookeeper/ZooKeeper.java --- @@ -39,32 +39,10 @@ import org.apache.zookeeper.client.ZKClientConfig; import

[GitHub] zookeeper pull request #122: [ZOOKEEPER-2642] Resurrect the reconfig() metho...

2016-12-10 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/122 [ZOOKEEPER-2642] Resurrect the reconfig() methods that were in ZooKeeper.java. Resurrect the reconfig() methods that were in ZooKeeper.java. While 3.5.x is an alpha there are clients

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-11-15 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r88091830 --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java --- @@ -543,7 +546,7 @@ protected void pRequest2Txn(int type, long zxid

[GitHub] zookeeper issue #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth...

2016-11-10 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/84 OK - I've put the args into container classes. Let me know what you think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs

2016-11-10 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/82 I never had to write any scripts so I really can't say. It all "just worked". But, then, Curator started as a git project. --- If your project is set up for it, you can reply to

[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs

2016-11-10 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/82 On Curator I always use the [] and it works. ¯\_(ツ)_/¯ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zookeeper issue #82: [ZOOKEEPER-2169] Enable creation of nodes with TTLs

2016-11-10 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/82 Yeah - in other projects a merge autocloses these. Dunno why this didn't. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zookeeper pull request #82: [ZOOKEEPER-2169] Enable creation of nodes with T...

2016-11-10 Thread Randgalt
Github user Randgalt closed the pull request at: https://github.com/apache/zookeeper/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-11-08 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r87054533 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-11-07 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r86868035 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper issue #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth...

2016-11-02 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/84 latest patch added --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zookeeper issue #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth...

2016-11-01 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/84 @fpj any updates on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] zookeeper issue #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth...

2016-10-29 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/84 @fpj I've addressed and pushed changes for all your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85649028 --- Diff: src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java --- @@ -31,7 +31,15 @@ private static boolean initialized

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85649005 --- Diff: src/java/test/org/apache/zookeeper/test/KeyAuthClientTest.java --- @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-29 Thread Randgalt
Github user Randgalt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/84#discussion_r85648967 --- Diff: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml --- @@ -1193,6 +1193,55 @@ authProvider.2=com.f.MyAuth2 only one

[GitHub] zookeeper issue #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth...

2016-10-27 Thread Randgalt
Github user Randgalt commented on the issue: https://github.com/apache/zookeeper/pull/84 @fpj Any more thoughts on this Flavio? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...

2016-10-04 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/84 [ZOOKEEPER-1525] Plumb ZooKeeperServer object into auth plugins Based on patch work from https://issues.apache.org/jira/browse/ZOOKEEPER-1525 Created ServerAuthenticationProvider which

[GitHub] zookeeper pull request #82: [ZOOKEEPER-2169] Enable creation of nodes with T...

2016-09-28 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/82 [ZOOKEEPER-2169] Enable creation of nodes with TTLs This patch takes advantage of 3.5's container support. Most of the work needed to support TTLs is there already. In order

[GitHub] zookeeper pull request: ZOOKEEPER-2163 - Introduce new ZNode type:...

2015-06-09 Thread Randgalt
Github user Randgalt closed the pull request at: https://github.com/apache/zookeeper/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper pull request: ZOOKEEPER-2163 - update doc for container ...

2015-06-09 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/34 ZOOKEEPER-2163 - update doc for container options to reflect correct version of 3.5.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] zookeeper pull request: ZOOKEEPER-2168 - first pass at C changes f...

2015-06-08 Thread Randgalt
GitHub user Randgalt opened a pull request: https://github.com/apache/zookeeper/pull/33 ZOOKEEPER-2168 - first pass at C changes for containers The C build doesn't compile on my Mac and it's been ages since I wrote any C. So, this needs careful review. You can merge this pull

  1   2   >