[GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4

2018-10-15 Thread dain
Github user dain commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/669#discussion_r225332620 --- Diff: zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

2018-06-14 Thread dain
Github user dain commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/184#discussion_r195534358 --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java --- @@ -79,7 +91,7 @@ public X509Util() { String cipherSuitesInput