Github user praste commented on the issue:
https://github.com/apache/zookeeper/pull/148
Reopening as multiple people are interested in it. However, I have switched
jobs and may not be able to make further changes until I get approval from my
new employer.
---
If your project
Github user praste closed the pull request at:
https://github.com/apache/zookeeper/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user praste commented on the issue:
https://github.com/apache/zookeeper/pull/148
Looks like no one is really interested in this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user praste commented on the issue:
https://github.com/apache/zookeeper/pull/148
can this be merged ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user praste commented on the issue:
https://github.com/apache/zookeeper/pull/148
Two options
1. Use patch
* Use link
https://patch-diff.githubusercontent.com/raw/apache/zookeeper/pull/148.diff and
save it as patch. Then use `git apply-patch`
2. Pull from
Github user praste commented on the issue:
https://github.com/apache/zookeeper/pull/148
Are sure you removed reference to `slf4j-log4j12` from all the `ivy.xml`
files?
I am not an ivy expert but you can take a look at
http://stackoverflow.com/questions/5405310/find-hidden
Github user praste commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/148#discussion_r98013864
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum
Github user praste commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/148#discussion_r97232914
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum
Github user praste commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/148#discussion_r96629041
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum
Github user praste commented on the issue:
https://github.com/apache/zookeeper/pull/148
I have made all the suggested changes except for using List appender,
which I will look into tonight
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user praste commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/148#discussion_r96327023
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
@@ -413,13 +418,18 @@ public void testBadPeerAddressInQuorum
Github user praste commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/148#discussion_r96277825
--- Diff: conf/log4j2.xml ---
@@ -0,0 +1,56 @@
+
+
+
+
+%d{ISO8601} [myid:%X{myid}] -
%-5p [%t:%C{1}@%L] - %m%n
--- End diff
Github user praste commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/148#discussion_r96277523
--- Diff: ivy.xml ---
@@ -41,13 +41,20
GitHub user praste opened a pull request:
https://github.com/apache/zookeeper/pull/148
ZOOKEEPER-2664 Log4j2 migration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/praste/zookeeper log4j2-migration
Alternatively you can
14 matches
Mail list logo
