Yisong Yue created ZOOKEEPER-3484:
-
Summary: Improve the throughput by optimizing the synchronization
around outstandingChanges
Key: ZOOKEEPER-3484
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3484
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
couldn't reproduce this failure locally. seems like a flakey test case.
retest this please
---
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
ð Thanks for the feedback! ð
---
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
@anmolnar
One drawback I see with this structure is that it makes it harder to
dynamically pick deserialization mode based on a snapshot's filename, since
`FileSnap` manages a whole
Github user yisong-yue commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/690#discussion_r232864632
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java
---
@@ -0,0 +1,336 @@
+/**
+ * Licensed
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
@anmolnar
I agree that concrete classes are a lot easier to test. Though in this
case, I think it's more appropriate for SnapStream to be a utility class that
does not hold any state
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
Here are some benchmark results I did with my laptop:
```
(1)
uncompressedsnappy gzip
Size: ~ 15.9 MB
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
squashed two commits into one.
---
GitHub user yisong-yue opened a pull request:
https://github.com/apache/zookeeper/pull/690
ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yisong-yue/zookeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yisong Yue reassigned ZOOKEEPER-3179:
-
Assignee: Yisong Yue
> Add snapshot compression to reduce the disk
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633616#comment-16633616
]
Yisong Yue commented on ZOOKEEPER-2847:
---
^ seems like a flakey test case. I cannot reproduce
GitHub user yisong-yue opened a pull request:
https://github.com/apache/zookeeper/pull/649
ZOOKEEPER-2847: Cannot bind to client port when reconfig based on old
static config
PR No.2: Prevent removing client info from static config file to fix
ReconfigLegacyTest
You can merge
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632638#comment-16632638
]
Yisong Yue commented on ZOOKEEPER-2847:
---
[~andorm] [~hanm] Sorry for the delay! It has been
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626522#comment-16626522
]
Yisong Yue commented on ZOOKEEPER-2847:
---
[~hanm] Yes, I'll put up a patch (by that you mean
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yisong Yue reassigned ZOOKEEPER-2847:
-
Assignee: Yisong Yue
> Cannot bind to client port when reconfig based on old sta
GitHub user yisong-yue opened a pull request:
https://github.com/apache/zookeeper/pull/620
ZOOKEEPER-2847: Cannot bind to client port when reconfig based on old
static config
Fixed the issue where clientPortAddress in the static config is not
correctly saved in QuorumVerifier
GitHub user yisong-yue opened a pull request:
https://github.com/apache/zookeeper/pull/543
ZOOKEEPER-3063: Track outstanding changes with ArrayDeque
Changed outstandingChanges from ArrayList to ArrayDeque.
You can merge this pull request into a Git repository by running:
$ git
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yisong Yue updated ZOOKEEPER-3063:
--
Summary: Track outstanding changes with ArrayDeque (was: track outstanding
changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yisong Yue updated ZOOKEEPER-3063:
--
Description:
Outstanding changes are tracked with an ArrayList, which has O(N) remove from
Yisong Yue created ZOOKEEPER-3063:
-
Summary: track outstanding changes with ArrayDeque
Key: ZOOKEEPER-3063
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3063
Project: ZooKeeper
Issue
20 matches
Mail list logo
