[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-25 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-457576254 > @arankin-irl You should be assigned to the Jira. > Would you please share your Jira username and I can add it to the contributors list

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-25 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-457545935 @ivmaykov @anmolnar - PR has been updated to resolve merge conflicts. I've removed the Null SSLContext test, as the SSLContextOptions now

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-21 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-456301995 @ivmaykov @anmolnar - PR updated with the requested changes. This is an

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-18 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-455483285 @ivmaykov @anmolnar - Addressed the comments and updated the PR. This is an

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-17 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-455303614 @ivmaykov - Updated the PR to resolve the comments. I stuck with the nested classes in the tests since package-private classes couldn't be

[GitHub] arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext

2019-01-03 Thread GitBox
arankin-irl commented on issue #728: ZOOKEEPER-3160: Custom User SSLContext URL: https://github.com/apache/zookeeper/pull/728#issuecomment-451193461 @anmolnar - should be up to date now. This is an automated message from the