[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-27 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 You are welcome. ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-27 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/294 Committed to master and 3.5 branches. Thanks @asdf2014 ! ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-26 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/294 @anmolnar green lights from CI This is a trivial patch, do you need another committer ? ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-26 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 Hi, @anmolnar @eolivelli . Is there anything I need to do before we merge this PR? ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-23 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/294 retest this please ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-22 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/294 retest this please ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-21 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 @eolivelli @anmolnar Thanks for your approval. ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-20 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 @eolivelli Thanks for your comment. I will describe this variable in `zookeeperJMX.md`. ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-19 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/294 We should also add the property to the docs ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-18 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/zookeeper/pull/294 @eolivelli Yep, I agree with you. ---

[GitHub] zookeeper issue #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBeanServer`...

2018-11-18 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/294 I would go for a system property ---