Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
You are welcome.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/294
Committed to master and 3.5 branches. Thanks @asdf2014 !
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/294
@anmolnar green lights from CI
This is a trivial patch, do you need another committer ?
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
Hi, @anmolnar @eolivelli . Is there anything I need to do before we merge
this PR?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/294
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/294
retest this please
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
@eolivelli @anmolnar Thanks for your approval.
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
@eolivelli Thanks for your comment. I will describe this variable in
`zookeeperJMX.md`.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/294
We should also add the property to the docs
---
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/294
@eolivelli Yep, I agree with you.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/294
I would go for a system property
---
11 matches
Mail list logo