Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/410
Committed to branch-3.5 and master. I tried applying to branch-3.4 but it
wouldn't apply cleanly. Please submit another pull request for 3.4 and I'll
review/commit that as well. Thanks @fr0stbyte !
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/410
I tested it with cmake and autotools based generation and the command lines
work properly with agreed upon defaults. LGTM. +1.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/410
@fr0stbyte According to my tiny C knowledge, it looks good to me.
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt @anmolnar any suggestion on changes or does this look good ?
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt Let me know if the changes are inline with what you've had in mind.
Once we clear that, I will add the changes for 3.6
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt both options seem fine to me. I think would prefer the first one,
that way if the library remains ABI compatible, the clients won't need to
recompile.
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/410
> I am not sure how
Yea, same here I'm afraid.
In thinking about it a bit perhaps what we could do is one of the following
two option (might be more):
1) add it with some
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@phunt I'd have no problem making in backward compatible, but I am not sure
how. Can you offer some guidance here ?
@anmolnar In the description of MESOS-4065 you can see 2 processes that
sh
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/410
This looks like a non-backward compatible change to me. That said I'm not
sure how many clients would rely on this behavior. thoughts?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/410
@fr0stbyte Reading some Stackoverflow about the flag
(https://stackoverflow.com/questions/22304631/what-is-the-purpose-to-set-sock-cloexec-flag-with-accept4-same-as-o-cloexec),
the change looks r
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/410
@fr0stbyte Thanks for linking to the Mesos bug. Unfortunately, I am not
familiar with the way Mesos handles processes and I think it is possible that
other members of the community share my ignoranc
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/410
@afine Thanks for looking at the PR
Here is the bug tracked on Mesos side :
https://issues.apache.org/jira/browse/MESOS-4065
---
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/410
Hi @fr0stbyte
I see in the JIRA that this ticked arises from an issue related to running
ZooKeeper Mesos. Would you be able to explain exactly why this is needed?
---
13 matches
Mail list logo
