Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/427
@phunt thanks, will keep that in mind.
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/427
@fr0stbyte in future I believe you need to update the commit message, that
doesn't seem to be updated along with the PR description I'm afraid. (something
to consider for future changes, I'll commit
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/427
@phunt @mfenes updated the initial comment of this PR. Let me know if you
need me to move it into a separate comment
---
Github user phunt commented on the issue:
https://github.com/apache/zookeeper/pull/427
For this one I'm fine with the whitespace as it also got into the trunk/3.5
commit.
It's unfortunate that github doesn't have an option to remove whitespace
changes from the diff they show
Github user mfenes commented on the issue:
https://github.com/apache/zookeeper/pull/427
@fr0stbyte could you please add a description to your PR so that everybody
could understand the purpose of this change?
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/427
@fr0stbyte no thanks, that's fine, I've dug it out already.
Going forward I suggest to make linter / indentation / whitespace changes
in a commit separate from the code changes.
---
Github user fr0stbyte commented on the issue:
https://github.com/apache/zookeeper/pull/427
@anmolnar sorry, my editor is configured to strip the trailing white spaces
. Do you need me to disable that?
---
