[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-04 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/650 yep. ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-04 Thread Reidddddd
Github user Reidd commented on the issue: https://github.com/apache/zookeeper/pull/650 Sure, do you mean creating another PR for branch-3.5? ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-04 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/650 Committed to master branch. Thanks @Reidd ! Unfortunately commit script has died in the middle, so I wasn't able to commit to 3.5 Would you please create a separate PR for that? ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-03 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/650 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2331/ ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-02 Thread Reidddddd
Github user Reidd commented on the issue: https://github.com/apache/zookeeper/pull/650 - Add descriptions about SetAclCommand.class - Fix the variable overriding. - Fix missed @Test annotation - Add a test case for unsetAcl znode. - Fix the wrong order of assertion.

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-02 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/650 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2306/ ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-10-02 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/650 retest this please ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-30 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/650 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2292/ ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-30 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/650 @Reidd please change the description now, you have added a UT :) ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-30 Thread eolivelli
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/650 retest this please ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-30 Thread Reidddddd
Github user Reidd commented on the issue: https://github.com/apache/zookeeper/pull/650 Failed UTs are unrelated, most of them are caused by timeout and oom. ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-30 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/650 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2291/ ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-29 Thread Reidddddd
Github user Reidd commented on the issue: https://github.com/apache/zookeeper/pull/650 I can add one if none exists. ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-29 Thread Reidddddd
Github user Reidd commented on the issue: https://github.com/apache/zookeeper/pull/650 Can you give a pointer where are those cli related tests? ---

[GitHub] zookeeper issue #650: ZOOKEEPER-1908: setAcl should be have a recursive func...

2018-09-29 Thread asfgit
Github user asfgit commented on the issue: https://github.com/apache/zookeeper/pull/650 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2287/ ---