Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/652
Merged to 3.5 and master branches. Thanks @revans2 !
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2550/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2549/
---
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/652
@anmolnar sorry it took me so long. I was out on vacation.
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/652
@revans2 Please rebase.
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/652
+1
The new change looks good to me, please rebase to resolve the conflict,
will merge this in after that. Sorry for lately reply, somehow lost tracking
this session.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2459/
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/652
retest this please
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/652
@revans2 We might need another committer to take a look.
Also you probably need to trigger another build to get a green one.
---
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/652
Ping any hope in getting this merged in?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2371/
---
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/652
I just rebased to deal with the directories being moved around.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2348/
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/652
@lvfangmin are u happy with the change?
---
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/652
Thanks for all of the reviews I just rebased and squashed commits.
---
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/652
Ping @eolivelli @lvfangmin @anmolnar
I think I have addressed all of the concerns on both branches. The test
failure here looks unrelated to the changes that I made.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2324/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2325/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2321/
---
Github user revans2 commented on the issue:
https://github.com/apache/zookeeper/pull/652
@anmolnar and @lvfangmin I think I have addressed all of your review
comments. I named the new class SaslServerPrincipal but if you have a
different idea for a name I am happy to change it.
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2303/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2301/
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/652
Looks great now
Like for branch-3.4 I think we'd better to have some test
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/652
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2300/
---
24 matches
Mail list logo
