Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/669
Merged to master branch. Thanks @ivmaykov !
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@anmolnar does anything else need to be done with this PR before it can be
merged?
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2603/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@maoling it will be hard to do perf comparison of netty3 vs netty4 for us
because we are currently using the NIO transports, and we don't plan on
switching to netty3 in production. Comparing NIO
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2588/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
Rebase, update localAddress after accepting connection and log it
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/669
find a
[blog](https://blog.twitter.com/engineering/en_us/a/2013/netty-4-at-twitter-reduced-gc-overhead.html)
about the twitter's practice of moving netty3 to netty4 for Finagle.it
couldn't be
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@normanmaurer a review from you would be very much appreciated! I bought
your book (Netty in Action) which helped me quite a bit :) This is the version
of the code we've been testing on a real
Github user normanmaurer commented on the issue:
https://github.com/apache/zookeeper/pull/669
Also @eolivelli
---
Github user normanmaurer commented on the issue:
https://github.com/apache/zookeeper/pull/669
@ivmaykov I would be have to review your code changes once you think these
are ready. While I don't know a lot about Zookeeper internals I know a few
things about Netty ;) Just ping me
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2528/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2496/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
Fixed various issues in netty code
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2484/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2485/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2483/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
Cleaner Epoll/Nio selection code
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@eolivelli use `voidPromise()` to avoid allocations when writing to channel
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2482/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@eolivelli changes you requested:
- use Epoll if available
- if (LOG.isDebugEnabled()) around complex LOG.debug() statements
- use netty-all artifact
Haven't looked into
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/669
@maoling there is no generic benchmarks.
For instance in Bookkeeper we switched to Netty 4 and now we are able to
leverage all the cool stuff about memory and so we are able to be more
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/669
- where can we find a benchmark comparing netty4 vs netty3?I am testing the
perfermance
- saw many use cases facing memory leak when migrate netty3 to netty4 for
misunderstading the netty4
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2480/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2479/
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/669
@ivmaykov I answered to all of your comments.
I expect this to be the very first step.
Coming with Netty 4 it is more easier to reduce memory allocations,
expecially on the hot
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@eolivelli thanks so much for the review! See my responses inline.
---
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/669
@eolivelli , good find with EPoll. :)
When @ivmaykov first mentioned using EPoll to me as a potential
optimization, I recommended leaving it for later so we would do the reviewers a
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2473/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2463/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2444/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2445/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2443/
---
Github user enixon commented on the issue:
https://github.com/apache/zookeeper/pull/669
@ivmaykov (or anyone with a stack overflow account, really), do you want to
tag a pointer to this PR with 'netty' on stack overflow (as per
https://netty.io/community.html) and see if any of the
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2442/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2441/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2439/
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/669
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2438/
---
Github user ivmaykov commented on the issue:
https://github.com/apache/zookeeper/pull/669
@dain take a look at the changes I made to airlift's test ByteBuf
allocator. With these changes, we (sometimes) get leak details printed to
stderr if a ByteBuf leaks, before the test crashes.
38 matches
Mail list logo
