Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
couldn't reproduce this failure locally. seems like a flakey test case.
retest this please
---
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/690
retest this please
---
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
ð Thanks for the feedback! ð
---
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/690
@yisong-yue
Yeah, that's true. Perhaps it would be too much hassle and I'm trying to
over-engineer things here. Let's just leave it as it is now and only do
refactoring if we could benefit
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
@anmolnar
One drawback I see with this structure is that it makes it harder to
dynamically pick deserialization mode based on a snapshot's filename, since
`FileSnap` manages a whole
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/690
@yisong-yue
Global state can still be maintained in a static field of a concrete class,
it shouldn't be a problem.
Though, you're probably right about `SnapStream` cannot maintain a
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
@anmolnar
I agree that concrete classes are a lot easier to test. Though in this
case, I think it's more appropriate for SnapStream to be a utility class that
does not hold any state. (It
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
Here are some benchmark results I did with my laptop:
```
(1)
uncompressedsnappy gzip
Size: ~ 15.9 MB
Github user yisong-yue commented on the issue:
https://github.com/apache/zookeeper/pull/690
squashed two commits into one.
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/690
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2610/
--nonenone--
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
@yisong-yue sorry for the spam. There is a problem with the pre-commit job.
I won't disturb you anymore on this PR
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/690
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2609/
--nonenone--
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/690
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2608/
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
retest this please
---
Github user asfgit commented on the issue:
https://github.com/apache/zookeeper/pull/690
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2606/
---
17 matches
Mail list logo
