[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

2018-12-14 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/714 retest this please ---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

2018-12-14 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/714 @lvfangmin Please approve. ---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

2018-12-12 Thread mkedwards
Github user mkedwards commented on the issue: https://github.com/apache/zookeeper/pull/714 I updated this PR to match the changes made to #703 during review. Anything else I can do to help? ---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

2018-12-12 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/714 @mkedwards @lvfangmin Apologies for being pushy, but this is a critical patch for the 3.5 release. Can we move on? ---

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

2018-12-09 Thread anmolnar
Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/714 @lvfangmin Thanks for recycling this PR. However I believe it's more convenient for the original author to port patches, but I'm happy to commit this anyway. Please let me know once who think

[GitHub] zookeeper issue #714: Zookeeper 1818 (on branch-3.5)

2018-12-08 Thread lvfangmin
Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/714 @mkedwards I just made a 3.5 patch as well and saw this when I tried to send out, thanks for porting this over, thee change seems identical with my 3.5 one except two comments change to follow