Github user JonathanO commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/456#discussion_r172802731
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -318,76 +318,167 @@ public Thread newThread(Runnable r) {
Github user JonathanO commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/456#discussion_r169910520
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -318,76 +318,167 @@ public Thread newThread(Runnable r) {
Github user fpj commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/456#discussion_r168620297
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -318,76 +318,167 @@ public Thread newThread(Runnable r) {
Github user JonathanO commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/456#discussion_r166036745
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -689,15 +669,15 @@ synchronized void connectOne(long sid){
GitHub user JonathanO opened a pull request:
https://github.com/apache/zookeeper/pull/456
ZOOKEEPER-2930: Leader cannot be elected due to network timeout of some
members.
Move sock.connect() into the async connection worker thread.
Use initiateConnectionAsync for all
