Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/501
---
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r184676493
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -311,6 +325,9 @@ public synchronized void commit() throws IOExcepti
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r184673319
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -311,6 +325,9 @@ public synchronized void commit() throws IOExcept
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r184667238
--- Diff: src/contrib/monitoring/check_zookeeper.py ---
@@ -256,6 +261,36 @@ def _parse_stat(self, data):
result['zk_znode_count'] = i
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r184549466
--- Diff: src/contrib/monitoring/check_zookeeper.py ---
@@ -256,6 +261,36 @@ def _parse_stat(self, data):
result['zk_znode_count'] = int
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r183980318
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r183907088
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r183632850
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r183573019
--- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
---
@@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
Github user phunt commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r183571986
--- Diff: docs/zookeeperAdmin.html ---
@@ -2213,6 +2213,7 @@ The Four Letter Words
zk_min_latency 0
zk_packets_receive
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181150889
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -55,6 +53,7 @@
private final File snapDir;
pr
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181134958
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -55,6 +53,7 @@
private final File snapDir;
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181127430
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -55,6 +53,7 @@
private final File snapDir;
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181129644
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -148,9 +150,23 @@ synchronized public void resetRequestCounters(){
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181127170
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -135,6 +136,8 @@
long currentSize;
File lo
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181126991
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -30,10 +30,8 @@
import org.apache.zookeeper.KeeperE
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181063500
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -32,6 +32,7 @@
private long minLatency = Long.MAX_VALUE;
priv
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181059907
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -146,6 +149,16 @@ public FileTxnLog(File logDir) {
th
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181060856
--- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
@@ -32,6 +32,7 @@
private long minLatency = Long.MAX_VALUE;
pri
GitHub user nkalmar opened a pull request:
https://github.com/apache/zookeeper/pull/501
ZOOKEEPER-3019 add metric for slow fsyncs count
Added metric to count fsyncWarningThresholdMS exceed in
FileTxnLog.commit(). Both jmx bean and Command can be used to get the stat.
Also u
20 matches
Mail list logo
